From f0003dd7f8da01699586109d6724e0d3e9b56a07 Mon Sep 17 00:00:00 2001 From: Lone Iversen <108085781+loivsen@users.noreply.github.com> Date: Mon, 13 Nov 2023 12:20:27 +0100 Subject: [PATCH] remove todo --- .../stylesheets/entity-actions/create/create-rtf.action.ts | 1 + .../stylesheets/entity-actions/create/create.action.ts | 1 + .../stylesheets/workspace/stylesheet-workspace.context.ts | 4 ++-- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/entity-actions/create/create-rtf.action.ts b/src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/entity-actions/create/create-rtf.action.ts index 23f1dfbbc6..0488b9c129 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/entity-actions/create/create-rtf.action.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/entity-actions/create/create-rtf.action.ts @@ -8,6 +8,7 @@ export class UmbCreateRTFStylesheetAction }> e async execute() { if (this.unique !== null) { + // Note: %2f is a slash (/) this.unique = this.unique.replace(/\//g, '%2f'); } diff --git a/src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/entity-actions/create/create.action.ts b/src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/entity-actions/create/create.action.ts index b41970b683..7e1a87a013 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/entity-actions/create/create.action.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/entity-actions/create/create.action.ts @@ -8,6 +8,7 @@ export class UmbCreateStylesheetAction }> exte async execute() { if (this.unique !== null) { + // Note: %2f is a slash (/) this.unique = this.unique.replace(/\//g, '%2f'); } diff --git a/src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/workspace/stylesheet-workspace.context.ts b/src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/workspace/stylesheet-workspace.context.ts index 23aa022152..d84322d9d2 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/workspace/stylesheet-workspace.context.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/templating/stylesheets/workspace/stylesheet-workspace.context.ts @@ -47,8 +47,8 @@ export class UmbStylesheetWorkspaceContext const path = this.getData()?.path?.replace(/\//g, '%2f'); const name = this.getData()?.name; - // TODO: %2F is a slash (/). Should we make it an actual slash in the URL? (%2F for now so that the server can find the correct stylesheet via URL) - return path && name ? `${path}%2F${name}` : name || ''; + // Note: %2f is a slash (/) + return path && name ? `${path}%2f${name}` : name || ''; } getData() {