V10: fix more nullable references (#12321)

* Add Nullable and WarningsAsErrors to Build.props

* Remove Nullable from cs proj, add ImplicitUsings to build.props

* Fix errors in core

* Fix in JsonSchema

* Fix infrastructure

* Add non-ambiguous using

* Fix Web/Lucene

* Fix backoffice

* Fix up new build errors from merge

Co-authored-by: Nikolaj Geisle <niko737@edu.ucl.dk>
This commit is contained in:
Nikolaj Geisle
2022-04-29 15:02:36 +02:00
committed by GitHub
parent 285c7e75a2
commit f23b57db65
49 changed files with 212 additions and 151 deletions

View File

@@ -159,7 +159,7 @@ namespace Umbraco.Cms.Web.BackOffice.Controllers
/// Returns all user groups
/// </summary>
/// <returns></returns>
public IEnumerable<UserGroupBasic?> GetUserGroups(bool onlyCurrentUserGroups = true)
public IEnumerable<UserGroupBasic> GetUserGroups(bool onlyCurrentUserGroups = true)
{
var allGroups = _umbracoMapper.MapEnumerable<IUserGroup, UserGroupBasic>(_userService.GetAllUserGroups())
.ToList();
@@ -170,7 +170,7 @@ namespace Umbraco.Cms.Web.BackOffice.Controllers
if (onlyCurrentUserGroups == false)
{
//this user is not an admin so in that case we need to exclude all admin users
allGroups.RemoveAt(allGroups.IndexOf(allGroups.Find(basic => basic?.Alias == Constants.Security.AdminGroupAlias)));
allGroups.RemoveAt(allGroups.IndexOf(allGroups.Find(basic => basic.Alias == Constants.Security.AdminGroupAlias)!));
return allGroups;
}