From f341206bfc197a2b5c7e44597971fe729d445c02 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20Lyngs=C3=B8?= Date: Thu, 18 Apr 2024 14:32:56 +0200 Subject: [PATCH] render clean up --- .../backoffice/components/backoffice-main.element.ts | 9 +++++---- .../src/packages/core/section/section-default.element.ts | 6 +----- .../section-main-views/section-main-views.element.ts | 6 +++--- 3 files changed, 9 insertions(+), 12 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/apps/backoffice/components/backoffice-main.element.ts b/src/Umbraco.Web.UI.Client/src/apps/backoffice/components/backoffice-main.element.ts index a04f0fad35..0eddd8fbc8 100644 --- a/src/Umbraco.Web.UI.Client/src/apps/backoffice/components/backoffice-main.element.ts +++ b/src/Umbraco.Web.UI.Client/src/apps/backoffice/components/backoffice-main.element.ts @@ -1,6 +1,6 @@ import type { UmbBackofficeContext } from '../backoffice.context.js'; import { UMB_BACKOFFICE_CONTEXT } from '../backoffice.context.js'; -import { css, html, customElement, state } from '@umbraco-cms/backoffice/external/lit'; +import { css, html, customElement, state, nothing } from '@umbraco-cms/backoffice/external/lit'; import { UmbSectionContext, UMB_SECTION_CONTEXT } from '@umbraco-cms/backoffice/section'; import type { UmbRoute, UmbRouterSlotChangeEvent } from '@umbraco-cms/backoffice/router'; import type { ManifestSection, UmbSectionElement } from '@umbraco-cms/backoffice/extension-registry'; @@ -99,17 +99,18 @@ export class UmbBackofficeMainElement extends UmbLitElement { render() { return this._routes.length > 0 ? html`` - : ''; + : nothing; } static styles = [ css` :host { - background-color: var(--uui-color-background); display: block; + background-color: var(--uui-color-background); + width: 100%; height: calc( 100% - 60px - ); // 60 => top header height, TODO: Make sure this comes from somewhere so it is maintainable and eventually responsive. + ); /* 60 => top header height, TODO: Make sure this comes from somewhere so it is maintainable and eventually responsive. */ } `, ]; diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/section/section-default.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/section/section-default.element.ts index 859f69b3b7..0c49c1ad17 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/section/section-default.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/section/section-default.element.ts @@ -86,7 +86,7 @@ export class UmbSectionDefaultElement extends UmbLitElement implements UmbSectio (app) => app.component, )} - ` + ` : nothing} ${this._routes && this._routes.length > 0 @@ -105,10 +105,6 @@ export class UmbSectionDefaultElement extends UmbLitElement implements UmbSectio height: 100%; display: flex; } - - h3 { - padding: var(--uui-size-4) var(--uui-size-8); - } `, ]; } diff --git a/src/Umbraco.Web.UI.Client/src/packages/core/section/section-main-views/section-main-views.element.ts b/src/Umbraco.Web.UI.Client/src/packages/core/section/section-main-views/section-main-views.element.ts index 6a7d3917b6..067981a818 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/core/section/section-main-views/section-main-views.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/core/section/section-main-views/section-main-views.element.ts @@ -98,7 +98,7 @@ export class UmbSectionMainViewElement extends UmbLitElement { ` - : html`${nothing}`; + : nothing; } #renderDashboards() { @@ -117,7 +117,7 @@ export class UmbSectionMainViewElement extends UmbLitElement { })} ` - : ''; + : nothing; } #renderViews() { @@ -140,7 +140,7 @@ export class UmbSectionMainViewElement extends UmbLitElement { })} ` - : ''; + : nothing; } static styles = [