From f42715548089e9fe294ba3c2ea6525b22fbd21db Mon Sep 17 00:00:00 2001
From: Shannon <sdeminick@gmail.com>
Date: Thu, 21 Nov 2019 19:39:30 +1100
Subject: [PATCH] Removes unused exceptions

---
 .../Exceptions/ConnectionException.cs         | 45 -------------------
 .../Migrations/DataLossException.cs           | 45 -------------------
 .../Services/Implement/PackagingService.cs    |  2 +-
 src/Umbraco.Core/Umbraco.Core.csproj          |  4 +-
 src/Umbraco.Web/Media/Exif/ExifExceptions.cs  | 40 -----------------
 .../Media/Exif/ExifExtendedProperty.cs        |  2 +-
 src/Umbraco.Web/Media/Exif/JPEGExceptions.cs  | 40 -----------------
 7 files changed, 3 insertions(+), 175 deletions(-)
 delete mode 100644 src/Umbraco.Core/Exceptions/ConnectionException.cs
 delete mode 100644 src/Umbraco.Core/Migrations/DataLossException.cs

diff --git a/src/Umbraco.Core/Exceptions/ConnectionException.cs b/src/Umbraco.Core/Exceptions/ConnectionException.cs
deleted file mode 100644
index 517d0633a0..0000000000
--- a/src/Umbraco.Core/Exceptions/ConnectionException.cs
+++ /dev/null
@@ -1,45 +0,0 @@
-using System;
-using System.Runtime.Serialization;
-
-namespace Umbraco.Core.Exceptions
-{
-    /// <summary>
-    /// The exception that is thrown when a connection fails.
-    /// </summary>
-    /// <seealso cref="System.Exception" />
-    [Serializable]
-    internal class ConnectionException : Exception
-    {
-        /// <summary>
-        /// Initializes a new instance of the <see cref="ConnectionException" /> class.
-        /// </summary>
-        public ConnectionException()
-        { }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="ConnectionException" /> class.
-        /// </summary>
-        /// <param name="message">The message that describes the error.</param>
-        public ConnectionException(string message)
-            : base(message)
-        { }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="ConnectionException" /> class.
-        /// </summary>
-        /// <param name="message">The error message that explains the reason for the exception.</param>
-        /// <param name="innerException">The exception that is the cause of the current exception, or a null reference (<see langword="Nothing" /> in Visual Basic) if no inner exception is specified.</param>
-        public ConnectionException(string message, Exception innerException)
-            : base(message, innerException)
-        { }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="ConnectionException" /> class.
-        /// </summary>
-        /// <param name="info">The <see cref="T:System.Runtime.Serialization.SerializationInfo" /> that holds the serialized object data about the exception being thrown.</param>
-        /// <param name="context">The <see cref="T:System.Runtime.Serialization.StreamingContext" /> that contains contextual information about the source or destination.</param>
-        protected ConnectionException(SerializationInfo info, StreamingContext context)
-            : base(info, context)
-        { }
-    }
-}
diff --git a/src/Umbraco.Core/Migrations/DataLossException.cs b/src/Umbraco.Core/Migrations/DataLossException.cs
deleted file mode 100644
index 1ba10bce62..0000000000
--- a/src/Umbraco.Core/Migrations/DataLossException.cs
+++ /dev/null
@@ -1,45 +0,0 @@
-using System;
-using System.Runtime.Serialization;
-
-namespace Umbraco.Core.Migrations
-{
-    /// <summary>
-    /// The exception that is thrown if a migration has executed, but the whole process has failed and cannot be rolled back.
-    /// </summary>
-    /// <seealso cref="System.Exception" />
-    [Serializable]
-    internal class DataLossException : Exception
-    {
-        /// <summary>
-        /// Initializes a new instance of the <see cref="DataLossException" /> class.
-        /// </summary>
-        public DataLossException()
-        { }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="DataLossException" /> class.
-        /// </summary>
-        /// <param name="message">The message that describes the error.</param>
-        public DataLossException(string message)
-            : base(message)
-        { }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="DataLossException" /> class.
-        /// </summary>
-        /// <param name="message">The error message that explains the reason for the exception.</param>
-        /// <param name="innerException">The inner exception.</param>
-        public DataLossException(string message, Exception innerException)
-            : base(message, innerException)
-        { }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="DataLossException" /> class.
-        /// </summary>
-        /// <param name="info">The <see cref="T:System.Runtime.Serialization.SerializationInfo" /> that holds the serialized object data about the exception being thrown.</param>
-        /// <param name="context">The <see cref="T:System.Runtime.Serialization.StreamingContext" /> that contains contextual information about the source or destination.</param>
-        protected DataLossException(SerializationInfo info, StreamingContext context)
-            : base(info, context)
-        { }
-    }
-}
diff --git a/src/Umbraco.Core/Services/Implement/PackagingService.cs b/src/Umbraco.Core/Services/Implement/PackagingService.cs
index b4dcc70a96..d85c688a0d 100644
--- a/src/Umbraco.Core/Services/Implement/PackagingService.cs
+++ b/src/Umbraco.Core/Services/Implement/PackagingService.cs
@@ -57,7 +57,7 @@ namespace Umbraco.Core.Services.Implement
             }
             catch (HttpRequestException ex)
             {
-                throw new ConnectionException("An error occurring downloading the package from " + url, ex);
+                throw new HttpRequestException("An error occurring downloading the package from " + url, ex);
             }
 
             //successful
diff --git a/src/Umbraco.Core/Umbraco.Core.csproj b/src/Umbraco.Core/Umbraco.Core.csproj
index d6b63880d6..6a0a77794e 100755
--- a/src/Umbraco.Core/Umbraco.Core.csproj
+++ b/src/Umbraco.Core/Umbraco.Core.csproj
@@ -680,7 +680,6 @@
     <Compile Include="Exceptions\ArgumentNullOrEmptyException.cs" />
     <Compile Include="Exceptions\AuthorizationException.cs" />
     <Compile Include="Exceptions\BootFailedException.cs" />
-    <Compile Include="Exceptions\ConnectionException.cs" />
     <Compile Include="Exceptions\DataOperationException.cs" />
     <Compile Include="Exceptions\InvalidCompositionException.cs" />
     <Compile Include="Composing\LightInject\LightInjectException.cs" />
@@ -1065,7 +1064,6 @@
     <Compile Include="Persistence\Mappers\UserGroupMapper.cs" />
     <Compile Include="Persistence\Mappers\UserMapper.cs" />
     <Compile Include="Persistence\Mappers\UserSectionMapper.cs" />
-    <Compile Include="Migrations\DataLossException.cs" />
     <Compile Include="Migrations\IMigration.cs" />
     <Compile Include="Migrations\IMigrationContext.cs" />
     <Compile Include="Migrations\IMigrationExpression.cs" />
@@ -1572,4 +1570,4 @@
     <Folder Include="Auditing\" />
   </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
-</Project>
+</Project>
\ No newline at end of file
diff --git a/src/Umbraco.Web/Media/Exif/ExifExceptions.cs b/src/Umbraco.Web/Media/Exif/ExifExceptions.cs
index 976fb849ed..3d2ce61e9e 100644
--- a/src/Umbraco.Web/Media/Exif/ExifExceptions.cs
+++ b/src/Umbraco.Web/Media/Exif/ExifExceptions.cs
@@ -44,44 +44,4 @@ namespace Umbraco.Web.Media.Exif
         { }
     }
 
-    /// <summary>
-    /// The exception that is thrown when an invalid enum type is given to an ExifEnumProperty.
-    /// </summary>
-    /// <seealso cref="System.Exception" />
-    [Serializable]
-    internal class UnknownEnumTypeException : Exception
-    {
-        /// <summary>
-        /// Initializes a new instance of the <see cref="UnknownEnumTypeException" /> class.
-        /// </summary>
-        public UnknownEnumTypeException()
-            : base("Unknown enum type.")
-        { }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="UnknownEnumTypeException" /> class.
-        /// </summary>
-        /// <param name="message">The message that describes the error.</param>
-        public UnknownEnumTypeException(string message)
-            : base(message)
-        { }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="UnknownEnumTypeException" /> class.
-        /// </summary>
-        /// <param name="message">The error message that explains the reason for the exception.</param>
-        /// <param name="innerException">The exception that is the cause of the current exception, or a null reference (<see langword="Nothing" /> in Visual Basic) if no inner exception is specified.</param>
-        public UnknownEnumTypeException(string message, Exception innerException)
-            : base(message, innerException)
-        { }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="UnknownEnumTypeException" /> class.
-        /// </summary>
-        /// <param name="info">The <see cref="T:System.Runtime.Serialization.SerializationInfo" /> that holds the serialized object data about the exception being thrown.</param>
-        /// <param name="context">The <see cref="T:System.Runtime.Serialization.StreamingContext" /> that contains contextual information about the source or destination.</param>
-        protected UnknownEnumTypeException(SerializationInfo info, StreamingContext context)
-            : base(info, context)
-        { }
-    }
 }
diff --git a/src/Umbraco.Web/Media/Exif/ExifExtendedProperty.cs b/src/Umbraco.Web/Media/Exif/ExifExtendedProperty.cs
index 40ba275fe4..63c1ce3365 100644
--- a/src/Umbraco.Web/Media/Exif/ExifExtendedProperty.cs
+++ b/src/Umbraco.Web/Media/Exif/ExifExtendedProperty.cs
@@ -64,7 +64,7 @@ namespace Umbraco.Web.Media.Exif
                     return new ExifInterOperability(tagid, 3, 1, ExifBitConverter.GetBytes((ushort)((object)mValue), BitConverterEx.SystemByteOrder, BitConverterEx.SystemByteOrder));
                 }
                 else
-                    throw new UnknownEnumTypeException();
+                    throw new InvalidOperationException($"An invalid enum type ({basetype.FullName}) was provided for type {type.FullName}");
             }
         }
     }
diff --git a/src/Umbraco.Web/Media/Exif/JPEGExceptions.cs b/src/Umbraco.Web/Media/Exif/JPEGExceptions.cs
index f23dbeb4d4..40fd9f3be8 100644
--- a/src/Umbraco.Web/Media/Exif/JPEGExceptions.cs
+++ b/src/Umbraco.Web/Media/Exif/JPEGExceptions.cs
@@ -4,46 +4,6 @@ using System.Runtime.Serialization;
 namespace Umbraco.Web.Media.Exif
 {
 
-    /// <summary>
-    /// The exception that is thrown when the format of the image file could not be understood.
-    /// </summary>
-    /// <seealso cref="System.Exception" />
-    [Serializable]
-    internal class NotValidImageFileException : Exception
-    {
-        /// <summary>
-        /// Initializes a new instance of the <see cref="NotValidImageFileException" /> class.
-        /// </summary>
-        public NotValidImageFileException()
-            : base("Not a valid image file.")
-        { }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="NotValidImageFileException" /> class.
-        /// </summary>
-        /// <param name="message">The message that describes the error.</param>
-        public NotValidImageFileException(string message)
-            : base(message)
-        { }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="NotValidImageFileException" /> class.
-        /// </summary>
-        /// <param name="message">The error message that explains the reason for the exception.</param>
-        /// <param name="innerException">The exception that is the cause of the current exception, or a null reference (<see langword="Nothing" /> in Visual Basic) if no inner exception is specified.</param>
-        public NotValidImageFileException(string message, Exception innerException)
-            : base(message, innerException)
-        { }
-
-        /// <summary>
-        /// Initializes a new instance of the <see cref="NotValidImageFileException" /> class.
-        /// </summary>
-        /// <param name="info">The <see cref="T:System.Runtime.Serialization.SerializationInfo" /> that holds the serialized object data about the exception being thrown.</param>
-        /// <param name="context">The <see cref="T:System.Runtime.Serialization.StreamingContext" /> that contains contextual information about the source or destination.</param>
-        protected NotValidImageFileException(SerializationInfo info, StreamingContext context)
-            : base(info, context)
-        { }
-    }
 
     /// <summary>
     /// The exception that is thrown when the format of the JPEG file could not be understood.