V10: fix build warnings infrastructure (#12369)

* Run code cleanup * Run dotnet format * Start manual fixes * Manual fixing of warnings * Fix nullability in columnalias * Fix tests * Fix up after merge * Start updating after review * Update editorconfig to contain new static & const rules * Fix up editorconfig to not contain duplicate rules * Fix up static member names * Fix up according to review * Update src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.DistributedCache.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.Repositories.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.Repositories.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Examine/ContentIndexPopulator.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Examine/ContentIndexPopulator.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Examine/ContentValueSetValidator.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Examine/ContentValueSetValidator.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Examine/ContentValueSetValidator.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Examine/ExamineUmbracoIndexingHandler.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Examine/PublishedContentIndexPopulator.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Extensions/InstanceIdentifiableExtensions.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/HostedServices/RecurringHostedServiceBase.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/HostedServices/ReportSiteTask.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Logging/Serilog/LoggerConfigExtensions.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Logging/Serilog/LoggerConfigExtensions.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Macros/MacroTagParser.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Macros/MacroTagParser.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Macros/MacroTagParser.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Migrations/Expressions/Alter/Table/IAlterTableColumnOptionBuilder.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Migrations/Upgrade/V_10_0_0/AddMemberPropertiesAsColumns.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/ModelsBuilder/Building/TextBuilder.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/ModelsBuilder/Building/TextBuilder.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/ModelsBuilder/Building/TextBuilder.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/ModelsBuilder/Building/TextBuilder.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/ModelsBuilder/Building/TextBuilder.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/ModelsBuilder/Building/TextBuilder.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/ModelsBuilder/Building/TextBuilder.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Persistence/Dtos/ExternalLoginDto.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Persistence/Mappers/AccessMapper.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Persistence/Mappers/AuditEntryMapper.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Persistence/Mappers/MediaMapper.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Persistence/Mappers/MemberMapper.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Persistence/Mappers/PropertyGroupMapper.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Persistence/Mappers/PropertyGroupMapper.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Persistence/Mappers/PropertyTypeMapper.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Persistence/Mappers/PropertyTypeMapper.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Persistence/Mappers/RelationTypeMapper.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Persistence/Mappers/RelationTypeMapper.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Persistence/NPocoMapperCollectionBuilder.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Persistence/Querying/ExpressionVisitorBase.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Update src/Umbraco.Infrastructure/Persistence/Repositories/Implement/ExternalLoginRepository.cs Co-authored-by: Mole <nikolajlauridsen@protonmail.ch> * Fix [..] to substring * Fix after merge with 10/dev * Fox ContentValueSetValidator.cs * Update LoggerConfigExtensions Co-authored-by: Nikolaj Geisle <niko737@edu.ucl.dk> Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
2022-06-02 08:18:31 +02:00
parent adcc9a0e1f
commit f4e333c178
838 changed files with 64052 additions and 61173 deletions
--- a/src/Umbraco.Infrastructure/ModelsBuilder/ModelsGenerationError.cs
+++ b/src/Umbraco.Infrastructure/ModelsBuilder/ModelsGenerationError.cs
@@ -1,87 +1,84 @@
-using System;
-using System.IO;
 using System.Text;
 using Microsoft.Extensions.Options;
 using Umbraco.Cms.Core.Configuration.Models;
 using Umbraco.Cms.Core.Hosting;
 using Umbraco.Extensions;

-namespace Umbraco.Cms.Infrastructure.ModelsBuilder
+namespace Umbraco.Cms.Infrastructure.ModelsBuilder;
+
+public sealed class ModelsGenerationError
 {
-    public sealed class ModelsGenerationError
+    private readonly IHostingEnvironment _hostingEnvironment;
+    private ModelsBuilderSettings _config;
+
+    /// <summary>
+    ///     Initializes a new instance of the <see cref="ModelsGenerationError" /> class.
+    /// </summary>
+    public ModelsGenerationError(IOptionsMonitor<ModelsBuilderSettings> config, IHostingEnvironment hostingEnvironment)
    {
-        private ModelsBuilderSettings _config;
-        private readonly IHostingEnvironment _hostingEnvironment;
+        _config = config.CurrentValue;
+        _hostingEnvironment = hostingEnvironment;
+        config.OnChange(x => _config = x);
+    }

-        /// <summary>
-        /// Initializes a new instance of the <see cref="ModelsGenerationError"/> class.
-        /// </summary>
-        public ModelsGenerationError(IOptionsMonitor<ModelsBuilderSettings> config, IHostingEnvironment hostingEnvironment)
+    public void Clear()
+    {
+        var errFile = GetErrFile();
+        if (errFile == null)
        {
-            _config = config.CurrentValue;
-            _hostingEnvironment = hostingEnvironment;
-            config.OnChange(x => _config = x);
+            return;
        }

-        public void Clear()
-        {
-            var errFile = GetErrFile();
-            if (errFile == null)
-            {
-                return;
-            }
+        // "If the file to be deleted does not exist, no exception is thrown."
+        File.Delete(errFile);
+    }

-            // "If the file to be deleted does not exist, no exception is thrown."
-            File.Delete(errFile);
+    public void Report(string message, Exception e)
+    {
+        var errFile = GetErrFile();
+        if (errFile == null)
+        {
+            return;
        }

-        public void Report(string message, Exception e)
+        var sb = new StringBuilder();
+        sb.Append(message);
+        sb.Append("\r\n");
+        sb.Append(e.Message);
+        sb.Append("\r\n\r\n");
+        sb.Append(e.StackTrace);
+        sb.Append("\r\n");
+
+        File.WriteAllText(errFile, sb.ToString());
+    }
+
+    public string? GetLastError()
+    {
+        var errFile = GetErrFile();
+        if (errFile == null)
        {
-            var errFile = GetErrFile();
-            if (errFile == null)
-            {
-                return;
-            }
-
-            var sb = new StringBuilder();
-            sb.Append(message);
-            sb.Append("\r\n");
-            sb.Append(e.Message);
-            sb.Append("\r\n\r\n");
-            sb.Append(e.StackTrace);
-            sb.Append("\r\n");
-
-            File.WriteAllText(errFile, sb.ToString());
+            return null;
        }

-        public string? GetLastError()
+        try
        {
-            var errFile = GetErrFile();
-            if (errFile == null)
-            {
-                return null;
-            }
-
-            try
-            {
-                return File.ReadAllText(errFile);
-            }
-            catch
-            {
-                // accepted
-                return null;
-            }
+            return File.ReadAllText(errFile);
        }
-
-        private string? GetErrFile()
+        catch
        {
-            var modelsDirectory = _config.ModelsDirectoryAbsolute(_hostingEnvironment);
-            if (!Directory.Exists(modelsDirectory))
-            {
-                return null;
-            }
-
-            return Path.Combine(modelsDirectory, "models.err");
+            // accepted
+            return null;
        }
    }
+
+    private string? GetErrFile()
+    {
+        var modelsDirectory = _config.ModelsDirectoryAbsolute(_hostingEnvironment);
+        if (!Directory.Exists(modelsDirectory))
+        {
+            return null;
+        }
+
+        return Path.Combine(modelsDirectory, "models.err");
+    }
 }