From f99b542ece1bc741683ce6b5e89efb91d89625b2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20Lyngs=C3=B8?= Date: Wed, 16 Oct 2024 11:40:04 +0200 Subject: [PATCH] expose button for no content editor block --- .../block-grid-block-inline.element.ts | 13 +------- .../block-grid-block.element.ts | 30 ++++++++++++++++++- .../block/context/block-entry.context.ts | 4 +-- 3 files changed, 32 insertions(+), 15 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/components/block-grid-block-inline/block-grid-block-inline.element.ts b/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/components/block-grid-block-inline/block-grid-block-inline.element.ts index 33dde6ab6c..82e3f4333f 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/components/block-grid-block-inline/block-grid-block-inline.element.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/block/block-grid/components/block-grid-block-inline/block-grid-block-inline.element.ts @@ -48,9 +48,6 @@ export class UmbBlockGridBlockInlineElement extends UmbLitElement { @property({ attribute: false }) content?: UmbBlockDataType; - @state() - private _exposed?: boolean; - @state() _inlineProperty?: UmbPropertyTypeModel; @@ -95,14 +92,6 @@ export class UmbBlockGridBlockInlineElement extends UmbLitElement { 'observeProperties', ); - this.observe( - this.#workspaceContext.exposed, - (exposed) => { - this._exposed = exposed; - }, - 'observeExposed', - ); - this.observe( context.content.structure.ownerContentTypeName, (name) => { @@ -174,7 +163,7 @@ export class UmbBlockGridBlockInlineElement extends UmbLitElement { } #renderInside() { - if (this._exposed === false) { + if (this.unpublished === true) { return html` { + this.#context = context; + this.observe(context.contentElementTypeName, (name) => { + this._ownerContentTypeName = name; + }); + }); + } + + #expose = () => { + this.#context?.expose(); + }; + override render() { return html` + ${this.config?.showContentEdit === false && this.unpublished + ? html` + + + ` + : nothing} diff --git a/src/Umbraco.Web.UI.Client/src/packages/block/block/context/block-entry.context.ts b/src/Umbraco.Web.UI.Client/src/packages/block/block/context/block-entry.context.ts index 90897490a7..1e5e0cd222 100644 --- a/src/Umbraco.Web.UI.Client/src/packages/block/block/context/block-entry.context.ts +++ b/src/Umbraco.Web.UI.Client/src/packages/block/block/context/block-entry.context.ts @@ -46,10 +46,10 @@ export abstract class UmbBlockEntryContext< #contentKey?: string; #variantId = new UmbClassState(undefined); - protected _variantId = this.#variantId.asObservable(); + protected readonly _variantId = this.#variantId.asObservable(); #hasExpose = new UmbBooleanState(undefined); - hasExpose = this.#hasExpose.asObservable(); + readonly hasExpose = this.#hasExpose.asObservable(); public readonly readOnlyState = new UmbReadOnlyVariantStateManager(this);