From f9ad6363443d50aaa01015a70f6e4bb3f8028b0e Mon Sep 17 00:00:00 2001 From: Nathan Woulfe Date: Sat, 25 Feb 2023 00:48:09 +1000 Subject: [PATCH] Member Group edit view - minor styles (#543) minor style tidyup Co-authored-by: Mads Rasmussen --- .../member-groups/workspace/member-group-workspace.context.ts | 3 ++- .../views/info/workspace-view-member-group-info.element.ts | 4 +--- .../workspace-property-layout.element.ts | 4 ++++ 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/Umbraco.Web.UI.Client/src/backoffice/members/member-groups/workspace/member-group-workspace.context.ts b/src/Umbraco.Web.UI.Client/src/backoffice/members/member-groups/workspace/member-group-workspace.context.ts index 194e50c0ae..0368570c64 100644 --- a/src/Umbraco.Web.UI.Client/src/backoffice/members/member-groups/workspace/member-group-workspace.context.ts +++ b/src/Umbraco.Web.UI.Client/src/backoffice/members/member-groups/workspace/member-group-workspace.context.ts @@ -39,8 +39,9 @@ export class UmbWorkspaceMemberGroupContext this.#data.update({ name }); } + // eslint-disable-next-line @typescript-eslint/no-unused-vars setPropertyValue(alias: string, value: string) { - // Not implemented for this context - member groups have no properties + // Not implemented for this context - member groups have no properties for editing return; } diff --git a/src/Umbraco.Web.UI.Client/src/backoffice/members/member-groups/workspace/views/info/workspace-view-member-group-info.element.ts b/src/Umbraco.Web.UI.Client/src/backoffice/members/member-groups/workspace/views/info/workspace-view-member-group-info.element.ts index 2a920cb34b..faf7d7e59d 100644 --- a/src/Umbraco.Web.UI.Client/src/backoffice/members/member-groups/workspace/views/info/workspace-view-member-group-info.element.ts +++ b/src/Umbraco.Web.UI.Client/src/backoffice/members/member-groups/workspace/views/info/workspace-view-member-group-info.element.ts @@ -42,7 +42,6 @@ export class UmbWorkspaceViewMemberGroupInfoElement extends UmbLitElement { // TODO: Figure out if this is the best way to consume the context or if it can be strongly typed with an UmbContextToken this.consumeContext('umbWorkspaceContext', (instance) => { this.#workspaceContext = instance; - console.log(instance); this.#observeMemberGroup(); }); } @@ -69,11 +68,10 @@ export class UmbWorkspaceViewMemberGroupInfoElement extends UmbLitElement { `; } - // TODO => should use umb-empty-state when it exists private _renderMemberGroupInfo() { return html` -

Member groups have no additional properties for editing.

+ Member groups have no additional properties for editing.
`; } diff --git a/src/Umbraco.Web.UI.Client/src/backoffice/shared/components/workspace/workspace-property-layout/workspace-property-layout.element.ts b/src/Umbraco.Web.UI.Client/src/backoffice/shared/components/workspace/workspace-property-layout/workspace-property-layout.element.ts index 82c6706f0d..3a77763147 100644 --- a/src/Umbraco.Web.UI.Client/src/backoffice/shared/components/workspace/workspace-property-layout/workspace-property-layout.element.ts +++ b/src/Umbraco.Web.UI.Client/src/backoffice/shared/components/workspace/workspace-property-layout/workspace-property-layout.element.ts @@ -29,6 +29,10 @@ export class UmbWorkspacePropertyLayoutElement extends LitElement { border-bottom:none; } + :host(:first-of-type) { + padding-top:0; + } + p { margin-bottom: 0; }