This commit is contained in:
Niels Lyngsø
2024-08-14 21:32:02 +02:00
parent eeb71900fc
commit fabb3d6d97
4 changed files with 3 additions and 4 deletions

View File

@@ -5,7 +5,6 @@ export interface UmbWorkspaceModalData<DataModelType = unknown> {
baseDataPath?: string;
}
// TODO: It would be good with a WorkspaceValueBaseType, to avoid the hardcoded type for unique here:
export type UmbWorkspaceModalValue =
| {
unique: string;

View File

@@ -181,7 +181,6 @@ export class UmbPropertyTypeWorkspaceViewSettingsElement extends UmbLitElement i
return html`
<uui-box class="uui-text">
<div class="container">
<!-- TODO: Align styling across this and the property of document type workspace editor, or consider if this can go away for a different UX flow -->
<uui-form-validation-message>
<uui-input
id="name-input"

View File

@@ -92,7 +92,6 @@ export class UmbServerModelValidatorContext
culture: variant.culture,
segment: variant.segment,
})}].value`;
// TODO: Make a const that holds this translation-key:
this.#context!.messages.addMessages('server', path, [UMB_VALIDATION_EMPTY_LOCALIZATION_KEY]);
});
});

View File

@@ -109,6 +109,8 @@ export abstract class UmbSubmittableWorkspaceContextBase<WorkspaceDataModelType>
#rejectSubmit = () => {
if (this.#submitPromise) {
// TODO: Capture the validation contexts messages on open, and then reset to them in this case. [NL]
this.#submitReject?.();
this.#submitPromise = undefined;
this.#submitResolve = undefined;
@@ -134,7 +136,7 @@ export abstract class UmbSubmittableWorkspaceContextBase<WorkspaceDataModelType>
this.#resolveSubmit();
// Calling reset on the validation context here. [NL]
// TODO: Consider if we really ant this, cause on save, we do not want to reset this... [NL] (Also adapt to concept of multiple validation contexts)
// TODO: Capture the validation messages on open, and then reset to that.
//this.validation.reset();
};