From fbd87b207bb48d5e6fdb97c2d4b7953447884659 Mon Sep 17 00:00:00 2001
From: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com>
Date: Tue, 4 Apr 2023 16:58:06 +0200
Subject: [PATCH] update urls to encode uri components

---
 .../log-viewer-message-templates-overview.element.ts        | 6 ++++--
 .../log-viewer-saved-searches-overview.element.ts           | 4 ++--
 .../views/search/components/log-viewer-message.element.ts   | 6 ++++--
 3 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/src/Umbraco.Web.UI.Client/src/backoffice/settings/logviewer/workspace/views/overview/components/log-viewer-message-templates-overview.element.ts b/src/Umbraco.Web.UI.Client/src/backoffice/settings/logviewer/workspace/views/overview/components/log-viewer-message-templates-overview.element.ts
index d2c29aafcb..1e10aff9bb 100644
--- a/src/Umbraco.Web.UI.Client/src/backoffice/settings/logviewer/workspace/views/overview/components/log-viewer-message-templates-overview.element.ts
+++ b/src/Umbraco.Web.UI.Client/src/backoffice/settings/logviewer/workspace/views/overview/components/log-viewer-message-templates-overview.element.ts
@@ -68,7 +68,7 @@ export class UmbLogViewerMessageTemplatesOverviewElement extends UmbLitElement {
 			<uui-button
 				label="${searchListItem.name ?? ''}"
 				title="${searchListItem.name ?? ''}"
-				href=${`section/settings/workspace/logviewer/search/${searchListItem.query}`}>
+				href=${`section/settings/workspace/logviewer/search/?lq=${searchListItem.query}`}>
 				<uui-icon name="umb:search"></uui-icon>${searchListItem.name}
 			</uui-button>
 		</li>`;
@@ -90,7 +90,9 @@ export class UmbLogViewerMessageTemplatesOverviewElement extends UmbLitElement {
 									html`<uui-table-row>
 										<uui-table-cell>
 											<a
-												href=${`section/settings/workspace/logviewer/search/@MessageTemplate='${template.messageTemplate}'`}>
+												href=${`section/settings/workspace/logviewer/search/?lq=${encodeURIComponent(
+													`@MessageTemplate='${template.messageTemplate}'`
+												)}`}>
 												<span>${template.messageTemplate}</span> <span>${template.count}</span>
 											</a>
 										</uui-table-cell>
diff --git a/src/Umbraco.Web.UI.Client/src/backoffice/settings/logviewer/workspace/views/overview/components/log-viewer-saved-searches-overview.element.ts b/src/Umbraco.Web.UI.Client/src/backoffice/settings/logviewer/workspace/views/overview/components/log-viewer-saved-searches-overview.element.ts
index f36787489f..a918939169 100644
--- a/src/Umbraco.Web.UI.Client/src/backoffice/settings/logviewer/workspace/views/overview/components/log-viewer-saved-searches-overview.element.ts
+++ b/src/Umbraco.Web.UI.Client/src/backoffice/settings/logviewer/workspace/views/overview/components/log-viewer-saved-searches-overview.element.ts
@@ -62,7 +62,7 @@ export class UmbLogViewerSavedSearchesOverviewElement extends UmbLitElement {
 			<uui-button
 				label="${searchListItem.name ?? ''}"
 				title="${searchListItem.name ?? ''}"
-				href=${`section/settings/workspace/logviewer/search/${searchListItem.query}`}>
+				href=${`section/settings/workspace/logviewer/search/?lq=${encodeURIComponent(searchListItem.query ?? '')}`}>
 				<uui-icon name="umb:search"></uui-icon>${searchListItem.name}
 			</uui-button>
 		</li>`;
@@ -71,7 +71,7 @@ export class UmbLogViewerSavedSearchesOverviewElement extends UmbLitElement {
 	render() {
 		return html` <uui-box id="saved-searches" headline="Saved searches">
 			<ul>
-				${this.#renderSearchItem({ name: 'All logs', query: '*' })} ${this._savedSearches.map(this.#renderSearchItem)}
+				${this.#renderSearchItem({ name: 'All logs', query: '' })} ${this._savedSearches.map(this.#renderSearchItem)}
 			</ul>
 		</uui-box>`;
 	}
diff --git a/src/Umbraco.Web.UI.Client/src/backoffice/settings/logviewer/workspace/views/search/components/log-viewer-message.element.ts b/src/Umbraco.Web.UI.Client/src/backoffice/settings/logviewer/workspace/views/search/components/log-viewer-message.element.ts
index 92154cf5f7..d4fade3f9d 100644
--- a/src/Umbraco.Web.UI.Client/src/backoffice/settings/logviewer/workspace/views/search/components/log-viewer-message.element.ts
+++ b/src/Umbraco.Web.UI.Client/src/backoffice/settings/logviewer/workspace/views/search/components/log-viewer-message.element.ts
@@ -219,7 +219,7 @@ export class UmbLogViewerMessageElement extends UmbLitElement {
 			queryString = name + '=' + value;
 		}
 
-		return queryString;
+		return encodeURIComponent(queryString);
 	}
 
 	#setOpen(event: Event) {
@@ -259,7 +259,9 @@ export class UmbLogViewerMessageElement extends UmbLitElement {
 												look="secondary"
 												label="Find logs with ${property.name}"
 												title="Find logs with ${property.name}"
-												href=${`section/settings/workspace/logviewer/search/${this._findLogsWithProperty(property)}`}>
+												href=${`section/settings/workspace/logviewer/search/?lq=${this._findLogsWithProperty(
+													property
+												)}`}>
 												<uui-icon name="umb:search"></uui-icon>
 										  </uui-button>`
 										: ''}