From fd3ef483677ce54130800caf4f2527dd6cf56349 Mon Sep 17 00:00:00 2001 From: Benjamin Carleski Date: Tue, 21 Jan 2020 17:03:46 -0800 Subject: [PATCH] Use dependency injection for config classes --- src/Umbraco.Tests/TestHelpers/BaseWebTest.cs | 6 +++-- .../AuthenticationControllerTests.cs | 4 +++- .../Web/Controllers/UsersControllerTests.cs | 13 +++++++---- .../Umbraco/Views/AuthorizeUpgrade.cshtml | 4 ++-- .../Umbraco/Views/Default.cshtml | 2 +- .../Editors/AuthenticationController.cs | 7 ++++-- .../Editors/BackOfficeController.cs | 21 +++++++++++------- src/Umbraco.Web/Editors/BackOfficeModel.cs | 5 ++++- .../Editors/BackOfficePreviewModel.cs | 3 ++- .../Editors/BackOfficeServerVariables.cs | 21 ++++++++++-------- src/Umbraco.Web/Editors/CodeFileController.cs | 12 +++++----- .../Editors/CurrentUserController.cs | 8 +++++-- src/Umbraco.Web/Editors/DataTypeController.cs | 7 ++++-- src/Umbraco.Web/Editors/MediaController.cs | 10 ++++++--- src/Umbraco.Web/Editors/PreviewController.cs | 10 ++++++--- .../RedirectUrlManagementController.cs | 7 ++++-- src/Umbraco.Web/Editors/TinyMceController.cs | 6 +++-- src/Umbraco.Web/Editors/TourController.cs | 7 ++++-- src/Umbraco.Web/Editors/UsersController.cs | 22 +++++++++++-------- .../FolderAndFilePermissionsCheck.cs | 13 ++++++----- .../HealthCheck/HealthCheckController.cs | 6 ++--- .../EmailNotificationMethod.cs | 7 ++++-- .../HtmlHelperBackOfficeExtensions.cs | 5 +++-- .../Install/Controllers/InstallController.cs | 6 ++--- src/Umbraco.Web/Install/InstallHelper.cs | 6 +++-- .../InstallSteps/DatabaseConfigureStep.cs | 8 ++++--- .../InstallSteps/DatabaseUpgradeStep.cs | 9 +++++--- .../Install/InstallSteps/NewInstallStep.cs | 11 +++++++--- .../JavaScript/JsInitialization.cs | 5 +++-- .../UmbracoClientDependencyLoader.cs | 7 +++--- .../Models/Mapping/DataTypeMapDefinition.cs | 7 ++++-- .../Models/Mapping/MediaMapDefinition.cs | 9 +++++--- .../Mvc/UmbracoViewPageOfTModel.cs | 17 ++++++++++---- src/Umbraco.Web/Routing/PublishedRequest.cs | 7 ++++-- src/Umbraco.Web/Routing/PublishedRouter.cs | 7 ++++-- src/Umbraco.Web/Runtime/WebInitialComposer.cs | 2 +- .../Scheduling/HealthCheckNotifier.cs | 9 ++++---- .../Scheduling/SchedulerComponent.cs | 14 ++++++++---- .../Security/AppBuilderExtensions.cs | 10 +++++---- .../BackOfficeCookieAuthenticationProvider.cs | 7 ++++-- src/Umbraco.Web/Security/WebSecurity.cs | 6 ++--- src/Umbraco.Web/UmbracoDefaultOwinStartup.cs | 3 +-- 42 files changed, 230 insertions(+), 126 deletions(-) diff --git a/src/Umbraco.Tests/TestHelpers/BaseWebTest.cs b/src/Umbraco.Tests/TestHelpers/BaseWebTest.cs index f76a8452d8..077ed80efa 100644 --- a/src/Umbraco.Tests/TestHelpers/BaseWebTest.cs +++ b/src/Umbraco.Tests/TestHelpers/BaseWebTest.cs @@ -15,6 +15,7 @@ using Umbraco.Core.Strings; using Umbraco.Tests.PublishedContent; using Umbraco.Tests.TestHelpers.Stubs; using Umbraco.Tests.Testing.Objects.Accessors; +using Umbraco.Web.Composing; using Umbraco.Web.Models.PublishedContent; using Umbraco.Web.Routing; @@ -88,7 +89,7 @@ namespace Umbraco.Tests.TestHelpers internal PublishedRouter CreatePublishedRouter(IFactory container = null, ContentFinderCollection contentFinders = null) { - return CreatePublishedRouter(TestObjects.GetUmbracoSettings().WebRouting, container, contentFinders); + return CreatePublishedRouter(TestObjects.GetUmbracoSettings().WebRouting, container ?? Factory, contentFinders); } internal static PublishedRouter CreatePublishedRouter(IWebRoutingSection webRoutingSection, IFactory container = null, ContentFinderCollection contentFinders = null) @@ -99,7 +100,8 @@ namespace Umbraco.Tests.TestHelpers new TestLastChanceFinder(), new TestVariationContextAccessor(), container?.TryGetInstance() ?? ServiceContext.CreatePartial(), - new ProfilingLogger(Mock.Of(), Mock.Of())); + new ProfilingLogger(Mock.Of(), Mock.Of()), + container?.TryGetInstance() ?? Current.Factory.GetInstance()); } } } diff --git a/src/Umbraco.Tests/Web/Controllers/AuthenticationControllerTests.cs b/src/Umbraco.Tests/Web/Controllers/AuthenticationControllerTests.cs index b03c581657..3705d23162 100644 --- a/src/Umbraco.Tests/Web/Controllers/AuthenticationControllerTests.cs +++ b/src/Umbraco.Tests/Web/Controllers/AuthenticationControllerTests.cs @@ -32,6 +32,7 @@ using Umbraco.Web.Editors; using Umbraco.Web.Features; using Umbraco.Web.Models.ContentEditing; using IUser = Umbraco.Core.Models.Membership.IUser; +using Umbraco.Core.Configuration.UmbracoSettings; namespace Umbraco.Tests.Web.Controllers { @@ -85,7 +86,8 @@ namespace Umbraco.Tests.Web.Controllers Factory.GetInstance(), Factory.GetInstance(), helper, - Factory.GetInstance()); + Factory.GetInstance(), + Factory.GetInstance()); return usersController; } diff --git a/src/Umbraco.Tests/Web/Controllers/UsersControllerTests.cs b/src/Umbraco.Tests/Web/Controllers/UsersControllerTests.cs index ccd9ff2063..ca355e096a 100644 --- a/src/Umbraco.Tests/Web/Controllers/UsersControllerTests.cs +++ b/src/Umbraco.Tests/Web/Controllers/UsersControllerTests.cs @@ -35,6 +35,7 @@ using Umbraco.Web.Features; using Umbraco.Web.Models.ContentEditing; using IUser = Umbraco.Core.Models.Membership.IUser; using Umbraco.Core.Mapping; +using Umbraco.Core.Configuration.UmbracoSettings; namespace Umbraco.Tests.Web.Controllers { @@ -90,7 +91,8 @@ namespace Umbraco.Tests.Web.Controllers helper, Factory.GetInstance(), ShortStringHelper, - Factory.GetInstance()); + Factory.GetInstance(), + Factory.GetInstance()); return usersController; } @@ -157,7 +159,8 @@ namespace Umbraco.Tests.Web.Controllers helper, Factory.GetInstance(), ShortStringHelper, - Factory.GetInstance()); + Factory.GetInstance(), + Factory.GetInstance()); return usersController; } @@ -195,7 +198,8 @@ namespace Umbraco.Tests.Web.Controllers helper, Factory.GetInstance(), ShortStringHelper, - Factory.GetInstance()); + Factory.GetInstance(), + Factory.GetInstance()); return usersController; } @@ -268,7 +272,8 @@ namespace Umbraco.Tests.Web.Controllers helper, Factory.GetInstance(), ShortStringHelper, - Factory.GetInstance()); + Factory.GetInstance(), + Factory.GetInstance()); return usersController; } diff --git a/src/Umbraco.Web.UI/Umbraco/Views/AuthorizeUpgrade.cshtml b/src/Umbraco.Web.UI/Umbraco/Views/AuthorizeUpgrade.cshtml index b48a67964c..040913cd1d 100644 --- a/src/Umbraco.Web.UI/Umbraco/Views/AuthorizeUpgrade.cshtml +++ b/src/Umbraco.Web.UI/Umbraco/Views/AuthorizeUpgrade.cshtml @@ -24,7 +24,7 @@ Umbraco @Html.RenderCssHere( - new BasicPath("Umbraco", Current.IOHelper.ResolveUrl(Current.Configs.Global().UmbracoPath))) + new BasicPath("Umbraco", Current.IOHelper.ResolveUrl(Model.GlobalSettings.UmbracoPath))) @*Because we're lazy loading angular js, the embedded cloak style will not be loaded initially, but we need it*@