From fee32bd6ec6bcd4bea7314ef85a8f1fb9a4dc8c3 Mon Sep 17 00:00:00 2001
From: Andy Butland <abutland73@gmail.com>
Date: Mon, 6 Nov 2023 17:58:01 +0100
Subject: [PATCH]  Remove parameter value/return nullability in
 `IImageSourceParser`, `ILocalLinkParser` and `IMacroParser` (#15130)

* Align nullability of ILocalLinkParser with other rich text content parsers (IMacroParser and IImageSourceParser).

* Remove value/return nullability in IImageSourceParser, ILocalLinkParser and IMacroParser

---------

Co-authored-by: Ronald Barendse <ronald@barend.se>
---
 src/Umbraco.Core/Deploy/IImageSourceParser.cs | 4 ++--
 src/Umbraco.Core/Deploy/IMacroParser.cs       | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/Umbraco.Core/Deploy/IImageSourceParser.cs b/src/Umbraco.Core/Deploy/IImageSourceParser.cs
index 7b9e3f5e96..0180ec0b3d 100644
--- a/src/Umbraco.Core/Deploy/IImageSourceParser.cs
+++ b/src/Umbraco.Core/Deploy/IImageSourceParser.cs
@@ -12,7 +12,7 @@ public interface IImageSourceParser
     /// <param name="dependencies">A list of dependencies.</param>
     /// <returns>The parsed value.</returns>
     /// <remarks>Turns src="/media/..." into src="umb://media/..." and adds the corresponding udi to the dependencies.</remarks>
-    string? ToArtifact(string? value, ICollection<Udi> dependencies);
+    string ToArtifact(string value, ICollection<Udi> dependencies);
 
     /// <summary>
     ///     Parses an artifact property value and produces an Umbraco property value.
@@ -20,5 +20,5 @@ public interface IImageSourceParser
     /// <param name="value">The artifact property value.</param>
     /// <returns>The parsed value.</returns>
     /// <remarks>Turns umb://media/... into /media/....</remarks>
-    string? FromArtifact(string? value);
+    string FromArtifact(string value);
 }
diff --git a/src/Umbraco.Core/Deploy/IMacroParser.cs b/src/Umbraco.Core/Deploy/IMacroParser.cs
index 1945b2bdb3..fed9dcc3af 100644
--- a/src/Umbraco.Core/Deploy/IMacroParser.cs
+++ b/src/Umbraco.Core/Deploy/IMacroParser.cs
@@ -8,14 +8,14 @@ public interface IMacroParser
     /// <param name="value">Property value.</param>
     /// <param name="dependencies">A list of dependencies.</param>
     /// <returns>Parsed value.</returns>
-    string? ToArtifact(string? value, ICollection<Udi> dependencies);
+    string ToArtifact(string value, ICollection<Udi> dependencies);
 
     /// <summary>
     ///     Parses an artifact property value and produces an Umbraco property value.
     /// </summary>
     /// <param name="value">Artifact property value.</param>
     /// <returns>Parsed value.</returns>
-    string? FromArtifact(string? value);
+    string FromArtifact(string value);
 
     /// <summary>
     ///     Tries to replace the value of the attribute/parameter with a value containing a converted identifier.