Updates the BulkInsertRecords method to optionally close the trans - shouldn't by default. Updates how permissions are handled in the new services and exposes another method, ensures it's all wrapped in trans and ensures that cache is cleared properly. Fixes: U4-4213 "Replace child node permissions" does not work if all permissions cleared

src/Umbraco.Core/Services/ContentService.cs

@@ -1511,6 +1511,8 @@ namespace Umbraco.Core.Services
 
                     //bulk insert it into the database
                     uow.Database.BulkInsertRecords(xmlItems, tr);
+
+                    tr.Complete();    
                 }
 
                 Audit.Add(AuditTypes.Publish, "RebuildXmlStructures completed, the xml has been regenerated in the database", 0, -1);

src/Umbraco.Core/Services/DataTypeService.cs

@@ -214,17 +214,17 @@ namespace Umbraco.Core.Services
             {
                 using (var uow = _uowProvider.GetUnitOfWork())
                 {
-                    var sortOrderObj =
-                        uow.Database.ExecuteScalar<object>(
-                            "SELECT max(sortorder) FROM cmsDataTypePreValues WHERE datatypeNodeId = @DataTypeId", new { DataTypeId = id });
-                    int sortOrder;
-                    if (sortOrderObj == null || int.TryParse(sortOrderObj.ToString(), out sortOrder) == false)
-                    {
-                        sortOrder = 1;
-                    }
-
                     using (var transaction = uow.Database.GetTransaction())
                     {
+                        var sortOrderObj =
+                        uow.Database.ExecuteScalar<object>(
+                            "SELECT max(sortorder) FROM cmsDataTypePreValues WHERE datatypeNodeId = @DataTypeId", new { DataTypeId = id });
+                        int sortOrder;
+                        if (sortOrderObj == null || int.TryParse(sortOrderObj.ToString(), out sortOrder) == false)
+                        {
+                            sortOrder = 1;
+                        }
+
                         foreach (var value in values)
                         {
                             var dto = new DataTypePreValueDto { DataTypeNodeId = id, Value = value, SortOrder = sortOrder };

src/Umbraco.Core/Services/IUserService.cs

@@ -53,6 +53,14 @@ namespace Umbraco.Core.Services
         /// <returns></returns>
         IEnumerable<EntityPermission> GetPermissions(IUser user, params int[] nodeIds);
 
+        /// <summary>
+        /// Assigns the same permission set for a single user to any number of entities
+        /// </summary>
+        /// <param name="userId"></param>
+        /// <param name="permissions"></param>
+        /// <param name="entityIds"></param>
+        void AssignUserPermissions(int userId, IEnumerable<char> permissions, params int[] entityIds);
+
         #region User types
 
         IEnumerable<IUserType> GetAllUserTypes(params int[] ids);

src/Umbraco.Core/Services/MediaService.cs

@@ -938,6 +938,8 @@ namespace Umbraco.Core.Services
 
                     //bulk insert it into the database
                     uow.Database.BulkInsertRecords(xmlItems, tr);
+
+                    tr.Complete();    
                 }
 
                 Audit.Add(AuditTypes.Publish, "RebuildXmlStructures completed, the xml has been regenerated in the database", 0, -1);

src/Umbraco.Core/Services/MemberService.cs

@@ -972,6 +972,8 @@ namespace Umbraco.Core.Services
 
                     //bulk insert it into the database
                     uow.Database.BulkInsertRecords(xmlItems, tr);
+
+                    tr.Complete();    
                 }
             }
         }

src/Umbraco.Core/Services/UserService.cs

@@ -398,6 +398,21 @@ namespace Umbraco.Core.Services
             }
         }
 
+        /// <summary>
+        /// Assigns the same permission set for a single user to any number of entities
+        /// </summary>
+        /// <param name="userId"></param>
+        /// <param name="permissions"></param>
+        /// <param name="entityIds"></param>
+        public void AssignUserPermissions(int userId, IEnumerable<char> permissions, params int[] entityIds)
+        {
+            var uow = _uowProvider.GetUnitOfWork();
+            using (var repository = _repositoryFactory.CreateUserRepository(uow))
+            {
+                repository.AssignUserPermissions(userId, permissions, entityIds);
+            }
+        }
+
         public IEnumerable<IUserType> GetAllUserTypes(params int[] ids)
         {
             var uow = _uowProvider.GetUnitOfWork();