Commit Graph

241 Commits

Author SHA1 Message Date
Sebastiaan Janssen
e8a9c4da2e Merge branch 'v8/dev' into v8/contrib 2021-03-31 13:01:25 +02:00
Shannon Deminick
d0f047e729 Fixes and Updates for DB Scope and Ambient Context leaks (#9953)
* Adds some scope tests (ported back from netcore) and provides a much better error message, ensure execution context is not flowed to child tasks that shouldn't leak any current ambient context

* updates comment

* Ensure SqlMainDomLock suppresses execution context too

* Since we're awaiting a task in a library method, ConfigureAwait(false)

* missing null check

Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
2021-03-15 12:56:38 +01:00
Chad
b8540ca128 Improve speed and reduce allocations by implementing logger overloads to avoid params [] allocation (#8917)
* Implement logger overloads to avoid params [] allocation

* Implement console logger ILogger

* Call correct signature

* Fix exceptions

* Introduce ILogger2

* fix logger reference

Co-authored-by: Nathan Woulfe <nathan@nathanw.com.au>
2021-02-22 08:22:49 +10:00
Chad
0bd4dced0b Improve performance and reduce memory use and reduce array allocations by reusing char[] (#9166)
* Reduce array allocations by reusing char[]

* don't hide .Equals()

* Reduce memory use by reducing array allocations

* Revert "Reduce memory use by reducing array allocations"

This reverts commit faf6b60234167f5443435243eb52187ab07d514c.

* reuse char[] for string.split() to avoid params [] allocation
2021-01-22 12:02:25 +10:00
Maikel Veen
b2d2938760 Add overloaded method for RecurringTaskBase 2020-12-16 00:46:41 +01:00
Shannon
c2d9f5aa4e Ensure that TaskScheduler.Default is used anywhere that ContinueWith is used, adds more debug logging to MainDom operations 2020-11-18 12:33:13 +11:00
Sebastiaan Janssen
841c4b5012 Merge branch 'v8/8.6' into v8/dev 2020-10-13 16:45:27 +02:00
Arkadiusz Biel
b96776949f make composers and components public
(cherry picked from commit f288a63342)
2020-10-13 16:41:26 +02:00
Sebastiaan Janssen
d6275f34f7 Merge branch 'v8/8.6' into v8/dev
# Conflicts:
#	src/Umbraco.Web/Security/MembershipHelper.cs
2020-09-23 11:09:40 +02:00
Shannon
6e08a0396e Umbraco to re-index data on background thread
Fixes issue with scopes being disposed or referenced incorrectly due to yield returns as this can capture a scope in the enumerator which will get passed to a background thread in Examine and cause some issues. We saw this issue in netcore but the issue must still exist in v8 but we don't visibly see it for some reason. The other issue is that the ValueSet lookup for content was done 3x when an IContent is saved and it should only be done 2x, one for published, one for unpublished. The other issue is that the data lookups to build a ValueSet are intended to be done on a background thread. This is the case in v7 because the IEnumerable is lazy and passed all the way down to Examine's background thread but this doesn't occur in v8 because we need to iterate/split that value set before it's sent to Examine so the ValueSet is eagerly built within the request. We can easily resolve this by using the background task manager and just pushing a task when IContent/IMedia/IMember is saved. This will return the execution to the UI quicker.
2020-08-31 23:41:19 +10:00
Sebastiaan Janssen
c8da5156fa Merge branch 'v8/dev' into v8/contrib
# Conflicts:
#	src/Umbraco.Web.UI.Client/package.json
#	src/Umbraco.Web.UI.Client/src/common/directives/components/content/umbvariantcontenteditors.directive.js
#	src/Umbraco.Web.UI.Client/src/common/directives/validation/valformmanager.directive.js
#	src/Umbraco.Web.UI.Client/src/common/services/formhelper.service.js
#	src/Umbraco.Web.UI.Client/src/views/components/overlays/umb-overlay.html
#	src/Umbraco.Web.UI.Client/src/views/content/overlays/publishdescendants.controller.js
#	src/Umbraco.Web.UI.Client/src/views/content/overlays/publishdescendants.html
#	src/Umbraco.Web.UI.Client/src/views/dictionary/edit.html
#	src/Umbraco.Web.UI/Umbraco/config/lang/en.xml
2020-08-19 13:12:13 +02:00
Ronald Barendse
568135a249 Fix LogScrubber exception when cleaning up temp files (#8326) 2020-07-30 17:41:18 +02:00
Shannon
e1757178b9 Fixes our sql azure transient fault detection to be inline with current standards, adds a scope for the health check schedule tasks 2020-07-08 17:26:31 +10:00
Niels Swimberghe
e578ca1b0f Add KeepAlive settings to resolve #7116 (#7164) 2019-12-20 08:14:42 +01:00
Shannon
3f78331145 Adds lots of notes, fixes tests to ensure we catch OperationCanceledException where necessary, adds logging to tests, fixes a boolean op 2019-12-05 23:26:49 +11:00
Shannon
6f9062c0cf fixes test (cherry picked) 2019-12-05 19:19:09 +11:00
Shannon
8218467e04 Merge branch 'v8/dev' into v8/bugfix/6546-MainDom-Cleanup
# Conflicts:
#	src/Umbraco.Core/MainDom.cs
#	src/Umbraco.Web/PublishedCache/NuCache/ContentStore.cs
#	src/Umbraco.Web/PublishedCache/NuCache/PublishedSnapshotService.cs
2019-12-04 16:09:22 +11:00
Shannon
c682bbcaf1 Adds notes and better logging to PublishedSnapshotService, fixes log output from HealthCheckNotifier, changes initial delay time of scheduled task to be longer. 2019-10-31 15:45:57 +11:00
Shannon
f513ed5476 Changes call transition from StopInitial to StopImmediate instead of terminate to ensure that all cancelation tokens are canceled and cleared 2019-10-24 14:35:30 +11:00
Shannon
52b0edf1f5 For backgroundtaskrunner, run shutdown on a threadpool thread to not block the shutdown of other IRegisteredObjects 2019-10-24 14:24:01 +11:00
Shannon
31ddc1d935 Changes BackgroundTaskRunner to shutdown faster and to ensures that any latched tasks are canceled even with Stop(immediate == false) is executed. 2019-10-23 14:17:30 +11:00
Shannon
b5f29f2390 Ensure the EventWaitHandle is cleaned up, MainDom and BackgroundTaskRunner was not using HostingEnvironment.Stop correctly, ensures no exception is thrown when setting task result on a background task, ensure multiple terminations don't occur, ensure terminations are done if shutdown fails. 2019-10-18 11:57:44 +11:00
Shannon
5cfdfd6e9c Moves temp file cleanup to a background task 2019-09-18 22:03:31 +10:00
Shannon
3603090421 Fixes race condition in PublishedSnapshotService and more... 2019-07-17 22:51:14 +10:00
Shannon
6f7e1cac3e Merge branch 'temp8' into temp8-contexts 2019-02-15 12:55:17 +11:00
Stephan
186e8fc58b Introduce IUmbracoContextFactory 2019-02-14 12:11:06 +01:00
Stephan
7660e9fb25 Reorganize composition code 2019-02-14 09:15:47 +01:00
Stephan
e636f12459 Fix leak in BackgroundTaskRunner 2019-02-04 13:39:32 +01:00
Shannon
f28c60ced3 Removes all irrelevant logging settings from umbraco settings 2019-01-31 01:11:15 +11:00
Shannon
1c8b4412e3 Removes scheduled tasks 2019-01-31 00:57:10 +11:00
Chris Houston
193e24afd2 Fixing all the TODO, FIXME & HACK comments so they all follow the same layout. 2019-01-27 11:16:00 +01:00
Chris Houston
0b6ba5aa52 Temp8 - Fixing spelling / typos etc in Umbraco.Web (#4148) 2019-01-26 16:52:19 +01:00
Stephan
c840895f90 Deal with more fixme 2019-01-22 09:49:35 +01:00
Stephan
1bd5127bcf Actually run HealthCheck notifier 2019-01-15 17:27:18 +01:00
Stephan
9ef8e9afc1 Cleanup task runner 2019-01-09 10:05:10 +01:00
Stephan
349f48aa2d Refactor task runner maindom hooks 2019-01-08 20:49:21 +01:00
Stephan
19ae9f5dee Refactor configuration for DI 2019-01-07 19:40:07 +01:00
Stephan
84f6239c98 Components Initialize and Terminate 2019-01-07 09:46:11 +01:00
Stephan
5670c6354e Introduce ComponentComposer to simplify registration of components 2019-01-05 15:49:10 +01:00
Stephan
97272e6220 Bugfix 2019-01-04 09:55:09 +01:00
Stephan
1bd4cba9ac Fix component constructors 2019-01-04 08:36:38 +01:00
Stephan
816ed84a2f Refactor components 2019-01-03 21:00:28 +01:00
Stephan
bb9846a6ca Merge branch origin/temp8 into temp8-di2690 2018-12-21 10:58:38 +01:00
Stephan
56c82d120b Bugfix keepalive route issue 2018-12-20 13:30:19 +01:00
Tristan Thompson
2a61d0d988 Remove/Replace ping.aspx
Remove ping.aspx
Add KeepAliveController to receive ping requests
Update KeepAlive.cs to call new MVC route rather than ping.aspx
2018-12-19 16:13:23 +01:00
Stephan
adced099be Move UmbracoConfig singleton to Current 2018-12-12 23:31:16 +01:00
Stephan
49a0b68b28 IContainer is IRegister+IFactory 2018-11-28 11:05:41 +01:00
Stephan
c23c7749b4 Composition fixes 2018-11-27 14:04:08 +01:00
Stephan
6ffc340725 Merge branch temp8 into temp8-di2690 2018-11-23 14:58:08 +01:00
Stephan
6cb20c1d79 Deal with events and contexts in scheduled publishing 2018-11-13 11:51:25 +01:00