Henrik
c64ec51305
Nonbreaking performance tweaks ( #17106 )
...
* Avoid doing multiple lookups in dictionaries, avoid doing string interpolation & adding single char strings to a StringBuilder, made some private/internal classes & some private methods static when possible, use FrozenSet for InvalidFileNameChars
* Avoid some array + list allocations & async methods and made some private methods static
* Avoid double lookup of XML attribute (and double null check) & avoid an unneeded lookup before writing to a dictionary
* Avoid some double lookups
# Conflicts:
# src/Umbraco.Core/Services/LocalizedTextService.cs
* Avoid double lookups
# Conflicts:
# src/Umbraco.Core/Services/LocalizedTextService.cs
* Avoid double lookups
* List AsSpan, also to trigger a new build that hopefully goes through
* Avoid concatting strings when using writer & more static
* Updated CollectionBenchmarks to show that ToArray isn't always the fastest & Lists can be iterated nearly as fast as arrays (and that ToList is nearly as fast as ToArray on IReadOnlyLists in .NET 8)
* Fix rebase
* Use explicit types ❤️ (I thought it was the other way round...)
# Conflicts:
# src/Umbraco.Core/Services/LocalizedTextService.cs
* Reduce number of lines in HtmlStringUtilities.Truncate to pass code quality analysis
* Avoid double lookups & allocating empty arrays
* Use native List Find instead of LINQ
2025-01-31 10:31:06 +01:00
Emma L Garland
ac575662ac
Resolved more warnings, and marked more warning types as errors ( #16991 )
...
* Fix warnings SA1111, SA1028, SA1500, IDE1270 in Umbraco.Web.Website, and updated rules.
* Remove warnings: IDE0270: Null check can be simplified
* More SqlServer project warnings resolved
* CS0105 namespace appeared already
* Suppress warning until implementation:
#pragma warning disable CS0162 // Unreachable code detected
#pragma warning disable CS0618 // Type or member is obsolete
CS0162 remove unreachable code
SA1028 remove trailing whitespace
SA1106 no empty statements
CS1570 malformed XML
CS1572 corrected xml parameter
CS1573 param tag added
IDE0007 var not explicit
IDE0008 explicit not var
IDE0057 simplify substring
IDE0074 compound assignment
CA1825 array.empty
Down to 3479 warnings
* - SA1116, SA117 params on same line
- IDE0057 substring simplified
Specific warnings for Umbraco.Tests.Benchmarks
* Fixed IDE0074 compound assignment and added specific warnings for Umbraco.Tests.Common
* Specific warnings for Umbraco.Tests.Integration and Umbraco.Tests.Common
Fixed:
- SA1111, SA1116, SA117 params and line formatting (not all as there are many)
- SA1122 string.Empty
- IDE0057 simplify substring
- IDE0044,IDE0044 make field readonly
- IDE1006 naming rule violation (add _)
- SA1111 closing parenthesis on line of last parameter
- SA1649 filename match type name
- SA1312,SA1306 lowercase variable and field names
* Fixed various warnings where they are more straight-forward, including:
- SA1649 file name match type name
- SA111 parenthesis on line of last parameter
- IDE0028 simplify collection initializer
- SA1306 lower-case letter field
- IDE044 readonly field
- SA1122 string.Empty
- SA1116 params same line
- IDE1006 upper casing
- IDE0041 simplify null check
Updated the following projects to only list their remaining specific warning codes:
- Umbraco.Tests.UnitTests
Typo in `Umbraco.Web.Website` project
* Reverted test change
* Now 1556 warnings.
Fixed various warnings where they are more straight-forward, including:
- SA1111/SA1116/SA1119 parenthesis
- SA1117 params
- SA1312 lowercase variable
- SA1121 built-in type
- SA1500/SA1513/SA1503 formatting braces
- SA1400 declare access modifier
- SA1122 string.Empty
- SA1310 no underscore
- IDE0049 name simplified
- IDE0057 simplify substring
- IDE0074 compound assignment
- IDE0032 use auto-property
- IDE0037 simplify member name
- IDE0008 explicit type not var
- IDE0016/IDE0270/IDE0041 simplify null checks
- IDE0048/SA1407 clarity in arithmetic
- IDE1006 correct param names
- IDE0042 deconstruct variable
- IDE0044 readonly
- IDE0018 inline variable declarations
- IDE0074/IDE0054 compound assignment
- IDE1006 naming
- CS1573 param XML
- CS0168 unused variable
Comment formatting in project files for consistency.
Updated all projects to only list remaining specific warning codes as warnings instead of errors (errors is now default).
* Type not var, and more warning exceptions
* Tweaked merge issue, readded comment about rollback
* Readded comment re rollback.
* Readded comments
* Comment tweak
* Comment tweak
2024-09-24 12:56:28 +01:00
Elitsa Marinovska
9c18cd22e0
V14: Deleted code marked as obsolete for V14 ( #15998 )
...
* Obsoletions related to Delivery API
* Fix TypeLoader and TypeFinder tests
* Remove obsolete and default implementations of IFileSource and IFileTypeCollection
* More Delivery API related obsoletions
* VariationContextAccessor related
* ValueFactories obsoletion and fix references
* ValueSetBuilders obsoletions
* ValueConverters obsoletions
* Other obsolete ctors and methods
* Forgotten VariationContextAccessor obsoletion
* More obsoletions
* XPath related obsoletions
* Revert XmlHelper changes
* Delete RenamedRootNavigator and its tests
* Fix test
* XmlHelper obsoletion
* Return null instead of GetXPathValue
* Obsolete entire class instead
* Remove XPath obsoletions from IPublishedCache
* Remove XPath-related if-block that is no longer needed
* Change obsolete msg for classes needed for NuCache
* Moving classes to NuCache and making them internal
* Remove more XPath-related obsoletions
* Remove NavigableNavigator and its tests
* Cleanup
* Remove Xpath references from tests
* Revert interface deletion in MediaCache
* Using XOR operation
Co-authored-by: Nuklon <Nuklon@users.noreply.github.com >
---------
Co-authored-by: Nuklon <Nuklon@users.noreply.github.com >
2024-04-09 09:06:48 +02:00
Elitsa Marinovska
e326370b5f
V14: Deleted code marked as obsolete for V12 and V13 ( #15999 )
...
* Forgotten v12 obsoletions
* V13 obsoletions
* Remove LegacyStaticServiceProvider and fix using statements of StaticServiceProvider
* Remove obsolete ctors for v13
* More v13 obsoletions
* UmbracoMapper obsoletion
* UmbracoPipelineFilter obsoletion
---------
Co-authored-by: nikolajlauridsen <nikolajlauridsen@protonmail.ch >
2024-04-08 11:17:32 +02:00
Sven Geusens
67d80da9ed
Merge branch 'v13/dev' into v14/dev
...
# Conflicts:
# src/Umbraco.Infrastructure/PropertyEditors/MultiUrlPickerValueEditor.cs
# src/Umbraco.Web.Common/Profiler/WebProfiler.cs
# src/Umbraco.Web.UI.Client/package-lock.json
# src/Umbraco.Web.UI.Client/src/common/directives/validation/valpropertymsg.directive.js
# src/Umbraco.Web.UI.Client/src/views/common/infiniteeditors/linkpicker/linkpicker.controller.js
# src/Umbraco.Web.UI.Client/src/views/common/infiniteeditors/linkpicker/linkpicker.html
# src/Umbraco.Web.UI.Client/src/views/content/content.create.controller.js
# src/Umbraco.Web.UI.Client/src/views/content/create.html
# src/Umbraco.Web.UI.Client/src/views/propertyeditors/blockgrid/umbBlockGridPropertyEditor.component.js
# src/Umbraco.Web.UI.Client/src/views/propertyeditors/multiurlpicker/multiurlpicker.controller.js
# src/Umbraco.Web.UI.Client/src/views/propertyeditors/multiurlpicker/multiurlpicker.html
# src/Umbraco.Web.UI.Client~HEAD
# Ignored changes
# https://github.com/umbraco/Umbraco-CMS/pull/14787
# https://github.com/umbraco/Umbraco-CMS/pull/15853
# https://github.com/umbraco/Umbraco-CMS/pull/15841
2024-03-27 16:13:09 +01:00
Awlad Hussain
3344274616
Xpath Query on Multinode Treepicker no longer working for new Nodes ( #15159 )
...
* fix for #14698
* Adjust XPath logic so it uses parentId as $current only when nodeContextId is null or 0
---------
Co-authored-by: Laura Neto <12862535+lauraneto@users.noreply.github.com >
2024-03-06 18:45:20 +01:00
Kenn Jacobsen
976bca456e
Remove macros ( #15794 )
...
* Remove macros!
* Clean up snippets
* Add migration that deletes all macros
* Review comments
2024-02-29 15:11:06 +01:00
Nikolaj Geisle
d116366b28
V12: Deprecate XPath ( #14372 )
...
* Deprecate all outward facing methods that uses XPath
* Add more obsolete messages
---------
Co-authored-by: Zeegaan <nge@umbraco.dk >
2023-07-07 11:12:04 +02:00
karlmacklin
5377c17b5d
XPath can unambiguously use $site/$parent ( #14127 )
...
* XPath can unambiguously use $site/$parent
* add deprecation notices and obsolete methods
* Update deprecation description text/instruction
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Small spelling fix on deprecation description
* keep depr. getByQuery and handle legacy usage
---------
Co-authored-by: Kalle Macklin <karlmacklin@users.noreply.github.co >
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
2023-05-15 08:42:58 +02:00
Nikolaj Geisle
60a5b19dc9
V10: Fix build warnings in core ( #12438 )
...
* Run code cleanup
* Start manual cleanup after dotnet format
* Finish up manual pass
* Fix up missed warnings
* Fix after merge
* Update src/Umbraco.Core/Cache/ContentTypeCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/DataTypeCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/DeepCloneAppCache.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/DomainCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/MacroCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/MediaCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/MemberCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/MemberGroupCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Composing/OrderedCollectionBuilderBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Configuration/Models/RequestHandlerSettings.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Composing/SetCollectionBuilderBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Composing/WeightedCollectionBuilderBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/ContentApps/ContentAppFactoryCollectionBuilder.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Dashboards/DashboardCollectionBuilder.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/ContentTypeRefreshedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/ContentTypeSavedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/ContentTypeSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/DictionaryCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/DataTypeCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/ContentUnpublishingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/DictionaryItemDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/DictionaryItemSavedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/DictionaryItemSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/DomainCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/LanguageCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MacroCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaEmptiedRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaEmptyingRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaMovedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaMovedToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaMovedToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaMovingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaMovingToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTreeChangeNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTreeChangeNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTypeChangedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTypeDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTypeMovedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTypeMovingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTypeMovingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTypeRefreshedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberGroupCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberGroupDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberGroupSavedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberGroupSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeChangedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeDeletedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeMovedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeMovedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeMovingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeMovingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeRefreshedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/UriExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MovedToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MovedToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MovingToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MovingToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PartialViewDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/UriExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/IO/PhysicalFileSystem.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/IO/PhysicalFileSystem.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/IO/ShadowWrapper.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Logging/DisposableTimer.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Install/InstallSteps/UpgradeStep.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Mapping/MapDefinitionCollectionBuilder.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Media/EmbedProviders/EmbedProvidersCollectionBuilder.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PartialViewSavedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Models/ContentEditing/ContentVariationDisplay.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PartialViewSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessEntryDeletedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessEntryDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessEntryDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessEntrySavedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessEntrySavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessEntrySavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/RelationTypeCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/RelationTypeDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/RelationTypeSavedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/RelationTypeSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/StatefulNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/StylesheetDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/StylesheetSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Models/DeepCloneHelper.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Models/File.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Models/PropertyGroupExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Models/PropertyGroupExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Fix based on review
* Fix after merge
Signed-off-by: Zeegaan <nge@umbraco.dk >
Co-authored-by: Nikolaj Geisle <niko737@edu.ucl.dk >
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
Co-authored-by: Zeegaan <nge@umbraco.dk >
2022-06-07 15:28:38 +02:00
Nikolaj Geisle
05a08bef63
Add nullability to nucache & lucene projects
2022-03-30 13:34:56 +02:00
Nikolaj Geisle
915e68e72e
Fix last build errors
2022-02-28 13:14:02 +01:00
Nikolaj Geisle
a8cf6ee127
More work on nullable references
2022-02-22 13:35:32 +01:00
Nikolaj Geisle
945b115067
Fix more nullability errors
2022-02-15 14:41:06 +01:00
Nikolaj Geisle
b75eae01f3
Add nullability to core project
2022-02-09 13:24:35 +01:00
Nikolaj Geisle
521023372b
Fix extension methods
2022-01-11 11:47:31 +01:00
Bjarke Berg
39faf63f9c
Fixed tryParse
2021-09-15 13:40:08 +02:00
Bjarke Berg
f68717c1c8
Temp commit
2021-09-14 22:13:39 +02:00
Bjarke Berg
37ed84871a
Merge remote-tracking branch 'origin/v8/dev' into netcore/dev
...
# Conflicts:
# build/NuSpecs/UmbracoCms.Core.nuspec
# build/NuSpecs/UmbracoCms.Web.nuspec
# src/SolutionInfo.cs
# src/Umbraco.Core/Cache/CacheKeys.cs
# src/Umbraco.Core/Composing/TypeFinder.cs
# src/Umbraco.Core/Configuration/GlobalSettings.cs
# src/Umbraco.Core/Configuration/GlobalSettingsExtensions.cs
# src/Umbraco.Core/Configuration/IGlobalSettings.cs
# src/Umbraco.Core/Configuration/UmbracoSettings/ContentElement.cs
# src/Umbraco.Core/Configuration/UmbracoSettings/ContentSectionExtensions.cs
# src/Umbraco.Core/Constants-AppSettings.cs
# src/Umbraco.Core/Editors/UserEditorAuthorizationHelper.cs
# src/Umbraco.Core/Extensions/StringExtensions.cs
# src/Umbraco.Core/Extensions/UriExtensions.cs
# src/Umbraco.Core/IO/IOHelper.cs
# src/Umbraco.Core/IO/PhysicalFileSystem.cs
# src/Umbraco.Core/Media/Exif/MathEx.cs
# src/Umbraco.Core/Media/UploadAutoFillProperties.cs
# src/Umbraco.Core/Models/Mapping/UserMapDefinition.cs
# src/Umbraco.Core/Models/Membership/User.cs
# src/Umbraco.Core/Models/UserExtensions.cs
# src/Umbraco.Core/Packaging/PackageDefinitionXmlParser.cs
# src/Umbraco.Core/PropertyEditors/ListViewConfiguration.cs
# src/Umbraco.Core/PropertyEditors/ValueConverters/MediaPickerValueConverter.cs
# src/Umbraco.Core/PropertyEditors/ValueConverters/MultiNodeTreePickerValueConverter.cs
# src/Umbraco.Core/Routing/AliasUrlProvider.cs
# src/Umbraco.Core/Routing/DefaultUrlProvider.cs
# src/Umbraco.Core/Routing/UriUtility.cs
# src/Umbraco.Core/Routing/UrlProviderExtensions.cs
# src/Umbraco.Core/Runtime/CoreRuntime.cs
# src/Umbraco.Core/RuntimeOptions.cs
# src/Umbraco.Core/RuntimeState.cs
# src/Umbraco.Core/Security/BackOfficeUserStore.cs
# src/Umbraco.Core/Security/ContentPermissions.cs
# src/Umbraco.Core/Sync/ApplicationUrlHelper.cs
# src/Umbraco.Core/Trees/TreeNode.cs
# src/Umbraco.Core/Udi.cs
# src/Umbraco.Examine.Lucene/BackOfficeExamineSearcher.cs
# src/Umbraco.Examine/Umbraco.Examine.csproj
# src/Umbraco.Infrastructure/Examine/ContentValueSetValidator.cs
# src/Umbraco.Infrastructure/Migrations/Install/DatabaseBuilder.cs
# src/Umbraco.Infrastructure/Packaging/PackageDataInstallation.cs
# src/Umbraco.Infrastructure/Persistence/SqlSyntax/SqlServerSyntaxProvider.cs
# src/Umbraco.Infrastructure/Scoping/Scope.cs
# src/Umbraco.Infrastructure/Search/ExamineComponent.cs
# src/Umbraco.Infrastructure/Security/IdentityMapDefinition.cs
# src/Umbraco.Infrastructure/Services/Implement/ContentService.cs
# src/Umbraco.Infrastructure/Services/Implement/MediaService.cs
# src/Umbraco.Infrastructure/Services/Implement/NotificationService.cs
# src/Umbraco.Persistence.SqlCe/SqlCeSyntaxProvider.cs
# src/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/LocksTests.cs
# src/Umbraco.Tests.UnitTests/Umbraco.Core/Models/UserExtensionsTests.cs
# src/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Editors/UserEditorAuthorizationHelperTests.cs
# src/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Examine/UmbracoContentValueSetValidatorTests.cs
# src/Umbraco.Tests/Configurations/UmbracoSettings/ContentElementTests.cs
# src/Umbraco.Tests/Configurations/UmbracoSettings/umbracoSettings.config
# src/Umbraco.Tests/TestHelpers/SettingsForTests.cs
# src/Umbraco.Tests/Testing/TestDatabase.cs
# src/Umbraco.Tests/Web/Controllers/ContentControllerUnitTests.cs
# src/Umbraco.Tests/Web/Controllers/FilterAllowedOutgoingContentAttributeTests.cs
# src/Umbraco.Tests/Web/Controllers/MediaControllerUnitTests.cs
# src/Umbraco.Web.BackOffice/Controllers/BackOfficeServerVariables.cs
# src/Umbraco.Web.BackOffice/Controllers/CodeFileController.cs
# src/Umbraco.Web.BackOffice/Controllers/ContentController.cs
# src/Umbraco.Web.BackOffice/Controllers/EntityController.cs
# src/Umbraco.Web.BackOffice/Controllers/MacrosController.cs
# src/Umbraco.Web.BackOffice/Controllers/MediaController.cs
# src/Umbraco.Web.BackOffice/Controllers/PackageInstallController.cs
# src/Umbraco.Web.BackOffice/Controllers/TourController.cs
# src/Umbraco.Web.BackOffice/Controllers/UserGroupEditorAuthorizationHelper.cs
# src/Umbraco.Web.BackOffice/Filters/FilterAllowedOutgoingContentAttribute.cs
# src/Umbraco.Web.BackOffice/Filters/FilterAllowedOutgoingMediaAttribute.cs
# src/Umbraco.Web.BackOffice/Mapping/ContentMapDefinition.cs
# src/Umbraco.Web.BackOffice/Services/IconService.cs
# src/Umbraco.Web.BackOffice/Trees/ContentTreeController.cs
# src/Umbraco.Web.BackOffice/Trees/ContentTreeControllerBase.cs
# src/Umbraco.Web.BackOffice/Trees/FileSystemTreeController.cs
# src/Umbraco.Web.BackOffice/Trees/MediaTreeController.cs
# src/Umbraco.Web.Common/Extensions/FormCollectionExtensions.cs
# src/Umbraco.Web.UI.Client/src/common/resources/content.resource.js
# src/Umbraco.Web.UI.Client/src/views/content/overlays/publish.html
# src/Umbraco.Web.UI.Client/src/views/propertyeditors/grid/editors/media.controller.js
# src/Umbraco.Web.UI.NetCore/umbraco/config/lang/da.xml
# src/Umbraco.Web.UI.NetCore/umbraco/config/lang/en.xml
# src/Umbraco.Web.UI.NetCore/umbraco/config/lang/en_us.xml
# src/Umbraco.Web.UI/config/umbracoSettings.Release.config
# src/Umbraco.Web/Cache/MemberCacheRefresher.cs
# src/Umbraco.Web/Composing/ModuleInjector.cs
# src/Umbraco.Web/Editors/BackOfficeController.cs
# src/Umbraco.Web/Editors/Binders/ContentModelBinderHelper.cs
# src/Umbraco.Web/Editors/ContentTypeController.cs
# src/Umbraco.Web/Editors/Filters/ContentSaveValidationAttribute.cs
# src/Umbraco.Web/Editors/Filters/MediaItemSaveValidationAttribute.cs
# src/Umbraco.Web/Editors/Filters/UserGroupAuthorizationAttribute.cs
# src/Umbraco.Web/Editors/TinyMceController.cs
# src/Umbraco.Web/Editors/UserGroupsController.cs
# src/Umbraco.Web/Editors/UsersController.cs
# src/Umbraco.Web/ImageCropperTemplateExtensions.cs
# src/Umbraco.Web/Logging/WebProfiler.cs
# src/Umbraco.Web/Logging/WebProfilerProvider.cs
# src/Umbraco.Web/Macros/PublishedContentHashtableConverter.cs
# src/Umbraco.Web/Mvc/EnsurePublishedContentRequestAttribute.cs
# src/Umbraco.Web/Mvc/JsonNetResult.cs
# src/Umbraco.Web/Mvc/MemberAuthorizeAttribute.cs
# src/Umbraco.Web/Mvc/RenderRouteHandler.cs
# src/Umbraco.Web/PropertyEditors/MediaPickerPropertyEditor.cs
# src/Umbraco.Web/PropertyEditors/MultiNodeTreePickerPropertyEditor.cs
# src/Umbraco.Web/PublishedCache/NuCache/DataSource/DatabaseDataSource.cs
# src/Umbraco.Web/RoutableDocumentFilter.cs
# src/Umbraco.Web/Routing/ContentFinderByUrlAlias.cs
# src/Umbraco.Web/Routing/NotFoundHandlerHelper.cs
# src/Umbraco.Web/Routing/PublishedRouter.cs
# src/Umbraco.Web/Runtime/WebInitialComposer.cs
# src/Umbraco.Web/Scheduling/KeepAlive.cs
# src/Umbraco.Web/Security/AppBuilderExtensions.cs
# src/Umbraco.Web/Security/BackOfficeClaimsIdentityFactory.cs
# src/Umbraco.Web/Security/Providers/UmbracoMembershipProvider.cs
# src/Umbraco.Web/Trees/DictionaryTreeController.cs
# src/Umbraco.Web/Trees/LanguageTreeController.cs
# src/Umbraco.Web/Trees/LogViewerTreeController.cs
# src/Umbraco.Web/Trees/PackagesTreeController.cs
# src/Umbraco.Web/UmbracoApplication.cs
# src/Umbraco.Web/UmbracoApplicationBase.cs
# src/Umbraco.Web/UmbracoInjectedModule.cs
# src/Umbraco.Web/WebApi/Filters/AdminUsersAuthorizeAttribute.cs
# src/Umbraco.Web/WebApi/Filters/CheckIfUserTicketDataIsStaleAttribute.cs
# src/Umbraco.Web/WebApi/Filters/EnsureUserPermissionForContentAttribute.cs
# src/Umbraco.Web/WebApi/Filters/EnsureUserPermissionForMediaAttribute.cs
# src/Umbraco.Web/WebApi/MemberAuthorizeAttribute.cs
2021-03-05 15:36:27 +01:00
Mole
bf41c2eeaa
Netcore: Align namespaces ( #9801 )
...
* Rename Umbraco.Core namespace to Umbraco.Cms.Core
* Move extension methods in core project to Umbraco.Extensions
* Move extension methods in core project to Umbraco.Extensions
* Rename Umbraco.Examine namespace to Umbraco.Cms.Examine
* Move examine extensions to Umbraco.Extensions namespace
* Reflect changed namespaces in Builder and fix unit tests
* Adjust namespace in Umbraco.ModelsBuilder.Embedded
* Adjust namespace in Umbraco.Persistence.SqlCe
* Adjust namespace in Umbraco.PublishedCache.NuCache
* Align namespaces in Umbraco.Web.BackOffice
* Align namespaces in Umbraco.Web.Common
* Ensure that SqlCeSupport is still enabled after changing the namespace
* Align namespaces in Umbraco.Web.Website
* Align namespaces in Umbraco.Web.UI.NetCore
* Align namespaces in Umbraco.Tests.Common
* Align namespaces in Umbraco.Tests.UnitTests
* Align namespaces in Umbraco.Tests.Integration
* Fix errors caused by changed namespaces
* Fix integration tests
* Undo the Umbraco.Examine.Lucene namespace change
This breaks integration tests on linux, since the namespace wont exists there because it's only used on windows.
* Fix merge
* Fix Merge
2021-02-18 11:06:02 +01:00
Chad
0bd4dced0b
Improve performance and reduce memory use and reduce array allocations by reusing char[] ( #9166 )
...
* Reduce array allocations by reusing char[]
* don't hide .Equals()
* Reduce memory use by reducing array allocations
* Revert "Reduce memory use by reducing array allocations"
This reverts commit faf6b60234167f5443435243eb52187ab07d514c.
* reuse char[] for string.split() to avoid params [] allocation
2021-01-22 12:02:25 +10:00
Benjamin Carleski
7583c1fb06
Start cleanup of IOHelper.MapPath calls
2020-11-18 07:25:11 -08:00
Bjarke Berg
1ea39f2762
Merge remote-tracking branch 'origin/v8/dev' into netcore/dev
...
# Conflicts:
# src/Umbraco.Core/Models/PublishedContent/IPublishedContent.cs
# src/Umbraco.Core/Models/PublishedContent/PublishedContentBase.cs
# src/Umbraco.Core/Models/PublishedContent/PublishedContentWrapped.cs
# src/Umbraco.Core/Packaging/ConflictingPackageData.cs
# src/Umbraco.Core/Packaging/PackagesRepository.cs
# src/Umbraco.Core/PublishedCache/PublishedMember.cs
# src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MacroRepository.cs
# src/Umbraco.Infrastructure/PropertyEditors/RichTextEditorPastedImages.cs
# src/Umbraco.PublishedCache.NuCache/PublishedContent.cs
# src/Umbraco.Tests/Persistence/Repositories/MacroRepositoryTest.cs
# src/Umbraco.Tests/PublishedContent/SolidPublishedSnapshot.cs
# src/Umbraco.Web/Macros/PublishedContentHashtableConverter.cs
# src/Umbraco.Web/PublishedContentExtensions.cs
# src/Umbraco.Web/Trees/MediaTypeTreeController.cs
2020-03-02 08:34:52 +01:00
Bjarke Berg
90c2381c86
Renamed Umbraco.Abstractions to Umbraco.Core
2020-02-24 08:21:53 +01:00
abi
a7ad464b40
Remove Empty Statements
2020-02-12 15:11:18 +01:00
Ronald Barendse
34008edd34
Fix issues with added PanicException
2019-11-15 09:15:12 +01:00
Ronald Barendse
f1953bc99c
Use same argument validation in AddAttribute as in SetAttribute
2019-11-13 23:56:00 +01:00
Shannon
e58edd7d5d
Moves remaining Umbraco.Core.Xml items to abstractions project
2019-11-12 12:56:17 +11:00
Shannon
fce8ac87a2
Moves a bunch of the xml/xpath classes/interfaces and remvoes unused code of XmlHelper
2019-11-12 12:37:21 +11:00
Bjarke Berg
13507c0e13
AB3653 - Static IOHelper -> IIOHelper (Moved into Current as a first step 😭 )
2019-11-08 07:51:14 +01:00
Bjarke Berg
9d91402aca
V8: Follow guidelines from .editorconfig ( #6849 )
...
* Removed unused variable
* Align usage of C# type keywords vs Universal type names. Now we use C# keywords all over.
2019-10-25 14:16:50 +01:00
Ronald Barendse
ed90e71f76
Removed usage of obsoleted ArgumentNullOrEmptyException
2019-10-07 22:10:21 +02:00
Jeavon
e23b9153a0
fix: set some methods within XmlHelper to internal
2019-04-04 09:45:04 +01:00
Jeavon
ef79e6c0e9
fix: make XmlHelper class public
2019-04-03 10:54:53 +01:00
Chris Houston
193e24afd2
Fixing all the TODO, FIXME & HACK comments so they all follow the same layout.
2019-01-27 11:16:00 +01:00
Chris Houston
78319bae9e
Temp8 fix typos 2 ( #4130 )
2019-01-23 00:03:39 +01:00
Shannon
c89b50f0b8
large refactor/cleanup of most of the old package installer logic dealing with persisting the installedPackages.config which is now in the services, creates new parsers and removes a ton of old code, changes fetching packages to be async, uses XElement instead of old XmlNode apis, next we need to do the actual package installer updates
2019-01-11 14:30:04 +11:00
Warren
4392055249
Removes mention of Log4Net & the commented code with it as it's never invoked
2018-07-31 15:27:27 +01:00
Stephan
7a615133ff
Renormalize
2018-06-29 19:52:40 +02:00
Stephan
d54658009c
Port 7.7 - WIP
2017-09-18 15:33:13 +02:00
Stephan
c76403077f
Normalize cr/lf/tab
2017-07-20 11:21:28 +02:00
Stephan
d3133abcab
Get rid of Mandate
2017-05-31 10:10:47 +02:00
Stephan
b26b415096
Merge origin/dev-v7-deploy into dev-v8-zbwip (builds)
2016-11-03 10:31:44 +01:00
Stephan
187e5ed751
Add and use ArgumentNullOrEmptyException
2016-10-17 11:00:13 +02:00
Stephan
ecee4d3702
Merge branch dev-v8 into temp-u4-8497
2016-07-20 12:38:57 +02:00
Stephan
3c7245f9ba
Merge origin/dev-v7 into dev-v8
2016-07-08 16:32:06 +02:00
Stephan
90500af915
Merge dev-v8 into temp-u4-8497
2016-06-02 10:03:14 +02:00
Shannon
6a5a736877
Merge remote-tracking branch 'origin/dev-v7' into dev-v8
...
# Conflicts:
# .gitignore
# build/UmbracoVersion.txt
# src/Umbraco.Core/Configuration/UmbracoVersion.cs
# src/Umbraco.Core/Persistence/Migrations/Upgrades/TargetVersionSeven/UpdateRelatedLinksData.cs
# src/Umbraco.Core/Services/DataTypeService.cs
# src/Umbraco.Core/Xml/XmlHelper.cs
# src/Umbraco.Tests/Routing/UrlRoutingTestBase.cs
# src/Umbraco.Tests/TestHelpers/BaseDatabaseFactoryTest.cs
# src/Umbraco.Tests/TestHelpers/BaseUmbracoApplicationTest.cs
# src/Umbraco.Web.UI/Umbraco.Web.UI.csproj
# src/Umbraco.Web.UI/config/ClientDependency.config
# src/Umbraco.Web.UI/umbraco/config/lang/da.xml
# src/Umbraco.Web/PropertyEditors/GridPropertyEditor.cs
# src/Umbraco.Web/PropertyEditors/ImageCropperPropertyEditor.cs
# src/Umbraco.Web/PropertyEditors/LabelPropertyEditor.cs
# src/Umbraco.Web/PropertyEditors/MultipleMediaPickerPropertyEditor.cs
# src/Umbraco.Web/Routing/ContentFinderByLegacy404.cs
# src/Umbraco.Web/Routing/NotFoundHandlerHelper.cs
# src/Umbraco.Web/Umbraco.Web.csproj
# src/Umbraco.Web/umbraco.presentation/content.cs
# src/Umbraco.Web/umbraco.presentation/umbraco/create/DLRScriptingTasks.cs
# src/Umbraco.Web/umbraco.presentation/umbraco/create/language.ascx.cs
# src/Umbraco.Web/umbraco.presentation/umbraco/developer/Python/editPython.aspx.cs
# src/Umbraco.Web/umbraco.presentation/umbraco/dialogs/sendToTranslation.aspx.cs
# src/umbraco.cms/businesslogic/Packager/Installer.cs
# src/umbraco.cms/businesslogic/translation/Translation.cs
2016-05-31 16:00:32 +02:00
Stephan
ba7638793f
U4-8497 - fixing... tests green
2016-05-27 12:48:38 +02:00
Stephan
06574b8b40
U4-8447 - prepare for NuCache (work-in-progress)
2016-05-26 17:12:04 +02:00
