Nikolaj Brask-Nielsen
6d48091328
docs: XML warnings ( #14663 )
...
* chore: Fix XML warnings
* docs: Fix XML warnings
* docs: Fix XML in resource designer
* docs: Fix XML warnings
* Revert "docs: Fix XML in resource designer"
This reverts commit 8ea61c51ac161e1853ae080db7fe1b4d4cb4d2be.
2023-09-06 20:08:17 +02:00
Nikolaj Geisle
60a5b19dc9
V10: Fix build warnings in core ( #12438 )
...
* Run code cleanup
* Start manual cleanup after dotnet format
* Finish up manual pass
* Fix up missed warnings
* Fix after merge
* Update src/Umbraco.Core/Cache/ContentTypeCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/DataTypeCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/DeepCloneAppCache.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/DomainCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/MacroCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/MediaCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/MemberCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/MemberGroupCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Composing/OrderedCollectionBuilderBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Configuration/Models/RequestHandlerSettings.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Composing/SetCollectionBuilderBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Composing/WeightedCollectionBuilderBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/ContentApps/ContentAppFactoryCollectionBuilder.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Dashboards/DashboardCollectionBuilder.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/ContentTypeRefreshedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/ContentTypeSavedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/ContentTypeSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/DictionaryCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/DataTypeCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/ContentUnpublishingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/DictionaryItemDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/DictionaryItemSavedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/DictionaryItemSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/DomainCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/LanguageCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MacroCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaEmptiedRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaEmptyingRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaMovedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaMovedToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaMovedToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaMovingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaMovingToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTreeChangeNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTreeChangeNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTypeChangedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTypeDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTypeMovedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTypeMovingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTypeMovingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTypeRefreshedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberGroupCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberGroupDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberGroupSavedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberGroupSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeChangedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeDeletedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeMovedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeMovedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeMovingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeMovingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeRefreshedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/UriExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MovedToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MovedToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MovingToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MovingToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PartialViewDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/UriExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/IO/PhysicalFileSystem.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/IO/PhysicalFileSystem.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/IO/ShadowWrapper.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Logging/DisposableTimer.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Install/InstallSteps/UpgradeStep.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Mapping/MapDefinitionCollectionBuilder.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Media/EmbedProviders/EmbedProvidersCollectionBuilder.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PartialViewSavedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Models/ContentEditing/ContentVariationDisplay.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PartialViewSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessEntryDeletedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessEntryDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessEntryDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessEntrySavedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessEntrySavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessEntrySavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/RelationTypeCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/RelationTypeDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/RelationTypeSavedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/RelationTypeSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/StatefulNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/StylesheetDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/StylesheetSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Models/DeepCloneHelper.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Models/File.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Models/PropertyGroupExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Models/PropertyGroupExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Fix based on review
* Fix after merge
Signed-off-by: Zeegaan <nge@umbraco.dk >
Co-authored-by: Nikolaj Geisle <niko737@edu.ucl.dk >
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
Co-authored-by: Zeegaan <nge@umbraco.dk >
2022-06-07 15:28:38 +02:00
Andy Butland
b187c89113
Updates to null reference types ( #12317 )
...
* Amended IFileSystem OpenFile to return Stream.Null rather than a nullable stream.
* Updated IUmbracoMapper to map enumerables without null elements given non-null inputs.
* Amended EntityRepositoryBase to not return null collections.
* Made IPublishedElement.Properties a non-nullable collection.
2022-04-29 08:19:34 +02:00
Nikolaj Geisle
c6e7e139e9
Fix up build errors
2022-04-01 14:49:39 +02:00
Nikolaj Geisle
70a00901b4
Finish up Web.Backoffice
2022-04-01 14:35:18 +02:00
Nikolaj Geisle
a8cf6ee127
More work on nullable references
2022-02-22 13:35:32 +01:00
Nikolaj Geisle
224341a533
Merge remote-tracking branch 'origin/v10/dev' into v10/feature/nullable-reference-types-in-Umbraco-Core
...
# Conflicts:
# src/Umbraco.Core/Configuration/Models/SecuritySettings.cs
# src/Umbraco.Core/Events/DeleteEventArgs.cs
# src/Umbraco.Core/Events/IEventDispatcher.cs
# src/Umbraco.Core/Events/PassThroughEventDispatcher.cs
# src/Umbraco.Core/Events/QueuingEventDispatcherBase.cs
# src/Umbraco.Core/IO/MediaFileManager.cs
# src/Umbraco.Core/Models/Mapping/MemberTabsAndPropertiesMapper.cs
# src/Umbraco.Core/PropertyEditors/DataValueEditor.cs
# src/Umbraco.Core/Routing/DefaultUrlProvider.cs
2022-02-15 09:29:58 +01:00
Nikolaj Geisle
b75eae01f3
Add nullability to core project
2022-02-09 13:24:35 +01:00
Nikolaj Geisle
b6d5465b49
Fix up to Macros in Core project
2022-01-13 09:27:37 +01:00
Bjarke Berg
642c216f94
Serve Media and App_Plugins using WebRootFileProvider (and allow changing the physical media path) ( #11783 )
...
* Allow changing UmbracoMediaPath to an absolute path. Also ensure Imagesharp are handing requests outside of the wwwroot folder.
* Let UmbracoMediaUrl fallback to UmbracoMediaPath when empty
* Add FileSystemFileProvider to expose an IFileSystem as IFileProvider
* Replace IUmbracoMediaFileProvider with IFileProviderFactory implementation
* Fix issue resolving relative paths when media URL has changed
* Remove FileSystemFileProvider and require explicitly implementing IFileProviderFactory
* Update tests (UnauthorizedAccessException isn't thrown anymore for rooted files)
* Update test to use UmbracoMediaUrl
* Add UmbracoMediaPhysicalRootPath global setting
* Remove MediaFileManagerImageProvider and use composited file providers
* Move CreateFileProvider to IFileSystem extension method
* Add rooted path tests
Co-authored-by: Ronald Barendse <ronald@barend.se >
2022-01-06 13:35:24 +01:00
Bjarke Berg
2ec92057c5
Started using nullable reference types..
2021-12-16 13:44:20 +01:00
Shannon
3eb54831cb
Remove OriginalMediaPathScheme, changes how we extract the media file path and use that correctly instead of hacks.
2021-07-07 14:36:52 -06:00
Shannon
f7123b355d
init commit for changing packages back to xml format so we can more easily deal with media.
2021-07-06 15:09:56 -06:00
Mole
c9ebaadf23
Netcore: File systems rework ( #10181 )
...
* Allow IMediaFileSystem to be replace in the DI, or registered with inner filesystem
* Remove GetFileSystem from Filesystems
It was only used by tests.
* Make MediaFileSystem inherit from PhysicalFileSystem directly
* Remove FileSystemWrapper
* Remove inner filesystem from MediaFileSystem
* Add MediaFileManager and bare minimum to make it testable
* Remove MediaFileSystem
* Fix unit tests using MediaFileManager
* Remove IFileSystem and rely only on FileSystem
* Hide dangerous methods in FileSystems and do some cleaning
* Apply stylecop warnings to MediaFileManager
* Add FilesystemsCreator to Tests.Common
This allows you to create an instance if FileSystems with your own specified IFileSystem for testing purposes outside our own test suite.
* Allow the stylesheet filesystem to be replaced.
* Fix tests
* Don't save stylesheetWrapper in a temporary var
* refactor(FileSystems): change how stylesheet filesystem is registered
* fix(FileSystems): unable to overwrite media filesystem
SetMediaFileSystem added the MediaManager as a Singleton instead of
replacing the existing instance.
* fix(FileSystems): calling AddFileSystems replaces MediaManager
When calling AddFileSystems after SetMediaFileSystem the MediaManager
gets replaced by the default PhysicalFileSystem, so instead of calling
SetMediaFileSystem in AddFileSystems we now call TrySetMediaFileSystem
instead. This method will not replace any existing instance of the
MediaManager if there's already a MediaManager registered.
* Use SetMediaFileSystem instead of TrySet, and rename AddFilesystems to ConfigureFileSystems
Also don't call AddFileSystems again in ConfigureFilesystems
* Don't wrap CSS filesystem twice
* Add CreateShadowWrapperInternal to avoid casting
* Throw UnauthorizedAccessException isntead of InvalidOperationException
* Remove ResetShadowId
Co-authored-by: Rasmus John Pedersen <mail@rjp.dk >
2021-04-27 09:52:17 +02:00
