* Migrating more model, mapping and tree classes
* Migrating files from Mapping dir without Newtonsoft dependency
* Migrating files from PublishedContent and Editors dirs without Newtonsoft dependency + some more of the same kind
* Migrating DataType class without the usage of Newtonsoft.Json and making the corresponding changes to all classes affected
* Combining 3 ContentExtensions files into 1
* Refactoring from migrating ContentExtensions
* Migrating more classes
* Migrating ContentRepositoryExtensions - combining it with existing file in Umbraco.Core
* removing Newtonsoft json dependency & migrating file. Adding partial migration of ConfigurationEditor, so PropertyTagsExtensions can be migrated
* Migrating ContentTagsExtensions, and refactoring from changes in PropertyTagsExtensions
* Changes that should be reverted once ConfigurationEditor class is fully migrated
* VS couldn't find Composing, so build was failing. Removing the using solves the problem
* Handling a single case for deserializing a subset of an input
* Small changes and added tests to JsonNetSerializer
Signed-off-by: Bjarke Berg <mail@bergmania.dk>
* Migrated ConfigurationEditor
Signed-off-by: Bjarke Berg <mail@bergmania.dk>
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
* Migrated database server registrar and messenger tasks into hosted services.
Moved DatabaseServerRegistrar Options into injectable configuration.
* Added further cases for unit tests on hosted services checking execution based on runtime level.
* Migrated DatabaseServerMessengerOptions into configuration.
* Split Bootstrap code from CoreRuntime
* Make ContentService method signatures match interface
prevents need to hide the concrete class in tests
* Remove Current
Only bit that bugs me is TreeNode for IconFilePath
I get the feeling it's dead code, but can just use a setter in cs or work out path in js if required.
* Fix tests, remember to terminate IRuntime
Amended signatures of method under test to support testing without the previously observed behaviour of an erroring test passing but crashing the test runner process.
* Implemented health check notifier as a hosted service.
Added validation to health check settings.
* Registered health check notifier as a hosted service.
Modified health check nested settings to use concrete classes to align with other configuration models.
* Resolved issues with email sending using development server.
* PR review comments and fixed failing unit test.
* Changed period and delay millisecond and hourly values to TimeSpans.
Changed configuration of first run time for health check notifications to use H:mm format.
* Set up SecureSocketOptions as a locally defined enum.
* Tightened up time format validation to verify input is an actual time (with hours and minutes only) and not a timespan.
* Aligned naming and namespace of health check configuration related classes with other configuration classes.
* Created constants for hex colors used in formatting health check results as HTML.
* Revert "Tightened up time format validation to verify input is an actual time (with hours and minutes only) and not a timespan."
This reverts commit f9bb8a7a825bcb58146879f18b47922e09453e2d.
* Renamed method to be clear validation is of a TimeSpan and not a time.
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
* Replace IFactory with IServiceProvider
* Replace IRegister with IServiceCollection
* Fix Rte.cshtml so the view can service locate.
* Replace Composing Lifetime with MSDI ServiceLifetime
* Remove ServiceProvider AddMultipleUnique extension
* Remove Umbraco.Web.Composing.Current.Reset and any calls
* Remove LightInject from net framework projects
* Brought back a helper for setting MediaFileSystem underlying IFileSystem
* Moved adapters from Infra -> Core
* Allow Composition to accept a service collection instead of an IRegister
* Composition no longer takes IRegister as constructor arg
all tests passing
* Composition no longer implements IRegister
* Lose _uniques in Composition
* lose Composition OnCreatingFactory actions
* Clean up UmbracoCoreServiceCollectionExtensions & Composition
Less IFactory
* LightInject gone where TFW == netstandard2.0 || TFW == netcoreapp3.1
* Resolve dead code issues
* Rename IFactory methods to match IServiceProvider so they can be trivially swapped later.
* Rename IFactory methods to match IServiceProvider so they can be trivially swapped later (continued)
Thought the counts were low, it's mostly extension method usage
* Doesn't make much sense to have Concrete on IRegister, only on IFactory
* Handle FilesTreeController requires IFileSystem of type PhysicalFileSystem
* Handle registration of default MediaFileSystem without using RegisterUniqueFor
* Remove RegisterFor / RegisterUniqueFor from IRegister
* Switch over from LightInject to wrappers around MSDI
* Made mapper dependencies more explicit
* Remove registration for AngularJsonMediaTypeFormatter
It's dependencies aren't registered so container validation fails
* Resolve lifetime issue for EnsureValidSessionId by service locating
else resolve scoped in singleton
* Make registration more explicit for backoffice UserManager
* Make install step registrations more explicit
* Disable service provider validation so site can launch
Maybe this is a problem maybe not, we build about 8000 service providers so maybe everything is fine later...
* Further cleanup of IFactory interface
* Further cleanup of IRegister interface
* Revert "Make registration more explicit for backoffice UserManager"
This reverts commit 7215fe836103c597cd0873c66737a79b91ed4c49.
* Resolve issue where NewInstallStep would fail to reset password for "SuperUser"
Before MSDI, somehow BackOfficeIdentityOptions would be configured with token provider map from IdentityBuilder.AddDefaultTokenProviders.
After switchover those config actions are lost.
Subclass IdentityBuilder to ensure BackOfficeIdentityOptions doesn't miss config setup upstream.
* Initialize current.
* Add todo to turn container validation back on.
* Migrated ScopeFileSystemsTests to integration tests
Signed-off-by: Bjarke Berg <mail@bergmania.dk>
* Resolve issue where MediaFileSystem was skipping ShadowFileSystem
* Attempt to fix ScopeFileSystemsTests on azure devops
Signed-off-by: Bjarke Berg <mail@bergmania.dk>
* Be interesting to know what the actual full path is in pipeline.
* Clarify intent of CreateMediaTest
Doesn't help resolve weird UnauthorizedAccessException but it cuts so much cognitive overhead for the future.
* Use ILoggerfactory rather than mock for the manually constructed file PhysicalFileSystem
* Maybe resolve failing test on azure pipeline.
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
* Started moving to JSON instead of config.
Mild refactoring but overall keeping it the same, except for injecting IConfiguration and JSON parsing instead of XML
Tests currently unaffected, need to increase coverage
* Moved to constants for appsettings keys
Moved from IConfiguration to global settings - later to be replaced with IOptions
Updated translation messages
Installed IOptions ready for new PR
Updated to new interface, IConfigurationService
* Post-merge fix
* Namespace move from Umbraco.Web to Umbraco.Core where appropriate
* Renamed abstractsettings (from abstractconfig)
Moving out of configservice into the POCO config check
* Made the IIsCustomErrors healthcheck as obsolete, as no web.config setting). Investigate reintroducing this check in the .NET Core way (UseDevelopment).
Reducing use of abstractsettings as not needed - we don't need a config service to read the config settings anymore as they're all explicit POCOs.
Consolidated health-checks in project.
* Removed test views that weren't meant to be added
* Returned to use of abstractsettings with different use
* Moved more health checks into correct folder/namespace, and enum into their own file
* Correct namespace
* Git history/compare lost due to file move, temporarily moving back to original folder. Will do another PR to move after this
* Use existing GetStatus in abstract check for Debug mode
* Updating to return to previous logic and putting files back into line
* Macro errors returned to previous logic
* Reuse abstractsettings class
* Swapped order to assist with reviewing PR
* Updated to include itempath
* Not implemented comment to avoid confusion
Implemented NotificationEmailCheck
* Changed to IOptionsMonitor as per PR comments. Removed configurationservice as we need to rethink the fixing strategy. Updated logger.
Needs to show fix message instead of fixing. Temporary fix for IIS version
* Switched to IOptionsMonitor for all
* No longer attempts to actually fix header in config. Still need to show suggestions.
Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
