Paul Johnson
a99f625f6a
Netcore: Alternate approach for MSDI refactor ( #9247 )
...
* Doesn't make much sense to have Concrete on IRegister, only on IFactory
* Handle FilesTreeController requires IFileSystem of type PhysicalFileSystem
* Handle registration of default MediaFileSystem without using RegisterUniqueFor
* Remove RegisterFor / RegisterUniqueFor from IRegister
* Switch over from LightInject to wrappers around MSDI
* Made mapper dependencies more explicit
* Remove registration for AngularJsonMediaTypeFormatter
It's dependencies aren't registered so container validation fails
* Resolve lifetime issue for EnsureValidSessionId by service locating
else resolve scoped in singleton
* Make registration more explicit for backoffice UserManager
* Make install step registrations more explicit
* Disable service provider validation so site can launch
Maybe this is a problem maybe not, we build about 8000 service providers so maybe everything is fine later...
* Further cleanup of IFactory interface
* Further cleanup of IRegister interface
* Revert "Make registration more explicit for backoffice UserManager"
This reverts commit 7215fe836103c597cd0873c66737a79b91ed4c49.
* Resolve issue where NewInstallStep would fail to reset password for "SuperUser"
Before MSDI, somehow BackOfficeIdentityOptions would be configured with token provider map from IdentityBuilder.AddDefaultTokenProviders.
After switchover those config actions are lost.
Subclass IdentityBuilder to ensure BackOfficeIdentityOptions doesn't miss config setup upstream.
* Initialize current.
* Add todo to turn container validation back on.
* Migrated ScopeFileSystemsTests to integration tests
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
* Resolve issue where MediaFileSystem was skipping ShadowFileSystem
* Attempt to fix ScopeFileSystemsTests on azure devops
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
* Be interesting to know what the actual full path is in pipeline.
* Clarify intent of CreateMediaTest
Doesn't help resolve weird UnauthorizedAccessException but it cuts so much cognitive overhead for the future.
* Use ILoggerfactory rather than mock for the manually constructed file PhysicalFileSystem
* Maybe resolve failing test on azure pipeline.
Co-authored-by: Bjarke Berg <mail@bergmania.dk >
2020-10-26 11:47:14 +01:00
Shannon
64d8b56eca
It builds!
2020-10-23 14:18:53 +11:00
Shannon
1400a02798
Merge branch 'netcore/dev' into netcore/task/6973-migrating-authenticationcontroller
...
# Conflicts:
# src/Umbraco.Core/Constants-Security.cs
# src/Umbraco.Infrastructure/BackOffice/BackOfficeClaimsPrincipalFactory.cs
# src/Umbraco.Infrastructure/BackOffice/BackOfficeUserManager.cs
# src/Umbraco.Infrastructure/Migrations/Upgrade/UmbracoPlan.cs
# src/Umbraco.Tests.AcceptanceTest/cypress/integration/Tour/backofficeTour.ts
# src/Umbraco.Web.BackOffice/Controllers/BackOfficeServerVariables.cs
# src/Umbraco.Web.BackOffice/Controllers/DenyLocalLoginAuthorizationAttribute.cs
# src/Umbraco.Web.BackOffice/Controllers/UsersController.cs
# src/Umbraco.Web.BackOffice/Extensions/HtmlHelperBackOfficeExtensions.cs
# src/Umbraco.Web.BackOffice/Services/IconService.cs
# src/Umbraco.Web.Common/Security/ExternalSignInAutoLinkOptions.cs
# src/Umbraco.Web.UI.Client/src/common/interceptors/_module.js
# src/Umbraco.Web.UI.Client/src/common/interceptors/requiredheaders.interceptor.js
# src/Umbraco.Web.UI.Client/src/views/common/overlays/user/user.controller.js
# src/Umbraco.Web.UI.NetCore/umbraco/UmbracoBackOffice/Default.cshtml
# src/Umbraco.Web.UI.NetCore/umbraco/config/lang/da.xml
# src/Umbraco.Web.UI.NetCore/umbraco/config/lang/en.xml
# src/Umbraco.Web.UI.NetCore/umbraco/config/lang/en_us.xml
# src/Umbraco.Web.UI/Umbraco/Views/AuthorizeUpgrade.cshtml
# src/Umbraco.Web/Editors/AuthenticationController.cs
# src/Umbraco.Web/Editors/BackOfficeController.cs
# src/Umbraco.Web/Editors/Filters/IsCurrentUserModelFilterAttribute.cs
# src/Umbraco.Web/Security/AppBuilderExtensions.cs
# src/Umbraco.Web/Security/AuthenticationOptionsExtensions.cs
# src/Umbraco.Web/UmbracoDefaultOwinStartup.cs
2020-10-23 10:10:02 +11:00
Anthony
759eee042f
Refactored according to PR feedback.
2020-10-21 20:57:21 +01:00
Anthony
c1e59525a3
Refactored unique node name generation with new BDD tests
2020-10-19 20:06:49 +01:00
Bjarke Berg
e567f25487
Migrated ContentEventsTests.cs
...
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
2020-10-14 11:10:02 +02:00
Bjarke Berg
424c3b821e
Clean up
2020-10-09 09:35:30 +02:00
Bjarke Berg
e69f3d02de
Clean up
2020-10-09 09:34:44 +02:00
Bjarke Berg
05d8b0aaf8
Changed to use a ReadOnlyRelation model
2020-10-09 09:32:32 +02:00
Bjarke Berg
731a189fbe
Removed uncommented code
2020-10-08 14:54:42 +02:00
Bjarke Berg
55db973e82
Introduced IRelationRepository.SaveBulk to use internally when performance is important.
...
Fixed issue in RelationRepository.Save not populating Ids on LocalDB/SqlServer
2020-10-08 14:38:02 +02:00
Bjarke Berg
3171cdda70
Migrated RelationServiceTests.cs
...
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
2020-10-07 21:01:28 +02:00
Bjarke Berg
c4cedceda1
Merge
2020-10-07 08:49:37 +02:00
Mole
b5aedde616
Do some ILogger cleaning
2020-09-28 08:48:49 +02:00
Bjarke Berg
35443f0e71
Merge remote-tracking branch 'origin/netcore/netcore' into netcore/feature/migrate-logging
...
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
# Conflicts:
# src/Umbraco.Infrastructure/Search/ExamineComponent.cs
# src/Umbraco.Tests/Persistence/Repositories/UserRepositoryTest.cs
2020-09-24 08:24:35 +02:00
Bjarke Berg
0d731e7a40
Merge remote-tracking branch 'origin/netcore/dev' into netcore/netcore
...
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
# Conflicts:
# build/build-bootstrap.ps1
# src/Umbraco.Infrastructure/Compose/NotificationsComponent.cs
# src/Umbraco.Infrastructure/Compose/PublicAccessComponent.cs
# src/Umbraco.Infrastructure/Search/ExamineComponent.cs
# src/Umbraco.ModelsBuilder.Embedded/Compose/ModelsBuilderComponent.cs
# src/Umbraco.Tests/Persistence/Repositories/UserRepositoryTest.cs
# src/Umbraco.Web/Compose/BackOfficeUserAuditEventsComponent.cs
# src/Umbraco.Web/Logging/WebProfilerComponent.cs
2020-09-23 13:28:36 +02:00
Bjarke Berg
e3c8bd8ced
Merge remote-tracking branch 'origin/v8/dev' into netcore/dev
...
# Conflicts:
# src/Umbraco.Core/Cache/MemberCacheRefresher.cs
# src/Umbraco.Infrastructure/Compose/NotificationsComponent.cs
# src/Umbraco.Infrastructure/Search/ExamineComponent.cs
# src/Umbraco.Tests/Persistence/Repositories/UserRepositoryTest.cs
# src/Umbraco.Web/Security/MembershipHelper.cs
# src/Umbraco.Web/Security/Providers/UmbracoMembershipProvider.cs
2020-09-23 12:54:13 +02:00
Mole
7ad8cd2bf8
Use loggerfactory in both constuctors in UmbracoDatabaseFactory
2020-09-21 08:03:27 +02:00
Mole
d61b9f54fa
Merge options
2020-09-18 12:53:06 +02:00
Nikolaj
001df5f5a1
Use Microsoft ILogger in Repositories
2020-09-17 09:42:55 +02:00
Nikolaj
120e163682
Begin trying to replace logger in Current
2020-09-16 13:46:45 +02:00
Nikolaj
a18580c7f6
Remove Debug<T> from LoggerExtensions
2020-09-16 10:24:05 +02:00
Nikolaj
488093add3
Remove LogWarning<T> from LoggerExtensions
2020-09-16 10:08:18 +02:00
Nikolaj
dda6fb12a3
Remove LogError<T> from LoggerExtensions
2020-09-16 09:40:49 +02:00
Bjarke Berg
b4353585c3
Simplifyed the ConnectionStrings config
2020-09-15 09:11:36 +02:00
Nikolaj
161061dbbc
Remove exception logging and finish LogWarning
2020-09-14 14:10:19 +02:00
Nikolaj
a1ecc4a5c9
Change Warn to LogWarning
2020-09-14 10:17:32 +02:00
Nikolaj
d7e3bce741
Rename Error to align it with MS ILogger
2020-09-14 09:10:53 +02:00
Bjarke Berg
dc643ab6a6
Merge remote-tracking branch 'origin/netcore/netcore' into feature/8651-config-options-patten
...
# Conflicts:
# src/Umbraco.Core/Configuration/ModelsBuilderConfigExtensions.cs
# src/Umbraco.ModelsBuilder.Embedded/BackOffice/ContentTypeModelValidatorBase.cs
# src/Umbraco.ModelsBuilder.Embedded/BackOffice/ModelsBuilderDashboardController.cs
# src/Umbraco.ModelsBuilder.Embedded/Building/ModelsGenerator.cs
# src/Umbraco.ModelsBuilder.Embedded/Compose/ModelsBuilderComposer.cs
# src/Umbraco.ModelsBuilder.Embedded/ModelsGenerationError.cs
# src/Umbraco.ModelsBuilder.Embedded/OutOfDateModelsStatus.cs
# src/Umbraco.ModelsBuilder.Embedded/PureLiveModelFactory.cs
# src/Umbraco.Web.BackOffice/Controllers/RedirectUrlManagementController.cs
2020-09-10 14:01:38 +02:00
Bjarke Berg
fc054e6546
Merge remote-tracking branch 'origin/netcore/dev' into netcore/netcore
...
# Conflicts:
# build/NuSpecs/UmbracoCms.Web.nuspec
# src/SolutionInfo.cs
# src/Umbraco.Infrastructure/Logging/Serilog/LoggerConfigExtensions.cs
# src/Umbraco.Infrastructure/PropertyEditors/NestedContentPropertyEditor.cs
# src/Umbraco.Tests.AcceptanceTest/cypress/integration/Tour/backofficeTour.ts
# src/Umbraco.Tests.AcceptanceTest/package.json
# src/Umbraco.Tests/TestHelpers/TestObjects.cs
# src/Umbraco.Web.BackOffice/Controllers/ContentTypeController.cs
# src/Umbraco.Web.BackOffice/Controllers/ImageUrlGeneratorController.cs
# src/Umbraco.Web.BackOffice/Controllers/ImagesController.cs
# src/Umbraco.Web.BackOffice/Controllers/MediaController.cs
# src/Umbraco.Web.BackOffice/Controllers/MemberTypeController.cs
# src/Umbraco.Web.BackOffice/Controllers/RelationTypeController.cs
# src/Umbraco.Web.BackOffice/Controllers/TemplateController.cs
# src/Umbraco.Web.UI.Client/src/common/services/formhelper.service.js
# src/Umbraco.Web.UI.Client/src/installer/steps/database.html
# src/Umbraco.Web.UI.Client/src/less/components/tree/umb-tree.less
# src/Umbraco.Web.UI.Client/src/less/components/umb-property-actions.less
# src/Umbraco.Web.UI.Client/src/less/forms.less
# src/Umbraco.Web.UI.Client/src/views/common/infiniteeditors/querybuilder/querybuilder.html
# src/Umbraco.Web.UI.Client/src/views/common/infiniteeditors/treepicker/treepicker.html
# src/Umbraco.Web.UI.Client/src/views/components/application/umb-navigation.html
# src/Umbraco.Web.UI.Client/src/views/components/property/umb-property-actions.html
# src/Umbraco.Web.UI.Client/src/views/content/overlays/publish.controller.js
# src/Umbraco.Web.UI.Client/src/views/content/overlays/publishdescendants.html
# src/Umbraco.Web.UI.Client/src/views/dictionary/edit.html
# src/Umbraco.Web.UI.Client/src/views/dictionary/list.html
# src/Umbraco.Web.UI.Client/src/views/logViewer/search.html
# src/Umbraco.Web.UI.Client/src/views/media/media.edit.controller.js
# src/Umbraco.Web.UI.Client/src/views/mediaTypes/edit.controller.js
# src/Umbraco.Web.UI.Client/src/views/member/member.edit.controller.js
# src/Umbraco.Web.UI.Client/src/views/memberTypes/edit.controller.js
# src/Umbraco.Web.UI.Client/src/views/packages/views/repo.html
# src/Umbraco.Web.UI.Client/src/views/propertyeditors/grid/dialogs/layoutconfig.html
# src/Umbraco.Web.UI.Client/src/views/propertyeditors/grid/dialogs/rowconfig.html
# src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/layouts.prevalues.html
# src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/layouts/list/list.listviewlayout.controller.js
# src/Umbraco.Web.UI.Client/src/views/propertyeditors/nestedcontent/nestedcontent.controller.js
# src/Umbraco.Web.UI.Client/src/views/propertyeditors/userpicker/userpicker.controller.js
# src/Umbraco.Web.UI.NetCore/umbraco/UmbracoBackOffice/Default.cshtml
# src/Umbraco.Web.UI.NetCore/umbraco/config/lang/da.xml
# src/Umbraco.Web.UI.NetCore/umbraco/config/lang/en.xml
# src/Umbraco.Web.UI.NetCore/umbraco/config/lang/en_us.xml
# src/Umbraco.Web.UI/Umbraco/config/lang/cs.xml
# src/Umbraco.Web.UI/Views/Partials/Grid/Editors/Media.cshtml
# src/Umbraco.Web.UI/config/umbracoSettings.config
# src/Umbraco.Web/Editors/BackOfficeServerVariables.cs
# src/Umbraco.Web/Editors/DictionaryController.cs
# src/Umbraco.Web/Editors/LogController.cs
# src/Umbraco.Web/Editors/MediaTypeController.cs
# src/Umbraco.Web/Editors/MemberGroupController.cs
2020-09-09 19:13:37 +02:00
Bjarke Berg
d14e2a99bc
Merge remote-tracking branch 'origin/v8/dev' into netcore/dev
...
# Conflicts:
# .gitignore
# build/NuSpecs/tools/Web.config.install.xdt
# src/Umbraco.Core/ContentExtensions.cs
# src/Umbraco.Infrastructure/Intall/InstallHelper.cs
# src/Umbraco.Infrastructure/Models/Blocks/BlockEditorModel.cs
# src/Umbraco.Infrastructure/Models/Blocks/BlockItemData.cs
# src/Umbraco.Infrastructure/Models/Blocks/BlockListLayoutReference.cs
# src/Umbraco.Infrastructure/Models/Mapping/CommonMapper.cs
# src/Umbraco.Infrastructure/PropertyEditors/BlockEditorPropertyEditor.cs
# src/Umbraco.Infrastructure/PropertyEditors/BlockListConfigurationEditor.cs
# src/Umbraco.Infrastructure/PropertyEditors/NestedContentPropertyEditor.cs
# src/Umbraco.Tests/PropertyEditors/BlockListPropertyValueConverterTests.cs
# src/Umbraco.Web.UI.Client/package-lock.json
# src/Umbraco.Web/Compose/NestedContentPropertyComponent.cs
2020-09-09 14:16:46 +02:00
Bjarke Berg
c8669b18c2
Merge remote-tracking branch 'origin/netcore/netcore' into feature/8651-config-options-patten
...
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
2020-09-04 14:30:48 +02:00
Shannon
1c83c68862
Fixes integration tests localization text
2020-09-04 01:30:47 +10:00
Shannon
7c78b5b34f
Updates CoreRuntime with better dependencies so we can disable caches, fixes integration test to run multiple callbacks registered for TearDown, ensure we TearDown the runtime.
2020-09-04 00:27:43 +10:00
Andy Butland
f1bda37a64
Updates following PR review.
2020-09-01 18:10:12 +02:00
Andy Butland
2a59a8385c
Merge branch 'netcore/netcore' into feature/8651-config-options-patten
...
# Conflicts:
# src/Umbraco.Tests.Common/Builders/GlobalSettingsBuilder.cs
# src/Umbraco.Tests/TEMP/DatabaseContextTests.sdf
# src/Umbraco.Web.BackOffice/Controllers/ImagesController.cs
2020-08-27 09:03:01 +02:00
Andy Butland
64f8752587
Removed introduced second constructors for IOptions based depenedencies and used Options.Create instead.
2020-08-26 11:58:44 +02:00
Bjarke Berg
3d55dcd3c4
Merge remote-tracking branch 'netcore/dev' into netcore/netcore
2020-08-26 08:05:15 +02:00
Andy Butland
8fd59d546e
Fixed failing tests.
2020-08-26 07:55:23 +02:00
Bjarke Berg
ca3f65891d
Merge remote-tracking branch 'origin/v8/dev' into netcore/dev
2020-08-25 14:00:59 +02:00
Andy Butland
2cd91a5a54
Converted to IOptions over IOptionsSnapshot due to the latter only working in scoped services.
...
Further amends to return to booting application.
2020-08-23 23:36:48 +02:00
Andy Butland
510bd92e78
Amended injection of further settings to use IOptionsSnapshot.
2020-08-21 14:52:47 +01:00
Andy Butland
e3a44c6717
Moved configuration setting POCOs into Umbraco.Core and adjusted references.
...
Amended injection of some settings to use IOptionsSnapshot.
2020-08-20 22:18:50 +01:00
Bjarke Berg
c57c42d2ec
Fixes merge conflicts
2020-08-07 14:00:56 +02:00
Bjarke Berg
39162f0f6a
Merge conflicts resolved
2020-08-06 12:59:21 +02:00
Shannon
e47f81efdc
Gettting password formats and hashing sorted, ensuring the password format on the user is used
2020-05-27 13:48:26 +10:00
Shannon
8134a35fe0
Moves ContentType, MemberType, MediaType, etc... less casting, less internals
2020-05-20 11:59:41 +10:00
Shannon
d444dfd441
Moves ContentTypeBase, Member, ContentTypeComposition, etc... removes the casting
2020-05-20 11:33:10 +10:00
Shannon
7bea165597
Moves UserGroup and UserGroupExtensions to core
2020-05-20 10:37:11 +10:00
Shannon
96e006e8b9
Moves user to Core models and removes backwards compat hacks and casting
2020-05-20 10:22:48 +10:00