Henrik
7f88013689
Make internal & private classes sealed where possible, to avoid code for virtual dispatch ( #19719 )
2025-07-21 08:32:54 +02:00
Kenn Jacobsen
790c451df1
Published status filtering ( #18281 )
...
* Initial refactor (pending more tests)
* Fix structural querying across changing publish states + add tests accordingly
* Add tests to validate ancestor and descendant order
* Remove axis querying from published status filtering
---------
Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com >
2025-02-25 13:25:33 +01:00
Henrik
ed08923b46
Use the new more efficient .NET 9 Lock type ( #18015 )
2025-01-20 11:41:13 +01:00
Nikolaj Geisle
e5e5e8cb11
V15: Warn when content is unroutable ( #17837 )
...
* Add notification handler
* Add IsContentPublished that bypasses caching
* Add clarifying comment
* Refactor, to never hit the db
* Remove old comment
* Don't add warnings if disabled
* Dedicated configuration option to suppress unroutable content warnings
---------
Co-authored-by: kjac <kja@umbraco.dk >
2025-01-08 09:14:14 +01:00
Sven Geusens
e7eb14d310
V15/task/cleanup obsolete ( #17433 )
...
* Replace obsolete UserGroup Alias consts to key equivalent in tests
* Update use of usergroup alias consts to key equivalent in IsSystemgroup extension method
* Obsolete (internally) unused helper function which purpose doesn't even seem true
* Prepped EmbedProviders for proper removal of non async methods and unneeded proxy methods
* Remove obsoleted UmbracoPath and updated internal references
* Corrected mistake and updated unittets
* Update usergroup tests that use aliases for "system" groups
* Replace more uses of globalsettings.UmbracoPath
* Remove GetDateType by key non async
* Cleanup some usages of hostingEnvironment.MapPathContentRoot
* More easy obsoletion cleanup
* Small Typeload cleanup
* More obsolete removal
* Deploy obsoletion cleanup
* Remove obsolete methods from OEmbedProviderBase.cs
---------
Co-authored-by: Zeegaan <skrivdetud@gmail.com >
2024-11-07 12:20:22 +01:00
Bjarke Berg
e6568c69dc
Added a notifiction handler that checks if we wanna have domain publish warnings. If so it adds as Umb-Notifications and logs it. ( #16507 )
2024-05-31 12:26:37 +02:00
Nikolaj Geisle
d5809da665
V14: Move towards get guid ( #15889 )
...
* Implement using keymap for member
* Remove current usages of GetUserById
* User userId resolver to resolve user key
* Refactor user repository to use GUID not int
* Add happy path test
* Remove user in cache when user gets updated
* Use await in async method
* Fix up according to review
* Update IMetricsConsentService.cs to have async method
* Fix according to review
* Fix more according to comments
* Revert "Fix up according to review"
This reverts commit a75acaaa
* Get current backoffice user from method
* Update user repository delete functionality
* Fix up more test
* Try to get user by id if key fails
* Add user key as required claim
* Fix tests
* Don't set claim in BackofficeController
* Create constant for the Sub claim
---------
Co-authored-by: kjac <kja@umbraco.dk >
2024-04-11 13:53:34 +02:00
Kenn Jacobsen
976bca456e
Remove macros ( #15794 )
...
* Remove macros!
* Clean up snippets
* Add migration that deletes all macros
* Review comments
2024-02-29 15:11:06 +01:00
Bjarke Berg
2839131033
Merge remote-tracking branch 'origin/v13/dev' into v14/dev
2023-08-08 12:10:18 +02:00
Bjarke Berg
85311f9277
Merge remote-tracking branch 'origin/v11/dev' into v12/dev
...
# Conflicts:
# src/Umbraco.Core/Events/EventAggregator.Notifications.cs
# src/Umbraco.Core/Events/EventAggregator.cs
2023-08-08 11:30:40 +02:00
Bjarke Berg
7cf4826e2f
Merge remote-tracking branch 'origin/v10/dev' into v11/dev
2023-08-08 11:26:01 +02:00
Bjarke Berg
04b74dddd0
Added missing async awaits in notifications that ensures objects are not disposed too early
...
Fixes https://github.com/umbraco/Umbraco-CMS/issues/14574
2023-08-02 11:37:39 +02:00
Bjarke Berg
c11d0d3f5a
Added missing async awaits in notifications that ensures objects are not disposed too early
...
Fixes https://github.com/umbraco/Umbraco-CMS/issues/14574
2023-08-01 14:23:30 +02:00
Bjarke Berg
22b2f79d15
Merge remote-tracking branch 'origin/v12/dev' into v14/dev
...
# Conflicts:
# src/Umbraco.Cms.Api.Common/DependencyInjection/UmbracoBuilderApiExtensions.cs
# src/Umbraco.Core/CompatibilitySuppressions.xml
# src/Umbraco.Infrastructure/CompatibilitySuppressions.xml
# src/Umbraco.Web.Common/Profiler/WebProfiler.cs
2023-06-21 09:06:42 +02:00
Bjarke Berg
197efbb12c
Merge remote-tracking branch 'origin/release/12.0' into v12/dev
...
# Conflicts:
# src/Umbraco.Infrastructure/Sync/ServerMessengerBase.cs
# version.json
2023-06-20 13:56:27 +02:00
Ronald Barendse
c989c5e214
Support publishing multiple notifications, filter on handler type and add IDistributedCacheNotificationHandler<TNotification> (optimizes cache refreshers) ( #14332 )
...
* Clean up DistributedCache and add additional checks
* Add IEnumerable overloads to DistributedCacheExtensions
* Update handlers to use new IEnumerable overloads
* Move DistributedCacheExtensions to Core
* Restructure cache refreshers into folders
* Add IDistributedCacheNotificationHandler
* Rewrite DistributedCacheBinder into seperate IDistributedCacheNotificationHandler implementations
* Obsolete DistributedCacheBinder and use new IDistributedCacheHandler implementations
* Clean up ServerMessengerBase
* Ensure cache refreshers only process distinct values
* Add support for publishing multiple notifications and filter on handler type
* Suppress compatibility issues
* Remove DistributedCacheBinder and suppress compatibility issues
* Add ScopedNotificationPublisher<TNotificationHandler>
* Improve notification type lookup/enumeration
* Ensure INotificationAsyncHandler handles multiple notitications sequentially
* Minimize cache instruction JSON
* Chunk notifications by type to keep publish order
* Only serialize required RefreshInstruction properties
2023-06-20 11:15:47 +02:00
Bjarke Berg
520309e3f8
Merge remote-tracking branch 'origin/v12/dev' into v14/dev
...
# Conflicts:
# src/Umbraco.Infrastructure/Migrations/Upgrade/UmbracoPlan.cs
# src/Umbraco.Infrastructure/Persistence/Repositories/Implement/UserRepository.cs
# src/Umbraco.Web.BackOffice/Controllers/MediaController.cs
# src/Umbraco.Web.BackOffice/Filters/FileUploadCleanupFilterAttribute.cs
2023-06-12 10:10:08 +02:00
Chad
e784cfa960
Improve logging performance by checking Trace/Debug log level is enabled ( #12793 )
2023-06-07 11:47:05 +02:00
Bjarke Berg
979e023d73
Merge remote-tracking branch 'origin/v12/dev' into v13/dev
...
# Conflicts:
# src/Umbraco.Infrastructure/CompatibilitySuppressions.xml
# tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/BlockGridEditor/Content/blockGridEditorAdvanced.spec.ts
2023-05-15 08:51:50 +02:00
Nikolaj Geisle
e4c03e0d4e
V11: Obsolete action to publish ( #14208 )
...
* Add obsolete message to ActionToPublish
* Obsolete handler for ContentSentTOPublishNotifcation
2023-05-11 13:58:57 +02:00
Nikolaj Geisle
5e90fa26c1
V13: Add parentkey to notifications ( #13832 )
...
* Add parent key to CopyingNotification
* Use parentkey on notifications
* Implement ParentKeys for Copying notification
* Obsolete parentId
* Implement MoveToEventInfoBase
* Refactor MovingToRecycleBinNotification to use the new MoveEVentInfoBase
* Refactor MediaMovingToRecycleBinNotification
* Refactor MovedToRecycleBinNotification to use new MoveEventInfo
* Refactor ContentMovedToRecycleBinNotification to use new MoveEventInfo
* Start implementing parent key in moveinfo
* Add FIXME's to move methods
* Refactor Move to get parentKey for descendants
* Add FIXME for move method
* Use MoveToRecycleBinEventInfo in RelateOnTrashNotificationHandler
* Add fixme's to DataTypeRepository
* Add obsolete messages
* Revert changes in ContentTypeServiceBaseOfTRepositoryTItemTService.cs
* Fix bad indentation
* Pass the recursive variable
* Revert changes in ContentService.cs
* Refactor MoveEventInfo to not duplicate equals method
* Refactor Equals to not duplicate code
* Add UnitTests of Equals
* make equals public and add non-happy path tests
* Remvoe duplicate call to base
---------
Co-authored-by: Zeegaan <nge@umbraco.dk >
2023-02-27 08:40:17 +01:00
Nikolaj Geisle
60a5b19dc9
V10: Fix build warnings in core ( #12438 )
...
* Run code cleanup
* Start manual cleanup after dotnet format
* Finish up manual pass
* Fix up missed warnings
* Fix after merge
* Update src/Umbraco.Core/Cache/ContentTypeCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/DataTypeCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/DeepCloneAppCache.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/DomainCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/MacroCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/MediaCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/MemberCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/MemberGroupCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Composing/OrderedCollectionBuilderBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Configuration/Models/RequestHandlerSettings.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Composing/SetCollectionBuilderBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Composing/WeightedCollectionBuilderBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/ContentApps/ContentAppFactoryCollectionBuilder.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Dashboards/DashboardCollectionBuilder.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/ContentTypeRefreshedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/ContentTypeSavedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/ContentTypeSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/DictionaryCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/DataTypeCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/ContentUnpublishingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/DictionaryItemDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/DictionaryItemSavedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/DictionaryItemSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/DomainCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/LanguageCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MacroCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaEmptiedRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaEmptyingRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaMovedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaMovedToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaMovedToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaMovingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaMovingToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTreeChangeNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTreeChangeNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTypeChangedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTypeDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTypeMovedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTypeMovingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTypeMovingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTypeRefreshedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberGroupCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberGroupDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberGroupSavedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberGroupSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeChangedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeDeletedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeMovedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeMovedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeMovingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeMovingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeRefreshedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/UriExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MovedToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MovedToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MovingToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MovingToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PartialViewDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/UriExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/IO/PhysicalFileSystem.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/IO/PhysicalFileSystem.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/IO/ShadowWrapper.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Logging/DisposableTimer.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Install/InstallSteps/UpgradeStep.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Mapping/MapDefinitionCollectionBuilder.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Media/EmbedProviders/EmbedProvidersCollectionBuilder.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PartialViewSavedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Models/ContentEditing/ContentVariationDisplay.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PartialViewSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessEntryDeletedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessEntryDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessEntryDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessEntrySavedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessEntrySavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessEntrySavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/RelationTypeCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/RelationTypeDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/RelationTypeSavedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/RelationTypeSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/StatefulNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/StylesheetDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/StylesheetSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Models/DeepCloneHelper.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Models/File.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Models/PropertyGroupExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Models/PropertyGroupExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Fix based on review
* Fix after merge
Signed-off-by: Zeegaan <nge@umbraco.dk >
Co-authored-by: Nikolaj Geisle <niko737@edu.ucl.dk >
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
Co-authored-by: Zeegaan <nge@umbraco.dk >
2022-06-07 15:28:38 +02:00
Andy Butland
96d33201aa
Few more NRT tweaks ( #12323 )
...
* Amended GetAll() on IDataTypeService to return an empty collection rather than null.
* Added a ClearSessionValue method to ISessionManager (given you can no longer set a value to null).
* Allow for null values in a StatefulNotification.
* Removed obsoletion of synchronous messages on TreeControllerBase.
* Fixed further CS8620 warnings in core project.
* Further fix to nullable warning.
* Aligned nullablility of retreiving tree nodes and menus, synchronously or asynchronously (such that we no longer can get null values, always empty collection objects).
2022-05-01 08:18:09 +02:00
Nikolaj Geisle
f23b57db65
V10: fix more nullable references ( #12321 )
...
* Add Nullable and WarningsAsErrors to Build.props
* Remove Nullable from cs proj, add ImplicitUsings to build.props
* Fix errors in core
* Fix in JsonSchema
* Fix infrastructure
* Add non-ambiguous using
* Fix Web/Lucene
* Fix backoffice
* Fix up new build errors from merge
Co-authored-by: Nikolaj Geisle <niko737@edu.ucl.dk >
2022-04-29 15:02:36 +02:00
Paul Johnson
95aa143db0
v10 make migration from v9 less painful WRT IScope ( #12293 )
...
* Restore IEventDispatcher
* Fix breaking changes WRT IScopeProvider and IScope
* Update internal usage.
* Update src/Umbraco.Core/Services/UserService.cs
* Better obsolete message
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
2022-04-26 10:22:37 +01:00
Nikolaj Geisle
b52c4e50cf
Add nullability to web.common
2022-03-29 13:44:21 +02:00
Nikolaj Geisle
214bcceffc
Merge v10/dev into infrastructure
2022-03-16 14:39:28 +01:00
Nikolaj Geisle
4ebd20bb66
Merge remote-tracking branch 'origin/v10/dev' into v10/feature/nullable-reference-types-in-Umbraco-Core
...
# Conflicts:
# build/build.ps1
# src/Umbraco.Core/Configuration/ConfigConnectionString.cs
# src/Umbraco.Core/Configuration/Models/ConnectionStrings.cs
# src/Umbraco.Core/Install/InstallSteps/TelemetryIdentifierStep.cs
# src/Umbraco.Core/Models/ContentType.cs
# src/Umbraco.Infrastructure/Migrations/Install/DatabaseBuilder.cs
# tests/Umbraco.Tests.AcceptanceTest/package.json
2022-03-16 13:00:38 +01:00
Bjarke Berg
981e66a673
Merge remote-tracking branch 'origin/v9/dev' into v10/dev
...
# Conflicts:
# src/Umbraco.Core/Telemetry/TelemetryService.cs
# src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.CoreServices.cs
# src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.Services.cs
# src/Umbraco.Infrastructure/HostedServices/ScheduledPublishing.cs
# src/Umbraco.Infrastructure/Migrations/Upgrade/UmbracoPlan.cs
# src/Umbraco.Infrastructure/Runtime/SqlMainDomLock.cs
# src/Umbraco.Web.BackOffice/Controllers/ContentController.cs
# src/Umbraco.Web.BackOffice/Controllers/DashboardController.cs
# tests/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/HostedServices/ScheduledPublishingTests.cs
2022-03-10 14:36:30 +01:00
Elitsa Marinovska
d9d5dc5626
Item tracking improvements ( #11919 )
...
* Adding TrackedReferencesController
* Adding/changing views
* Adding/Editing js files
* RelationService changes
* RelationRepository changes
* Adding missing translations
* Adding/Modifying tests
* Beginning of #9125 migration
* Introducing a new component + refactoring based on that
* Abstracting + refactoring
* Work on content unpublishing
* Work on media.delete
* Various small changes
* Beginning of #9119 migration
* Changes on content.delete
* Various fixes
* Adding new keys used in the listview bulk actions
* Adding methods to get the items used in relations from array of ids
* Adding the checkLinkedItems function to the trackedReferencesResource
* Passing the selected items from a listview to unpublish and delete
* Adding umb-tracked-references-listview
* Adding umb-tracked-references-listview-table with language column
* Fixes for tracked references
* Changes in listview unpublish dialog
* Changes in listview delete dialog
* Removing Variants logic as it is not currently supported
* Visual fixes
* Closing dialogs on click
* Fix wording
* Fix breaking changes
* Change to a single title "Items in use" instead of 2 different for Content and Media
* No need for obsoleting because we can change new controllers
* Return ActionResult from actions
* V9: Prevent delete or unpublish of items that have references (#12047 )
* Introducing config settings that prevent delete or unpublish of items referenced by other items
* Disable deletion of content items and show a new warning
* Disable deletion of media items and show a new warning
* Disable deletion of list view items
* Disable unpublish and bulk unpublish
* Add a new warning
* V9: Displaying descendants in use as part of item tracking (#12039 )
* Replace HasReferencesInDescendants with GetPagedDescendantsInReferences
* Display descendants in use on parent's info tab
* Add getPagedDescendantsInReferences to trackedReferencesResource
* Add lang keys for Descendants in use
* Refactoring controller actions
* Don't call check descendants usage when it is a new item
* rename busfy to busy
* always show references
* rearrange for scrollbar to appear at the edge of the dialog
* use the word referenced instead of used
* change fallback texts
* Added "IsDependency" to relation types
* refactor of umb-tracked-references
* rename checkLinkedItems to getPagedReferencedItems
* rename check to load, to be consistent with the rest.
* Refactored backend . Needs frontend fixes
* Cleanup
* Use filters
* Front-end refactor to match refactored end-points
* Fixed bug + warning
* Fixed query (more then 2100 descensdants) and optimized it (using nested select instead of inner join).
* remove comment
* hideNoneDependencies including varying text for the configuration
* Hack for SqlCE :(
* some final adjustments for item tracking ui
* Unbreak change
Co-authored-by: Niels Lyngsø <niels.lyngso@gmail.com >
Co-authored-by: Bjarke Berg <mail@bergmania.dk >
2022-03-07 22:46:16 +01:00
Nikolaj Geisle
d1cf640f2a
more build errors in Core
2022-02-27 21:20:50 +01:00
Nikolaj Geisle
6be2cd45db
Use nullability on the rest of core
2022-02-16 16:03:53 +01:00
Nikolaj Geisle
224341a533
Merge remote-tracking branch 'origin/v10/dev' into v10/feature/nullable-reference-types-in-Umbraco-Core
...
# Conflicts:
# src/Umbraco.Core/Configuration/Models/SecuritySettings.cs
# src/Umbraco.Core/Events/DeleteEventArgs.cs
# src/Umbraco.Core/Events/IEventDispatcher.cs
# src/Umbraco.Core/Events/PassThroughEventDispatcher.cs
# src/Umbraco.Core/Events/QueuingEventDispatcherBase.cs
# src/Umbraco.Core/IO/MediaFileManager.cs
# src/Umbraco.Core/Models/Mapping/MemberTabsAndPropertiesMapper.cs
# src/Umbraco.Core/PropertyEditors/DataValueEditor.cs
# src/Umbraco.Core/Routing/DefaultUrlProvider.cs
2022-02-15 09:29:58 +01:00
Nikolaj Geisle
b75eae01f3
Add nullability to core project
2022-02-09 13:24:35 +01:00
Bjarke Berg
ae6920a4a2
Merge remote-tracking branch 'origin/v10/dev' into v10/feature/scope-provider-cleanup
...
# Conflicts:
# src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.Repositories.cs
# src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.Services.cs
2022-01-23 14:16:44 +01:00
Nikolaj Geisle
936dd38c55
Make lots of models nullable
2022-01-21 11:43:58 +01:00
Paul Johnson
235918ecfc
Merge branch 'v9/dev' into v10/feature/merge-v9-dev
...
# Conflicts:
# build/templates/UmbracoPackage/.template.config/template.json
# build/templates/UmbracoProject/.template.config/template.json
# src/Directory.Build.props
# src/Umbraco.Core/Actions/ActionAssignDomain.cs
# src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.Services.cs
# src/Umbraco.Web.BackOffice/Controllers/AuthenticationController.cs
# src/Umbraco.Web.BackOffice/DependencyInjection/UmbracoBuilderExtensions.cs
# src/Umbraco.Web.Common/Extensions/ApplicationBuilderExtensions.cs
2022-01-18 11:37:43 +00:00
Paul Johnson
71ce038330
Scope no longer uses MediaFileManager.
...
Deleting media via services results in a published MediaDeletedNotification
via scope.Notifications, these are fired on Scope.Complete() and picked up
by the registered handlers.
2022-01-13 09:24:30 +00:00
Nikolaj Geisle
b6d5465b49
Fix up to Macros in Core project
2022-01-13 09:27:37 +01:00
Paul Johnson
ae2ff856fb
Remove IEventDispatcher, it's no longer used.
2022-01-11 17:02:20 +00:00
Paul Johnson
a952d17e74
Make using scoped services in notification handlers less painful. ( #11733 )
...
* Add failing test to demo issue with handlers + scoped dependencies.
* Make using scoped services in notification handlers less painful.
* Update comments for accuracy.
2022-01-10 15:31:46 +00:00
Bjarke Berg
2ec92057c5
Started using nullable reference types..
2021-12-16 13:44:20 +01:00
Nikolaj Geisle
ba463cddc1
Updated classes according to review
2021-10-01 14:31:59 +02:00
Nikolaj Geisle
eb01984763
Created TestOptionsMonitor.cs and updated tests to use this new class
2021-09-23 11:49:47 +02:00
Shannon
8ff78fb1de
Fixes email handler detection
2021-09-08 11:19:52 -06:00
Shannon
2fc0fc6850
Removes CannotSuppressNotificationAttribute
2021-07-14 11:56:30 -06:00
Shannon Deminick
1fc4bf6dcd
Update src/Umbraco.Core/Events/IScopedNotificationPublisher.cs
...
Co-authored-by: Andy Butland <abutland73@gmail.com >
2021-07-14 01:19:06 +10:00
Shannon
dcae692407
Fix typo, adds [CannotSuppressNotification]
2021-07-12 11:54:38 -06:00
Shannon
113b6598ed
removes raiseEvent params
2021-07-12 09:46:56 -06:00
Bjarke Berg
23293b77f6
Merge remote-tracking branch 'origin/v8/dev' into v9/feature/merge-v8-05072021
...
# Conflicts:
# build/NuSpecs/UmbracoCms.Web.nuspec
# src/SolutionInfo.cs
# src/Umbraco.Core/Compose/RelateOnTrashComponent.cs
# src/Umbraco.Core/Composing/Current.cs
# src/Umbraco.Core/Constants-AppSettings.cs
# src/Umbraco.Core/Constants-SqlTemplates.cs
# src/Umbraco.Core/Dashboards/ContentDashboardSettings.cs
# src/Umbraco.Core/Dashboards/IContentDashboardSettings.cs
# src/Umbraco.Core/Extensions/PublishedPropertyExtension.cs
# src/Umbraco.Core/HealthChecks/Checks/Services/SmtpCheck.cs
# src/Umbraco.Core/Models/IReadOnlyContentBase.cs
# src/Umbraco.Core/Models/Mapping/MemberTabsAndPropertiesMapper.cs
# src/Umbraco.Core/Models/Mapping/UserMapDefinition.cs
# src/Umbraco.Core/Models/ReadOnlyContentBaseAdapter.cs
# src/Umbraco.Core/Persistence/NPocoDatabaseExtensions-Bulk.cs
# src/Umbraco.Core/PropertyEditors/IPropertyCacheCompression.cs
# src/Umbraco.Core/PropertyEditors/IPropertyCacheCompressionOptions.cs
# src/Umbraco.Core/PropertyEditors/MediaPicker3Configuration.cs
# src/Umbraco.Core/PropertyEditors/NoopPropertyCacheCompressionOptions.cs
# src/Umbraco.Core/PropertyEditors/PropertyCacheCompression.cs
# src/Umbraco.Core/Routing/UrlProviderExtensions.cs
# src/Umbraco.Core/Runtime/CoreRuntime.cs
# src/Umbraco.Core/Services/ILocalizedTextService.cs
# src/Umbraco.Core/Services/LocalizedTextServiceExtensions.cs
# src/Umbraco.Examine.Lucene/BackOfficeExamineSearcher.cs
# src/Umbraco.Examine/UmbracoContentIndex.cs
# src/Umbraco.Infrastructure/Examine/GenericIndexDiagnostics.cs
# src/Umbraco.Infrastructure/IPublishedContentQuery.cs
# src/Umbraco.Infrastructure/Migrations/Upgrade/UmbracoPlan.cs
# src/Umbraco.Infrastructure/Models/MediaWithCrops.cs
# src/Umbraco.Infrastructure/Persistence/NPocoDatabaseExtensions.cs
# src/Umbraco.Infrastructure/Persistence/UmbracoDatabase.cs
# src/Umbraco.Infrastructure/PropertyEditors/ImageCropperConfiguration.cs
# src/Umbraco.Infrastructure/PropertyEditors/MediaPicker3PropertyEditor.cs
# src/Umbraco.Infrastructure/PropertyEditors/NestedContentPropertyEditor.cs
# src/Umbraco.Infrastructure/PropertyEditors/UploadFileTypeValidator.cs
# src/Umbraco.Infrastructure/PropertyEditors/ValueConverters/ImageCropperValue.cs
# src/Umbraco.Infrastructure/PropertyEditors/ValueConverters/MediaPickerWithCropsValueConverter.cs
# src/Umbraco.Infrastructure/PublishedContentQuery.cs
# src/Umbraco.Infrastructure/Search/UmbracoTreeSearcherFields.cs
# src/Umbraco.Infrastructure/Services/Implement/LocalizedTextService.cs
# src/Umbraco.Persistence.SqlCe/SqlCeSyntaxProvider.cs
# src/Umbraco.PublishedCache.NuCache/DataSource/BTree.DictionaryOfPropertyDataSerializer.cs
# src/Umbraco.PublishedCache.NuCache/DataSource/BTree.cs
# src/Umbraco.PublishedCache.NuCache/DataSource/ContentData.cs
# src/Umbraco.PublishedCache.NuCache/DataSource/ContentSourceDto.cs
# src/Umbraco.PublishedCache.NuCache/DataSource/PropertyData.cs
# src/Umbraco.Tests.Integration/Umbraco.Infrastructure/Services/ContentTypeServiceVariantsTests.cs
# src/Umbraco.Tests.UnitTests/Umbraco.Web.Common/ImageCropperTest.cs
# src/Umbraco.Tests/App.config
# src/Umbraco.Tests/Models/Mapping/ContentWebModelMappingTests.cs
# src/Umbraco.Tests/PublishedContent/NuCacheChildrenTests.cs
# src/Umbraco.Tests/PublishedContent/NuCacheTests.cs
# src/Umbraco.Tests/Scoping/ScopedNuCacheTests.cs
# src/Umbraco.Web.BackOffice/Controllers/CodeFileController.cs
# src/Umbraco.Web.BackOffice/Controllers/ContentController.cs
# src/Umbraco.Web.BackOffice/Controllers/ContentTypeControllerBase.cs
# src/Umbraco.Web.BackOffice/Controllers/DashboardController.cs
# src/Umbraco.Web.BackOffice/Controllers/DataTypeController.cs
# src/Umbraco.Web.BackOffice/Controllers/MediaController.cs
# src/Umbraco.Web.BackOffice/Controllers/PackageInstallController.cs
# src/Umbraco.Web.BackOffice/Controllers/TemplateQueryController.cs
# src/Umbraco.Web.BackOffice/Mapping/ContentMapDefinition.cs
# src/Umbraco.Web.BackOffice/Trees/ContentTreeControllerBase.cs
# src/Umbraco.Web.BackOffice/Trees/DataTypeTreeController.cs
# src/Umbraco.Web.BackOffice/Trees/MediaTypeTreeController.cs
# src/Umbraco.Web.Common/Extensions/FriendlyImageCropperTemplateExtensions.cs
# src/Umbraco.Web.Common/Extensions/ImageCropperTemplateCoreExtensions.cs
# src/Umbraco.Web.Common/Macros/MacroRenderer.cs
# src/Umbraco.Web.UI.NetCore/umbraco/config/lang/da.xml
# src/Umbraco.Web.UI/Umbraco/config/lang/it.xml
# src/Umbraco.Web.UI/web.Template.Debug.config
# src/Umbraco.Web.UI/web.Template.config
# src/Umbraco.Web/Compose/NotificationsComponent.cs
# src/Umbraco.Web/Composing/ModuleInjector.cs
# src/Umbraco.Web/Editors/AuthenticationController.cs
# src/Umbraco.Web/Editors/BackOfficeController.cs
# src/Umbraco.Web/Editors/ContentTypeController.cs
# src/Umbraco.Web/Editors/CurrentUserController.cs
# src/Umbraco.Web/Editors/DictionaryController.cs
# src/Umbraco.Web/Editors/MediaTypeController.cs
# src/Umbraco.Web/Editors/MemberController.cs
# src/Umbraco.Web/Editors/MemberGroupController.cs
# src/Umbraco.Web/Editors/MemberTypeController.cs
# src/Umbraco.Web/Editors/NuCacheStatusController.cs
# src/Umbraco.Web/Editors/UserGroupsController.cs
# src/Umbraco.Web/Editors/UsersController.cs
# src/Umbraco.Web/HealthCheck/Checks/Config/AbstractConfigCheck.cs
# src/Umbraco.Web/HealthCheck/Checks/Config/CompilationDebugCheck.cs
# src/Umbraco.Web/HealthCheck/Checks/Config/ConfigurationService.cs
# src/Umbraco.Web/HealthCheck/Checks/Config/CustomErrorsCheck.cs
# src/Umbraco.Web/HealthCheck/Checks/Config/MacroErrorsCheck.cs
# src/Umbraco.Web/HealthCheck/Checks/Config/NotificationEmailCheck.cs
# src/Umbraco.Web/HealthCheck/Checks/Config/TraceCheck.cs
# src/Umbraco.Web/HealthCheck/Checks/Config/TrySkipIisCustomErrorsCheck.cs
# src/Umbraco.Web/HealthCheck/Checks/Permissions/FolderAndFilePermissionsCheck.cs
# src/Umbraco.Web/HealthCheck/Checks/Security/BaseHttpHeaderCheck.cs
# src/Umbraco.Web/HealthCheck/Checks/Security/ExcessiveHeadersCheck.cs
# src/Umbraco.Web/HealthCheck/Checks/Security/HttpsCheck.cs
# src/Umbraco.Web/HealthCheck/NotificationMethods/EmailNotificationMethod.cs
# src/Umbraco.Web/Models/Trees/MenuItemList.cs
# src/Umbraco.Web/PublishedCache/NuCache/DataSource/ContentCacheDataModel.cs
# src/Umbraco.Web/PublishedCache/NuCache/DataSource/DatabaseDataSource.cs
# src/Umbraco.Web/PublishedCache/NuCache/DataSource/SerializerBase.cs
# src/Umbraco.Web/PublishedCache/NuCache/NuCacheComposer.cs
# src/Umbraco.Web/Runtime/WebRuntime.cs
# src/Umbraco.Web/Search/ExamineComponent.cs
# src/Umbraco.Web/Trees/ApplicationTreeController.cs
# src/Umbraco.Web/Trees/MemberTreeController.cs
# src/Umbraco.Web/UrlHelperRenderExtensions.cs
2021-07-05 20:58:04 +02:00
