Commit Graph

2976 Commits

Author SHA1 Message Date
Philippe Guilmette
19a6184502 Delete entries from umbracoUserLogin before deleting the user (fix for 10269) 2021-08-06 16:14:32 +02:00
Sebastiaan Janssen
210d155afd Merge branch 'v8/dev' into v8/contrib 2021-08-06 14:10:23 +02:00
Sebastiaan Janssen
e6cff8c7f5 Merge branch 'v8/8.15' into v8/dev 2021-08-06 14:08:20 +02:00
nzdev
6f8749bc52 Automatically intern contentType Alias and propertyType Alias when querying the database to save on memory and speed up comparisons. 2021-08-06 13:00:28 +02:00
Bjarne Fyrstenborg
9f3eddf95f Refactor NPoco queries to use constants and dtos (#10654) 2021-08-06 11:32:16 +02:00
Warren Buckley
4df4b3eeaf Merge pull request #10603 from umbraco/v8/bugfix/creating-document-types-sqlce
Fix duplicate ID when creating document types with SQL CE
2021-07-21 12:11:22 +01:00
Shannon
93f5dd7631 Changes bulk copy timeout to be infinite. Changes bulk copy to not allocate an arbitrary array. 2021-07-09 13:35:43 -06:00
Shannon
7dc03256ed Fixes SQLCE migration for nucache table. 2021-07-09 12:05:19 -06:00
Mole
9b32c83182 Update PropertyTypeGroupDto IdentitySeed to no longer collide with new media types 2021-07-06 13:03:44 +02:00
Shannon
060e78f8e1 Merge remote-tracking branch 'origin/v8/contrib' into v8/feature/nucache-perf 2021-06-21 10:15:09 -06:00
inetzo
1e37410578 Convert date to datetime
Datetime values where always converted to date(102) so sorting by time does not work.
By converting to 120 (yyyy-mm-dd hh:mi:ss (24h)) the time is respected.
2021-06-07 15:38:45 +02:00
Shannon
2739e049a6 Merge remote-tracking branch 'origin/v8/contrib' into v8/feature/nucache-perf
# Conflicts:
#	src/Umbraco.TestData/LoadTestComposer.cs
2021-05-17 11:56:11 -07:00
Mole
d8d4be9e8e Backport cache key fix and optimizations (#10199)
* Add GetKey<T, TId>

* Update Usages of GetKey and remove GetKey<T>(object)

We shouldn't have to retain this since RepositoryCacheKeys is internal.

* Apply changes to DefaultRepositoryCachePolicy

* Add check for default/less than -1 on UserRepository PerformGet

Co-authored-by: Nikolaj <nel@umbraco.dk>
2021-05-03 10:22:42 +02:00
Niels Lyngsø
1a5b88525b Media Picker v3 (#9461)
* set input file accept

* Use PreValue file extensions for limiting the files to be chosen in file input

* Current state for Warren to review

* This should fix up what you need Niels

* update csproj

* use empty string if fileExtensions is undefined

* public interface

* initial work

* local crops

* translations

* translation correction

* fix misspeling

* some progress

* filter media picker

* align media card grid items correctly

* responsive media cropper

* always be able to scale 3 times smallest scale

* making image cropper property editor responsive

* scroll to scale

* adjust slider look

* rearrange parts of mediaentryeditor

* test helper

* styling

* move controls inside umb-image-crop

* seperate umg-cropper-gravity styling

* corrected layout

* more ui refinement

* keep the idea of mandatory out for now.

* remove double ;

* removed testing code

* JSON Property Value Convertor now has an array of property editors to exclude

* Property Value Convertor for Media Picker 3 aka Media Picker with Local Crops

* Experimenting on best approach to retrieve local crop in razor view when iterating over picked media items

* Update ValueConvertor to use ImageCropperValue as part of the model for views as alot of existing CropUrls can then use it

* Update extension methods to take an ImageCropperValue model (localCropData)

* Forgot to update CSProj for new ValueConvertor

* New GetCropUrl @Url.GetCropUrl(crop.Alias, media.LocalCrops) as oppposed to @Url.GetCropUrl(media.LocalCrops, cropAlias:crop.Alias, useCropDimensions: true)

* Remove dupe item in CSProj

* Use a contains as an opposed to Array.IndexOf

* various corrections, SingleMode based on max 1, remove double checkerBackground, enforce validation for Crops, changed error indication

* mediapicker v3

* correct version

* fixing file ext label text color

* clipboard features for MediaPicker v3

* highlight not allowed types

* highlight trashed as an error

* Media Types Video, Sound, Document and Vector Image

* Rename to Audio and VectorGraphics

* Add (SVG) in the name for Vector Graphics

* adding CSV to Documents

* remove this commented code.

* remove this commented code

* number range should not go below 0, at-least as default until we make that configurable.

* use min not ng-min

* description for local crops

* Error/Limits highlighting reactive

* visual adjustments

* Enabling opening filtered folders + corrected select hover states

* Varous fixes to resolve issues with unit tests.

* Refactor MediaType Documents to only contain Article file type

* mark as build-in

* predefined MediaPicker3 DataTypes, renaming v2 to "old"

* set scale bar current value after min and max has been set

* added missing }

* update when focal point is dragged

* adjusted styling for Image Cropper property editor

* correcting comment

* remove todo - message for trashed media items works

* Changed parameter ordering

* Introduced new extension method on MediaWithCrops to get croppings urls in with full path

* Reintroducing Single Item Mode

* use Multiple instead of SingleMode

* renaming and adding multiple to preconfigured datatypes

* Change existing media picker to use the Clipboard type MEDIA, enabling shared functionality.

* clean up unused clipboard parts

* adjusted to new amount

* correcting test

* Fix unit test

* Move MediaWithCrops to separate file and move to Core.Models

* parseContentForPaste

* clean up

* ensure crops is an array.

* actively enable focal points, so we dont set focal points that aren't used.

* only accept files that matches file extensions from Umbraco Settings

* Cleanup

* Add references from MediaPicker3 to media

* corrections from various feedback

* remove comment

* correct wording

* use windowResizeListener

Co-authored-by: Warren Buckley <warren@umbraco.com>
Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
Co-authored-by: Andy Butland <abutland73@gmail.com>
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
Co-authored-by: Sebastiaan Janssen <sebastiaan@umbraco.com>
Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
2021-04-22 10:28:53 +02:00
Chad
98d8971ce9 Merge in v8/contrib to V8/feature/nucache perf sync (#10151)
* Bump version to 8.6.8

* Initial rework of Lock dictionaries

* [Issue 5277-146] accessibility - Close 'X' icon next to language drop… (#9264)

* [Issue 5277-146] accessibility - Close 'X' icon next to language drop down is identified as "link" - screen reader

* add new loacalization key

* Fix issue with SqlMainDomLock that cannot use implicit lock timeouts … (#9973)

* Fix issue with SqlMainDomLock that cannot use implicit lock timeouts … (#9973)

(cherry picked from commit da5351dfcf)

* Adjust unit tests and apply fixes to scope

* Add more unit tests, showing current issue

* Counting Umbraco.ModelsBuilder and ModelsBuilder.Umbraco namespaces as external providers

* Fix dead lock with TypeLoader

* Fix errors shown in unit tests

* Throw error if all scopes hasn't been disposed

* Clean

* Fixes and Updates for DB Scope and Ambient Context leaks (#9953)

* Adds some scope tests (ported back from netcore) and provides a much better error message, ensure execution context is not flowed to child tasks that shouldn't leak any current ambient context

* updates comment

* Ensure SqlMainDomLock suppresses execution context too

* Since we're awaiting a task in a library method, ConfigureAwait(false)

* missing null check

Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>

* Adds additional error checking and reporting to MainDom/SqlMainDomLock (#9954)

Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>

* Add copy logic to Media Picker (#9957)

* Add copy logic to Media Picker

* Add action for copy all

* Fix for selectable media item

* Wrap calls to map in scopes

* Autocomplete scopes

* Remove unnecessary aria-hidden attribute from <umb-icon>

* Remove scope from method that calls another method that has a scope

* Fixes #9993 - Cannot save empty image in Grid

* Clean

* Revert "The Value() method for IPublishedContent was not working with the defaultValue parameter" (#9989)

* Use a hashset to keep track of acquired locks

This simplifies disposing/checking for locks greatly.

* Add images in grid - fixes 9982 (#9987)

Co-authored-by: Sebastiaan Janssen <sebastiaan@umbraco.com>

* Only create the dicts and hashset when a lock is requested

* Clean

* Adds a config for configuring the access rules on the content dashboard - by default it granted for all user groups

* Adds additional params indicating whether user is admin

* Add images in grid - fixes 9982 (#9987)

Co-authored-by: Sebastiaan Janssen <sebastiaan@umbraco.com>
(cherry picked from commit e2019777fb)

* Bump version to 8.12.2

* #9964 Removed unneeded check for HttpContext

* Fix for #9950 - HttpsCheck will now retry using the login background image if inital request returns 301/302. Excessvie Headers check will now check the root url instead of the backoffice

* Merge pull request #9994 from umbraco/v8/bugfix/9993

Fixes #9993 - Cannot save empty image in Grid

(cherry picked from commit 0ecc933921)

* Apply suggestions from review

* Fixes #9983 - Getting kicked, if document type has a Umbraco.UserPicker property (#10002)

* Fixes #9983

Temporary fix for this issue. using the entityservice like before.

* Needed to remove the call to usersResource here as well for displaying the picked items

* Don't need usersResource for now

* Fixes #9983 - Getting kicked, if document type has a Umbraco.UserPicker property (#10002)

* Fixes #9983

Temporary fix for this issue. using the entityservice like before.

* Needed to remove the call to usersResource here as well for displaying the picked items

* Don't need usersResource for now

(cherry picked from commit 45de0a101e)

* 8539: Allow alias in image cropper (#9266)

Co-authored-by: Owain Williams <owaingdwilliams@gmail.com>

* Wrap dumping dictionaries in a method.

* Create method for generating log message

And remove forgotten comments.

* Fix swedish translation for somethingElse.

* Copy member type (#10020)

* Add copy dialog for member type

* Implement copy action for member type

* Create specific localization for content type, media type and member type

* Handle "foldersonly" querystring

* Add button type attribute

* Add a few missing changes of anchor to button element

* Null check on scope and options to ensure backward compatibility

* Improve performance, readability and handling of FollowInternalRedirects (#9889)

* Improve performance, readability and handling of FollowInternalRedirects

* Logger didn't like string param

Passing string param to _logger.Debug<PublishedRouter, int> wasn't happy. Changed to pass existing internalRedirectAsInt variable.

Co-authored-by: Nathan Woulfe <nathan@nathanw.com.au>

* Update casing of listview layout name

* 9097 add contextual password helper (#9256)

* update back-office forms

* Display tip on reset password page as well

* add directive for password tip

* integrate directove in login screen

* forgot the ng-keyup :-)

* adapt tooltip directive to potential different Members and Users password settings

* remove watcher

Co-authored-by: Nathan Woulfe <nathan@nathanw.com.au>

* Unbind listener

Listening for splitViewRequest was only unbound if the split view editor was opened. Not cleaning up the listener caused a memory leak when changing between nodes as the spit view editor was detached but not garbage-collected

* Replace icon in date picker with umb-icon component (#10040)

* Replace icon in date picker with <umb-icon> component

* Adjust height of clear button

* Update cypress and fix tests

* Listview config icons (#10036)

* Update icons to use <umb-icon> component

* Simplify markup and use disabled button

* Use move cursor style on sortable handle

* Add class for action column

* Update setting auto focus

* Increase font size of umb-panel-header-icon

* Anchor noopener (#10009)

* Set rel="noopener" for anchors with target="_blank"

* Reverted unwanted changes to Default.cshtml

* Align 'Add language' test to netcore

* Add new cypress tests

* Add indentation

* Getting rid of the config file and implementing an appSetting instead

* Implementation for IContentDashboardSettings

* Cleanup

* bool.Try

* Taking AllowContentDashboardAccessToAllUsers prop from GlobalSettings to ContentDashboardSettings and saving AccessRulesFromConfig into a backing field

* Handling multiple values per field in Examine Management

* Add Root<T> and Breadcrumbs extension methods for IPublishedContent (#9033)

* Fix usage of obsolete CreatorName and WriterName properties

* Add generic Root extension method

* Add Breadcrumbs extension methods

* Orders member type grouping of members alphabetically, matching the listing of member types.

* Revert updating deprecated WriterName/CreatorName refs

Changing the properties to use the extensions is a good thing (given the props are deprecated), but causes issues deep in tests. I'm reverting that change to fix the tests, and all refs to the deprecated properties should be updated in one sweep, to deal with any other test issues that might crop up.

* Handle Invalid format for Upgrade check

* Fixes tabbing-mode remains active after closing modal #9790 (#10074)

* Allow to pass in boolean to preventEnterSubmit directive (#8639)

* Pass in value to preventEnterSubmit directive

* Set enabled similar to preventDefault and preventEnterSubmit directives

* Update prevent enter submit value

* Init value from controller

* Use a different default input id prefix for umb-search-filter

* Fix typo

* Check for truthly value

* Revert "Set enabled similar to preventDefault and preventEnterSubmit directives"

This reverts commit 536ce855c4545ead82cea77b4013bf9010a8687b.

* None pointer events when clicking icon

* Use color variable

* Fixes tabbing-mode remains active after closing modal #9790 (#10074)

(cherry picked from commit c881fa9e7d)

* Null check on scope and options to ensure backward compatibility

(cherry picked from commit fe8cd239d2)

* Fix validation of step size in integer/numeric field

* 9962: Use $allowedEditors instead of allowed (#10086)

* 9962: Use $allowedEditors instead of allowed

* 9962: Remove redundant statement

* fixes #10021 adds ng-form and val-form-manager to the documentation

* Improved accessibility of link picker (#10099)

* Added support for screeen reader alerts on the embed so that assitive technology knows when a url retrieve has been succesfull.
Added labels for the controls
Preview reload only triggered if the values for height and width change

* Added control ids for the link picker

* Add French translation

* Accessibility: Alerts the user how many results have been returned on a tree search (#10100)

* Added support for screeen reader alerts on the embed so that assitive technology knows when a url retrieve has been succesfull.
Added labels for the controls
Preview reload only triggered if the values for height and width change

* Tree search details the number of search items returned

* Add French translations

* Updated LightInject to v6.4.0

* Remove HtmlSanitizer once more - see #9803

* Also make sure NuGet installs the correct version of the CodePages dependency

* Bump version to 8.13 RC

* Fixed copy preserving sort order (#10091)

* Revert "Updated LightInject to v6.4.0"

This reverts commit fc77252ec7.

* Revert "Add copy logic to Media Picker (#9957)"

This reverts commit f7c032af65.

* Reintroduce old constructor to make non-breaking

* Update cypress test to make macros in the grid work again

* Attributes could be multiple items, test specifically if `Directory` is an attribute

* Accessibility: Adding label fors and control ids for the macro picker (#10101)

* Added support for screeen reader alerts on the embed so that assitive technology knows when a url retrieve has been succesfull.
Added labels for the controls
Preview reload only triggered if the values for height and width change

* Added support for label fors for the macro picker and also gave the ,acro search box a title

* Now displays a count of the matching macros returned. Please note the language file amends shared with #10100

* Removed src-only class for the display of the count of messages

* Updating typo

* Removed top-margin from switcher icon

* Allow KeepAlive controller Ping method to be requested by non local requests (#10126)

* Allow KeepAlive controller Ping method to be requested by non local requests and accept head requests

* removed unused references

* fix csproj

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Sebastiaan Janssen <sebastiaan@umbraco.com>
Co-authored-by: Justin Shearer <justin.shearer@gmail.com>
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
Co-authored-by: Callum Whyte <hey@callumwhyte.com>
Co-authored-by: Shannon <sdeminick@gmail.com>
Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
Co-authored-by: patrickdemooij9 <patrickdemooij98@hotmail.com>
Co-authored-by: Bjarne Fyrstenborg <bjarne_fyrstenborg@hotmail.com>
Co-authored-by: Michael Latouche <michael@crossingpaths.be>
Co-authored-by: Nathan Woulfe <nathan@nathanw.com.au>
Co-authored-by: Markus Johansson <markus@obviuse.se>
Co-authored-by: Jeavon Leopold <jeavon@crumpled-dog.com>
Co-authored-by: Benjamin Carleski <benjamin@proworks.com>
Co-authored-by: Owain Williams <owaingdwilliams@gmail.com>
Co-authored-by: Jesper Löfgren <jesper.lofgren@sappa.se>
Co-authored-by: Martin Bentancour <mbe@umbraco.dk>
Co-authored-by: Ronald Barendse <ronald@panoramastudios.nl>
Co-authored-by: Andy Butland <abutland73@gmail.com>
Co-authored-by: BeardinaSuit <BeardInASuit@outlook.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
Co-authored-by: Rachel Breeze <RachBreeze@users.noreply.github.com>
Co-authored-by: Dave de Moel <d.demoel@wearetriple.com>
Co-authored-by: ric <60885685+ricbrady@users.noreply.github.com>
Co-authored-by: Carole Rennie Logan <crgrieve@users.noreply.github.com>
Co-authored-by: Dennis Öhman <dennis.ohman@bjornmamman.se>
2021-04-21 09:05:01 +10:00
Elitsa Marinovska
8e14543616 Merge remote-tracking branch 'origin/v8/dev' into v8/feature/AB10632-recycle-bin-smells-caching 2021-04-15 09:02:53 +02:00
Elitsa Marinovska
2534f99cdb Adding new RecycleBin event handlers 2021-04-14 16:55:37 +02:00
BeardinaSuit
e7ce6a307e Handle Invalid format for Upgrade check 2021-03-30 15:08:00 +02:00
Elitsa Marinovska
05e9710ca6 Using an atomic operation when calling GetCacheItem - a callback is specified when the item isn't found 2021-03-25 13:29:27 +01:00
Elitsa Marinovska
19c17836aa Adding recycle bin smells caches at repository level 2021-03-25 12:54:46 +01:00
Shannon
1ab73b35a4 Merge remote-tracking branch 'origin/v8/contrib' into v8/feature/nucache-perf 2021-03-12 16:50:00 +11:00
Shannon
37abae83b3 Merge remote-tracking branch 'origin/v8/dev' into v8/feature/nucache-perf
# Conflicts:
#	build/NuSpecs/UmbracoCms.Web.nuspec
#	src/Umbraco.Web/PublishedCache/NuCache/DataSource/DatabaseDataSource.cs
2021-03-12 16:32:21 +11:00
Shannon
7bb18f1cc3 Fixes the Sql server SET LOCK_TIMEOUT call which was missing a space. 2021-03-01 13:16:32 +01:00
Bjarke Berg
4e1c25363d Merge pull request #9891 from umbraco/v8/bugfix/lock-timeout-fix
Fixes the Sql server SET LOCK_TIMEOUT call which was missing a space.
2021-02-24 07:32:27 +01:00
Shannon
82545e3185 Fixes the Sql server SET LOCK_TIMEOUT call which was missing a space. 2021-02-24 16:55:00 +11:00
Chad
b8540ca128 Improve speed and reduce allocations by implementing logger overloads to avoid params [] allocation (#8917)
* Implement logger overloads to avoid params [] allocation

* Implement console logger ILogger

* Call correct signature

* Fix exceptions

* Introduce ILogger2

* fix logger reference

Co-authored-by: Nathan Woulfe <nathan@nathanw.com.au>
2021-02-22 08:22:49 +10:00
Nathan Woulfe
f167f022c1 9769 - shift index increment before tryget to allow loop to continue if current iteration exits early (#9799) 2021-02-21 12:00:22 +01:00
Sebastiaan Janssen
2c54adacf2 Add the ability to change the SQL Write Lock TimeOut (#9750)
Co-authored-by: Shannon <sdeminick@gmail.com>
2021-02-20 13:44:15 +01:00
nzdev
2a8d043445 support bulk insert for binary in sql ce. Fix column ordering in contentnudto. 2021-02-12 15:01:46 +13:00
Shannon
55a39613c1 Merge remote-tracking branch 'origin/v8/contrib' into v8/feature/nucache-perf 2021-02-11 12:38:06 +11:00
Sebastiaan Janssen
37402c5ba4 Add the ability to change the SQL Write Lock TimeOut (#9744)
* Add the ability to change the SQL Write Lock TimeOut

* Needed to add a default setting to to the settings for tests
2021-02-02 15:17:59 +00:00
Shannon
0688de7767 Merge remote-tracking branch 'origin/v8/dev' into v8/feature/nucache-perf 2021-01-28 15:00:19 +11:00
Chad
0bd4dced0b Improve performance and reduce memory use and reduce array allocations by reusing char[] (#9166)
* Reduce array allocations by reusing char[]

* don't hide .Equals()

* Reduce memory use by reducing array allocations

* Revert "Reduce memory use by reducing array allocations"

This reverts commit faf6b60234167f5443435243eb52187ab07d514c.

* reuse char[] for string.split() to avoid params [] allocation
2021-01-22 12:02:25 +10:00
Shannon
e01f8319f6 Updates the new nodedto index to include 2 cols as the key and update the includes, this is required for more optimal querying for nucache and others. 2021-01-22 01:12:26 +11:00
Shannon
4c31fd176b Merge branch 'v8/dev' into v8/feature/nucache-perf
# Conflicts:
#	src/Umbraco.Core/Constants-SqlTemplates.cs
2021-01-21 22:49:33 +11:00
Sebastiaan Janssen
a04af69181 Merge branch 'v8/8.10' into v8/8.11 2021-01-19 17:31:07 +01:00
Nik
6a8c2a0a55 [AMEND] Updated the redirect URL Repository to search for entries wit… (#9653)
Co-authored-by: Nik Rimington <nrimington@spindogs.com>
(cherry picked from commit aa5470a801)
2021-01-19 17:30:00 +01:00
Nik
aa5470a801 [AMEND] Updated the redirect URL Repository to search for entries wit… (#9653)
Co-authored-by: Nik Rimington <nrimington@spindogs.com>
2021-01-19 17:29:13 +01:00
Sebastiaan Janssen
08bba71ef0 Merge branch 'v8/8.10' into v8/8.11 2021-01-11 11:37:03 +01:00
Sebastiaan Janssen
51a6995b7f Merge branch 'v8/8.9' into v8/8.10 2021-01-11 11:36:21 +01:00
Sebastiaan Janssen
ffcc958f58 Merge branch 'v8/8.8' into v8/8.9 2021-01-11 11:35:38 +01:00
Sebastiaan Janssen
12e8dfd4c7 Merge branch 'v8/8.7' into v8/8.8 2021-01-11 11:35:13 +01:00
Sebastiaan Janssen
e249c4f68d Merge branch 'v8/8.6' into v8/8.7 2021-01-11 11:34:44 +01:00
Warren Buckley
3914be43b8 Merge pull request #9629 from umbraco/v8/bugfix/4637-variation-deleting-content
V8: Fix bug where allowing culture variation would delete content from element types #7471
(cherry picked from commit 463bc46675)
2021-01-11 11:32:11 +01:00
Warren Buckley
463bc46675 Merge pull request #9629 from umbraco/v8/bugfix/4637-variation-deleting-content
V8: Fix bug where allowing culture variation would delete content from element types #7471
2021-01-11 09:58:45 +00:00
Sebastiaan Janssen
967485f4e1 Merge branch 'v8/contrib' into v8/dev
# Conflicts:
#	src/Umbraco.Core/Runtime/SqlMainDomLock.cs
2021-01-08 15:18:03 +01:00
Mole
20868f3cfe Check composition property with oldContentTypeVariation 2021-01-08 14:58:01 +01:00
Shannon Deminick
74e7ddb45f Merge pull request #9482 from umbraco/v8/feature/unattended-install
Add support for unattended installs
2021-01-07 19:19:52 +11:00
Shannon
fce13e23e9 Fixes test, adds null checks 2021-01-07 17:51:03 +11:00
Shannon
28b9b62781 Merge remote-tracking branch 'origin/v8/dev' into v8/feature/nucache-perf
# Conflicts:
#	src/Umbraco.Core/Migrations/Upgrade/UmbracoPlan.cs
2020-12-16 15:26:57 +11:00