James Jackson-South
601270640c
Merge remote-tracking branch 'upstream/netcore/netcore' into netcore/linting
2020-11-30 21:19:32 +00:00
Bjarke Berg
fc9e0fa244
Removed old XmlConfigManipulator
...
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
2020-11-27 09:05:12 +01:00
James Jackson-South
de70b58183
Merge remote-tracking branch 'upstream/netcore/netcore' into netcore/linting
2020-11-18 23:59:53 +00:00
Benjamin Carleski
7583c1fb06
Start cleanup of IOHelper.MapPath calls
2020-11-18 07:25:11 -08:00
Bjarke Berg
e46a248832
Merge remote-tracking branch 'origin/netcore/netcore' into netcore/task/6973-migrating-authenticationcontroller-merge
...
# Conflicts:
# src/Umbraco.Infrastructure/HostedServices/ScheduledPublishing.cs
# src/Umbraco.Infrastructure/Runtime/CoreInitialComposer.cs
# src/Umbraco.Infrastructure/Scheduling/SchedulerComponent.cs
# src/Umbraco.Infrastructure/Scheduling/SchedulerComposer.cs
# src/Umbraco.Tests.Integration/Testing/UmbracoIntegrationTest.cs
# src/Umbraco.Tests/Testing/UmbracoTestBase.cs
# src/Umbraco.Web.BackOffice/Extensions/BackOfficeApplicationBuilderExtensions.cs
# src/Umbraco.Web.BackOffice/Runtime/BackOfficeComposer.cs
# src/Umbraco.Web.Common/Runtime/AspNetCoreComposer.cs
# src/Umbraco.Web.Common/UmbracoContext/UmbracoContext.cs
# src/Umbraco.Web.UI.NetCore/appsettings.json
# src/Umbraco.Web/Editors/BackOfficeController.cs
# src/Umbraco.Web/Runtime/WebInitialComponent.cs
2020-11-12 13:10:19 +01:00
Bjarke Berg
d756248c7c
Merge remote-tracking branch 'origin/netcore/dev' into netcore/task/6973-migrating-authenticationcontroller-merge
...
# Conflicts:
# src/Umbraco.Examine.Lucene/UmbracoContentIndex.cs
# src/Umbraco.Tests.Integration/Umbraco.Infrastructure/Services/MediaServiceTests.cs
# src/Umbraco.Tests/Services/MemberServiceTests.cs
# src/Umbraco.Web.BackOffice/Controllers/PreviewController.cs
# src/Umbraco.Web.BackOffice/Services/IconService.cs
# src/Umbraco.Web.UI.NetCore/umbraco/UmbracoBackOffice/Preview.cshtml
# src/Umbraco.Web.UI.NetCore/umbraco/config/lang/da.xml
# src/Umbraco.Web.UI.NetCore/umbraco/config/lang/en.xml
# src/Umbraco.Web.UI.NetCore/umbraco/config/lang/en_us.xml
# src/Umbraco.Web.UI/config/umbracoSettings.config
2020-11-12 12:57:03 +01:00
James Jackson-South
4678e00fa4
Merge remote-tracking branch 'upstream/netcore/netcore' into netcore/linting
2020-11-11 16:24:27 +00:00
Andy Butland
b4ce2873cc
NetCore: Migrated database server registrar and messenger tasks into hosted services ( #9353 )
...
* Migrated database server registrar and messenger tasks into hosted services.
Moved DatabaseServerRegistrar Options into injectable configuration.
* Added further cases for unit tests on hosted services checking execution based on runtime level.
* Migrated DatabaseServerMessengerOptions into configuration.
2020-11-10 20:02:09 +01:00
Bjarke Berg
dae6e2b8ee
Migrated RenderNoContentController + related ( #9309 )
...
* Migrated RenderNoContentController + related
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
* Fix after MSDI
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
* Update src/Umbraco.Web.UI/Umbraco.Web.UI.csproj
Co-authored-by: Elitsa Marinovska <21998037+elit0451@users.noreply.github.com >
* Removing connection string
* Fixed tests after moving endpoint registration
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
Co-authored-by: Elitsa Marinovska <elm@umbraco.dk >
Co-authored-by: Elitsa Marinovska <21998037+elit0451@users.noreply.github.com >
2020-11-03 18:55:55 +01:00
James Jackson-South
4aa85073d0
Update copyright notice based on root license
2020-11-03 17:47:16 +00:00
James Jackson-South
5321b761a5
Add stylecop linting and example fix.
2020-11-03 17:31:05 +00:00
Bjarke Berg
8e44d89856
Introducing interface for our needs of a CronTabParser. And inject it where needed
...
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
2020-11-03 09:36:56 +01:00
Bjarke Berg
2da6c8517a
Merge remote-tracking branch 'origin/netcore/netcore' into feature/amend-health-check-notifier-first-run-time-to-crontab
...
# Conflicts:
# src/Umbraco.Core/ServiceCollectionExtensions.cs
# src/Umbraco.Web.Common/Runtime/AspNetCoreComposer.cs
2020-11-03 07:09:15 +01:00
Andy Butland
a0ce44c9fc
Changed configuration of first run time for health check notifier from a time string to a cron expression.
2020-10-31 22:49:12 +01:00
Andy Butland
433fdbb047
Change LoggingSettings.MaxLogAge from integer (minutes) to a TimeSpan.
2020-10-31 14:25:40 +01:00
Andy Butland
9cb59239d1
Migrated KeepAlive recurring task to hosted service.
2020-10-30 17:19:01 +01:00
Andy Butland
bdb8f34da3
Netcore: Health check notifier hosted service ( #9295 )
...
* Implemented health check notifier as a hosted service.
Added validation to health check settings.
* Registered health check notifier as a hosted service.
Modified health check nested settings to use concrete classes to align with other configuration models.
* Resolved issues with email sending using development server.
* PR review comments and fixed failing unit test.
* Changed period and delay millisecond and hourly values to TimeSpans.
Changed configuration of first run time for health check notifications to use H:mm format.
* Set up SecureSocketOptions as a locally defined enum.
* Tightened up time format validation to verify input is an actual time (with hours and minutes only) and not a timespan.
* Aligned naming and namespace of health check configuration related classes with other configuration classes.
* Created constants for hex colors used in formatting health check results as HTML.
* Revert "Tightened up time format validation to verify input is an actual time (with hours and minutes only) and not a timespan."
This reverts commit f9bb8a7a825bcb58146879f18b47922e09453e2d.
* Renamed method to be clear validation is of a TimeSpan and not a time.
Co-authored-by: Bjarke Berg <mail@bergmania.dk >
2020-10-30 13:56:13 +01:00
Shannon
64d8b56eca
It builds!
2020-10-23 14:18:53 +11:00
Shannon
2b1dfc5888
Merge remote-tracking branch 'origin/netcore/netcore' into netcore/task/6973-migrating-authenticationcontroller
...
# Conflicts:
# src/Umbraco.Tests.Integration/Testing/UmbracoIntegrationTest.cs
# src/Umbraco.Tests/Web/Mvc/UmbracoViewPageTests.cs
# src/Umbraco.Web.BackOffice/Controllers/BackOfficeController.cs
# src/Umbraco.Web/Editors/BackOfficeController.cs
# src/Umbraco.Web/Mvc/UmbracoController.cs
2020-10-22 21:16:44 +11:00
berg
070307ea88
Ensure unit tests run on linux
...
Signed-off-by: berg <mail@bergmania.dk >
2020-10-21 21:04:10 +02:00
Emma L Garland
7a570110d0
Netcore/feature/healthcheck replaceconfiglogic ( #8934 )
...
* Started moving to JSON instead of config.
Mild refactoring but overall keeping it the same, except for injecting IConfiguration and JSON parsing instead of XML
Tests currently unaffected, need to increase coverage
* Moved to constants for appsettings keys
Moved from IConfiguration to global settings - later to be replaced with IOptions
Updated translation messages
Installed IOptions ready for new PR
Updated to new interface, IConfigurationService
* Post-merge fix
* Namespace move from Umbraco.Web to Umbraco.Core where appropriate
* Renamed abstractsettings (from abstractconfig)
Moving out of configservice into the POCO config check
* Made the IIsCustomErrors healthcheck as obsolete, as no web.config setting). Investigate reintroducing this check in the .NET Core way (UseDevelopment).
Reducing use of abstractsettings as not needed - we don't need a config service to read the config settings anymore as they're all explicit POCOs.
Consolidated health-checks in project.
* Removed test views that weren't meant to be added
* Returned to use of abstractsettings with different use
* Moved more health checks into correct folder/namespace, and enum into their own file
* Correct namespace
* Git history/compare lost due to file move, temporarily moving back to original folder. Will do another PR to move after this
* Use existing GetStatus in abstract check for Debug mode
* Updating to return to previous logic and putting files back into line
* Macro errors returned to previous logic
* Reuse abstractsettings class
* Swapped order to assist with reviewing PR
* Updated to include itempath
* Not implemented comment to avoid confusion
Implemented NotificationEmailCheck
* Changed to IOptionsMonitor as per PR comments. Removed configurationservice as we need to rethink the fixing strategy. Updated logger.
Needs to show fix message instead of fixing. Temporary fix for IIS version
* Switched to IOptionsMonitor for all
* No longer attempts to actually fix header in config. Still need to show suggestions.
Co-authored-by: Elitsa Marinovska <elm@umbraco.dk >
2020-10-21 11:29:25 +02:00
Shannon
d1b35deb43
Migrates remaining backofficecontroller but still a bunch of work to do , streamlines Backoffice to BackOffice (but is that what we want?)
2020-10-21 16:51:00 +11:00
Shannon
779214f9d3
preserve function names and update smidge
2020-10-16 15:23:02 +11:00
Bjarke Berg
35443f0e71
Merge remote-tracking branch 'origin/netcore/netcore' into netcore/feature/migrate-logging
...
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
# Conflicts:
# src/Umbraco.Infrastructure/Search/ExamineComponent.cs
# src/Umbraco.Tests/Persistence/Repositories/UserRepositoryTest.cs
2020-09-24 08:24:35 +02:00
Bjarke Berg
435cf2623a
Updated ImageSharp.Web to 1.0.0
...
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
2020-09-23 14:00:08 +02:00
Mole
8258178c5a
Merge remote-tracking branch 'origin/netcore/netcore' into netcore/feature/migrate-logging
...
# Conflicts:
# src/Umbraco.Infrastructure/Media/UploadAutoFillProperties.cs
# src/Umbraco.Infrastructure/PropertyEditors/FileUploadPropertyEditor.cs
# src/Umbraco.Infrastructure/PropertyEditors/ImageCropperPropertyEditor.cs
# src/Umbraco.Tests/Models/MediaXmlTest.cs
# src/Umbraco.Tests/Routing/MediaUrlProviderTests.cs
# src/Umbraco.Web.BackOffice/Controllers/BackOfficeController.cs
# src/Umbraco.Web.BackOffice/Controllers/MediaController.cs
2020-09-23 13:32:49 +02:00
Bjarke Berg
f413f279eb
Merge remote-tracking branch 'origin/netcore/netcore' into netcore/feature/migrate-logging
...
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
# Conflicts:
# src/Umbraco.ModelsBuilder.Embedded/LiveModelsProvider.cs
# src/Umbraco.ModelsBuilder.Embedded/PureLiveModelFactory.cs
# src/Umbraco.Tests.Integration/Implementations/TestHelper.cs
# src/Umbraco.Tests.Integration/Persistence/Repositories/TemplateRepositoryTest.cs
# src/Umbraco.Tests.Integration/RuntimeTests.cs
# src/Umbraco.Tests.UnitTests/Umbraco.Core/PropertyEditors/ColorListValidatorTest.cs
# src/Umbraco.Tests.UnitTests/Umbraco.Core/PropertyEditors/EnsureUniqueValuesValidatorTest.cs
# src/Umbraco.Tests.UnitTests/Umbraco.Core/PropertyEditors/MultiValuePropertyEditorTests.cs
# src/Umbraco.Tests.UnitTests/Umbraco.Core/Published/NestedContentTests.cs
# src/Umbraco.Tests.UnitTests/Umbraco.Core/Published/PropertyCacheLevelTests.cs
# src/Umbraco.Tests/Components/ComponentTests.cs
# src/Umbraco.Tests/IO/ShadowFileSystemTests.cs
# src/Umbraco.Tests/Models/VariationTests.cs
# src/Umbraco.Tests/Packaging/PackageDataInstallationTests.cs
# src/Umbraco.Tests/Persistence/DatabaseContextTests.cs
# src/Umbraco.Tests/Persistence/Repositories/MediaRepositoryTest.cs
# src/Umbraco.Tests/Persistence/Repositories/MediaTypeRepositoryTest.cs
# src/Umbraco.Tests/Persistence/Repositories/MemberRepositoryTest.cs
# src/Umbraco.Tests/Persistence/Repositories/MemberTypeRepositoryTest.cs
# src/Umbraco.Tests/Persistence/Repositories/PublicAccessRepositoryTest.cs
# src/Umbraco.Tests/Persistence/Repositories/TagRepositoryTest.cs
# src/Umbraco.Tests/Persistence/Repositories/UserRepositoryTest.cs
# src/Umbraco.Tests/Persistence/SqlCeTableByTableTest.cs
# src/Umbraco.Tests/Published/ConvertersTests.cs
# src/Umbraco.Tests/PublishedContent/SolidPublishedSnapshot.cs
# src/Umbraco.Tests/Routing/ContentFinderByIdTests.cs
# src/Umbraco.Tests/Routing/ContentFinderByUrlAndTemplateTests.cs
# src/Umbraco.Tests/Routing/DomainsAndCulturesTests.cs
# src/Umbraco.Tests/Routing/UmbracoModuleTests.cs
# src/Umbraco.Tests/Scoping/ScopeEventDispatcherTests.cs
# src/Umbraco.Tests/Scoping/ScopedNuCacheTests.cs
# src/Umbraco.Tests/Services/ContentServicePerformanceTest.cs
# src/Umbraco.Tests/Services/ContentTypeServiceVariantsTests.cs
2020-09-23 07:59:10 +02:00
Bjarke Berg
2b8d5b7edd
Merge remote-tracking branch 'origin/netcore/netcore' into feature/8651-move-image-file-types-from-config
...
# Conflicts:
# src/Umbraco.Core/Configuration/Models/ContentImagingSettings.cs
# src/Umbraco.Infrastructure/Media/UploadAutoFillProperties.cs
2020-09-22 21:10:19 +02:00
Andy Butland
f42e8856db
Removed supported image file types from configuration and set up as a property on IImageUrlGenerator, so different providers can indicate support for different sets of images.
2020-09-22 15:06:22 +02:00
Andy Butland
fe158ec7d9
Removed custom validation of configuration enum values, reverting to framework based validation when binding direct to the enum values.
2020-09-21 21:20:46 +02:00
Andy Butland
574e4d6446
Reverted change to enum parse from string configuration value, as we can't avoid the property being evaluated before the validation has occurred.
2020-09-21 16:23:58 +02:00
Andy Butland
1a59d6a978
Created constants for all configuration sections and used this and nameof expressions for building up configuration validation error messages.
2020-09-21 16:23:12 +02:00
Mole
d3ae921293
Remove most of the last references and rename LoggerFactory_ to LoggerFactory in UmbracoTestBase
2020-09-21 13:04:57 +02:00
Andy Butland
cce091de74
Throw exception on unexpected failure of creation on enum value from configuration, rather than falling back to a default.
...
This shouldn't happen in practice due to the configuration validation (e.g. by ContentSettingsValidator), so any failure of parsing here should be considered an exception.
2020-09-21 12:04:30 +02:00
Andy Butland
e032af5b06
Fixed failing tests.
2020-09-21 10:04:34 +02:00
Mole
894abdd183
Remove a bunch of references to the old logger
2020-09-21 09:41:18 +02:00
Andy Butland
903e964925
Set default value for SmtpSettings DeliveryMethod configuration.
2020-09-21 08:54:03 +02:00
Andy Butland
d55b54ce49
Added unit tests for introduced unit test configuration setting builders.
2020-09-21 08:54:03 +02:00
Andy Butland
8aadbe02d6
Added unit tests for configuration validators.
2020-09-21 08:54:03 +02:00
Andy Butland
bae4f2fb53
Changed NuCache settings to use a nullable integer.
2020-09-21 08:54:03 +02:00
Andy Butland
b9e67dde55
Added configuration validation for models builder and hosting settings.
...
Renamed models builder config class suffix to match others.
2020-09-18 12:53:10 +02:00
Mole
d61b9f54fa
Merge options
2020-09-18 12:53:06 +02:00
Andy Butland
eb62789b68
Added configuration validation for content imaging settings.
2020-09-18 12:02:12 +02:00
Andy Butland
1f8d7f18be
Added configuration validation for content and request handler settings.
2020-09-18 11:30:26 +02:00
Nikolaj
dda6fb12a3
Remove LogError<T> from LoggerExtensions
2020-09-16 09:40:49 +02:00
Bjarke Berg
b7a48686f0
Updates based on review feedback
2020-09-15 13:18:01 +02:00
Bjarke Berg
5836ca3da4
Bugfix - Imagesharp cache folder is not relative to root but to the wwwroot. "~" is not replaced with root
2020-09-15 10:27:23 +02:00
Bjarke Berg
b4353585c3
Simplifyed the ConnectionStrings config
2020-09-15 09:11:36 +02:00
Nikolaj
02828db8fd
Add work on PublishedSnapshotService
2020-09-15 08:45:40 +02:00
Bjarke Berg
4a4b57ef87
bugfixes related to no umbraco connection string
...
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
2020-09-14 21:53:56 +02:00