Bjarke Berg
348f69734b
Revert "FIxes more of the auth procedure"
...
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
2020-11-27 13:15:54 +01:00
Bjarke Berg
ab924e0c7d
Merge remote-tracking branch 'origin/netcore/netcore' into netcore/feature/linux-paths
2020-11-27 09:42:57 +01:00
Shannon
ec6ac41e56
FIxes more of the auth procedure
2020-11-27 15:58:00 +11:00
Shannon
47ab15f457
Cleans up BackofficeSecurity, fixes up AuthenticationController for endpoints that aren't authorized (and simplifies)
2020-11-27 15:42:41 +11:00
Shannon
313a2e6f7c
Ensures that all back office controllers are authenticated under the back office scheme
2020-11-27 13:32:41 +11:00
Shannon
7d143ec240
Moves auto linking logic to the BackOfficeSignInManager
2020-11-27 12:51:37 +11:00
Bjarke Berg
064dbd2f67
Fixed tests
...
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
2020-11-26 15:15:53 +01:00
Shannon
c08db7763e
Gets oauth working (with google) now need to test others and debug why the styles aren't working
2020-11-27 00:44:36 +11:00
Bjarke Berg
f249553549
Merge remote-tracking branch 'origin/netcore/netcore' into netcore/feature/linux-paths
...
# Conflicts:
# src/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/HostedServices/TempFileCleanupTests.cs
# src/Umbraco.Web.Common/Extensions/UmbracoCoreServiceCollectionExtensions.cs
2020-11-26 13:14:26 +01:00
Shannon
e01abf2802
Moves some files, adds notes, starts poc for back office login providers
2020-11-26 19:24:55 +11:00
Shannon
8e15e265fd
Adds TODOs, puts back UmbracoRequireHttpsAttribute but in a nicer way, ensures test classes initialize the authz policies with the test scheme
2020-11-26 16:52:03 +11:00
Shannon
e0665973e3
Merge remote-tracking branch 'origin/netcore/netcore' into netcore/task/6666-auth-policies
...
# Conflicts:
# src/Umbraco.Infrastructure/Runtime/CoreInitialComposer.cs
# src/Umbraco.Web.BackOffice/Extensions/BackOfficeServiceCollectionExtensions.cs
# src/Umbraco.Web.Common/Filters/UmbracoBackOfficeAuthorizeFilter.cs
# src/Umbraco.Web.Common/Runtime/AspNetCoreComposer.cs
2020-11-25 11:55:16 +11:00
Bjarke Berg
84237d4a57
Remove Security from UmbracoContext ( #9392 )
...
* Remove Security from UmbracoContext
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
* Removing files reference from csproj
Co-authored-by: Elitsa Marinovska <elm@umbraco.dk >
2020-11-24 12:52:48 +01:00
Shannon
f313a4f583
some cleanup of handlers that check multiple query strings
2020-11-24 11:56:53 +11:00
Shannon
40d75f88f3
Merge remote-tracking branch 'origin/netcore/netcore' into netcore/task/6666-auth-policies
...
# Conflicts:
# src/Umbraco.Web.BackOffice/Controllers/AuthenticationController.cs
# src/Umbraco.Web.Common/Filters/UmbracoMemberAuthorizeFilter.cs
2020-11-24 00:46:38 +11:00
Shannon
bde025f661
streamlines the naming of the content/media permissions handlers
2020-11-24 00:42:52 +11:00
Shannon
4dbfe5867b
migrates the custom content persmission helper and media permissions helper checks to authz policies and cleans up that code/class/namespaces
2020-11-24 00:37:26 +11:00
Bjarke Berg
ebe643e30b
Merge pull request #9412 from AndyButland/feature/membership-helper-facade
...
NetCore: Creates abstraction for membership helper and migrates controllers now dependent on it.
2020-11-23 13:15:26 +01:00
Shannon
c34540cb06
Migrates EnsureUserPermissionForContentAttribute to authz policies
2020-11-23 22:43:41 +11:00
Bjarke Berg
a9eb5c3428
Fix issue found in test. Return IActionResult instead of HttpResponseMessage
2020-11-23 08:11:01 +01:00
Bjarke Berg
d2a57496e5
Fix issue found in test. Return IActionResult instead of HttpResponseMessage
2020-11-23 08:08:52 +01:00
Shannon
eeb6c79b14
After testing, removes notes
2020-11-20 15:37:18 +11:00
Shannon
7757447244
Migrates UmbracoBackOfficeAuthorizeAttribute to authz policies and adds notes/questions
2020-11-20 15:32:36 +11:00
Shannon
84c2f75a27
Adds notes, only run back office authz policies on the back office scheme
2020-11-20 14:59:08 +11:00
Shannon
e7b4c5a811
Converts FeatureAuthorize to authz policy
2020-11-20 12:40:29 +11:00
Shannon
f32399292e
Migrates UserGroupAuthorizationAttribute to authz policies
2020-11-20 12:23:09 +11:00
Shannon
9c5ce631a9
removes UmbracoWebApiRequireHttpsAttribute since we dont' need it
2020-11-20 12:12:54 +11:00
Shannon
6a995127b1
Migrates AdminUsersAuthorizeAttribute and DenyLocalLoginAuthorizationAttribute to authz policies
2020-11-19 23:53:04 +11:00
Shannon
29c2bca012
remove delete relation in relation controller, this is not used and shouldn't really be there if only having access to content.
2020-11-19 22:18:56 +11:00
Shannon
63fceebca0
Removes UmbracoApplicationAuthorizeAttribute and migrates usages to authz policies
2020-11-19 22:17:42 +11:00
Shannon
daaade185e
Removes UmbracoTreeAuthorizeAttribute and migrates usages to authz policies
2020-11-19 19:23:41 +11:00
Benjamin Carleski
2309bb9d5b
Finish removing IOHelper.MapPath references
2020-11-18 08:10:16 -08:00
Andy Butland
0fbe01cd22
Created new abstraction IUmbracoWebsiteSecurity and migrated controller's using it (replacing MembershipHelper) to Umbraco.Web.Website.
2020-11-18 16:12:42 +01:00
Shannon
99247d7fbe
Merge remote-tracking branch 'origin/netcore/netcore' into netcore/task/6973-migrating-authenticationcontroller
...
# Conflicts:
# src/Umbraco.Infrastructure/PropertyEditors/PropertyEditorsComposer.cs
2020-11-18 16:02:51 +11:00
Elitsa Marinovska
dd5f400cf3
Netcore: Migration of Model classes from Umbraco.Infrastructure to Core ( #9404 )
...
* Migrating more model, mapping and tree classes
* Migrating files from Mapping dir without Newtonsoft dependency
* Migrating files from PublishedContent and Editors dirs without Newtonsoft dependency + some more of the same kind
* Migrating DataType class without the usage of Newtonsoft.Json and making the corresponding changes to all classes affected
* Combining 3 ContentExtensions files into 1
* Refactoring from migrating ContentExtensions
* Migrating more classes
* Migrating ContentRepositoryExtensions - combining it with existing file in Umbraco.Core
* removing Newtonsoft json dependency & migrating file. Adding partial migration of ConfigurationEditor, so PropertyTagsExtensions can be migrated
* Migrating ContentTagsExtensions, and refactoring from changes in PropertyTagsExtensions
* Changes that should be reverted once ConfigurationEditor class is fully migrated
* VS couldn't find Composing, so build was failing. Removing the using solves the problem
* Handling a single case for deserializing a subset of an input
* Small changes and added tests to JsonNetSerializer
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
* Migrated ConfigurationEditor
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
Co-authored-by: Bjarke Berg <mail@bergmania.dk >
2020-11-17 20:27:10 +01:00
Bjarke Berg
e46a248832
Merge remote-tracking branch 'origin/netcore/netcore' into netcore/task/6973-migrating-authenticationcontroller-merge
...
# Conflicts:
# src/Umbraco.Infrastructure/HostedServices/ScheduledPublishing.cs
# src/Umbraco.Infrastructure/Runtime/CoreInitialComposer.cs
# src/Umbraco.Infrastructure/Scheduling/SchedulerComponent.cs
# src/Umbraco.Infrastructure/Scheduling/SchedulerComposer.cs
# src/Umbraco.Tests.Integration/Testing/UmbracoIntegrationTest.cs
# src/Umbraco.Tests/Testing/UmbracoTestBase.cs
# src/Umbraco.Web.BackOffice/Extensions/BackOfficeApplicationBuilderExtensions.cs
# src/Umbraco.Web.BackOffice/Runtime/BackOfficeComposer.cs
# src/Umbraco.Web.Common/Runtime/AspNetCoreComposer.cs
# src/Umbraco.Web.Common/UmbracoContext/UmbracoContext.cs
# src/Umbraco.Web.UI.NetCore/appsettings.json
# src/Umbraco.Web/Editors/BackOfficeController.cs
# src/Umbraco.Web/Runtime/WebInitialComponent.cs
2020-11-12 13:10:19 +01:00
Bjarke Berg
d756248c7c
Merge remote-tracking branch 'origin/netcore/dev' into netcore/task/6973-migrating-authenticationcontroller-merge
...
# Conflicts:
# src/Umbraco.Examine.Lucene/UmbracoContentIndex.cs
# src/Umbraco.Tests.Integration/Umbraco.Infrastructure/Services/MediaServiceTests.cs
# src/Umbraco.Tests/Services/MemberServiceTests.cs
# src/Umbraco.Web.BackOffice/Controllers/PreviewController.cs
# src/Umbraco.Web.BackOffice/Services/IconService.cs
# src/Umbraco.Web.UI.NetCore/umbraco/UmbracoBackOffice/Preview.cshtml
# src/Umbraco.Web.UI.NetCore/umbraco/config/lang/da.xml
# src/Umbraco.Web.UI.NetCore/umbraco/config/lang/en.xml
# src/Umbraco.Web.UI.NetCore/umbraco/config/lang/en_us.xml
# src/Umbraco.Web.UI/config/umbracoSettings.config
2020-11-12 12:57:03 +01:00
Bjarke Berg
bb1b04be15
Netcore: Cleanup and migrate few classes from Umbraco.Web ( #9375 )
...
* Migrated a few classes, and cleaned up by removing some old classs too in the Umbraco.Web Project
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
* Migrated a few classes, and cleaned up by removing some old classs too in the Umbraco.Web Project
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
* Moved SurfaceControllerTypeCollection + Builder
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
* Moved Extension methods
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
* Removed Wrap methods.. People should use their own TagBuilder
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
2020-11-12 11:01:19 +01:00
Paul Johnson
3f5f85880e
NetCore: MSDI refactor split CoreRuntime & Remove Current ( #9356 )
...
* Split Bootstrap code from CoreRuntime
* Make ContentService method signatures match interface
prevents need to hide the concrete class in tests
* Remove Current
Only bit that bugs me is TreeNode for IconFilePath
I get the feeling it's dead code, but can just use a setter in cs or work out path in js if required.
* Fix tests, remember to terminate IRuntime
2020-11-10 09:50:47 +01:00
Andy Butland
0351a3eed4
Merge branch 'netcore/netcore' into feature/avoid-sync-io-exception-on-image-render
...
# Conflicts:
# src/Umbraco.Web.BackOffice/Extensions/BackOfficeServiceCollectionExtensions.cs
2020-11-06 15:16:51 +01:00
Bjarke Berg
10849175f9
post merge fix
...
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
2020-10-26 16:18:48 +01:00
Bjarke Berg
715071a33f
Merge remote-tracking branch 'origin/netcore/task/6973-migrating-authenticationcontroller' into netcore/task/6973-migrating-authenticationcontroller-merge
...
# Conflicts:
# src/Umbraco.Web.BackOffice/Controllers/BackOfficeServerVariables.cs
# src/Umbraco.Web.BackOffice/Extensions/BackOfficeApplicationBuilderExtensions.cs
# src/Umbraco.Web/Logging/WebProfilerComponent.cs
# src/Umbraco.Web/Logging/WebProfilerComposer.cs
2020-10-26 14:37:56 +01:00
Bjarke Berg
b47f946ffe
Merge remote-tracking branch 'origin/netcore/netcore' into netcore/task/6973-migrating-authenticationcontroller
...
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
# Conflicts:
# src/Umbraco.Infrastructure/HealthCheck/NotificationMethods/EmailNotificationMethod.cs
# src/Umbraco.Web/Editors/AuthenticationController.cs
2020-10-26 14:34:06 +01:00
Mole
9cd752c2f8
Netcore: Align Namespaces in Tests and Web.BackOffice ( #9274 )
...
* Align namespaces in integration tests
* Align namespaces in unit tests
* Align namespaces in Backoffice.Filters
* Align namespaces in Backoffice.ActionResults
* Align namespaces in Backoffice.Mapping
* Align namespaces in Backoffice.PorpertyEditors and SignalR
* Align namespaces in Backoffice.Trees
* Align unit tests after migration
2020-10-26 13:34:08 +01:00
Bjarke Berg
109ccb19b3
Merge pull request #9252 from umbraco/netcore/feature/AB8969-email-message-abstraction
...
NetCore: Email message abstraction
2020-10-23 14:20:10 +02:00
Bjarke Berg
5fe849c8e2
https://github.com/umbraco/Umbraco-CMS/pull/9252 - Changed EmailMessage to be completely immutable
...
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
2020-10-23 12:37:23 +02:00
Bjarke Berg
f791bd4426
Fixed unit test, by injecting IHttpContextAccessor instead of using HttpContext directly. Not the test class is mockable again
...
Signed-off-by: Bjarke Berg <mail@bergmania.dk >
2020-10-23 10:36:47 +02:00
Shannon
64d8b56eca
It builds!
2020-10-23 14:18:53 +11:00
Shannon
1400a02798
Merge branch 'netcore/dev' into netcore/task/6973-migrating-authenticationcontroller
...
# Conflicts:
# src/Umbraco.Core/Constants-Security.cs
# src/Umbraco.Infrastructure/BackOffice/BackOfficeClaimsPrincipalFactory.cs
# src/Umbraco.Infrastructure/BackOffice/BackOfficeUserManager.cs
# src/Umbraco.Infrastructure/Migrations/Upgrade/UmbracoPlan.cs
# src/Umbraco.Tests.AcceptanceTest/cypress/integration/Tour/backofficeTour.ts
# src/Umbraco.Web.BackOffice/Controllers/BackOfficeServerVariables.cs
# src/Umbraco.Web.BackOffice/Controllers/DenyLocalLoginAuthorizationAttribute.cs
# src/Umbraco.Web.BackOffice/Controllers/UsersController.cs
# src/Umbraco.Web.BackOffice/Extensions/HtmlHelperBackOfficeExtensions.cs
# src/Umbraco.Web.BackOffice/Services/IconService.cs
# src/Umbraco.Web.Common/Security/ExternalSignInAutoLinkOptions.cs
# src/Umbraco.Web.UI.Client/src/common/interceptors/_module.js
# src/Umbraco.Web.UI.Client/src/common/interceptors/requiredheaders.interceptor.js
# src/Umbraco.Web.UI.Client/src/views/common/overlays/user/user.controller.js
# src/Umbraco.Web.UI.NetCore/umbraco/UmbracoBackOffice/Default.cshtml
# src/Umbraco.Web.UI.NetCore/umbraco/config/lang/da.xml
# src/Umbraco.Web.UI.NetCore/umbraco/config/lang/en.xml
# src/Umbraco.Web.UI.NetCore/umbraco/config/lang/en_us.xml
# src/Umbraco.Web.UI/Umbraco/Views/AuthorizeUpgrade.cshtml
# src/Umbraco.Web/Editors/AuthenticationController.cs
# src/Umbraco.Web/Editors/BackOfficeController.cs
# src/Umbraco.Web/Editors/Filters/IsCurrentUserModelFilterAttribute.cs
# src/Umbraco.Web/Security/AppBuilderExtensions.cs
# src/Umbraco.Web/Security/AuthenticationOptionsExtensions.cs
# src/Umbraco.Web/UmbracoDefaultOwinStartup.cs
2020-10-23 10:10:02 +11:00
Elitsa Marinovska
d7eca3d0d5
Abstracting MailMessage
2020-10-22 15:08:07 +02:00