Commit Graph

1492 Commits

Author SHA1 Message Date
Ronald Barendse
ab28251558 Use RuntimeState to determine whether to install missing database 2021-09-17 16:30:46 +02:00
Ronald Barendse
d702b2f616 Fix non-Windows database configuration install step 2021-09-17 13:10:21 +02:00
Ronald Barendse
51002ba7a4 Minor code cleanup 2021-09-17 12:52:23 +02:00
Ronald Barendse
074bbb045b Install missing database during unattended install 2021-09-17 12:52:05 +02:00
Ronald Barendse
81cbbd8614 Add LocalDB database option to installer 2021-09-17 12:50:25 +02:00
Ronald Barendse
785630922e Rename IEmbeddedDatabaseCreator to IDatabaseCreator and refactor implementations 2021-09-17 12:48:48 +02:00
Ronald Barendse
57610c96b9 Detect as brand new install if we can't connect and InstallMissingDatabase is enabled 2021-09-17 11:57:20 +02:00
Ronald Barendse
aa15b0d244 Simplify parsing provider name from connection string 2021-09-15 15:41:20 +02:00
Bjarke Berg
39faf63f9c Fixed tryParse 2021-09-15 13:40:08 +02:00
Ronald Barendse
af0f263e3c Fix code formatting 2021-09-14 23:56:49 +02:00
Ronald Barendse
7e7e28f7c7 Use IFileService to save macro partial views 2021-09-14 23:48:24 +02:00
Bjarke Berg
f68717c1c8 Temp commit 2021-09-14 22:13:39 +02:00
Bjarke Berg
f3096c99da Merge remote-tracking branch 'origin/v8/8.17' into v9/feature/merge_v8_14092021
# Conflicts:
#	src/Umbraco.Core/ConfigsExtensions.cs
#	src/Umbraco.Core/Configuration/CoreDebug.cs
#	src/Umbraco.Core/Scoping/ScopeProvider.cs
#	src/Umbraco.Infrastructure/Scoping/Scope.cs
#	src/Umbraco.PublishedCache.NuCache/ContentStore.cs
#	src/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/LocksTests.cs
#	src/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/UnitOfWorkTests.cs
#	src/Umbraco.Tests.UnitTests/Umbraco.Infrastructure/Scoping/ScopeUnitTests.cs
#	src/Umbraco.Tests/Components/ComponentTests.cs
#	src/Umbraco.Tests/TestHelpers/TestObjects.cs
#	src/Umbraco.Web.UI.Client/package-lock.json
#	src/Umbraco.Web.UI.Client/package.json
#	src/Umbraco.Web/HealthCheck/Checks/Security/BaseHttpHeaderCheck.cs
2021-09-14 11:32:43 +02:00
Bjarke Berg
c8a67528ea Merge pull request #11071 from umbraco/v9/bugfix/empty-recycle-bin-index
Fixes empty recycle bin performance with indexing
2021-09-10 11:10:15 +02:00
Nikolaj Geisle
1291a38097 Merge pull request #11060 from umbraco/v9/bugfix/110056-added_missing_null_check_when_conneciton_is_missing
Fixes issue when ConnectionStrings.umbracoDbDSN is missing
2021-09-10 10:33:07 +02:00
Shannon
71448eafe6 Fixes empty recycle bin performance with indexing
Currently when the recycle bin is empty, it is going to individually delete each item from the index. This is going to cause tons of allocations in Umbraco for DeferedDeleteIndex objects for each item and then down within Examine is going to process each one individually instead of just doing it in bulk. There will be a lot of allocations made there too along with a bunch of extra and unecessary threads.
2021-09-09 16:04:18 -06:00
Shannon
769f24aaae Fixes reading connection strings after install
The issue was discovered when testing Umbraco Id. If you have an existing install and there is a pending Umbraco migration (upgrade), but you clear out the connection string to force a new install screen, fill out the existing connection string details, it all works and redirects to the back office. This will throw exceptions because the runtime state is in an upgrade state (which is fixed in #11064) but if you then logout and try to log in with an active OAuth provider, it means there is a redirect outside of Umbraco and back again and you'll end up back on the installer screen - but it will not show you the upgrade screen, instead it shows you the normal install screen. This is because we are not using IOptionsMonitor for connection string settings which means it's already read the original empty connection string setting fom the very beginning and isn't reading the current/updated value.

We need to review all IOptions usages. Most of them should be IOptionsMonitor unless its impossible to change the app behavior at runtime with a particular config option.
2021-09-09 13:15:11 -06:00
Bjarke Berg
d121456054 https://github.com/umbraco/Umbraco-CMS/issues/11056 Handle null checks 2021-09-09 13:08:27 +02:00
Nikolaj
acf0052f8e Merge branch 'v9/dev' into v9/bugfix/imagesize-cleanup
# Conflicts:
#	src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.CoreServices.cs
2021-09-09 11:40:17 +02:00
Bjarke Berg
97486e0705 Merge pull request #11050 from umbraco/v9/bugfix/fix-imagecropper-trygetmediapath
Fix Image Cropper media path parsing
2021-09-08 21:03:46 +02:00
Bjarke Berg
2cfb099dea Merge pull request #11058 from umbraco/v9/bugfix/fix-email-handler-detection
Fixes email handler detection
2021-09-08 19:59:23 +02:00
Shannon
8ff78fb1de Fixes email handler detection 2021-09-08 11:19:52 -06:00
Bjarke Berg
1d55d50809 Merge pull request #11046 from umbraco/v9/feature/merge_v8.17-rc
Merge 8.17 RC into V9, cleanup/refactor property groups/tabs API
2021-09-08 19:17:02 +02:00
Bjarke Berg
e284e30df5 Fixed issues where we used the global setting UmbracoPath instead of the constant 2021-09-08 18:29:24 +02:00
Ronald Barendse
7c250fcac7 Use ImageSharp configuration from DI (and its related ReadOrigin) 2021-09-08 15:18:29 +02:00
Ronald Barendse
bd8d7b91d6 Support plain file path strings as Image Cropper values 2021-09-08 12:07:05 +02:00
Ronald Barendse
b145f09368 Ensure TryGetMediaPath only returns true on non-empty values 2021-09-08 12:03:56 +02:00
Elitsa Marinovska
6c56c298d6 Merge branch 'v9/dev' into v9/bugfix/fix_issues_when_changing_umbraco_path 2021-09-08 08:17:59 +02:00
Ronald Barendse
e2497d66a8 Refactor IContentTypeBase API to use property group aliases 2021-09-07 20:48:45 +02:00
Ronald Barendse
fc9c69d1fa Add 8.17.0 migration to plan 2021-09-07 16:32:24 +02:00
Ronald Barendse
8ce4993cdc Fix failing tests because of missing property group alias 2021-09-07 14:40:45 +02:00
Ronald Barendse
ee2da5b8ca Merge branch 'v8/8.17' into v9/feature/merge_v8.17-rc 2021-09-07 12:10:58 +02:00
Bjarke Berg
8e54946810 Apply suggestions from code review
Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com>
2021-09-06 15:24:04 +02:00
Bjarke Berg
e1ca6da8b7 https://github.com/umbraco/Umbraco-CMS/issues/10965 - Added support for appsettings configuration of the UmbracoFile "sink".
{
  "Serilog": {
    "WriteTo": [
      {
        "Name": "UmbracoFile",
        "Args": {
          "RestrictedToMinimumLevel": "Warning"
          "FileSizeLimitBytes": 1073741824,
          "RollingInterval" : "Day"
          "FlushToDiskInterval": null,
          "RollOnFileSizeLimit": false,
          "RetainedFileCountLimit": 31
        }
      }
    ]
  },
}
2021-09-06 12:46:09 +02:00
Warren Buckley
74b1c8384a Merge pull request #10998 from umbraco/v9/bugfix/email-sending-metadata
Updates email sender to have some metadata
2021-09-01 10:27:29 +01:00
Warren Buckley
8888c55d2e Update to use constants for emailtype strings 2021-09-01 09:02:41 +01:00
Bjarke Berg
5953c9ebe7 Fixed issues with confusion about when to use umbracoPath and when to use the const.
Now it is possible to change the location of backoffice.
{
  "Umbraco": {
    "CMS": {
      "Global": {
       "UmbracoPath": "~/my-secret-loginpanel",
        "IconsPath": "~/my-secret-loginpanel/assets/icons"
      }
    }
  }
}
2021-09-01 07:50:17 +02:00
Shannon
4d125da6f1 Updates email sender to have some metadata 2021-08-31 13:41:33 -06:00
Nikolaj Geisle
65545134f4 Merge pull request #10946 from umbraco/v9/feature/validationService-optimization
V9: Reuse value editors for validation
2021-08-31 13:58:01 +02:00
Nikolaj
d448ddd7df Make ValueEditorCacheRefresher a distributed cache refresher 2021-08-30 10:46:05 +02:00
Ronald Barendse
806ebc6106 Merge branch 'v9/dev' into v9/bugfix/imagesize-cleanup
# Conflicts:
#	src/Umbraco.Infrastructure/DependencyInjection/UmbracoBuilder.CoreServices.cs
#	src/Umbraco.Infrastructure/Media/ImageDimensionExtractor.cs
2021-08-27 08:46:02 +02:00
Bjarke Berg
56d8e0e684 Merge remote-tracking branch 'origin/v8/8.16' into v9/dev
# Conflicts:
#	build/NuSpecs/UmbracoCms.Core.nuspec
#	build/NuSpecs/UmbracoCms.nuspec
#	build/build.ps1
#	src/SolutionInfo.cs
#	src/Umbraco.Core/Diagnostics/MiniDump.cs
#	src/Umbraco.Core/Sync/DatabaseServerMessenger.cs
#	src/Umbraco.Infrastructure/Persistence/LocalDb.cs
#	src/Umbraco.Infrastructure/PropertyEditors/BlockEditorPropertyHandler.cs
#	src/Umbraco.Web/PublishedCache/NuCache/PublishedSnapshotService.cs
2021-08-26 12:13:04 +02:00
Bjarke Berg
392eec2371 Fixed potential null reference exception in KeepAlive 2021-08-25 11:56:20 +02:00
Nikolaj
dc22ee8563 Merge branch 'v9/dev' into v9/feature/validationService-optimization 2021-08-23 14:32:43 +02:00
Nikolaj
306ed56027 Create a cache for value editors 2021-08-23 14:28:44 +02:00
Paul Johnson
8dd645f36e Merge pull request #10880 from umbraco/v9/bugfix/suppress-notifications-migrations
Suppress scope notifications during migrations
2021-08-23 13:25:47 +01:00
Paul Johnson
d41ab6a429 Fix integration tests - register PackageMigrationRunner 2021-08-20 16:18:57 +01:00
Zeegaan
bccd4796e2 Merge remote-tracking branch 'origin/v9/dev' into v9/task/removed_obsolete_property_in_user 2021-08-20 11:11:14 +02:00
Paul Johnson
061f1b3b87 Move EmailSender to Mail namespace. 2021-08-19 14:38:38 +01:00
Paul Johnson
6b18f93ae7 Fix issue where MSDI confused which ctor to use for EmailSender 2021-08-19 14:11:40 +01:00