Commit Graph

38556 Commits

Author SHA1 Message Date
Warren Buckley
dabecbf7af V9 Netcore: Fix missing launch browser param for dotnet run from template (#10238)
* Adds in launchBrowser for Kestrel/Propject profile so running dotnet run from CLI will launch browser

* Keep in sync with the template file that will we ship
2021-05-06 19:56:04 +02:00
Andy Butland
6e75006f0b Merge pull request #10234 from umbraco/v9/bugfix/10232_bugfix_for_modelsbuilder_when_having_inherited_doctypes
V9: Bugfix for modelsbuilder when having inherited doctypes
2021-05-06 15:26:38 +02:00
Bjarne Fyrstenborg
a464fadf2c Update spectrum color picker to latest v2.0.8 (#10225)
* Update spectrum color picker to latest v2.0.8

* Update package-lock.json
2021-05-06 12:54:07 +02:00
Bjarke Berg
205c111dbc https://github.com/umbraco/Umbraco-CMS/issues/10232
Fixes issue with modelsbuilder when doctypes are inheriting from other doc types.
2021-05-06 10:58:45 +02:00
Bjarke Berg
261730f530 V9: Reintroduce missing friendly get crop url extensions (#10233)
* Adds missing extension methods of `GetCropUrl` that uses the service locator og inject the required services.

* Xml docs updated
2021-05-06 10:06:22 +02:00
Warren Buckley
0bdeda378a Merge pull request #10205 from umbraco/v9/feature/replace-system-drawing-with-imagesharp
Replaces System.Drawing with ImageSharp, and thereby fix TODO.
2021-05-05 14:57:01 +01:00
Andy Butland
811377b2e5 Fixes FileUploadCleanupFilterAttribute when incomimg model is not provided (#10162). (#10230) 2021-05-05 15:41:45 +02:00
Niels Lyngsø
6e16550b84 Dont let validation issues prevent saving (#9691)
* skipValidation for content save

* Correcting merge

* Use warning style when saving

* final corrections

* skip client side validation

* remove log

* show invariant property validation issues in the save dialog

* use warning color for .show-validation-type-warning

Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
2021-05-05 11:18:46 +02:00
Niels Lyngsø
c1dd004604 use warning color for .show-validation-type-warning 2021-05-05 11:15:23 +02:00
Niels Lyngsø
f8c38942f4 Merge remote-tracking branch 'origin/v8/dev' into v8/bugfix/always-ignorer-validation-when-saving
# Conflicts:
#	src/Umbraco.Web.UI.Client/src/common/directives/validation/valformmanager.directive.js
2021-05-05 10:37:27 +02:00
Harikrishna Parmar
857997b5d4 Bugfix/umbraco backoffice icon #10192 (#10212)
* Umbraco backoffice icon #10192

Added umbraco icon

* Update icon-umbraco.svg

updated viewbox
2021-05-05 02:10:26 +02:00
Bjarke Berg
8891edc7d5 also copy snupkg files to artifacts (symbol nuget) 2021-05-04 19:51:46 +02:00
Warren Buckley
f43f37dc35 Umbraco V9 Adds SourceLink package from Microsoft for people to debug into the relevent build commit with GitHub source code (#10224)
We had this previously in Umbraco V8
2021-05-04 18:58:50 +02:00
Niels Lyngsø
7ab09cb404 Ensure BlockObjects have references to a working current property editor. (#10195)
Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
2021-05-04 16:58:31 +02:00
Martin Amsinck Andersen
7d4a76bad4 appsettings "WebRouting:DisableRedirectUrlTracking" should be a bool not a string (#10207) 2021-05-04 13:42:31 +02:00
comstyle
8705b067c1 Update CompiledPackageXmlParser.cs (#10209)
Fix issue with hardcoded '\' as directory separator char. This caused all files in packages to be restored in the root folder with '\' in the filename on Linux.
2021-05-04 13:41:12 +02:00
Martin Amsinck Andersen
2bc1c46e57 Casing in appsettings:umbraco:cms:contentMacroErrors and using MacroErrorBehaviour Enum (#10208)
* appsettings "WebRouting:DisableRedirectUrlTracking" should be a bool not a string

* Casing in appsettings "Umbraco:CMS:Content:MacroErrors" + Using MacroErrorBehaviour enum
2021-05-04 13:40:53 +02:00
Kenn Jacobsen
b7b3eeb143 Do not change function and class names when minifying JS (#10223) 2021-05-04 13:40:35 +02:00
Jan Skovgaard
a721f92aed Accessibility: Add focus lock for the infinite editor (#8522)
* Toggle the inert attribute when adding or removing the first/last editor

* Add focus lock directive for the editor

* Increase timeout period so infinite editors transclusions will also have time to finish

* Make sure elements containing .ng-hide are not part of the possible focusable elements

* Update comments

* Conditionally add umb-focus-lock and inert attributes

* Hook into the evenservice to reinitialize the onInit method if the last editor has not been closed when the lock is used in infinite mode

* Don't try to add focus to something that does not exist

* Minor code refactor placing some variables outside the init method

* Refactoring code to make things a bit more clean

* Remove the event listener when the directive is destroyed

* Add mutationObserver to watch for attribute changes and then trigger the getFocusableElements method

* Fetch focusable elements on domChange

* Ensure that args exists before trying to read the properties

* Refactor to use mutationobserver when overlays are closed passing the correct target and re-initialising the directive to activate the focus lock

* Change ng-hide to ng-if so the focusable elements inside the hidden div are not being selected

* Narrow attributes to look for down to the bare minimum of the umb-focus-lock

* Refactor to using good ol' for loop (Fastest)

* Disconnect the observer once the init function has been called - Massive performance improvement

* Event handler cleanup

* Refactor the code to re-initialize the init method on destroy in case infinite editors still exists in the DOM

* Align codestyle

* Add logic to deal with "lastKnowFocused" elements in infinite editing mode

* Re-add attributes after merge with contrib branch

* Correct spelling mistake

* Move onInit into the $includeContentLoaded event and set the timeout to 0

* Make sure to add focus to elements with role="button" as well

* Add comments and remove timeout / delay settings

* Debouce domObserver

* Wrap init function in safeApply

* Add comments to help remember / understand what things are intended to be doing and add missing event param as well as getting rid of some unused code

* Adding more comments

* Move setting of first and last focusable elements into the setElement function

* Remove todo

* Move the setup of first and last focusable elements back to where they were...

Co-authored-by: Joe Glombek <gh@joe.gl>
2021-05-04 10:08:02 +01:00
Niels Lyngsø
c8a98a670c Review AB11194 — Improve media selector UX (#10157)
* set input file accept

* Use PreValue file extensions for limiting the files to be chosen in file input

* Current state for Warren to review

* This should fix up what you need Niels

* update csproj

* use empty string if fileExtensions is undefined

* public interface

* initial work

* local crops

* translations

* translation correction

* fix misspeling

* some progress

* filter media picker

* align media card grid items correctly

* responsive media cropper

* always be able to scale 3 times smallest scale

* making image cropper property editor responsive

* scroll to scale

* adjust slider look

* rearrange parts of mediaentryeditor

* test helper

* styling

* move controls inside umb-image-crop

* seperate umg-cropper-gravity styling

* corrected layout

* more ui refinement

* keep the idea of mandatory out for now.

* remove double ;

* removed testing code

* JSON Property Value Convertor now has an array of property editors to exclude

* Property Value Convertor for Media Picker 3 aka Media Picker with Local Crops

* Experimenting on best approach to retrieve local crop in razor view when iterating over picked media items

* Update ValueConvertor to use ImageCropperValue as part of the model for views as alot of existing CropUrls can then use it

* Update extension methods to take an ImageCropperValue model (localCropData)

* Forgot to update CSProj for new ValueConvertor

* New GetCropUrl @Url.GetCropUrl(crop.Alias, media.LocalCrops) as oppposed to @Url.GetCropUrl(media.LocalCrops, cropAlias:crop.Alias, useCropDimensions: true)

* Remove dupe item in CSProj

* Use a contains as an opposed to Array.IndexOf

* various corrections, SingleMode based on max 1, remove double checkerBackground, enforce validation for Crops, changed error indication

* mediapicker v3

* correct version

* fixing file ext label text color

* clipboard features for MediaPicker v3

* highlight not allowed types

* highlight trashed as an error

* Media Types Video, Sound, Document and Vector Image

* Rename to Audio and VectorGraphics

* Add (SVG) in the name for Vector Graphics

* adding CSV to Documents

* remove this commented code.

* remove this commented code

* number range should not go below 0, at-least as default until we make that configurable.

* use min not ng-min

* description for local crops

* Error/Limits highlighting reactive

* visual adjustments

* Enabling opening filtered folders + corrected select hover states

* Varous fixes to resolve issues with unit tests.

* Refactor MediaType Documents to only contain Article file type

* mark as build-in

* predefined MediaPicker3 DataTypes, renaming v2 to "old"

* set scale bar current value after min and max has been set

* added missing }

* update when focal point is dragged

* adjusted styling for Image Cropper property editor

* correcting comment

* remove todo - message for trashed media items works

* Changed parameter ordering

* Introduced new extension method on MediaWithCrops to get croppings urls in with full path

* Reintroducing Single Item Mode

* use Multiple instead of SingleMode

* renaming and adding multiple to preconfigured datatypes

* Change existing media picker to use the Clipboard type MEDIA, enabling shared functionality.

* clean up unused clipboard parts

* adjusted to new amount

* correcting test

* Fix unit test

* Move MediaWithCrops to separate file and move to Core.Models

* parseContentForPaste

* clean up

* ensure crops is an array.

* actively enable focal points, so we dont set focal points that aren't used.

* only accept files that matches file extensions from Umbraco Settings

* Cleanup

* Add references from MediaPicker3 to media

* corrections from various feedback

* remove comment

* correct wording

* use windowResizeListener

* Show Media Type Selector if there is multiple types that matches the current upload batch

* clean-up and refactoring

* auto pick option

Co-authored-by: Warren Buckley <warren@umbraco.com>
Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
Co-authored-by: Andy Butland <abutland73@gmail.com>
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
Co-authored-by: Sebastiaan Janssen <sebastiaan@umbraco.com>
Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
2021-05-04 11:06:52 +02:00
Warren Buckley
f344479b40 Netcore: dotnet new template updates and change HideTopLevelNodeFromPath default value to true (#10222)
* As we always ship with config in V8 to set this to be true makes sense it now because default in code

* Explicitly add JSON Schema property incase user IDE does not automap it

* Escaping issue with example usages
2021-05-04 11:06:25 +02:00
Niels Lyngsø
c2fd28810b show invariant property validation issues in the save dialog 2021-05-04 10:38:26 +02:00
Niels Lyngsø
ce34165e9d use formCtrl.$invalid instead of running angularHelper.countAllFormErrors, as this method is way too heavy to run in a $watch. (#10134)
Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
2021-05-03 16:18:15 +02:00
Bjarke Berg
ba2792b33e fix lowercase issue for packages 2021-05-03 15:54:25 +02:00
Niels Lyngsø
0b4be695cf Merge remote-tracking branch 'origin/v8/dev' into v8/bugfix/always-ignorer-validation-when-saving 2021-05-03 15:47:36 +02:00
Elitsa Marinovska
4bdb011b16 V9: Implementing Error Describers for translated error messages (#10216)
* Adding missing keys needed for the translation of the error describers' msgs

* Override all methods from IdentityErrorDescriber in order to provide our own translated error messages using our own translation engine (ILocalizedTextService)

* Fix tests

* Refactoring based on introducing an UmbracoErrorDescriberBase

* Remove unnecessary usings
2021-05-03 14:05:17 +02:00
Niels Lyngsø
dcfdcb11de remove log 2021-05-03 11:29:52 +02:00
Mole
d8d4be9e8e Backport cache key fix and optimizations (#10199)
* Add GetKey<T, TId>

* Update Usages of GetKey and remove GetKey<T>(object)

We shouldn't have to retain this since RepositoryCacheKeys is internal.

* Apply changes to DefaultRepositoryCachePolicy

* Add check for default/less than -1 on UserRepository PerformGet

Co-authored-by: Nikolaj <nel@umbraco.dk>
2021-05-03 10:22:42 +02:00
Andy Butland
12c55dd605 Made the LocalDb class public for access from Deploy. 2021-04-30 16:45:26 +02:00
Andy Butland
1f8810ebb2 Made some further DTOs public so can be used in Deploy. 2021-04-30 16:20:53 +02:00
Andy Butland
c4f594de12 Merge pull request #10203 from umbraco/v9/task/internals-visible-to-packages
Made a couple of internal classes public that Deploy has a dependency on.
2021-04-29 22:18:04 +02:00
Bjarke Berg
a854959b85 Replaces System.Drawing with ImageSharp, and thereby fix TODO. 2021-04-29 20:32:26 +02:00
Bjarke Berg
743f4a6610 https://github.com/umbraco/Umbraco-CMS/issues/10201 - Fix duplicate xml end tag 2021-04-29 17:30:07 +02:00
Andy Butland
b12c4b7d66 Aligned access modifier of related Dto. 2021-04-29 16:52:18 +02:00
Andy Butland
4ddc6ad868 Made a couple of internal classes public that Deploy has a dependency on. 2021-04-29 15:27:02 +02:00
Bjarne Fyrstenborg
727be420ff Use umb-icon component in listview dropdown 2021-04-29 08:40:00 +10:00
Bjarne Fyrstenborg
349c5ac3ab Fix issue with active style affected nested block list elements 2021-04-29 08:21:36 +10:00
Mike Chambers
b783399c5c Update ModelsBuilderComposer.cs
issue #10186

typo in IsExternalModelsBuilderInstalled -> Umbraco.ModelsBuider
2021-04-28 18:05:40 +02:00
Bjarke Berg
8a2c8f1c09 Update version to beta002 2021-04-28 10:11:41 +02:00
Bjarke Berg
ae3fc84369 Fix templates by only allowing generated https ports withing the range 44300-44399 https://docs.microsoft.com/en-us/iis/extensions/using-iis-express/running-iis-express-without-administrative-privileges#summary 2021-04-28 09:30:05 +02:00
Bjarke Berg
5157d67485 Fix for template 2021-04-27 15:01:13 +02:00
Sebastiaan Janssen
e7a3fd37ce Revert "Fixed copy preserving sort order (#10091)"
This reverts commit 26d11a8314.
2021-04-27 14:57:17 +02:00
Kenn Jacobsen
3781c6b00f Remove a bunch of template related, unreferenced methods from file service and stylesheet repository (#9875)
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
2021-04-27 12:30:38 +02:00
Kenn Jacobsen
8674244e61 Remove a bunch of partial views related, unreferenced methods from file service and partial view repositories (#9879)
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
2021-04-27 11:42:06 +02:00
Kenn Jacobsen
4f0d4d1fcd Remove a bunch of script related, unreferenced methods from file service and script repository (#9878)
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
2021-04-27 10:36:28 +02:00
Kenn Jacobsen
720e529474 Remove a bunch of template related, unreferenced methods from file service and template repository (#9876) 2021-04-27 09:59:51 +02:00
Mole
c9ebaadf23 Netcore: File systems rework (#10181)
* Allow IMediaFileSystem to be replace in the DI, or registered with inner filesystem

* Remove GetFileSystem from Filesystems

It was only used by tests.

* Make MediaFileSystem inherit from PhysicalFileSystem directly

* Remove FileSystemWrapper

* Remove inner filesystem from MediaFileSystem

* Add MediaFileManager and bare minimum to make it testable

* Remove MediaFileSystem

* Fix unit tests using MediaFileManager

* Remove IFileSystem and rely only on FileSystem

* Hide dangerous methods in FileSystems and do some cleaning

* Apply stylecop warnings to MediaFileManager

* Add FilesystemsCreator to Tests.Common

This allows you to create an instance if FileSystems with your own specified IFileSystem for testing purposes outside our own test suite.

* Allow the stylesheet filesystem to be replaced.

* Fix tests

* Don't save stylesheetWrapper in a temporary var

* refactor(FileSystems): change how stylesheet filesystem is registered

* fix(FileSystems): unable to overwrite media filesystem

SetMediaFileSystem added the MediaManager as a Singleton instead of
replacing the existing instance.

* fix(FileSystems): calling AddFileSystems replaces MediaManager

When calling AddFileSystems after SetMediaFileSystem the MediaManager
gets replaced by the default PhysicalFileSystem, so instead of calling
SetMediaFileSystem in AddFileSystems we now call TrySetMediaFileSystem
instead. This method will not replace any existing instance of the
MediaManager if there's already a MediaManager registered.

* Use SetMediaFileSystem instead of TrySet, and rename AddFilesystems to ConfigureFileSystems

Also don't call AddFileSystems again in ConfigureFilesystems

* Don't wrap CSS filesystem twice

* Add CreateShadowWrapperInternal to avoid casting

* Throw UnauthorizedAccessException isntead of InvalidOperationException

* Remove ResetShadowId

Co-authored-by: Rasmus John Pedersen <mail@rjp.dk>
2021-04-27 09:52:17 +02:00
Shannon Deminick
eaa46fe190 Allows for structured logging with the IProfilingLogger (#9958)
* Allows for structured logging with the IProfilingLogger

* Review fixes

Co-authored-by: Bjarke Berg <mail@bergmania.dk>
2021-04-27 09:10:30 +02:00
Mole
51a720b16c Add references to Umbraco.Code as PrivateAsset (#10148)
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
2021-04-27 09:07:10 +02:00
Anders Bjerner
4ade2264d2 Minor Danish translations 2021-04-27 08:06:57 +10:00