Commit Graph

34698 Commits

Author SHA1 Message Date
Bjarne Fyrstenborg
aaa13303b2 Adjust grid editor layout configuration (#9887)
* Fix wrong end closing tag

* Add button type attribute

* Assign null instead of undefined

* Left align text in row button

* Assign temporary rows to currentLayout

* Cleanup output

* Register functions in vm

* Move nameChanged property to init function

* Don't set toggled as checked when switching columns in row

* Use existing behaviour to set allowAll

* Remove vm.layout again

* copy rows when adding new section + clean up rows on submit and close

Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
2021-05-07 10:23:19 +02:00
Bjarne Fyrstenborg
a464fadf2c Update spectrum color picker to latest v2.0.8 (#10225)
* Update spectrum color picker to latest v2.0.8

* Update package-lock.json
2021-05-06 12:54:07 +02:00
Niels Lyngsø
6e16550b84 Dont let validation issues prevent saving (#9691)
* skipValidation for content save

* Correcting merge

* Use warning style when saving

* final corrections

* skip client side validation

* remove log

* show invariant property validation issues in the save dialog

* use warning color for .show-validation-type-warning

Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
2021-05-05 11:18:46 +02:00
Niels Lyngsø
c1dd004604 use warning color for .show-validation-type-warning 2021-05-05 11:15:23 +02:00
Niels Lyngsø
f8c38942f4 Merge remote-tracking branch 'origin/v8/dev' into v8/bugfix/always-ignorer-validation-when-saving
# Conflicts:
#	src/Umbraco.Web.UI.Client/src/common/directives/validation/valformmanager.directive.js
2021-05-05 10:37:27 +02:00
Harikrishna Parmar
857997b5d4 Bugfix/umbraco backoffice icon #10192 (#10212)
* Umbraco backoffice icon #10192

Added umbraco icon

* Update icon-umbraco.svg

updated viewbox
2021-05-05 02:10:26 +02:00
Niels Lyngsø
7ab09cb404 Ensure BlockObjects have references to a working current property editor. (#10195)
Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
2021-05-04 16:58:31 +02:00
Jan Skovgaard
a721f92aed Accessibility: Add focus lock for the infinite editor (#8522)
* Toggle the inert attribute when adding or removing the first/last editor

* Add focus lock directive for the editor

* Increase timeout period so infinite editors transclusions will also have time to finish

* Make sure elements containing .ng-hide are not part of the possible focusable elements

* Update comments

* Conditionally add umb-focus-lock and inert attributes

* Hook into the evenservice to reinitialize the onInit method if the last editor has not been closed when the lock is used in infinite mode

* Don't try to add focus to something that does not exist

* Minor code refactor placing some variables outside the init method

* Refactoring code to make things a bit more clean

* Remove the event listener when the directive is destroyed

* Add mutationObserver to watch for attribute changes and then trigger the getFocusableElements method

* Fetch focusable elements on domChange

* Ensure that args exists before trying to read the properties

* Refactor to use mutationobserver when overlays are closed passing the correct target and re-initialising the directive to activate the focus lock

* Change ng-hide to ng-if so the focusable elements inside the hidden div are not being selected

* Narrow attributes to look for down to the bare minimum of the umb-focus-lock

* Refactor to using good ol' for loop (Fastest)

* Disconnect the observer once the init function has been called - Massive performance improvement

* Event handler cleanup

* Refactor the code to re-initialize the init method on destroy in case infinite editors still exists in the DOM

* Align codestyle

* Add logic to deal with "lastKnowFocused" elements in infinite editing mode

* Re-add attributes after merge with contrib branch

* Correct spelling mistake

* Move onInit into the $includeContentLoaded event and set the timeout to 0

* Make sure to add focus to elements with role="button" as well

* Add comments and remove timeout / delay settings

* Debouce domObserver

* Wrap init function in safeApply

* Add comments to help remember / understand what things are intended to be doing and add missing event param as well as getting rid of some unused code

* Adding more comments

* Move setting of first and last focusable elements into the setElement function

* Remove todo

* Move the setup of first and last focusable elements back to where they were...

Co-authored-by: Joe Glombek <gh@joe.gl>
2021-05-04 10:08:02 +01:00
Niels Lyngsø
c8a98a670c Review AB11194 — Improve media selector UX (#10157)
* set input file accept

* Use PreValue file extensions for limiting the files to be chosen in file input

* Current state for Warren to review

* This should fix up what you need Niels

* update csproj

* use empty string if fileExtensions is undefined

* public interface

* initial work

* local crops

* translations

* translation correction

* fix misspeling

* some progress

* filter media picker

* align media card grid items correctly

* responsive media cropper

* always be able to scale 3 times smallest scale

* making image cropper property editor responsive

* scroll to scale

* adjust slider look

* rearrange parts of mediaentryeditor

* test helper

* styling

* move controls inside umb-image-crop

* seperate umg-cropper-gravity styling

* corrected layout

* more ui refinement

* keep the idea of mandatory out for now.

* remove double ;

* removed testing code

* JSON Property Value Convertor now has an array of property editors to exclude

* Property Value Convertor for Media Picker 3 aka Media Picker with Local Crops

* Experimenting on best approach to retrieve local crop in razor view when iterating over picked media items

* Update ValueConvertor to use ImageCropperValue as part of the model for views as alot of existing CropUrls can then use it

* Update extension methods to take an ImageCropperValue model (localCropData)

* Forgot to update CSProj for new ValueConvertor

* New GetCropUrl @Url.GetCropUrl(crop.Alias, media.LocalCrops) as oppposed to @Url.GetCropUrl(media.LocalCrops, cropAlias:crop.Alias, useCropDimensions: true)

* Remove dupe item in CSProj

* Use a contains as an opposed to Array.IndexOf

* various corrections, SingleMode based on max 1, remove double checkerBackground, enforce validation for Crops, changed error indication

* mediapicker v3

* correct version

* fixing file ext label text color

* clipboard features for MediaPicker v3

* highlight not allowed types

* highlight trashed as an error

* Media Types Video, Sound, Document and Vector Image

* Rename to Audio and VectorGraphics

* Add (SVG) in the name for Vector Graphics

* adding CSV to Documents

* remove this commented code.

* remove this commented code

* number range should not go below 0, at-least as default until we make that configurable.

* use min not ng-min

* description for local crops

* Error/Limits highlighting reactive

* visual adjustments

* Enabling opening filtered folders + corrected select hover states

* Varous fixes to resolve issues with unit tests.

* Refactor MediaType Documents to only contain Article file type

* mark as build-in

* predefined MediaPicker3 DataTypes, renaming v2 to "old"

* set scale bar current value after min and max has been set

* added missing }

* update when focal point is dragged

* adjusted styling for Image Cropper property editor

* correcting comment

* remove todo - message for trashed media items works

* Changed parameter ordering

* Introduced new extension method on MediaWithCrops to get croppings urls in with full path

* Reintroducing Single Item Mode

* use Multiple instead of SingleMode

* renaming and adding multiple to preconfigured datatypes

* Change existing media picker to use the Clipboard type MEDIA, enabling shared functionality.

* clean up unused clipboard parts

* adjusted to new amount

* correcting test

* Fix unit test

* Move MediaWithCrops to separate file and move to Core.Models

* parseContentForPaste

* clean up

* ensure crops is an array.

* actively enable focal points, so we dont set focal points that aren't used.

* only accept files that matches file extensions from Umbraco Settings

* Cleanup

* Add references from MediaPicker3 to media

* corrections from various feedback

* remove comment

* correct wording

* use windowResizeListener

* Show Media Type Selector if there is multiple types that matches the current upload batch

* clean-up and refactoring

* auto pick option

Co-authored-by: Warren Buckley <warren@umbraco.com>
Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
Co-authored-by: Andy Butland <abutland73@gmail.com>
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
Co-authored-by: Sebastiaan Janssen <sebastiaan@umbraco.com>
Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
2021-05-04 11:06:52 +02:00
Niels Lyngsø
c2fd28810b show invariant property validation issues in the save dialog 2021-05-04 10:38:26 +02:00
Niels Lyngsø
ce34165e9d use formCtrl.$invalid instead of running angularHelper.countAllFormErrors, as this method is way too heavy to run in a $watch. (#10134)
Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
2021-05-03 16:18:15 +02:00
Niels Lyngsø
0b4be695cf Merge remote-tracking branch 'origin/v8/dev' into v8/bugfix/always-ignorer-validation-when-saving 2021-05-03 15:47:36 +02:00
Niels Lyngsø
dcfdcb11de remove log 2021-05-03 11:29:52 +02:00
Mole
d8d4be9e8e Backport cache key fix and optimizations (#10199)
* Add GetKey<T, TId>

* Update Usages of GetKey and remove GetKey<T>(object)

We shouldn't have to retain this since RepositoryCacheKeys is internal.

* Apply changes to DefaultRepositoryCachePolicy

* Add check for default/less than -1 on UserRepository PerformGet

Co-authored-by: Nikolaj <nel@umbraco.dk>
2021-05-03 10:22:42 +02:00
Bjarne Fyrstenborg
727be420ff Use umb-icon component in listview dropdown 2021-04-29 08:40:00 +10:00
Bjarne Fyrstenborg
349c5ac3ab Fix issue with active style affected nested block list elements 2021-04-29 08:21:36 +10:00
Mike Chambers
b783399c5c Update ModelsBuilderComposer.cs
issue #10186

typo in IsExternalModelsBuilderInstalled -> Umbraco.ModelsBuider
2021-04-28 18:05:40 +02:00
Sebastiaan Janssen
e7a3fd37ce Revert "Fixed copy preserving sort order (#10091)"
This reverts commit 26d11a8314.
2021-04-27 14:57:17 +02:00
Anders Bjerner
4ade2264d2 Minor Danish translations 2021-04-27 08:06:57 +10:00
Shannon
1a3165507e adds note 2021-04-26 18:26:49 +10:00
Shannon
053a56a45b Removes the callbacks from DatabaseServerMessenger, moves logic for cold boot into the components responsible for what needs to happen in cold boot. This is still not ideal but we are stuck with backwards compat. In netcore the initialization will be fixed up (if not already). Ensure examine rebuilds don't occur until the first http request is done instead of on a timer which could be problematic with cold boots. 2021-04-26 18:07:23 +10:00
Shannon Deminick
dccec91073 Merge pull request #9859 from nzdev/v8/bugfix/fix-cold-boot
Reduce cold boot times by loading content and media only once on cold boot
2021-04-26 15:52:41 +10:00
Shannon
22afe5e341 Adds cold boot restart to load test proj 2021-04-26 15:40:46 +10:00
nzdev
306c82f871 Change log to Info 2021-04-23 17:03:32 +12:00
Mads Rasmussen
4369747c72 skip client side validation 2021-04-22 16:55:18 +02:00
Sebastiaan Janssen
c885831e02 Revert "use v8 branch as default for API Docs"
This reverts commit 0dfefb72cb.
2021-04-22 16:34:11 +02:00
Arkadiusz Biel
0dfefb72cb use v8 branch as default for API Docs 2021-04-22 16:12:20 +02:00
Niels Lyngsø
1a5b88525b Media Picker v3 (#9461)
* set input file accept

* Use PreValue file extensions for limiting the files to be chosen in file input

* Current state for Warren to review

* This should fix up what you need Niels

* update csproj

* use empty string if fileExtensions is undefined

* public interface

* initial work

* local crops

* translations

* translation correction

* fix misspeling

* some progress

* filter media picker

* align media card grid items correctly

* responsive media cropper

* always be able to scale 3 times smallest scale

* making image cropper property editor responsive

* scroll to scale

* adjust slider look

* rearrange parts of mediaentryeditor

* test helper

* styling

* move controls inside umb-image-crop

* seperate umg-cropper-gravity styling

* corrected layout

* more ui refinement

* keep the idea of mandatory out for now.

* remove double ;

* removed testing code

* JSON Property Value Convertor now has an array of property editors to exclude

* Property Value Convertor for Media Picker 3 aka Media Picker with Local Crops

* Experimenting on best approach to retrieve local crop in razor view when iterating over picked media items

* Update ValueConvertor to use ImageCropperValue as part of the model for views as alot of existing CropUrls can then use it

* Update extension methods to take an ImageCropperValue model (localCropData)

* Forgot to update CSProj for new ValueConvertor

* New GetCropUrl @Url.GetCropUrl(crop.Alias, media.LocalCrops) as oppposed to @Url.GetCropUrl(media.LocalCrops, cropAlias:crop.Alias, useCropDimensions: true)

* Remove dupe item in CSProj

* Use a contains as an opposed to Array.IndexOf

* various corrections, SingleMode based on max 1, remove double checkerBackground, enforce validation for Crops, changed error indication

* mediapicker v3

* correct version

* fixing file ext label text color

* clipboard features for MediaPicker v3

* highlight not allowed types

* highlight trashed as an error

* Media Types Video, Sound, Document and Vector Image

* Rename to Audio and VectorGraphics

* Add (SVG) in the name for Vector Graphics

* adding CSV to Documents

* remove this commented code.

* remove this commented code

* number range should not go below 0, at-least as default until we make that configurable.

* use min not ng-min

* description for local crops

* Error/Limits highlighting reactive

* visual adjustments

* Enabling opening filtered folders + corrected select hover states

* Varous fixes to resolve issues with unit tests.

* Refactor MediaType Documents to only contain Article file type

* mark as build-in

* predefined MediaPicker3 DataTypes, renaming v2 to "old"

* set scale bar current value after min and max has been set

* added missing }

* update when focal point is dragged

* adjusted styling for Image Cropper property editor

* correcting comment

* remove todo - message for trashed media items works

* Changed parameter ordering

* Introduced new extension method on MediaWithCrops to get croppings urls in with full path

* Reintroducing Single Item Mode

* use Multiple instead of SingleMode

* renaming and adding multiple to preconfigured datatypes

* Change existing media picker to use the Clipboard type MEDIA, enabling shared functionality.

* clean up unused clipboard parts

* adjusted to new amount

* correcting test

* Fix unit test

* Move MediaWithCrops to separate file and move to Core.Models

* parseContentForPaste

* clean up

* ensure crops is an array.

* actively enable focal points, so we dont set focal points that aren't used.

* only accept files that matches file extensions from Umbraco Settings

* Cleanup

* Add references from MediaPicker3 to media

* corrections from various feedback

* remove comment

* correct wording

* use windowResizeListener

Co-authored-by: Warren Buckley <warren@umbraco.com>
Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
Co-authored-by: Andy Butland <abutland73@gmail.com>
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
Co-authored-by: Sebastiaan Janssen <sebastiaan@umbraco.com>
Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
2021-04-22 10:28:53 +02:00
Niels Lyngsø
021c0b82c1 final corrections 2021-04-20 11:35:40 +02:00
Niels Lyngsø
eeb30db36d Merge remote-tracking branch 'origin/v8/bugfix/use-warning-message-style-when-saving' into v8/bugfix/always-ignorer-validation-when-saving
# Conflicts:
#	src/Umbraco.Web.UI.Client/src/common/directives/components/content/edit.controller.js
2021-04-20 11:16:20 +02:00
Niels Lyngsø
12cde0c571 Use warning style when saving 2021-04-20 11:10:07 +02:00
Sebastiaan Janssen
a3e3e83a3d Bump version to 8.13.0 2021-04-19 17:34:01 +02:00
Sebastiaan Janssen
f1e4fec4c4 Revert "The Value() method for IPublishedContent was not working with the defaultValue parameter (#9888)"
This reverts commit 52b670973d.
2021-04-19 17:31:53 +02:00
Sebastiaan Janssen
57ed4698f0 Revert "Revert "The Value() method for IPublishedContent was not working with the defaultValue parameter" (#9989)"
This reverts commit 156c1c9416.
2021-04-19 17:31:09 +02:00
Mole
0c3788eba1 Merge pull request #10061 from umbraco/v8/feature/AB10632-recycle-bin-smells-caching
RecycleBinSmells caching
2021-04-16 13:14:33 +02:00
Elitsa Marinovska
7d09de6d0f Removing unused param 2021-04-15 10:33:21 +02:00
Elitsa Marinovska
8e14543616 Merge remote-tracking branch 'origin/v8/dev' into v8/feature/AB10632-recycle-bin-smells-caching 2021-04-15 09:02:53 +02:00
Elitsa Marinovska
038afa5664 Fixing tests after adding the new event related to EmptiedRecycleBin 2021-04-15 09:00:58 +02:00
Elitsa Marinovska
2534f99cdb Adding new RecycleBin event handlers 2021-04-14 16:55:37 +02:00
Jeavon
c8b6841ef1 Allow KeepAlive controller Ping method to be requested by non local requests (#10126)
* Allow KeepAlive controller Ping method to be requested by non local requests and accept head requests

* removed unused references
2021-04-13 03:10:44 +02:00
Shannon Deminick
de4a7eff85 Fixes some property editors ensuring ngModelController(#10013)
Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
2021-04-12 15:19:32 +02:00
Niels Lyngsø
18fa631f1c use paste-resolvers (#10121)
Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
2021-04-12 14:38:52 +02:00
Niels Lyngsø
8d8fb2d15c Dont show block catalogue if only one block is available. Enable ente… (#9575)
* Dont show block catalogue if only one block is available. Enable entering clipboard directly.

* corrected button states

* jump clipboard icon when adding items to the clipboard.

* fix merge issue

* add missing eventsService

* correcting missing parts from Merge

Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
2021-04-12 12:27:12 +02:00
Dennis Öhman
4f49e57573 Removed top-margin from switcher icon 2021-04-12 02:29:05 +02:00
Carole Rennie Logan
3b6de9cb9e Updating typo 2021-04-10 02:47:49 +02:00
Rachel Breeze
e21cc6f97e Accessibility: Adding label fors and control ids for the macro picker (#10101)
* Added support for screeen reader alerts on the embed so that assitive technology knows when a url retrieve has been succesfull.
Added labels for the controls
Preview reload only triggered if the values for height and width change

* Added support for label fors for the macro picker and also gave the ,acro search box a title

* Now displays a count of the matching macros returned. Please note the language file amends shared with #10100

* Removed src-only class for the display of the count of messages
2021-04-10 02:34:18 +02:00
Sebastiaan Janssen
b0592f1126 Merge branch 'v8/dev' into v8/contrib 2021-04-07 16:27:34 +02:00
Sebastiaan Janssen
8c20e252dc Merge branch 'v8/8.13' into v8/dev 2021-04-07 16:26:48 +02:00
Sebastiaan Janssen
ecf67669ce Attributes could be multiple items, test specifically if Directory is an attribute 2021-04-07 16:25:46 +02:00
Sebastiaan Janssen
9fdbbb54fb Update cypress test to make macros in the grid work again 2021-04-07 15:44:28 +02:00