Commit Graph

36606 Commits

Author SHA1 Message Date
Bjarke Berg
ccc0e82579 #8919 - Avoid having fat controller and do not new up a controller in a model 2020-09-22 08:58:16 +02:00
Claus
6e56b16342 adding IconService 2020-09-22 08:57:48 +02:00
Claus
b327399cd2 adding icon svg data from IconController. 2020-09-22 08:11:58 +02:00
Bjarke Berg
525ca95acf uncomment SMTP info by default
Signed-off-by: Bjarke Berg <mail@bergmania.dk>
2020-09-22 08:01:04 +02:00
Shannon
e6e7917b0c fixes create button 2020-09-22 11:34:59 +10:00
Shannon
ac9dedf327 Ensure we don't swallow exceptions in angular when logging in, fixes a null ref in angular preventing login in authorize screen, fixes login screen to use an explicit ng-form instance. 2020-09-22 11:05:37 +10:00
Andy Butland
fe158ec7d9 Removed custom validation of configuration enum values, reverting to framework based validation when binding direct to the enum values. 2020-09-21 21:20:46 +02:00
Andy Butland
1bd22d72c2 Removed configuration model builders. 2020-09-21 21:06:24 +02:00
Andy Butland
574e4d6446 Reverted change to enum parse from string configuration value, as we can't avoid the property being evaluated before the validation has occurred. 2020-09-21 16:23:58 +02:00
Andy Butland
1a59d6a978 Created constants for all configuration sections and used this and nameof expressions for building up configuration validation error messages. 2020-09-21 16:23:12 +02:00
Mole
4917025327 Change some Microsoft.Extensions.Logging.ILogger to just ILogger 2020-09-21 15:34:22 +02:00
Warren Buckley
3950f3286e Merge pull request #8815 from umbraco/v8/bugfix/events-unsubscribe
Ensure event handlers are unsubscribed  in Core Components

(cherry picked from commit e7f98a5690)
2020-09-21 15:23:02 +02:00
Mole
5dae6235c5 Initialize ILoggerFactory in Current 2020-09-21 15:16:25 +02:00
Mole
3be396f384 Use Factory.GetInstance in Current 2020-09-21 15:12:14 +02:00
Mole
5c9a681566 Use typed logger for XmlPublishedSnapshotService 2020-09-21 15:11:40 +02:00
Mole
d512a43ba6 Make majority of unit tests pass 2020-09-21 14:35:28 +02:00
Mole
ed30cd1800 Remove ILogger and its classes implementing it 2020-09-21 13:09:48 +02:00
Mole
d3ae921293 Remove most of the last references and rename LoggerFactory_ to LoggerFactory in UmbracoTestBase 2020-09-21 13:04:57 +02:00
Warren Buckley
e7f98a5690 Merge pull request #8815 from umbraco/v8/bugfix/events-unsubscribe
Ensure event handlers are unsubscribed  in Core Components
2020-09-21 11:27:47 +01:00
Andy Butland
cce091de74 Throw exception on unexpected failure of creation on enum value from configuration, rather than falling back to a default.
This shouldn't happen in practice due to the configuration validation (e.g. by ContentSettingsValidator), so any failure of parsing here should be considered an exception.
2020-09-21 12:04:30 +02:00
Mole
581775e08c Remove public ILogger from PluginController
Having a public ILogger doesn't align with MS ILogger, and the logger is never used
2020-09-21 11:46:29 +02:00
Mole
a12ea89517 Use MS Ilogger in ExamineExtensions 2020-09-21 11:43:09 +02:00
Mole
dfd5f991a6 Use Ms ILogger in LogProfiler allowing us to delete ConsoleLogger 2020-09-21 11:30:16 +02:00
Mole
a679a1d2c4 Remove unused NullLogger 2020-09-21 11:22:32 +02:00
Mole
ab3ac5ad91 Remove a bunch of references to the old logger 2020-09-21 11:19:46 +02:00
Andy Butland
e032af5b06 Fixed failing tests. 2020-09-21 10:04:34 +02:00
Mole
894abdd183 Remove a bunch of references to the old logger 2020-09-21 09:41:18 +02:00
Andy Butland
903e964925 Set default value for SmtpSettings DeliveryMethod configuration. 2020-09-21 08:54:03 +02:00
Andy Butland
309d39a34f Set default models builder config to nothing now have fixed issue that prevented it loading (as previous value of pure live currently erroring). 2020-09-21 08:54:03 +02:00
Andy Butland
d55b54ce49 Added unit tests for introduced unit test configuration setting builders. 2020-09-21 08:54:03 +02:00
Andy Butland
d5d6082d07 Moved configuration settings builders into own folder. 2020-09-21 08:54:03 +02:00
Andy Butland
8aadbe02d6 Added unit tests for configuration validators. 2020-09-21 08:54:03 +02:00
Andy Butland
bae4f2fb53 Changed NuCache settings to use a nullable integer. 2020-09-21 08:54:03 +02:00
Andy Butland
41c7f6989a Made config files alphabetical and aligned spacing. 2020-09-21 08:54:03 +02:00
Mole
8ff33e3cd0 Use LoggerFactory in UmbracoController instead of global ILogger 2020-09-21 08:29:44 +02:00
Mole
30d4233565 Use MS Ilogger in LocalizedTextService 2020-09-21 08:19:26 +02:00
Mole
7ad8cd2bf8 Use loggerfactory in both constuctors in UmbracoDatabaseFactory 2020-09-21 08:03:27 +02:00
Mole
20e12c7596 Use MS ILogger in Services 2020-09-18 15:27:38 +02:00
Mole
a3d74bb79f Remove public Logger from DataEditor
It was only used one place where it shouldn't be used
2020-09-18 14:45:22 +02:00
Mole
578e8c4f9e Use MS ILogger for DataEditor 2020-09-18 14:37:19 +02:00
Andy Butland
b9e67dde55 Added configuration validation for models builder and hosting settings.
Renamed models builder config class suffix to match others.
2020-09-18 12:53:10 +02:00
Mole
d61b9f54fa Merge options 2020-09-18 12:53:06 +02:00
Andy Butland
eb62789b68 Added configuration validation for content imaging settings. 2020-09-18 12:02:12 +02:00
Andy Butland
1f8d7f18be Added configuration validation for content and request handler settings. 2020-09-18 11:30:26 +02:00
berg
f6f0687bf8 fix in syntax after merge
Signed-off-by: berg <mail@bergmania.dk>
2020-09-18 09:11:16 +02:00
Mole
df7617ec98 Register NullLogger in ComponentTests 2020-09-18 08:39:38 +02:00
berg
a2a5e25713 Merge remote-tracking branch 'origin/netcore/netcore' into netcore/feature/use-serilog-to-log-all-messages
Signed-off-by: berg <mail@bergmania.dk>
2020-09-18 08:34:20 +02:00
berg
f11391961f Merge remote-tracking branch 'origin/netcore/netcore' into netcore/feature/use-serilog-to-log-all-messages
# Conflicts:
#	src/Umbraco.Tests.Integration/TestServerTest/UmbracoBuilderExtensions.cs
#	src/Umbraco.Web.Common/Extensions/UmbracoCoreServiceCollectionExtensions.cs
#	src/Umbraco.Web/UmbracoApplicationBase.cs
2020-09-18 08:31:09 +02:00
Bjarke Berg
d7ab7d3d2e Removed test code
Signed-off-by: Bjarke Berg <mail@bergmania.dk>
2020-09-18 08:30:48 +02:00
Bjarke Berg
81f670f10a Merge remote-tracking branch 'origin/netcore/netcore' into netcore/feature/AB8239-nuget-updates 2020-09-18 08:24:29 +02:00