Commit Graph

10518 Commits

Author SHA1 Message Date
Daniël Knippers
5a5291d149 V8/feature/ab4550 segments ui variant picker (#7676)
* Fixes incorrect property inheritance logic

* Fixes crash in canVariantPublish when variant.language is null

* Adds variant display name in dropdown

* Logic for invariant properties updated to also support segment invariance

* Properties varied by segment only now properly saved when multiple variants are saved/published

* Logic for disabling property editors moved to function and corrected for all cases of culture/segment properties

* Fixes syntax error in less file

* Fixes empty variants returned from GetEmpty() for a ContentType set to vary by segment

* Replaced _.each with _.find to prevent having to loop through all variants and/or somehow open multiple.

It is not possible to break out of _.each using a return statement, it simply returns that current function
but _.each will continue calling the others after that.

* Added a null check on Culture prop which is now possibly null due to segments

* Makes sure segments are not completely removed when their value is null.

During save/publish, Umbraco first deletes all property data of a specific version
and then adds property values again. However, any segments that were created but had
an empty value would not be added again which meant the segments were entirely gone afterwards.

* GetSegments() updated to always return the default segment, not only when there are no segments at all.

This makes sure that even if there is no property data for the default segment in the database but only for
some segments, the default segment will still be returned here.
2020-02-18 11:46:31 +01:00
Niels Lyngsø
23b0a30db2 clean up + validation limit range 2020-02-18 10:07:58 +01:00
Poornima Nayar
a9bb1ff49e Merge pull request #7021 from stevemegson/v8/pr/member-cmsContentNu
OnMemberRefreshedEntity stores data as published rather than edited
2020-02-17 15:26:48 +00:00
Daniël Knippers
1a4e6e564c Review Perplex change for Segments (#7659)
* Fixes incorrect property inheritance logic

* Fixes crash in canVariantPublish when variant.language is null

* Adds variant display name in dropdown

* Logic for invariant properties updated to also support segment invariance

* Properties varied by segment only now properly saved when multiple variants are saved/published

* Logic for disabling property editors moved to function and corrected for all cases of culture/segment properties

* Fixes syntax error in less file

* Fixes empty variants returned from GetEmpty() for a ContentType set to vary by segment
2020-02-14 15:16:50 +01:00
Niels Lyngsø
42ab969725 numberrange prevalue editor 2020-02-13 12:38:07 +01:00
Paul Seal
69a1729967 Change the icon in the Document Types Tree to be the chosen icon instead of a default one. (#7358)
* - changed the icon in the document types tree to be the icon chose rather than the default doc type icon

* - rendered icons for media types and member types

* - used null coalescing for icon setting for better null handling

Co-authored-by: paulmoriyama <48755798+paulmoriyama@users.noreply.github.com>
2020-02-13 08:07:46 +00:00
Niels Lyngsø
bc1f5f2086 Initial work on Block List Prevalue Editor 2020-02-12 17:17:04 +01:00
abi
a7ad464b40 Remove Empty Statements 2020-02-12 15:11:18 +01:00
Shannon
7182be93d9 Ensures that we don't set IsChildOfListView when it's a user's start node since we are actually rendering that tree node when that is the case 2020-02-12 13:47:48 +11:00
Shannon
8dc9d4ace4 Updates c# ShouldRenderChildrenOfContainer to allow for nested list views 2020-02-12 11:44:57 +11:00
Benjamin Carleski
c63af8e161 Merge pull request #7616 from umbraco/temp-7538-image-url-generator
Introduce Image URL Generator abstraction
2020-02-11 10:30:48 -08:00
Bjarke Berg
ad8d908ddf Merge pull request #7550 from stevetemple/v8/feature/obsolete-publishedcontent-url
Obsolete Url on IPublishedContent
2020-02-11 13:09:46 +01:00
Bjarke Berg
3c1076e023 Merge pull request #7544 from stevetemple/v8/feature/obsolete-creatorname-writername
Obsolete CreatorName and WriterName on IPublishedContent
2020-02-11 13:08:15 +01:00
Niels Lyngsø
9733c64b20 Merge remote-tracking branch 'origin/v8/dev' into v8/feature/block-editor-list 2020-02-11 12:42:52 +01:00
emma burstow
c5ddba47a8 Update SetUmbracoVersionStep.cs
Punctuation fix
2020-02-10 20:21:35 +01:00
Niels Lyngsø
0b730968ed get and set AllowSegmentVariant 2020-02-10 14:39:05 +01:00
Niels Lyngsø
87b9642d1a Merge branch 'v8/feature/AB4550-segments-clientcode' into v8/feature/AB4550-segments-ui-variant-picker 2020-02-10 11:34:29 +01:00
Daniël Knippers
124bc27921 V8/feature/ab4550 segments ui variant picker (#7614)
* Fixes incorrect property inheritance logic

* Fixes crash in canVariantPublish when variant.language is null

* Adds variant display name in dropdown

* Logic for invariant properties updated to also support segment invariance

* Properties varied by segment only now properly saved when multiple variants are saved/published

* Logic for disabling property editors moved to function and corrected for all cases of culture/segment properties

* Fixes syntax error in less file
2020-02-10 09:16:03 +01:00
Benjamin Carleski
4309489174 Make changes for PR suggestions 2020-02-09 11:12:29 -08:00
Benjamin Carleski
7e7d38e74b Add ImageUrlGeneratorController 2020-02-08 16:49:12 -08:00
Benjamin Carleski
408ee452e1 Code cleanup, added unit tests 2020-02-08 11:05:14 -08:00
Benjamin Carleski
a7ff20de6e Introduce Image URL Generator abstraction 2020-02-07 15:01:03 -08:00
Sebastiaan Janssen
d285d40578 That safeguard unfortunately broke all the tests 2020-02-06 17:52:36 +01:00
Sebastiaan Janssen
fbd95f1c8e Fixes problem with #7530 where UmbracoContext is empty when HtmlImageSourceParser gets initialized 2020-02-06 15:10:05 +01:00
Niels Lyngsø
555be8dd0a first part of enabling allow segments 2020-02-06 12:47:50 +01:00
Shannon
45e892f350 Changes api to GetData 2020-02-06 16:52:34 +11:00
Shannon
3d0543922a un-breaks ctor 2020-02-03 22:48:00 +11:00
Shannon
9f0becaf52 Adds another test to show how to access the data block from a layout element 2020-02-03 18:31:18 +11:00
Shannon
c39c81914e Merge branch 'v8/feature/block-editor-list' into v8/feature/AB2207-block-list-models
# Conflicts:
#	src/Umbraco.Web/PropertyEditors/BlockListPropertyEditor.cs
2020-02-03 16:58:16 +11:00
Shannon
3f3ff3c4b5 Merge branch 'v8/dev' into v8/feature/block-editor-list 2020-02-03 16:52:48 +11:00
Shannon
a23f93c557 Gets the block list property value converter tests running and written 2020-02-03 16:45:54 +11:00
Robert Foster
a3bf9d2a51 Renamed "DermineIsChildOfListView" to "DetermineIsChildOfListView" 2020-02-02 13:00:40 +01:00
Steve Temple
a8672790d3 Obsolete Url on IPublishedContent 2020-02-01 13:38:14 +00:00
Steve Temple
6b46167180 In GetDataTable use Obsolete CreatorName and WriterName for now 2020-01-31 14:40:37 +00:00
Steve Temple
b95d674092 Tidy up formatting 2020-01-31 09:50:37 +00:00
Steve Temple
377f1925ea Obsolete CreatorName and WriterName on IPublishedContent 2020-01-31 09:34:08 +00:00
Shannon
292c76df0b Getting models and value converter setup along with tests 2020-01-31 15:59:27 +11:00
Kenn Jacobsen
0a89fcc248 V8: Ensure consistent template file casing no matter how templa… (#4889)
Thanks Kenn! Wonderful, as ever
2020-01-30 16:06:15 +00:00
emma burstow
c7cceedbd6 Merge branch 'v8/contrib' into pr/5917 2020-01-30 10:50:47 +00:00
Aleksandr Šmailov
537674a0b3 Improve RTE performance when using base64 images (#7530) 2020-01-29 08:53:08 +01:00
Lars-Erik Aabech
af7f03e1f7 Don't downcast IPublishedSnapshot unnecessarily in PublishedContent 2020-01-28 22:28:54 +01:00
Nathan Woulfe
902d4196cf add dialog for change password, shift form from user details view int… (#7450) 2020-01-27 06:29:04 +01:00
Niels Lyngsø
d9b0916ca7 Merge remote-tracking branch 'origin/v8/dev' into v8/feature/block-editor-list 2020-01-24 13:35:37 +01:00
Sebastiaan Janssen
d45ef632f1 Merge branch 'v8/dev' into v8/contrib 2020-01-24 09:01:37 +01:00
Bjarke Berg
fd11ef6ed1 Merge pull request #7306 from umbraco/v8/bugfix/AB3323-SqlMainDom
Introduce a new IMainDomLock and both default and sql implementations
2020-01-23 12:44:11 +01:00
Poornima Nayar
df8f281141 Merge pull request #7045 from ronaldbarendse/v8/bugfix/nested-content-defaultpropertyvalueconverters
Add DefaultPropertyValueConverterAttribute to core Nested Content PropertyValueConverters
2020-01-23 11:26:13 +00:00
Shannon Deminick
238db1c908 Merge pull request #7430 from ronaldbarendse/v8/bugfix/enum-extensions
Clean up EnumExtensions
2020-01-23 15:03:51 +11:00
Bjarke Berg
db27090ac0 Merge pull request #7233 from umbraco/v8/bugfix/6758-nucache-fix
When nucache updates are made the previous Gen root node is cleared
2020-01-22 11:13:43 +01:00
Ronald Barendse
b01f2ed35e Merge remote-tracking branch 'upstream' into v8/bugfix/enum-extensions 2020-01-22 11:04:11 +01:00
Bjarke Berg
1dfdfba236 Merge remote-tracking branch 'origin/v8/dev' into v8/bugfix/AB3323-SqlMainDom 2020-01-22 09:39:06 +01:00