Commit Graph

41051 Commits

Author SHA1 Message Date
Paul Johnson
576f90ad37 Speedup codeql run (#11877)
* Speedup codeql run

* npm build once, ignore node_modules

* Misc cleanup
2022-01-18 00:35:53 +00:00
Paul Johnson
9a145537aa Fix config file, should be on init 2022-01-17 22:29:42 +00:00
Paul Johnson
c410f78986 Restore config file and prevent duplicate run for feature branches 2022-01-17 21:41:24 +00:00
Paul Johnson
2c44d67686 Modify codeql setup. (#11876) 2022-01-17 14:42:41 +00:00
Nikolaj Geisle
0e9525d216 Added null check 2022-01-17 08:32:13 +01:00
Søren Kottal
8cd0e5a003 Change logmessages 2022-01-16 13:42:57 +01:00
Erik-Jan Westendorp
ee1153ee56 Localization: Translate history cleanup labels/descriptions to Dutch (#11835)
* Update nl.xml to show labels in dutch in info content app

* Update nl.xml to show labels in dutch in permissions app
2022-01-16 12:33:49 +01:00
Erik-Jan Westendorp
294ea7373e Localization: Rename RelatieTypen to RelatieTypes (Dutch) (#11849)
* Change RelatieTypen to RelatieTypes

* Small 't'
2022-01-16 12:13:17 +01:00
Erik-Jan Westendorp
73e99b75b2 Add missing read more translation (#11850) 2022-01-16 05:36:45 +01:00
Mole
0eed641235 Delete temp document type file if validation fails (#11836)
Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
2022-01-13 13:12:44 +01:00
Bjarke Berg
baba7ffed9 Bugfix - Take ufprt from form data if the request has form content type, otherwise fallback to use the query (#11845) 2022-01-12 13:54:14 +01:00
Bjarne Fyrstenborg
eb4acba081 Set default tree group for core trees (#11801)
Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
2022-01-12 12:35:48 +01:00
Nikolaj Geisle
18a3133536 v9: Fix max allowed content length on iis & kestrel (#11802)
* Update web.config

* Change web.config to align with v8 default values

* Adjust kestrel options to align with v8

* Add better comment

* added web.config to root

* change web.config to 30mb

* delete obsolete comment

* No reason to have web.config to just have it default

* Add back ConfigureIISServerOptions.cs

* Add obsolete comment, can't link to documentation yet as it doesn't exist

* Apply suggestions from code review

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>

* Add link to documentation

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
2022-01-12 12:32:53 +01:00
Paul Johnson
d9bdd8196c Misc/obsolete redundant extension (#11838)
* Mark AddUnique<TImplementing> obsolete.

* Remove all internal usages of AddUnique<TImplementing>.
2022-01-10 17:03:33 +01:00
Paul Johnson
a952d17e74 Make using scoped services in notification handlers less painful. (#11733)
* Add failing test to demo issue with handlers + scoped dependencies.

* Make using scoped services in notification handlers less painful.

* Update comments for accuracy.
2022-01-10 15:31:46 +00:00
Ronald Barendse
2155062678 Prune/remove indentation from JSON property values (#11806)
* Use Formatting.None for JSON property data in default value editor

* Use Formatting.None for JSON property data in custom value editors

* Use Formatting.None for JSON property data in Nested Content and Block List

* Use Formatting.None for JSON property tags

* Use Formatting.None for JSON configuration data

* Use Formatting.None in custom JSON converter

* Ensure empty tags and complex editor values are not stored

* Fix NestedContentPropertyComponentTests

* Do not store empty property data

* Use Formatting.None and don't store configured crops (without coordinates)

* Fix JSON deserialization of tags value
2022-01-10 09:32:29 +01:00
Nikolaj Geisle
187cac469e Add package tests (#11824) 2022-01-07 08:55:40 +01:00
Bjarke Berg
642c216f94 Serve Media and App_Plugins using WebRootFileProvider (and allow changing the physical media path) (#11783)
* Allow changing UmbracoMediaPath to an absolute path. Also ensure Imagesharp are handing requests outside of the wwwroot folder.

* Let UmbracoMediaUrl fallback to UmbracoMediaPath when empty

* Add FileSystemFileProvider to expose an IFileSystem as IFileProvider

* Replace IUmbracoMediaFileProvider with IFileProviderFactory implementation

* Fix issue resolving relative paths when media URL has changed

* Remove FileSystemFileProvider and require explicitly implementing IFileProviderFactory

* Update tests (UnauthorizedAccessException isn't thrown anymore for rooted files)

* Update test to use UmbracoMediaUrl

* Add UmbracoMediaPhysicalRootPath global setting

* Remove MediaFileManagerImageProvider and use composited file providers

* Move CreateFileProvider to IFileSystem extension method

* Add rooted path tests

Co-authored-by: Ronald Barendse <ronald@barend.se>
2022-01-06 13:35:24 +01:00
Nikolaj Geisle
d5ba5be096 Merge pull request #11386 from matthewcare/temp-11381
Request Handler Settings for character replacement
2022-01-05 14:56:11 +01:00
Nikolaj Geisle
dfc3e56eb7 Check if we're in debug and set IncludeErrorPolicy accordingly 2022-01-05 13:16:07 +01:00
Ronald Barendse
75bb8051bf Prune Image Cropper and Media Picker (v3) values (#11805)
* Clean up redundant/default Umbraco.ImageCropper data

* Fix ToString() and add HasCrops() method

* Re-use crop/focal point pruning for Umbraco.MediaPicker3

* Fix ImageCropperTest

Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
2022-01-05 11:11:27 +01:00
Mole
a54c5bb21d V8: Merge package telemetry from V9 (#11785)
* Merge Telemetry classes from V9

* Use TelemetryService in ReportSiteTask

* Migrate tests
2022-01-04 10:11:34 +01:00
Ronald Barendse
763cb70e67 Move member properties to Member Content App (V9 merge regression) (#11768)
* Fix regression after merging to v9

* Update test to align with removed member properties
2022-01-04 08:21:58 +01:00
Mole
65c0d8fcec V9: Use current request for emails (#11778)
* Use request url for email

* Fixed potential null ref exceptions

Co-authored-by: Bjarke Berg <mail@bergmania.dk>
2022-01-04 08:18:01 +01:00
Mole
bbfa975096 Bump versions to non-rc 2022-01-03 15:36:52 +01:00
Nikolaj Geisle
421faf8d43 Fix assignDomain to handle case sensitive operating systems (#11784) 2022-01-03 15:33:32 +01:00
Nikolaj Geisle
84fea8f953 Fix assignDomain to handle case sensitive operating systems (#11784) 2022-01-03 15:07:44 +01:00
Bjarne Fyrstenborg
be8e7b285b Fix incorrect styling of actions in tags editor 2021-12-30 03:11:31 +01:00
Bjarne Fyrstenborg
025db57b03 Fix issue with missing URLs shown in redirect management 2021-12-30 02:49:03 +01:00
Søren Kottal
fad0c948a1 Makes the width of .login-overlay__logo dynamic 2021-12-28 02:33:57 +01:00
Mole
04d20269ab Merge CharCollection and UserDefinedCharCollection
Otherwise only CharCollection would work, and that's obsolete, now you can use either, but UserDefinedCharCollection takes priority
2021-12-22 13:04:40 +01:00
Nikolaj Geisle
bc6d8b5ece v9: Throw error on duplicate routes (#11774)
* Add conflicting route service and check

* Added testclass

* Cleanup

* Update src/Umbraco.Web.BackOffice/Services/ConflictingRouteService.cs

Co-authored-by: Elitsa Marinovska <21998037+elit0451@users.noreply.github.com>

* Implemented out variable

Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
Co-authored-by: Elitsa Marinovska <21998037+elit0451@users.noreply.github.com>
2021-12-22 13:03:38 +01:00
Mole
53e5a25df8 Remove ugly CharCollection hack
By adding a new configuration and mapping the old CharCollection to that, we can get around having to return null the first time, by obsoleting the old one and redirecting to the new GetCharReplacements method
2021-12-22 11:29:04 +01:00
Nikolaj Geisle
380b70046f Merge pull request #11753 from SpringIT/v9/bugfix/incorrect-import-document-url-casing
Fix incorrect camelcasing for import document type
2021-12-22 10:05:16 +01:00
Andy Butland
1af09c7f13 Updates Forms and adds Deploy JSON schema. (#11739) 2021-12-21 15:19:55 +01:00
Mole
c6d28f01a8 Check for null in DefaultShortStringHelperConfig.WithDefault 2021-12-21 15:15:53 +01:00
Mole
040116c004 Remove TODO
With some testing this seems to be a none-issue, since we don't operate on the keys themselves
2021-12-21 14:48:56 +01:00
Nikolaj Geisle
76cf5037e5 v9: Move local xml package files to database instead (#11654)
* Move package to database

* Added migration and implemented new repository

* Updated migrations to use proper xml convert

* Fixed save function and renamed createDate to update date

* Updated dependencyInjection

* Updated UmbracoPlan.cs

* Apply suggestions from code review

Co-authored-by: Elitsa Marinovska <21998037+elit0451@users.noreply.github.com>

* Added File check

* Tried using same context as create table

* Fix DTO

* Fix GetById and local package saving

* Fix images when migrating

* Implement deletion of all local files

* Only delete local repo file, not file snapshots

* Remove static package path and use the one we save

* Update package repo to export package and remove check for ids when exporting

* Minor fixes

* Fix so that you can download package after creating

* Update savePackage method to export package afterwards

Co-authored-by: Nikolaj Geisle <niko737@edu.ucl.dk>
Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
Co-authored-by: Elitsa Marinovska <21998037+elit0451@users.noreply.github.com>
2021-12-21 14:02:49 +01:00
Mole
80cda3364b Make CharCollection return the merged result
Since this is the way it's been previously, we cannot change the behaviour of this. Unfortunately due to how the config binding works, we have to make sure it returns null the very first time it's called by the framework to ensure that overrides actually gets registered.
2021-12-21 13:35:30 +01:00
Bjarke Berg
4abace7e51 Merge remote-tracking branch 'origin/v9/9.2' into v9/dev 2021-12-21 12:54:53 +01:00
Elitsa Marinovska
0ea5f6a02c Adding UmbracoApplicationUrlCheck "Read more" URL 2021-12-21 12:50:44 +01:00
Elitsa Marinovska
be53ccf1fd Implement #11776 for v9 2021-12-21 12:50:25 +01:00
Mole
72d9f56478 V9: Use current request for emails (#11778)
* Use request url for email

* Fixed potential null ref exceptions

Co-authored-by: Bjarke Berg <mail@bergmania.dk>
2021-12-21 12:48:35 +01:00
Nikolaj Geisle
65c0039656 Merge pull request #11779 from umbraco/v9/feature/AB15639-umbracoApplicationUrl-healthcheck
V9: Add a health check for umbraco application url
2021-12-21 12:15:07 +01:00
Mole
6147375a3e Return CharItem instead of IChar from CharCollection
On second thought this is not a breaking change since CharItem implements IChar, so you could still do something lke IEnumerable<IChar> chars = requestHandlerSettings.CharCollection
2021-12-21 11:56:33 +01:00
Nikolaj Geisle
bd1c392dff Merge pull request #11776 from umbraco/v8/bugfix/AB15639-umbracoApplicationUrl-healthcheck
Add a health check for umbraco application url
2021-12-21 11:35:41 +01:00
Sebastiaan Janssen
4240f89534 Adds migration back for v9 for #10450 (#11769) 2021-12-21 11:15:57 +01:00
Mole
d77e198d31 Move unit test to the new location 2021-12-21 10:44:36 +01:00
Mole
338bbdd382 Reintroduce IChar interface
Removing a public interface is a breaking change, in case someone is implementing the interface for some reason.
2021-12-21 10:36:25 +01:00
Mole
8a8b1e3247 Rename CharacterReplacement back to CharItem
Since the class is public renaming this would be a breaking change, since if anyone is directly referring to the class it would break
2021-12-21 10:30:19 +01:00