Commit Graph

168 Commits

Author SHA1 Message Date
Sebastiaan Janssen
c6832491b6 Merge branch 'v8/contrib' into v8/dev
# Conflicts:
#	src/Umbraco.Web.UI.Client/src/views/prevalueeditors/obsoletemediapickernotice.html
2021-06-28 09:34:26 +02:00
Warren Buckley
dc334c1015 Automated install user with Environment Variables & unattended.user.json (#9930)
* Try to update admin user unattended

This will fail because we're not in install runtime state

* Create a new user instead of trying to update the default admin

* Create a new user instead of trying to update the default admin

* Use same logic from NewInstallStep to modify the SuperUser aka -1

* Add back stuff after merge conflict from v8/dev

* Add event to be raised

* Trying to wire up events

* Remove commented out code - just need to figure out why event is not hit/triggered

* Read Appsettings as opposed to ENV variables

* Use a JSON file that deletes itself as storing secrets in web.config will be accidently committed

* Remove component based event - Component were only initialized after DB creation

* Move UnattendedInstall down after _factory

* Remove commented out code

* Fixed issue where upgrader UI would show up - needed to recheck the Runtimelevel after UnattenedInstall

* Apply suggestions from code review - Thanks Marc :)

Co-authored-by: Marc Goodson <marc@moriyama.co.uk>

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Marc Goodson <marc@moriyama.co.uk>
2021-06-16 10:00:29 +01:00
Chad
98d8971ce9 Merge in v8/contrib to V8/feature/nucache perf sync (#10151)
* Bump version to 8.6.8

* Initial rework of Lock dictionaries

* [Issue 5277-146] accessibility - Close 'X' icon next to language drop… (#9264)

* [Issue 5277-146] accessibility - Close 'X' icon next to language drop down is identified as "link" - screen reader

* add new loacalization key

* Fix issue with SqlMainDomLock that cannot use implicit lock timeouts … (#9973)

* Fix issue with SqlMainDomLock that cannot use implicit lock timeouts … (#9973)

(cherry picked from commit da5351dfcf)

* Adjust unit tests and apply fixes to scope

* Add more unit tests, showing current issue

* Counting Umbraco.ModelsBuilder and ModelsBuilder.Umbraco namespaces as external providers

* Fix dead lock with TypeLoader

* Fix errors shown in unit tests

* Throw error if all scopes hasn't been disposed

* Clean

* Fixes and Updates for DB Scope and Ambient Context leaks (#9953)

* Adds some scope tests (ported back from netcore) and provides a much better error message, ensure execution context is not flowed to child tasks that shouldn't leak any current ambient context

* updates comment

* Ensure SqlMainDomLock suppresses execution context too

* Since we're awaiting a task in a library method, ConfigureAwait(false)

* missing null check

Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>

* Adds additional error checking and reporting to MainDom/SqlMainDomLock (#9954)

Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>

* Add copy logic to Media Picker (#9957)

* Add copy logic to Media Picker

* Add action for copy all

* Fix for selectable media item

* Wrap calls to map in scopes

* Autocomplete scopes

* Remove unnecessary aria-hidden attribute from <umb-icon>

* Remove scope from method that calls another method that has a scope

* Fixes #9993 - Cannot save empty image in Grid

* Clean

* Revert "The Value() method for IPublishedContent was not working with the defaultValue parameter" (#9989)

* Use a hashset to keep track of acquired locks

This simplifies disposing/checking for locks greatly.

* Add images in grid - fixes 9982 (#9987)

Co-authored-by: Sebastiaan Janssen <sebastiaan@umbraco.com>

* Only create the dicts and hashset when a lock is requested

* Clean

* Adds a config for configuring the access rules on the content dashboard - by default it granted for all user groups

* Adds additional params indicating whether user is admin

* Add images in grid - fixes 9982 (#9987)

Co-authored-by: Sebastiaan Janssen <sebastiaan@umbraco.com>
(cherry picked from commit e2019777fb)

* Bump version to 8.12.2

* #9964 Removed unneeded check for HttpContext

* Fix for #9950 - HttpsCheck will now retry using the login background image if inital request returns 301/302. Excessvie Headers check will now check the root url instead of the backoffice

* Merge pull request #9994 from umbraco/v8/bugfix/9993

Fixes #9993 - Cannot save empty image in Grid

(cherry picked from commit 0ecc933921)

* Apply suggestions from review

* Fixes #9983 - Getting kicked, if document type has a Umbraco.UserPicker property (#10002)

* Fixes #9983

Temporary fix for this issue. using the entityservice like before.

* Needed to remove the call to usersResource here as well for displaying the picked items

* Don't need usersResource for now

* Fixes #9983 - Getting kicked, if document type has a Umbraco.UserPicker property (#10002)

* Fixes #9983

Temporary fix for this issue. using the entityservice like before.

* Needed to remove the call to usersResource here as well for displaying the picked items

* Don't need usersResource for now

(cherry picked from commit 45de0a101e)

* 8539: Allow alias in image cropper (#9266)

Co-authored-by: Owain Williams <owaingdwilliams@gmail.com>

* Wrap dumping dictionaries in a method.

* Create method for generating log message

And remove forgotten comments.

* Fix swedish translation for somethingElse.

* Copy member type (#10020)

* Add copy dialog for member type

* Implement copy action for member type

* Create specific localization for content type, media type and member type

* Handle "foldersonly" querystring

* Add button type attribute

* Add a few missing changes of anchor to button element

* Null check on scope and options to ensure backward compatibility

* Improve performance, readability and handling of FollowInternalRedirects (#9889)

* Improve performance, readability and handling of FollowInternalRedirects

* Logger didn't like string param

Passing string param to _logger.Debug<PublishedRouter, int> wasn't happy. Changed to pass existing internalRedirectAsInt variable.

Co-authored-by: Nathan Woulfe <nathan@nathanw.com.au>

* Update casing of listview layout name

* 9097 add contextual password helper (#9256)

* update back-office forms

* Display tip on reset password page as well

* add directive for password tip

* integrate directove in login screen

* forgot the ng-keyup :-)

* adapt tooltip directive to potential different Members and Users password settings

* remove watcher

Co-authored-by: Nathan Woulfe <nathan@nathanw.com.au>

* Unbind listener

Listening for splitViewRequest was only unbound if the split view editor was opened. Not cleaning up the listener caused a memory leak when changing between nodes as the spit view editor was detached but not garbage-collected

* Replace icon in date picker with umb-icon component (#10040)

* Replace icon in date picker with <umb-icon> component

* Adjust height of clear button

* Update cypress and fix tests

* Listview config icons (#10036)

* Update icons to use <umb-icon> component

* Simplify markup and use disabled button

* Use move cursor style on sortable handle

* Add class for action column

* Update setting auto focus

* Increase font size of umb-panel-header-icon

* Anchor noopener (#10009)

* Set rel="noopener" for anchors with target="_blank"

* Reverted unwanted changes to Default.cshtml

* Align 'Add language' test to netcore

* Add new cypress tests

* Add indentation

* Getting rid of the config file and implementing an appSetting instead

* Implementation for IContentDashboardSettings

* Cleanup

* bool.Try

* Taking AllowContentDashboardAccessToAllUsers prop from GlobalSettings to ContentDashboardSettings and saving AccessRulesFromConfig into a backing field

* Handling multiple values per field in Examine Management

* Add Root<T> and Breadcrumbs extension methods for IPublishedContent (#9033)

* Fix usage of obsolete CreatorName and WriterName properties

* Add generic Root extension method

* Add Breadcrumbs extension methods

* Orders member type grouping of members alphabetically, matching the listing of member types.

* Revert updating deprecated WriterName/CreatorName refs

Changing the properties to use the extensions is a good thing (given the props are deprecated), but causes issues deep in tests. I'm reverting that change to fix the tests, and all refs to the deprecated properties should be updated in one sweep, to deal with any other test issues that might crop up.

* Handle Invalid format for Upgrade check

* Fixes tabbing-mode remains active after closing modal #9790 (#10074)

* Allow to pass in boolean to preventEnterSubmit directive (#8639)

* Pass in value to preventEnterSubmit directive

* Set enabled similar to preventDefault and preventEnterSubmit directives

* Update prevent enter submit value

* Init value from controller

* Use a different default input id prefix for umb-search-filter

* Fix typo

* Check for truthly value

* Revert "Set enabled similar to preventDefault and preventEnterSubmit directives"

This reverts commit 536ce855c4545ead82cea77b4013bf9010a8687b.

* None pointer events when clicking icon

* Use color variable

* Fixes tabbing-mode remains active after closing modal #9790 (#10074)

(cherry picked from commit c881fa9e7d)

* Null check on scope and options to ensure backward compatibility

(cherry picked from commit fe8cd239d2)

* Fix validation of step size in integer/numeric field

* 9962: Use $allowedEditors instead of allowed (#10086)

* 9962: Use $allowedEditors instead of allowed

* 9962: Remove redundant statement

* fixes #10021 adds ng-form and val-form-manager to the documentation

* Improved accessibility of link picker (#10099)

* Added support for screeen reader alerts on the embed so that assitive technology knows when a url retrieve has been succesfull.
Added labels for the controls
Preview reload only triggered if the values for height and width change

* Added control ids for the link picker

* Add French translation

* Accessibility: Alerts the user how many results have been returned on a tree search (#10100)

* Added support for screeen reader alerts on the embed so that assitive technology knows when a url retrieve has been succesfull.
Added labels for the controls
Preview reload only triggered if the values for height and width change

* Tree search details the number of search items returned

* Add French translations

* Updated LightInject to v6.4.0

* Remove HtmlSanitizer once more - see #9803

* Also make sure NuGet installs the correct version of the CodePages dependency

* Bump version to 8.13 RC

* Fixed copy preserving sort order (#10091)

* Revert "Updated LightInject to v6.4.0"

This reverts commit fc77252ec7.

* Revert "Add copy logic to Media Picker (#9957)"

This reverts commit f7c032af65.

* Reintroduce old constructor to make non-breaking

* Update cypress test to make macros in the grid work again

* Attributes could be multiple items, test specifically if `Directory` is an attribute

* Accessibility: Adding label fors and control ids for the macro picker (#10101)

* Added support for screeen reader alerts on the embed so that assitive technology knows when a url retrieve has been succesfull.
Added labels for the controls
Preview reload only triggered if the values for height and width change

* Added support for label fors for the macro picker and also gave the ,acro search box a title

* Now displays a count of the matching macros returned. Please note the language file amends shared with #10100

* Removed src-only class for the display of the count of messages

* Updating typo

* Removed top-margin from switcher icon

* Allow KeepAlive controller Ping method to be requested by non local requests (#10126)

* Allow KeepAlive controller Ping method to be requested by non local requests and accept head requests

* removed unused references

* fix csproj

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Sebastiaan Janssen <sebastiaan@umbraco.com>
Co-authored-by: Justin Shearer <justin.shearer@gmail.com>
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
Co-authored-by: Callum Whyte <hey@callumwhyte.com>
Co-authored-by: Shannon <sdeminick@gmail.com>
Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
Co-authored-by: patrickdemooij9 <patrickdemooij98@hotmail.com>
Co-authored-by: Bjarne Fyrstenborg <bjarne_fyrstenborg@hotmail.com>
Co-authored-by: Michael Latouche <michael@crossingpaths.be>
Co-authored-by: Nathan Woulfe <nathan@nathanw.com.au>
Co-authored-by: Markus Johansson <markus@obviuse.se>
Co-authored-by: Jeavon Leopold <jeavon@crumpled-dog.com>
Co-authored-by: Benjamin Carleski <benjamin@proworks.com>
Co-authored-by: Owain Williams <owaingdwilliams@gmail.com>
Co-authored-by: Jesper Löfgren <jesper.lofgren@sappa.se>
Co-authored-by: Martin Bentancour <mbe@umbraco.dk>
Co-authored-by: Ronald Barendse <ronald@panoramastudios.nl>
Co-authored-by: Andy Butland <abutland73@gmail.com>
Co-authored-by: BeardinaSuit <BeardInASuit@outlook.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
Co-authored-by: Rachel Breeze <RachBreeze@users.noreply.github.com>
Co-authored-by: Dave de Moel <d.demoel@wearetriple.com>
Co-authored-by: ric <60885685+ricbrady@users.noreply.github.com>
Co-authored-by: Carole Rennie Logan <crgrieve@users.noreply.github.com>
Co-authored-by: Dennis Öhman <dennis.ohman@bjornmamman.se>
2021-04-21 09:05:01 +10:00
Sebastiaan Janssen
e8a9c4da2e Merge branch 'v8/dev' into v8/contrib 2021-03-31 13:01:25 +02:00
Shannon Deminick
653bf52a1c Adds additional error checking and reporting to MainDom/SqlMainDomLock (#9954)
Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
2021-03-15 13:49:37 +01:00
Shannon Deminick
d0f047e729 Fixes and Updates for DB Scope and Ambient Context leaks (#9953)
* Adds some scope tests (ported back from netcore) and provides a much better error message, ensure execution context is not flowed to child tasks that shouldn't leak any current ambient context

* updates comment

* Ensure SqlMainDomLock suppresses execution context too

* Since we're awaiting a task in a library method, ConfigureAwait(false)

* missing null check

Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
2021-03-15 12:56:38 +01:00
Sebastiaan Janssen
9b39bfbf51 Merge branch 'v8/dev' into v8/contrib 2021-03-12 09:30:30 +01:00
Bjarke Berg
da5351dfcf Fix issue with SqlMainDomLock that cannot use implicit lock timeouts … (#9973) 2021-03-12 09:23:32 +01:00
Shannon
1ab73b35a4 Merge remote-tracking branch 'origin/v8/contrib' into v8/feature/nucache-perf 2021-03-12 16:50:00 +11:00
Chad
b8540ca128 Improve speed and reduce allocations by implementing logger overloads to avoid params [] allocation (#8917)
* Implement logger overloads to avoid params [] allocation

* Implement console logger ILogger

* Call correct signature

* Fix exceptions

* Introduce ILogger2

* fix logger reference

Co-authored-by: Nathan Woulfe <nathan@nathanw.com.au>
2021-02-22 08:22:49 +10:00
Shannon
55a39613c1 Merge remote-tracking branch 'origin/v8/contrib' into v8/feature/nucache-perf 2021-02-11 12:38:06 +11:00
Shannon
4c31fd176b Merge branch 'v8/dev' into v8/feature/nucache-perf
# Conflicts:
#	src/Umbraco.Core/Constants-SqlTemplates.cs
2021-01-21 22:49:33 +11:00
Shannon
c5642fa513 change logging to profile loggin 2021-01-18 15:33:14 +11:00
Rasmus John Pedersen
5efc1817d6 Add unattended upgrade support 2021-01-15 09:17:37 +01:00
Sebastiaan Janssen
967485f4e1 Merge branch 'v8/contrib' into v8/dev
# Conflicts:
#	src/Umbraco.Core/Runtime/SqlMainDomLock.cs
2021-01-08 15:18:03 +01:00
Shannon
fce13e23e9 Fixes test, adds null checks 2021-01-07 17:51:03 +11:00
Shannon
083b5d2611 Fixes issue with SqlMainDomLock during install, obsolete InstallEmptyDatabase, ensures installation can occur with/without the umbraco version 2021-01-05 16:27:42 +11:00
Shannon
28b9b62781 Merge remote-tracking branch 'origin/v8/dev' into v8/feature/nucache-perf
# Conflicts:
#	src/Umbraco.Core/Migrations/Upgrade/UmbracoPlan.cs
2020-12-16 15:26:57 +11:00
Shannon
bbe2941d25 New ext methods to check if Umbraco db is installed, fixes issue with SqlMainDomLock when doing unattended installs, changes how we determine if Umbraco db is installed 2020-12-16 12:06:48 +11:00
Sebastiaan Janssen
5ff101d31c Merge branch 'v8/8.9' into v8/8.10
# Conflicts:
#	src/Umbraco.Core/Runtime/SqlMainDomLock.cs
2020-12-14 15:12:28 +01:00
Sebastiaan Janssen
a141467bae Merge branch 'v8/8.6' into v8/8.7 2020-12-14 15:04:38 +01:00
Shannon
3927a8db67 Ensure we capture exceptions that occur when trying to create a transaction 2020-12-14 12:04:19 +11:00
Rasmus John Pedersen
db634f7c28 Add unattended install support 2020-12-08 10:38:32 +01:00
Shannon
c2d9f5aa4e Ensure that TaskScheduler.Default is used anywhere that ContinueWith is used, adds more debug logging to MainDom operations 2020-11-18 12:33:13 +11:00
Shannon
780b2e573b Fixes a startup issue that doesn't bubble the underlying boot failed exception if the container fails. 2020-09-25 00:27:46 +10:00
Shannon
c8488b6683 Merge branch 'v8/8.6' into v8/8.7
# Conflicts:
#	src/SolutionInfo.cs
#	src/Umbraco.Core/Runtime/SqlMainDomLock.cs
#	src/Umbraco.Web.UI.Client/src/common/directives/components/application/umbtour.directive.js
#	src/Umbraco.Web.UI.Client/src/common/services/clipboard.service.js
#	src/Umbraco.Web.UI.Client/src/views/propertyeditors/nestedcontent/nestedcontent.controller.js
2020-07-20 16:08:07 +10:00
Shannon
639c7a40ee Merge branch 'v8/8.6' into v8/dev
# Conflicts:
#	src/SolutionInfo.cs
#	src/Umbraco.Core/Runtime/SqlMainDomLock.cs
#	src/Umbraco.Examine/IndexRebuilder.cs
#	src/Umbraco.Web.UI.Client/src/common/directives/components/application/umbtour.directive.js
#	src/Umbraco.Web.UI.Client/src/common/services/clipboard.service.js
#	src/Umbraco.Web.UI.Client/src/views/propertyeditors/nestedcontent/nestedcontent.controller.js
2020-07-20 16:03:10 +10:00
Shannon
b80dc8f34b readability 2020-07-08 15:07:12 +10:00
Shannon
7590161858 comments 2020-07-08 14:54:26 +10:00
Shannon
7819d1acf5 comments 2020-07-08 14:53:53 +10:00
Shannon
a947fa3121 comments 2020-07-08 14:51:35 +10:00
Shannon
651756d96a Ensure we don't shutdown MainDom if there is an error while listening, only shutdown if the appdomain is triggered to shutdown, else we'll keep listening/logging 2020-07-08 13:43:20 +10:00
Shannon
65101beaf6 transactions for sqlmaindom 2020-07-08 13:43:20 +10:00
Shannon
6aa49242f2 Don't try to reuse db instances, thsi can result in potential zombie transactions 2020-07-08 13:43:20 +10:00
Sebastiaan Janssen
a88a5a0cae Merge pull request #7984 from umbraco/v8/bugfix/7967-sqlmaindom
Fixes #7967 - cannot start site with SqlMainDomLock  when db isn't configured

(cherry picked from commit cbfe643a79)
2020-07-02 10:38:10 +02:00
Shannon
af29b8da68 Cherry pick #8058 to fix #8038 2020-05-04 20:59:22 +10:00
Shannon
2dd938bf29 Change to re-use the MainDomId of the normal maindom 2020-05-04 19:12:20 +10:00
Shannon
0717d5b246 Fixes: SqlMainDom setting for Azure does not work in Load Balancing #8038 2020-05-04 18:57:55 +10:00
Shannon
008df6018c Fixes: SqlMainDomLock when configured via appSettings cannot be used unless umbraco is installed #7967 2020-04-21 00:02:59 +10:00
Jeavon
5efeb53805 Add missing methods "GetChildren(Guid id)" & "HasChildren(Guid id)" to "IContentTypeBaseService" (#7700) 2020-02-24 11:11:33 +00:00
Shannon
52b93bfc9c ensures only _sqlServerSyntax is used 2020-01-23 18:33:55 +11:00
Shannon
8d7ed7dd32 adds const fixing naming 2020-01-23 16:26:13 +11:00
Shannon
201927580c Fixing accidental api signature breaking change 2020-01-23 16:23:27 +11:00
Bjarke Berg
1dfdfba236 Merge remote-tracking branch 'origin/v8/dev' into v8/bugfix/AB3323-SqlMainDom 2020-01-22 09:39:06 +01:00
Shannon
b02360518d Changed to GetAwaiter/GetResult and updates comment 2020-01-13 22:25:46 +11:00
Shannon
95337d5a70 Cleans up old notes 2020-01-06 21:39:26 +11:00
Shannon
7a129f890d Changes MainDom testing timeout to be larger... but not 1.5 mins! 2020-01-03 15:07:21 +11:00
Shannon
a46e9124d2 First commit in fixing deadlock - committing my notes, etc... 2020-01-03 10:38:48 +11:00
Shannon
b24a87d986 Changes logging to debug 2019-12-30 18:51:38 +11:00
Shannon
5476388e78 adds lock else we end up detecting when not needed 2019-12-30 18:49:33 +11:00