Dan Booth
df19d4fc6d
Fixes: Consistency for Nullable reference types in LINQ extensions methods #12692 ( #12703 )
...
* Ensure Name and Children can never return null.
* Name should be empty not null
* Ensure Name and Children type queries never return null
Co-authored-by: Sebastiaan Janssen <sebastiaan@umbraco.com >
2022-10-19 10:32:09 +02:00
Nikolaj Geisle
60a5b19dc9
V10: Fix build warnings in core ( #12438 )
...
* Run code cleanup
* Start manual cleanup after dotnet format
* Finish up manual pass
* Fix up missed warnings
* Fix after merge
* Update src/Umbraco.Core/Cache/ContentTypeCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/DataTypeCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/DeepCloneAppCache.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/DomainCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/FastDictionaryAppCacheBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/MacroCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/MediaCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/MemberCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Cache/MemberGroupCacheRefresher.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Composing/OrderedCollectionBuilderBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Configuration/Models/RequestHandlerSettings.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Composing/SetCollectionBuilderBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Composing/WeightedCollectionBuilderBase.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/ContentApps/ContentAppFactoryCollectionBuilder.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Dashboards/DashboardCollectionBuilder.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/ContentTypeRefreshedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/ContentTypeSavedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/ContentTypeSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/DictionaryCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/DataTypeCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/ContentUnpublishingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/DictionaryItemDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/DictionaryItemSavedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/DictionaryItemSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/DomainCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/LanguageCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MacroCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaEmptiedRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaEmptyingRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaMovedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaMovedToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaMovedToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaMovingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaMovingToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTreeChangeNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTreeChangeNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTypeChangedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTypeDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTypeMovedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTypeMovingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTypeMovingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MediaTypeRefreshedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberGroupCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberGroupDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberGroupSavedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberGroupSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeChangedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeDeletedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeMovedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeMovedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeMovingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeMovingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeRefreshedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MemberTypeSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/StringExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/UriExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MovedToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MovedToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MovingToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/MovingToRecycleBinNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PartialViewDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Extensions/UriExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/IO/PhysicalFileSystem.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/IO/PhysicalFileSystem.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/IO/ShadowWrapper.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Logging/DisposableTimer.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Install/InstallSteps/UpgradeStep.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Mapping/MapDefinitionCollectionBuilder.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Media/EmbedProviders/EmbedProvidersCollectionBuilder.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PartialViewSavedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Models/ContentEditing/ContentVariationDisplay.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PartialViewSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessEntryDeletedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessEntryDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessEntryDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessEntrySavedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessEntrySavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/PublicAccessEntrySavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/RelationTypeCacheRefresherNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/RelationTypeDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/RelationTypeSavedNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/RelationTypeSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/StatefulNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/StylesheetDeletingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Notifications/StylesheetSavingNotification.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Models/DeepCloneHelper.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Models/File.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Models/PropertyGroupExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Update src/Umbraco.Core/Models/PropertyGroupExtensions.cs
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
* Fix based on review
* Fix after merge
Signed-off-by: Zeegaan <nge@umbraco.dk >
Co-authored-by: Nikolaj Geisle <niko737@edu.ucl.dk >
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch >
Co-authored-by: Zeegaan <nge@umbraco.dk >
2022-06-07 15:28:38 +02:00
Nikolaj Geisle
f23b57db65
V10: fix more nullable references ( #12321 )
...
* Add Nullable and WarningsAsErrors to Build.props
* Remove Nullable from cs proj, add ImplicitUsings to build.props
* Fix errors in core
* Fix in JsonSchema
* Fix infrastructure
* Add non-ambiguous using
* Fix Web/Lucene
* Fix backoffice
* Fix up new build errors from merge
Co-authored-by: Nikolaj Geisle <niko737@edu.ucl.dk >
2022-04-29 15:02:36 +02:00
Andy Butland
b187c89113
Updates to null reference types ( #12317 )
...
* Amended IFileSystem OpenFile to return Stream.Null rather than a nullable stream.
* Updated IUmbracoMapper to map enumerables without null elements given non-null inputs.
* Amended EntityRepositoryBase to not return null collections.
* Made IPublishedElement.Properties a non-nullable collection.
2022-04-29 08:19:34 +02:00
Nikolaj Geisle
b52c4e50cf
Add nullability to web.common
2022-03-29 13:44:21 +02:00
Nikolaj Geisle
6be2cd45db
Use nullability on the rest of core
2022-02-16 16:03:53 +01:00
Nikolaj Geisle
093d336cc7
Fix more nullability errors
2022-02-15 15:48:41 +01:00
Nikolaj Geisle
b75eae01f3
Add nullability to core project
2022-02-09 13:24:35 +01:00
Bjarke Berg
2ec92057c5
Started using nullable reference types..
2021-12-16 13:44:20 +01:00
Shannon Deminick
c77dc5dc00
Migrating tests that depend on Published Cache from the old test project ( #11242 )
...
* starts cleaning up old test project, removing ones we'll never convert, moves new test to where it should be.
* Makes ContentNodeKit immutable properties, moves first nucache tests over
* Gets the Nucache unit tests working and refactors a bit to use builder pattern for models.
* Migrates first xml based cache test to use nucache.
* Migrates a bunch more
* Migrates remaining tests for PublishedContentTests
* Moves PublishedRouterTests
* Moves PublishedContentExtensionTests
* Moves more tests.
* committing wip
* committing wip
* Gets PublishedContentLanguageVariantTests converted and working.
* Fixes DataTable ext method and moves PublishedContentDataTableTests
* Moves PublishedMediaTests
* wip - moving EntityXmlSerializerTests
* Moves more tests
* moves more tests
* moves more tests
* Move another test
* Moves more tests
* Fix test
* move another test
* Moves more tests
* Moves more tests
* Moves more tests
* wip before merge
* More tests
* More tests
* More tests
* More tests
* More tests
* More tests
* Cleanup and moving classes.
* Remove unused code
* Fixed failing tests, due to new null checks, that did not exist in v8
* Avoid breaking changes
* Unbreak more things, even that it the old solution was crazy..
* Fixed bug where ordering of stream readings was changed..
* cleanup
Co-authored-by: Bjarke Berg <mail@bergmania.dk >
2021-10-19 14:11:54 +02:00
Shannon
d6a6016801
implement noop published snapshot service, splits tests models for published content, fixes sqlce image mapper to not have circular ref.
2021-06-24 10:25:23 -06:00
