* RCL for static assets to replace the nuspec
* Fix build
* Fix unit tests
* clean up in build.ps1
* Removed test (lang files will be removed later anyway)
* Fixed namespaces.. + Ensure we set web root path if missing (e.g. wwwroot folder do not exist) + Added StaticWebAssetBasePath
* fixed namespace
* cleanup
* Set root variable
* Added static assets
* Experimenting with StaticWebAssetBasePath
* Embedded lang files into Umbraco.Core
* Removed legacy test. New test can be implemented instead
* Fixed tests
* clean up
* Fix merge issue
* Created Persistence.SQLite project skeleton.
* SQLite database initialization
* Various changes and hacks to make things work.
* WIP integration tests
* Fix thread safety tests
* Fix tests that relied on tie breaker sorting.
Spent a fair amount of time looking for a less lazy fix but gave up.
* Convert right join to left join ContentTypeRepository.PerformGetByQuery
SQLite doesn't support right join
* Fix test Can_Generate_Delete_SubQuery_Statement
Worth noting that NPoco.DatabaseTypes.SQLiteDatabaseType doesn't override
EscapeSqlIdentifier so NPoco will escape with [].
SQLite docs say > "A keyword enclosed in square brackets is an identifier.
This is not standard SQL.
This quoting mechanism is used by MS Access and SQL Server and is
included in SQLite for compatibility."
Also could have updated SqliteSyntaxProvider to match npoco but
decided against it.
* Fixes for paginated custom order by
* Fix tests broken by lack of unique indexes.
* Fix SqlServerTableByTableTest tests.
These tests didn't actually do anything as the tables already exist so schema creator just returned.
Did however point out that the default implementation for DoesTableExist just returns false so added a default naive implementation.
* Fix ValidateLoginSession - SelectTop must come later
* dry up database cleanup
* Fix up db migration tests.
We can't drop pk in sqlite without recreating table.
Test looks to be testing that add column works as intended which we can test.
* Prevent schema creation errors.
* SQLite ignore lock tests, WAL back on.
* Fix package schema tests
* Fix NPocoFetchTests - case sensitivity not under test
* Fix AdvancedMigrationTests (where possible)
Migrations probably need a good look later.
Maybe nuke old migrations and only support moving to v10 from v9.
If we do that can do some cleanup.
* Cleanup test database configuration
* Run integration tests against SQLite on build agent.
* Drop MS.Data.SQLite
System.Data.SQLite was quicker to roll out due to more CLR type mapping
* YAML
* Skip Umbraco.Tests.Integration.SqlCe
* Drop SqlServerTableByTable tests.
Until this week they did nothing anyway as they with NewSchemaPerTest
so the tests all passed as CreateTable was no op (already exists).
Also all of the tables are created in an empty database by SchemaValidationTest.cs
DatabaseSchemaCreation_Produces_DatabaseSchemaResult_With_Zero_Errors
* Might aswell run against macOS also.
* Copy azure pipelines task header layout
* Delete SQLCe projects
* Remove SQL CE specific code.
* Remove SQL CE NuSpec, template params, build script setup
* Delete umbraco-netcore-only.sln
* Add SkipTests solution configuration and use for codeql
* Remove reference to deleted nuspec file.
* Refactor ConnectionStrings WRT DataDirectory placeholder & ProviderName.
At this point you can try out SQLite support by setting the following
in appsettings.json and then completing the install process.
"ConnectionStrings": {
"umbracoDbDSN": "Data Source=|DataDirectory|/umbraco.sqlite",
"umbracoDbDSN_ProviderName": "System.Data.SQLite"
},
Not currently possible via installer UI without provider name pre-set in
configuration.
* Switch to Microsoft.Data.Sqlite
Some gross hacks but will be good to find out if this works
with apple silicon.
* Enable selection of SQLite via installer UI (also quick install)
* Remove SqlServerDbProviderFactoryCreator to cleanup a TODO
* Move SQL Server support to its own class library
* Add persistence dependencies to Umbraco.CMS metapackage
* Bugfix packages delete query
Created invalid query for SQLite.
* Try out cypress tests Linux + SQLite
* Prevent cypress test artifact upload failure on attempt 2+
* LocalDb bugfixes
* Drop redundant enum
* Move SqlClient constant
* Misc whitespace
* Remove IsSqlCe extension (TODO: drop non 9->10 migrations later).
* Umbraco.Persistence.* -> Umbraco.Cms.Persistence.*
* Display quick install defaults and per provider default database name.
* Misc remove old comment
* little re-arrange
* Remove almost all usages of IsSqlite extension.
* visual adjustments
* Custom Database Configuration is last step and should then say Install.
* use text instead of disabled inputs
* move legend, rename to Install
* Update SqlMainDomLock to work without distributed locks.
* Added IDistributedLockingMechanism interface and in memory impl.
* Drop locking from ISqlSyntaxProvider & wire up scope to abstraction.
* Added SqlServerDistributedLockingMechanism
* Move distributed locking interfaces and exceptions to Core + xmldocs.
* Fix tests, Misc cleanup, Add SQL distributed locking integration tests
* Provide mechanism to specify DistributedLockingMechanism in config
(even if added by composer)
* Nomplementation -> NoImplementation
* Fix misleading comment
* Integration tests use SqlServerDistributedLockingMechanism when possible
* Handle up-gradable locks SqlServerDistributedLockingMechanism.
TODO: InMemoryDistributedLockingMechanism.
Note: Nuked SqlServerDistributedLockingMechanismTests, will still sleep
at night.
Is covered by Umbraco.Cms.Tests.Integration.Umbraco.Infrastructure.Persistence.LockTests
* Make tests pass for InMemoryDistributedLockingMechanism, pretty hacky.
* Tweak constraints on WithCollectionBuilder so i can drop bad constructor
* Added SqliteDistributedLockingMechanism
* Dropped InMemoryDistributedMechanism + magic
InMemoryDistributedMechanism was pretty rubbish and now we have
a decent implementation for SQLite as we no longer block readers
see 8d1f42b.
Also drop the CollectionBuilder setup, instead do the same as we do
for syntax providers etc, it's more automagical so we never require an
explicit selection although we are allowing for it.
However keeping the optional IUmbracoBuilder constructor param for
CollectionBuilders as it's extremely useful.
* Fix quick install "" database name.
* Hide Database Configuration section when a connection string is pre-set.
Doesn't seem worth it to extract db name from connection string.
* Ensure wal test 2+
* Fix logging inconsistencies.
* Ensure in transaction when obtaining locks + no-op the SQLite read lock.
There's no point in running the query just to make a single test pass.
* Fix installer database display names
* Allow SQLite shared cache without losing deferred transactions
* Opt into shared cache for new SQLite databases + fix filename
* Fix misc inconsistency in .gitignore
* Prefer our interceptor interface
* Restore DEBUG_DATABASES code OnConnectionOpened in case it's used.
* Back to private cache.
* Added retry strategy for SQLite + refactor out SQL server specific stuff
* Fix SQL server tests.
* Misc - Orphaned comment, incorrect casing.
* InMemory SQLite test database & turn shared cache back on everywhere.
Co-authored-by: Niels Lyngsø <niels.lyngso@gmail.com>
It worked properly if the Umbraco files are on disk before a build
but when the files are not there yet or a dotnet clean is done first the
files are not compiled. This is often the case on build servers that start
with a clean working directory for each build.
Using this target we simply ensure the files are included as "Content"
which Razor will scan for .cshtml files in their "ResolveRazorGenerateInputs"
target.
* Changed targetFramework in nuspec file & project files + updated NuGet dependencies
* Updated .net version in pipelines
* Updated .net version in templates
* Update more dependencies
* Fixed ambiguous call to DistinctBy() - part of Umbraco.Extensions and System.Linq
* Disabling the Razor source generators in .NET 6 due to error: "Cannot find the fallback endpoint specified by route values..."
* Fixed unit tests
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
<PropertyGroup>
<UmbracoWwwrootName>my-secret-loginpanel</UmbracoWwwrootName>
</PropertyGroup>
it will now copy to wwwroot/my-secret-loginpanel instead of wwwroot/umbraco
This should at least fix#10793 because of a memory leak fix in Serilog.Sinks.Map 1.0.2. Also updated the rest for good measure.
Note that Serilog.Sinks.File is not upgraded to the latest version because it is a new major (4.1.0 -> 5.0.0). Also note that Serilog.Filters.Expressions is deprecated and should be replaced by Serilog.Expressions. I considered both out of scope for this fix.
* Bump version to 8.6.8
* Initial rework of Lock dictionaries
* [Issue 5277-146] accessibility - Close 'X' icon next to language drop… (#9264)
* [Issue 5277-146] accessibility - Close 'X' icon next to language drop down is identified as "link" - screen reader
* add new loacalization key
* Fix issue with SqlMainDomLock that cannot use implicit lock timeouts … (#9973)
* Fix issue with SqlMainDomLock that cannot use implicit lock timeouts … (#9973)
(cherry picked from commit da5351dfcf)
* Adjust unit tests and apply fixes to scope
* Add more unit tests, showing current issue
* Counting Umbraco.ModelsBuilder and ModelsBuilder.Umbraco namespaces as external providers
* Fix dead lock with TypeLoader
* Fix errors shown in unit tests
* Throw error if all scopes hasn't been disposed
* Clean
* Fixes and Updates for DB Scope and Ambient Context leaks (#9953)
* Adds some scope tests (ported back from netcore) and provides a much better error message, ensure execution context is not flowed to child tasks that shouldn't leak any current ambient context
* updates comment
* Ensure SqlMainDomLock suppresses execution context too
* Since we're awaiting a task in a library method, ConfigureAwait(false)
* missing null check
Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
* Adds additional error checking and reporting to MainDom/SqlMainDomLock (#9954)
Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
* Add copy logic to Media Picker (#9957)
* Add copy logic to Media Picker
* Add action for copy all
* Fix for selectable media item
* Wrap calls to map in scopes
* Autocomplete scopes
* Remove unnecessary aria-hidden attribute from <umb-icon>
* Remove scope from method that calls another method that has a scope
* Fixes#9993 - Cannot save empty image in Grid
* Clean
* Revert "The Value() method for IPublishedContent was not working with the defaultValue parameter" (#9989)
* Use a hashset to keep track of acquired locks
This simplifies disposing/checking for locks greatly.
* Add images in grid - fixes 9982 (#9987)
Co-authored-by: Sebastiaan Janssen <sebastiaan@umbraco.com>
* Only create the dicts and hashset when a lock is requested
* Clean
* Adds a config for configuring the access rules on the content dashboard - by default it granted for all user groups
* Adds additional params indicating whether user is admin
* Add images in grid - fixes 9982 (#9987)
Co-authored-by: Sebastiaan Janssen <sebastiaan@umbraco.com>
(cherry picked from commit e2019777fb)
* Bump version to 8.12.2
* #9964 Removed unneeded check for HttpContext
* Fix for #9950 - HttpsCheck will now retry using the login background image if inital request returns 301/302. Excessvie Headers check will now check the root url instead of the backoffice
* Merge pull request #9994 from umbraco/v8/bugfix/9993
Fixes#9993 - Cannot save empty image in Grid
(cherry picked from commit 0ecc933921)
* Apply suggestions from review
* Fixes#9983 - Getting kicked, if document type has a Umbraco.UserPicker property (#10002)
* Fixes#9983
Temporary fix for this issue. using the entityservice like before.
* Needed to remove the call to usersResource here as well for displaying the picked items
* Don't need usersResource for now
* Fixes#9983 - Getting kicked, if document type has a Umbraco.UserPicker property (#10002)
* Fixes#9983
Temporary fix for this issue. using the entityservice like before.
* Needed to remove the call to usersResource here as well for displaying the picked items
* Don't need usersResource for now
(cherry picked from commit 45de0a101e)
* 8539: Allow alias in image cropper (#9266)
Co-authored-by: Owain Williams <owaingdwilliams@gmail.com>
* Wrap dumping dictionaries in a method.
* Create method for generating log message
And remove forgotten comments.
* Fix swedish translation for somethingElse.
* Copy member type (#10020)
* Add copy dialog for member type
* Implement copy action for member type
* Create specific localization for content type, media type and member type
* Handle "foldersonly" querystring
* Add button type attribute
* Add a few missing changes of anchor to button element
* Null check on scope and options to ensure backward compatibility
* Improve performance, readability and handling of FollowInternalRedirects (#9889)
* Improve performance, readability and handling of FollowInternalRedirects
* Logger didn't like string param
Passing string param to _logger.Debug<PublishedRouter, int> wasn't happy. Changed to pass existing internalRedirectAsInt variable.
Co-authored-by: Nathan Woulfe <nathan@nathanw.com.au>
* Update casing of listview layout name
* 9097 add contextual password helper (#9256)
* update back-office forms
* Display tip on reset password page as well
* add directive for password tip
* integrate directove in login screen
* forgot the ng-keyup :-)
* adapt tooltip directive to potential different Members and Users password settings
* remove watcher
Co-authored-by: Nathan Woulfe <nathan@nathanw.com.au>
* Unbind listener
Listening for splitViewRequest was only unbound if the split view editor was opened. Not cleaning up the listener caused a memory leak when changing between nodes as the spit view editor was detached but not garbage-collected
* Replace icon in date picker with umb-icon component (#10040)
* Replace icon in date picker with <umb-icon> component
* Adjust height of clear button
* Update cypress and fix tests
* Listview config icons (#10036)
* Update icons to use <umb-icon> component
* Simplify markup and use disabled button
* Use move cursor style on sortable handle
* Add class for action column
* Update setting auto focus
* Increase font size of umb-panel-header-icon
* Anchor noopener (#10009)
* Set rel="noopener" for anchors with target="_blank"
* Reverted unwanted changes to Default.cshtml
* Align 'Add language' test to netcore
* Add new cypress tests
* Add indentation
* Getting rid of the config file and implementing an appSetting instead
* Implementation for IContentDashboardSettings
* Cleanup
* bool.Try
* Taking AllowContentDashboardAccessToAllUsers prop from GlobalSettings to ContentDashboardSettings and saving AccessRulesFromConfig into a backing field
* Handling multiple values per field in Examine Management
* Add Root<T> and Breadcrumbs extension methods for IPublishedContent (#9033)
* Fix usage of obsolete CreatorName and WriterName properties
* Add generic Root extension method
* Add Breadcrumbs extension methods
* Orders member type grouping of members alphabetically, matching the listing of member types.
* Revert updating deprecated WriterName/CreatorName refs
Changing the properties to use the extensions is a good thing (given the props are deprecated), but causes issues deep in tests. I'm reverting that change to fix the tests, and all refs to the deprecated properties should be updated in one sweep, to deal with any other test issues that might crop up.
* Handle Invalid format for Upgrade check
* Fixes tabbing-mode remains active after closing modal #9790 (#10074)
* Allow to pass in boolean to preventEnterSubmit directive (#8639)
* Pass in value to preventEnterSubmit directive
* Set enabled similar to preventDefault and preventEnterSubmit directives
* Update prevent enter submit value
* Init value from controller
* Use a different default input id prefix for umb-search-filter
* Fix typo
* Check for truthly value
* Revert "Set enabled similar to preventDefault and preventEnterSubmit directives"
This reverts commit 536ce855c4545ead82cea77b4013bf9010a8687b.
* None pointer events when clicking icon
* Use color variable
* Fixes tabbing-mode remains active after closing modal #9790 (#10074)
(cherry picked from commit c881fa9e7d)
* Null check on scope and options to ensure backward compatibility
(cherry picked from commit fe8cd239d2)
* Fix validation of step size in integer/numeric field
* 9962: Use $allowedEditors instead of allowed (#10086)
* 9962: Use $allowedEditors instead of allowed
* 9962: Remove redundant statement
* fixes#10021 adds ng-form and val-form-manager to the documentation
* Improved accessibility of link picker (#10099)
* Added support for screeen reader alerts on the embed so that assitive technology knows when a url retrieve has been succesfull.
Added labels for the controls
Preview reload only triggered if the values for height and width change
* Added control ids for the link picker
* Add French translation
* Accessibility: Alerts the user how many results have been returned on a tree search (#10100)
* Added support for screeen reader alerts on the embed so that assitive technology knows when a url retrieve has been succesfull.
Added labels for the controls
Preview reload only triggered if the values for height and width change
* Tree search details the number of search items returned
* Add French translations
* Updated LightInject to v6.4.0
* Remove HtmlSanitizer once more - see #9803
* Also make sure NuGet installs the correct version of the CodePages dependency
* Bump version to 8.13 RC
* Fixed copy preserving sort order (#10091)
* Revert "Updated LightInject to v6.4.0"
This reverts commit fc77252ec7.
* Revert "Add copy logic to Media Picker (#9957)"
This reverts commit f7c032af65.
* Reintroduce old constructor to make non-breaking
* Update cypress test to make macros in the grid work again
* Attributes could be multiple items, test specifically if `Directory` is an attribute
* Accessibility: Adding label fors and control ids for the macro picker (#10101)
* Added support for screeen reader alerts on the embed so that assitive technology knows when a url retrieve has been succesfull.
Added labels for the controls
Preview reload only triggered if the values for height and width change
* Added support for label fors for the macro picker and also gave the ,acro search box a title
* Now displays a count of the matching macros returned. Please note the language file amends shared with #10100
* Removed src-only class for the display of the count of messages
* Updating typo
* Removed top-margin from switcher icon
* Allow KeepAlive controller Ping method to be requested by non local requests (#10126)
* Allow KeepAlive controller Ping method to be requested by non local requests and accept head requests
* removed unused references
* fix csproj
Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
Co-authored-by: Sebastiaan Janssen <sebastiaan@umbraco.com>
Co-authored-by: Justin Shearer <justin.shearer@gmail.com>
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
Co-authored-by: Callum Whyte <hey@callumwhyte.com>
Co-authored-by: Shannon <sdeminick@gmail.com>
Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
Co-authored-by: patrickdemooij9 <patrickdemooij98@hotmail.com>
Co-authored-by: Bjarne Fyrstenborg <bjarne_fyrstenborg@hotmail.com>
Co-authored-by: Michael Latouche <michael@crossingpaths.be>
Co-authored-by: Nathan Woulfe <nathan@nathanw.com.au>
Co-authored-by: Markus Johansson <markus@obviuse.se>
Co-authored-by: Jeavon Leopold <jeavon@crumpled-dog.com>
Co-authored-by: Benjamin Carleski <benjamin@proworks.com>
Co-authored-by: Owain Williams <owaingdwilliams@gmail.com>
Co-authored-by: Jesper Löfgren <jesper.lofgren@sappa.se>
Co-authored-by: Martin Bentancour <mbe@umbraco.dk>
Co-authored-by: Ronald Barendse <ronald@panoramastudios.nl>
Co-authored-by: Andy Butland <abutland73@gmail.com>
Co-authored-by: BeardinaSuit <BeardInASuit@outlook.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
Co-authored-by: Rachel Breeze <RachBreeze@users.noreply.github.com>
Co-authored-by: Dave de Moel <d.demoel@wearetriple.com>
Co-authored-by: ric <60885685+ricbrady@users.noreply.github.com>
Co-authored-by: Carole Rennie Logan <crgrieve@users.noreply.github.com>
Co-authored-by: Dennis Öhman <dennis.ohman@bjornmamman.se>
* TourController now uses the core tours from embedded resources
* Moved tinyMceConfig.*.config to IOptions
* Embedded the default grid.editors.config.js
* Fixed issue when saving grid with an empty media cell
* Logviewer now uses sql as database instead of file.
* Remove config folder from build script and nuget pacakges.
* Removing auto-generated Id added to appsettings.json
* Update src/Umbraco.Web.BackOffice/Controllers/TourController.cs
Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
Co-authored-by: Elitsa Marinovska <21998037+elit0451@users.noreply.github.com>
