Commit Graph

80 Commits

Author SHA1 Message Date
Shannon Deminick
df3dc32de6 Block Editor List (#8273)
* add style to create-option in itempicker + removing overflow hidden

* style adjustment

* clean up of html

* correct sentence to use the number 7

* correct overlays, so they can use size

* numberrange prevalue editor

* add confirmRemove overlay

* correcting primary btn colors

* move confirmMessage below content of overlay.

* min max validation for numberrange

* remove comment

* improved actions for block list

* use file tree for view picker

* style adjustment to border of creator item in item-picker

* vertical align

* clean up + validation limit range

* rename ElementTypes to Blocks

* implement block list editor

* renaming

* use Chrome Headless for unit tests

* test for blockEditorService

* safer code

* block list editor

* rename view to overlayView

* block editor work

* Revert "rename view to overlayView"

This reverts commit 5b910c178a.

* block editor implementation

* sync models

* block list editor copy paste feature

* order var declarations

* remove unused paste function

* block list editor better naming

* simpler label generation

* clean up

* compile config for test mode

* Chrome Debug for VS code

* promise test working

* space change

* another two tests

* more tests for block list editor

* provide key on blockModel for angularJS performance optimization

* syncronization from infinite editing layers

* use an isolated scope

* more tests

* fix C# test

* remove unused block watcher component

* clean css

* only show on hover or focus for block-actions

* clean up and prepare for implementing settings

* remove console

* Add ability to render block list editor using Grid style rendering extension

* Enable Block List Editor settings editing

* Add Stacked Content to Block List migration

* Block Editor: Clean-up, refactoring, one step closer being ready for Content-Apps

* changes naming to Submit, to avoid misunderstanding.

* use a common variable on the block model for isOpen, to be able to make Actions show when open.

* NotSupported property editor, to be used when an editor is not supported in the given context.

* remove unused controller

* Hide group header if only one group is presented

* rename notsupport property editor css class

* smaller header for property group

* hide description if no description is presented

* css adjustments

* Inline create button styling: Better spacing, darker blue color for Focus Outline, moving the plus icon to mouse position for better visual appearance.

* css correction

* Add references for picked items

* Revert commit 45e892f350 - Changes api to GetData

* Use the .Data propertry as opposed to GetData in this PartialView

* Fix block list test failures

* Just parsing layout as model for partial views.

* minor adjustments

* Remove DB migrations so that they can be reviewed as a block

* Add migrations for new block editor

* Update default rendering partial view

* Add error handling to default template

* Handle color picker data in stacked content

* BlockList PreValue Editor opens configurations as overlay

* translation for prevalue editor property group headlines

* blockcard corrections

* block list prevalue corrections

* revert agressive clean up

* Block Picker

* MaxPropertyWidth PreValue + Implementation

* Incorporate latest block list editor changes, update migration for changed configuration

* Change declared converter type

* Handle invalid data type references

* Remove code duplicated from PR #7957

* use ElementModel for the ContentModel of an ElementType. So we can use ElementTypeModel for the ModelDefinition aka. the Type.

* do still show itempicker for BlockConfiguration even though there is no ElementTypes to pick. This enables the option to create a new ElementType to be used.

* use the right wrapper, for correct spacing

* parse item

* correct fallback for label

* removed unused callback

* paste feature for block-picker

* localize block-picker tabs

* Slightly change for shadow on block-picker item hover

* Localization of BlockEditor Settings Tab

* localizationService

* only filter when more than 8 items available

* Add multiple blocks if hold down CTRL or SuperKey

* adds notes

* ability to add a scoped stylesheet for block view

* make scoped block draggable + style adjustments

* provide index for custom view

* rename contentModel to data + rename layoutModel to layout

* clean up

* more localization

* openSettings option for block editor

* minor changes for a better developer experience

* paste mistake corrected

* only manipulate content-content-app if its present

* make small overlays slightly bigger

* moved block list entry editor into block list editor folder

* limit labelinterpretator to only runs ones pr. edit. and lets make sure to have a label thought we dont have any properties.

* fixed inline views gulp watcher

* changed vm to a better controller instance name

* make watch for views work again.

* able to re run watch

* make js up to date

* fix white background of image-picker

* media-picker container class

* loading indication

* adjust unit tests to latest interface

* getting started on JS Docs

* converting code to use contentTypeKey instead of contentTypeAlias, still missing a few TODOs.

* revert change

* add todo

* use Guid for Key

* use key

* Updates the caching layer to handle GUID keys for content types while preserving backwards compat, fixes unit tests, removes the strongly typed lists for the block editor value since it's unecessary

* Reverts the nested content changes, fixes up the GetEmptyByKey

* Returns ContentTypeKey from the server, updates js to use this everywhere and fix all js tests.

* Allows key in SimpleContentType

* correct for the new spelling

* appended this. since the method is a non-static class method.

* only add background-image if value isnt null

* simplifyed limits validation

* clean up

* no need to execute a digest.

* define the full model for new configurations

* removed setDataFromBlockModel and general clean up and added documentation

* default size should be medium

* use retriveValuesFrom method to transfer data.

* ability to disable an navigation item

* createElementTypeAndCallback working again for settings.

* still have the ability to retrive a scaffold model by alias, since we are still using alias in clipboard service.

* disable clipboard tab if no available paste options

* ups, should stay as alias

* disable clipboard when empty

* use property alias for content add button

* use a grey that can be seen on top of grey and on top of white.

* some accessibility improvements

* rename entry to block

* appended ' and added space in Element Type

* use background color for hover to corospond with active state

* make nested content unsupported

* Moving BlockEditorModelObject into its own file for Documentation purpose. Same goes for renaming BlockModel to BlockObject. and a lot of documentation written.

* fix links in js docs

* added a blocklistentryeditor for unsupported blocks

* ability to retrive the $scope from UmbVariantContentEditors, needed for Block Editor to get a scope existing across variants and splitview.

* Appending the block objects to layout, to share it across variants and in split-view.

* removed trailing comma

* Unsupported block

* Dont copy unsupported blocks

* use grey color for unsupported block

* text correction

* we dont have this fallback anymore

* sort properties

* Text change

* css correction

* use active to determine if an inline editor is expanded. To enable the inline editor to be expanded on creation.

* using udi instead of key.

* bringing the runtime block key back

* live editing ability

* live editing for settings data

* call formSubmit before property editor are removed from DOM. Both for overlay-editing and inline-editing. Fire an postFormSubmitting event after formSubmitting event to let editors know that data could have been updated.

* make sure settings object exists

* only set active to false if it was false before opening the editor.

* update test with new scope parameter

* move destroy responsibility to blockObject

* rename onDestroy to destroy

* added some JS-Docs

* correction jsDocs

* Update ElementType Resource to not use hardcoded URL but to use the Umbraco.Sys.ServerVariables.umbracoUrls instead

* Remove partially completed ConvertToElement migration, fixed in issue 7939 instead.

* Remove external property editor migration

* corrected naming of umbBlockListScopedBlock and umbBlockListBlock

* correct ngdoc type

* removed vscode specific configuration of karma

* Finished Todo, gets name of documentType if copying all entities in an infinite editor

* changed comment from TODO to something that explains the state.

* stop tracking build output files.

* rename files to match file name conventions

* this should not happen.

* remove dublicated code

* rename requestCopyBlock to copyBlock

* make sure images does not repeat.

* scale thumbnail for block showcase

* renamed blockcard.component to umb-block-card and moved it.

* removed inline style

* correct style location

* corrected filepath

* corrected file path

* keep elementTypes up to date through the EventService.

* mark Umbraco.BlockList as unsupported inside Nested Content

* correct js docs name

* remove comment

* remove comment

* remove unused controller

* rename inline method name

* corrected spelling mistake

* remove not very used vars

* make binding one-way

* split in multiple lines

* corrected default rendering

* removing documentation that is relevant for developers of new block editors. this documentation will be transfered to Our documentation.

* added danish translation

* corrected blog to blok

* Remove invalid using statement

* use native forEach

Co-authored-by: Niels Lyngsø <nsl@umbraco.dk>
Co-authored-by: Benjamin Carleski <benjamin@proworks.com>
Co-authored-by: Warren Buckley <warren@umbraco.com>
Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
Co-authored-by: Niels Lyngsø <niels.lyngso@gmail.com>
Co-authored-by: Claus <claus@claus.nu>
2020-06-30 10:52:42 +01:00
Shannon
d1524cdafe Merge branch 'v8/dev' into v8/bugfix/7868-nucache-null-parent
# Conflicts:
#	src/Umbraco.Web/PublishedCache/NuCache/ContentStore.cs
2020-04-17 15:04:10 +10:00
Shannon Deminick
4a071f6e05 Nucache NullReferenceException when copying (#7961)
(cherry picked from commit b30db05cc7)

# Conflicts:
#	src/Umbraco.Tests/PublishedContent/NuCacheChildrenTests.cs
2020-04-15 20:55:11 +02:00
Shannon
36c9cd47a1 Adds notes 2020-04-08 11:22:15 +10:00
Shannon
18d9ad3c73 udpates health check and service methods to be flexible for data integrity checks, fixes tests 2020-04-07 16:42:21 +10:00
Shannon
50e9f79ae6 Adds a null check if things are out of order when building up the tree/linked list 2020-04-06 23:10:52 +10:00
Shannon
c9c8693560 removes one null check, adds notes 2020-04-01 13:13:15 +11:00
Shannon
f1b398fab6 Adds some null checks, need to see if tests pass 2020-04-01 11:06:21 +11:00
Bjarke Berg
fd11ef6ed1 Merge pull request #7306 from umbraco/v8/bugfix/AB3323-SqlMainDom
Introduce a new IMainDomLock and both default and sql implementations
2020-01-23 12:44:11 +01:00
Shannon
3e71de4698 ensure locks the data types 2020-01-13 22:28:25 +11:00
Shannon
d26334ad39 Fixes the issue of manipulating data for an existing Gen, adds notes, makes the Gen comparison operator consistent. 2020-01-13 17:16:55 +11:00
Shannon
95337d5a70 Cleans up old notes 2020-01-06 21:39:26 +11:00
Shannon
c2ac5e8531 Fixes a couple more issues with recursive locks 2020-01-06 18:34:04 +11:00
Shannon
243e76b3cc Removes ability to have recursive locks in SnapDictionary, changes logic to require locking around the methods just like ContentStore, updates tests 2020-01-03 15:04:39 +11:00
Shannon
8e3b3c8326 Changes methods that should already be locked to check that they are and changes their names/adds docs 2020-01-03 13:21:49 +11:00
Shannon
e6b333a3ec Changes readlocks to normal locks, no need to have extra objects allocated and complex code. 2020-01-03 12:39:56 +11:00
Shannon
a46e9124d2 First commit in fixing deadlock - committing my notes, etc... 2020-01-03 10:38:48 +11:00
Shannon
8218467e04 Merge branch 'v8/dev' into v8/bugfix/6546-MainDom-Cleanup
# Conflicts:
#	src/Umbraco.Core/MainDom.cs
#	src/Umbraco.Web/PublishedCache/NuCache/ContentStore.cs
#	src/Umbraco.Web/PublishedCache/NuCache/PublishedSnapshotService.cs
2019-12-04 16:09:22 +11:00
Shannon
68db41fe93 Ensures that when there is no cache file, or if a cache file is empty, on startup any call to SetAllFastSorted was not ensuring the local db cache file was updated if the data was loaded from the database. 2019-10-31 18:58:07 +11:00
Shannon
296e1ee80f removes test code 2019-10-22 15:55:43 +02:00
Shannon
652591d1c8 removes TODO 2019-10-22 15:55:36 +02:00
Shannon
4641e61743 Fixes issue - when calling Set, we were not setting all node graph elements. 2019-10-22 15:55:28 +02:00
Shannon
b04f9c17ae Makes some updates based on code reviews 2019-10-22 11:55:05 +11:00
JohnBlair
d774ff8bc1 Undoing a bad previous change where logic in a catch should have been in a finally. Also dispose could throw an error so catch it and complete the clean up. 2019-10-22 11:45:03 +11:00
JohnBlair
e998fce5d1 Trying to lock could throw exceptions so always make sure to properly clean up the local DB. 2019-10-22 11:44:07 +11:00
Shannon
1caf7f4587 Fixes regression issue in nucache causing a panic exception 2019-09-25 13:51:19 +02:00
Shannon
cc1e46ae05 Simplifies ContentStore for all the instances it's trying to find a linked node by a gen 2019-09-18 00:36:12 +10:00
Shannon
e6805b23e3 Oops! didn't complete the scope, ok now package install works within a trans, fixes nucache changes to not pass around _liveGen since sometimes we want the latest that is not _liveGen 2019-09-18 00:10:02 +10:00
Shannon
7fdbb84c04 Fixes bug with nucache - it wasn't using gen/snapshots the way it was supposed to 2019-09-17 22:38:43 +10:00
Shannon
e1433ddac9 Merge remote-tracking branch 'origin/v8/dev' into v8/bugfix/AB2684-purelive-model-regen 2019-09-17 13:09:54 +10:00
Stephan
b51fb2da9d Fix NuCache ContentStore 2019-09-16 17:27:03 +02:00
Shannon
a85d8f3e21 ensure that we don't CreateModel during cache notification 2019-09-16 14:25:02 +10:00
Sebastiaan Janssen
5bbe1fadda Fixes #6021 - Error on save and publish for existing node after content creation in eventhandler 2019-09-05 10:31:08 +02:00
Shannon
fb38d9afe1 Merges - double linked list for children performance + updates 2019-08-19 23:22:27 +10:00
Shannon
f2a22e9843 Ensure we throw an exception when a fatal Exception is caught instead of swallowing 2019-08-19 22:07:22 +10:00
Shannon
890309bc11 Fixes SetAllFastSorted and sort orders 2019-08-19 17:18:45 +10:00
Shannon
e9717ee86a changes to PanicException 2019-08-16 16:18:58 +10:00
Shannon
3d56e45266 Adds notes, cleans up other code 2019-08-15 19:25:28 +10:00
Shannon
e9d4b607bb Adds POC for fast building of in-memory nucache from persisted files 2019-08-15 19:05:43 +10:00
Shannon
16d8f8846e Adds PanicException with details instead of throwing "panic" strings 2019-07-30 22:40:15 +10:00
Shannon Deminick
31716e574c Update src/Umbraco.Web/PublishedCache/NuCache/ContentStore.cs
good catch!

Co-Authored-By: Bjarke Berg <mail@bergmania.dk>
2019-07-03 18:34:11 +10:00
Shannon
7c52b9602c Reduce some allocations and in advertent SQL calls along with inadvertent enumeration of the entire cache, adds some notes 2019-07-03 17:43:30 +10:00
Stephan
b306e41560 NuCache - failover to database when local db fails to load 2019-06-25 13:26:50 +02:00
Stephan
e8d6daf59a NuCache - be more tolerant when cache is weird 2019-06-25 12:54:16 +02:00
Shannon
da1e2680cb Fixes ContentStore when it's building the cache from sources, adds TODO notes, questions, concerns, etc.... 2019-06-21 15:47:47 +10:00
Stephan
62e6168e03 Revert ContentStore changes - have to find the bug now 2019-06-18 11:36:53 +02:00
Shannon
fecadeec51 Fixes issue with nucache and rebuilding and fixes ChildrenForAllCultures to deal with unpublished children 2019-06-18 11:57:36 +10:00
Stephan
94d2a5cbad Bugfix published cache and children 2019-06-17 13:03:01 +02:00
Stephan
9c252131f7 Better exception message in NuCache 2019-06-12 08:55:03 +02:00
Shannon
8eafadc29b adds some more info to panic exceptions 2019-06-12 14:00:28 +10:00