Elitsa Marinovska
84f19e093a
NetCore: Refactor internal usages of UmbracoHelper ( #7744 )
...
* Removing properties related to IPublishedContentQuery, ITagQuery, ICultureDictionaryFactory, IUmbracoComponentRenderer from UmbracoHelper and using the corresponding private fields instead. Removing Media related methods
* Removed UmbracoHelper from UmbracoApiControllerBase
* Removed UmbracoHelper references
* Inject the needed Interfaces to classes that previously used UmbracoHelper to get the same functionality
* Fixed tests referencing UmbracoHelper
* Adding Media methods back
* Cleanup and moved UmbracoHelper from more base classes, when not used + simplified tests
* Reintroduced some methods..
* Reintroduced some methods..
* Reintroducing last missing bits
Co-authored-by: Bjarke Berg <mail@bergmania.dk >
2020-03-03 11:59:17 +01:00
Bjarke Berg
8e3cb8f3e6
Removed MembershipHelper from UmbracoHelper
2020-02-27 09:56:35 +01:00
Andy Butland
d1373862e5
Removed Url property from IPublishedContent and amended usages to use the existing Url() extension method.
2020-01-31 13:09:33 +01:00
Shannon
1136e15a27
kill user membership provider, adds some passwords api abstractions, moves membership provider logic out of Core/services, removes membership scenario and other membership code we don't want anymore.
2019-11-25 21:20:00 +11:00
Ronald Barendse
101a8b6c78
Added ValidateUmbracoFormRouteStringAttribute to public controllers
2019-07-14 23:18:21 +02:00
Sebastiaan Janssen
4d2c551b79
Merge branch 'v7/dev' into v8/dev
2019-07-02 22:01:34 +02:00
Bjarke Berg
1770a0abec
Inject IUmbracoContextAccessor instead of UmbracoContext
2019-02-14 12:40:45 +01:00
Shannon
7b55d2f1b2
New IMacroRenderer and ITemplateRenderer and hides underlying logic for these in internal classes. Massively cleans up the macro rendering logic (almost makes sense now), removes unused macro code, injects UmbracoHelper wherever it's needed (not creating manually), fixes UmbracoHelper to have it's services injected, no more empty services, allows setting the AssignedContentItem on the UmbracoHelper and ensures it's lifespan is Transient, updates all corresponding ctors. Fixes macro rendering, ensures the correct culture variation is assigned, and that we can render macros for any given IPublishedContent, not just the one assigned in the request.
2019-01-31 15:09:31 +11:00
Chris Houston
193e24afd2
Fixing all the TODO, FIXME & HACK comments so they all follow the same layout.
2019-01-27 11:16:00 +01:00
Stephan
9522ee826f
Deal with fixme in Umbraco.Web
2019-01-21 16:01:37 +01:00
Stephan
3982732b7d
Fix merge + cleanup
2019-01-18 15:05:20 +01:00
Stephan
876056f0bb
Merge branch temp8 into temp8-appCaches
2019-01-18 14:54:08 +01:00
Stephan
67e4703821
CacheHelper becomes AppCaches
2019-01-17 08:34:29 +01:00
Shannon
355ac09d90
WIP - moved out the tree and section service from Core, these are web only things, removes their xml parsing, fixes base controller ctor params with UmbracoContext, need to implement tree/section collections taking into account controllers and not scanning so much
2019-01-17 13:20:19 +11:00
Stephan
a60fd1b7be
Merge branch origin/temp8 into temp8-di2690
2018-12-21 15:47:08 +01:00
Shannon
2fcb30e54e
Merge remote-tracking branch 'origin/dev-v7' into temp8
...
# Conflicts:
# .editorconfig
# .gitignore
# src/Umbraco.Core/Persistence/Repositories/EntityRepository.cs
# src/Umbraco.Core/Persistence/Repositories/UserRepository.cs
# src/Umbraco.Web.UI.Client/src/common/services/navigation.service.js
# src/Umbraco.Web.UI.Client/src/less/components/buttons/umb-era-button.less
# src/Umbraco.Web.UI.Client/src/views/common/dialogs/login.html
# src/Umbraco.Web.UI.Client/src/views/common/overlays/contenttypeeditor/compositions/compositions.controller.js
# src/Umbraco.Web.UI.Client/src/views/common/overlays/contenttypeeditor/compositions/compositions.html
# src/Umbraco.Web.UI.Client/src/views/content/content.delete.controller.js
# src/Umbraco.Web.UI.Client/src/views/content/content.restore.controller.js
# src/Umbraco.Web.UI.Client/src/views/content/restore.html
# src/Umbraco.Web.UI.Client/src/views/dashboard/developer/healthcheck.html
# src/Umbraco.Web.UI.Client/src/views/media/media.move.controller.js
# src/Umbraco.Web.UI.Client/src/views/media/move.html
# src/Umbraco.Web.UI.Client/src/views/propertyeditors/grid/dialogs/layoutconfig.controller.js
# src/Umbraco.Web.UI.Client/src/views/propertyeditors/grid/dialogs/rowconfig.controller.js
# src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/listview.controller.js
# src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/listview.html
# src/Umbraco.Web.UI/Umbraco/config/lang/da.xml
# src/Umbraco.Web.UI/config/umbracoSettings.Release.config
# src/Umbraco.Web.UI/umbraco/config/lang/en.xml
# src/Umbraco.Web.UI/umbraco/config/lang/en_us.xml
# src/Umbraco.Web/Controllers/UmbLoginController.cs
# src/Umbraco.Web/Controllers/UmbLoginStatusController.cs
# src/Umbraco.Web/Controllers/UmbProfileController.cs
# src/Umbraco.Web/Controllers/UmbRegisterController.cs
# src/Umbraco.Web/Editors/ContentController.cs
# src/Umbraco.Web/Editors/ContentTypeControllerBase.cs
# src/Umbraco.Web/HtmlHelperRenderExtensions.cs
# src/Umbraco.Web/Trees/ContentTreeController.cs
# src/Umbraco.Web/Trees/MediaTreeController.cs
# src/Umbraco.Web/umbraco.presentation/umbraco/create/XsltTasks.cs
# src/Umbraco.Web/umbraco.presentation/umbraco/create/xslt.ascx.cs
# src/Umbraco.Web/umbraco.presentation/umbraco/developer/Xslt/editXslt.aspx.cs
# src/Umbraco.Web/umbraco.presentation/umbraco/webservices/codeEditorSave.asmx.cs
2018-12-20 16:58:01 +11:00
elitsa
3c74ce2427
Implementing anti forgery token which will not allows members to be created by sending a request directly to the registration controller when the request is not coming from a page in the application
2018-12-10 08:55:54 +01:00
Stephan
c23c7749b4
Composition fixes
2018-11-27 14:04:08 +01:00
Stephan
6ffc340725
Merge branch temp8 into temp8-di2690
2018-11-23 14:58:08 +01:00
Warren Buckley
54a2aa00a7
Revert "Temp8 tinymce"
2018-11-22 14:05:51 +00:00
Shannon
c3736ce7ab
Merge remote-tracking branch 'origin/dev-v7' into temp8
...
# Conflicts:
# .github/README.md
# build.bat
# src/Umbraco.Core/Migrations/Expressions/Alter/Table/AlterTableBuilder.cs
# src/Umbraco.Core/Migrations/Expressions/Create/Column/CreateColumnBuilder.cs
# src/Umbraco.Core/Migrations/Expressions/Create/Index/CreateIndexBuilder.cs
# src/Umbraco.Core/Migrations/Expressions/Create/Table/CreateTableBuilder.cs
# src/Umbraco.Core/Persistence/DatabaseModelDefinitions/DefinitionFactory.cs
# src/Umbraco.Core/Persistence/DatabaseModelDefinitions/IndexDefinition.cs
# src/Umbraco.Core/Persistence/Factories/MediaFactory.cs
# src/Umbraco.Core/Persistence/Migrations/Syntax/Alter/Column/AlterColumnBuilder.cs
# src/Umbraco.Core/Persistence/Repositories/EntityRepository.cs
# src/Umbraco.Core/Persistence/Repositories/UserRepository.cs
# src/Umbraco.Core/Persistence/Repositories/VersionableRepositoryBase.cs
# src/Umbraco.Core/Persistence/SqlSyntax/MySqlSyntaxProvider.cs
# src/Umbraco.Core/Services/EntityService.cs
# src/Umbraco.Core/Services/IMediaService.cs
# src/Umbraco.Core/Services/MediaService.cs
# src/Umbraco.Core/Services/NotificationService.cs
# src/Umbraco.Web.UI.Client/bower.json
# src/Umbraco.Web.UI.Client/src/common/directives/components/imaging/umbimagegravity.directive.js
# src/Umbraco.Web.UI.Client/src/common/directives/components/tree/umbtreeitem.directive.js
# src/Umbraco.Web.UI.Client/src/common/directives/validation/valtab.directive.js
# src/Umbraco.Web.UI.Client/src/common/resources/media.resource.js
# src/Umbraco.Web.UI.Client/src/common/resources/mediatype.resource.js
# src/Umbraco.Web.UI.Client/src/controllers/navigation.controller.js
# src/Umbraco.Web.UI.Client/src/less/main.less
# src/Umbraco.Web.UI.Client/src/less/panel.less
# src/Umbraco.Web.UI.Client/src/less/property-editors.less
# src/Umbraco.Web.UI.Client/src/views/common/infiniteeditors/mediapicker/mediapicker.controller.js
# src/Umbraco.Web.UI.Client/src/views/common/overlays/mediaPicker/mediapicker.html
# src/Umbraco.Web.UI.Client/src/views/components/imaging/umb-image-gravity.html
# src/Umbraco.Web.UI.Client/src/views/content/copy.html
# src/Umbraco.Web.UI.Client/src/views/content/emptyrecyclebin.html
# src/Umbraco.Web.UI.Client/src/views/content/move.html
# src/Umbraco.Web.UI.Client/src/views/dashboard/settings/settingsdashboardintro.html
# src/Umbraco.Web.UI.Client/src/views/datatypes/move.html
# src/Umbraco.Web.UI.Client/src/views/documenttypes/copy.html
# src/Umbraco.Web.UI.Client/src/views/documenttypes/create.html
# src/Umbraco.Web.UI.Client/src/views/documenttypes/move.html
# src/Umbraco.Web.UI.Client/src/views/documenttypes/views/templates/templates.controller.js
# src/Umbraco.Web.UI.Client/src/views/documenttypes/views/templates/templates.html
# src/Umbraco.Web.UI.Client/src/views/media/move.html
# src/Umbraco.Web.UI.Client/src/views/mediatypes/copy.html
# src/Umbraco.Web.UI.Client/src/views/mediatypes/create.html
# src/Umbraco.Web.UI.Client/src/views/mediatypes/move.html
# src/Umbraco.Web.UI.Client/src/views/propertyeditors/fileupload/fileupload.controller.js
# src/Umbraco.Web.UI.Client/src/views/propertyeditors/imagecropper/imagecropper.prevalues.html
# src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/listview.controller.js
# src/Umbraco.Web.UI.Client/src/views/propertyeditors/listview/listview.html
# src/Umbraco.Web.UI.Client/src/views/propertyeditors/mediapicker/mediapicker.controller.js
# src/Umbraco.Web.UI.Client/src/views/propertyeditors/mediapicker/mediapicker.html
# src/Umbraco.Web.UI.Client/src/views/propertyeditors/radiobuttons/radiobuttons.html
# src/Umbraco.Web.UI.Client/src/views/users/views/user/details.html
# src/Umbraco.Web.UI/Umbraco/config/lang/da.xml
# src/Umbraco.Web.UI/Umbraco/config/lang/fr.xml
# src/Umbraco.Web.UI/Umbraco/config/lang/nl.xml
# src/Umbraco.Web.UI/Umbraco/config/lang/pl.xml
# src/Umbraco.Web.UI/Umbraco/config/lang/ru.xml
# src/Umbraco.Web.UI/Umbraco/config/lang/sv.xml
# src/Umbraco.Web.UI/Umbraco/config/lang/zh.xml
# src/Umbraco.Web.UI/Umbraco/developer/Macros/editMacro.aspx
# src/Umbraco.Web.UI/Umbraco/dialogs/ChangeDocType.aspx
# src/Umbraco.Web.UI/umbraco/config/lang/en.xml
# src/Umbraco.Web.UI/umbraco/config/lang/en_us.xml
# src/Umbraco.Web.UI/umbraco/config/lang/es.xml
# src/Umbraco.Web.UI/umbraco/dialogs/editMacro.aspx
# src/Umbraco.Web/Controllers/UmbLoginController.cs
# src/Umbraco.Web/Editors/ContentControllerBase.cs
# src/Umbraco.Web/Editors/ContentTypeController.cs
# src/Umbraco.Web/Editors/MediaController.cs
# src/Umbraco.Web/Editors/PasswordChanger.cs
# src/Umbraco.Web/HttpRequestExtensions.cs
# src/Umbraco.Web/Models/ContentEditing/Tab.cs
# src/Umbraco.Web/PropertyEditors/ImageCropperPropertyEditor.cs
# src/Umbraco.Web/Templates/TemplateRenderer.cs
# src/Umbraco.Web/Trees/ApplicationTreeController.cs
# src/Umbraco.Web/Trees/ContentTreeController.cs
# src/Umbraco.Web/Trees/ContentTreeControllerBase.cs
# src/Umbraco.Web/Trees/MediaTreeController.cs
# src/Umbraco.Web/_Legacy/Controls/TabView.cs
# src/Umbraco.Web/umbraco.presentation/umbraco/developer/RelationTypes/EditRelationType.aspx.cs
# src/Umbraco.Web/umbraco.presentation/umbraco/developer/Xslt/editXslt.aspx.cs
# src/Umbraco.Web/umbraco.presentation/umbraco/dialogs/protectPage.aspx.cs
# src/Umbraco.Web/umbraco.presentation/umbraco/settings/editLanguage.aspx.cs
# src/umbraco.cms/Actions/Action.cs
# src/umbraco.providers/members/UmbracoMembershipProvider.cs
2018-11-19 15:32:26 +11:00
GwanYeong Kim
b539cc2a7a
Remove this commented out code
2018-10-23 09:43:29 +02:00
Stephan
57d7888740
Merge branch temp8 into temp8-di
2018-07-06 17:49:02 +02:00
Stephan
7a615133ff
Renormalize
2018-06-29 19:52:40 +02:00
Lars-Erik Aabech
e4aca5f5d8
Several property injections removed from Mvc artifacts and base classes
2018-06-19 18:53:25 +02:00
Stephan
0a4878d2a3
Port v7@2aa0dfb2c5 - WIP
2018-03-27 10:04:07 +02:00
Ian Houghton
f5f3676a56
U4-10762 Fix issue with empty name when registering new members from snippet
2018-01-09 15:51:32 +00:00
Stephan
c76403077f
Normalize cr/lf/tab
2017-07-20 11:21:28 +02:00
Stephan
8561d85f7a
porting 7.6-rc1 into 8
2017-05-24 12:25:39 +02:00
Niels Hartvig
da27108d0d
Updates login controller to not accept non local urls
2016-12-19 10:44:22 +01:00
Stephan
0597eea72b
Resvolution - Components, Runtime & Booting
2016-09-19 16:33:43 +02:00
Shannon
e3598b99a5
Ensures tempdata is set on our member controllers in the correct place and ensures that the RegisterModel doesn't explicitly set the RedirectUrl because we want it to be empty by default.
2015-08-27 14:56:42 +02:00
Shannon
cd3c17d73f
Obsoletes AllowAll on MemberAuthorizeAttribute
2015-08-21 12:15:45 +02:00
Shannon
fe6d783222
auths member controllers
2015-08-21 12:11:22 +02:00
Shannon
508a40cd50
Merge remote-tracking branch 'origin/6.2.0' into 7.1.2
...
Conflicts:
src/Umbraco.Web/Controllers/UmbRegisterController.cs
src/Umbraco.Web/Models/RegisterModel.cs
2014-04-23 12:00:32 +10:00
Shannon
a92c232178
Fixes: U4-4653 MembershipHelper RegisterMember does not set password and ignores logMemberIn, adds a new flag to the model as to whether or not to have the cookie set as a persistent cookie (default is true)
2014-04-22 19:03:43 +10:00
Sebastiaan Janssen
f6d56f51d4
Merge branch '6.2.0' of https://github.com/umbraco/Umbraco-CMS into 7.1.0
...
Conflicts:
src/Umbraco.Core/Services/IRelationService.cs
src/Umbraco.Web/Controllers/UmbRegisterController.cs
2014-04-02 12:01:55 +02:00
Sebastiaan Janssen
53c0bd6938
Fixes: Password is not saved when using the Register snippet
2014-04-02 11:59:16 +02:00
Shannon
4d13925e3b
Fixes merge issues
2014-03-18 19:05:07 +11:00
Shannon
fd14065f14
Merge remote-tracking branch 'origin/6.2.0' into 7.1.0
...
Conflicts:
src/Umbraco.Core/Models/Member.cs
src/Umbraco.Core/Models/Membership/MembershipUserExtensions.cs
src/Umbraco.Core/Persistence/Factories/MemberFactory.cs
src/Umbraco.Core/Persistence/Factories/MemberReadOnlyFactory.cs
src/Umbraco.Core/Persistence/Mappers/MemberMapper.cs
src/Umbraco.Core/Persistence/Repositories/MemberRepository.cs
src/Umbraco.Core/Services/IMembershipUserService.cs
src/Umbraco.Core/Services/UserService.cs
src/Umbraco.Tests/Persistence/Repositories/MemberRepositoryTest.cs
src/Umbraco.Tests/Persistence/Repositories/UserRepositoryTest.cs
src/Umbraco.Tests/Services/ContentServiceTests.cs
src/Umbraco.Tests/TestHelpers/Entities/MockedMember.cs
src/Umbraco.Tests/TestHelpers/Entities/MockedUser.cs
src/Umbraco.Web.UI/install/steps/DefaultUser.ascx.cs
src/Umbraco.Web/Controllers/UmbProfileController.cs
src/Umbraco.Web/Routing/PublishedContentRequestEngine.cs
src/Umbraco.Web/Security/WebSecurity.cs
src/Umbraco.Web/umbraco.presentation/LegacyClasses.cs
src/Umbraco.Web/umbraco.presentation/install/steps/LegacyClasses.cs
src/Umbraco.Web/umbraco.presentation/umbraco/channels/UmbracoMetaWeblogAPI.cs
src/Umbraco.Web/umbraco.presentation/umbraco/create/member.ascx.cs
src/Umbraco.Web/umbraco.presentation/umbraco/create/memberTasks.cs
src/Umbraco.Web/umbraco.presentation/umbraco/create/userTasks.cs
src/Umbraco.Web/umbraco.presentation/umbraco/dashboard/ChangePassword.ascx.cs
src/Umbraco.Web/umbraco.presentation/umbraco/login.aspx.cs
src/Umbraco.Web/umbraco.presentation/umbraco/members/EditMember.aspx.cs
src/Umbraco.Web/umbraco.presentation/umbraco/webservices/MediaUploader.ashx.cs
2014-03-18 18:47:49 +11:00
Shannon
e2881e07d1
Ensures that all calls to the members membership provider are done so explicitly with the membership provider alias - this decouples the need to have the umbraco membership provider declared as the default, we were doing both before.
2014-03-18 17:08:21 +11:00
Shannon
b533a9f690
Merge commit '85a74e4fa700c83bab4bf3436f69f045029932cd' into 7.1.0
...
Conflicts:
src/Umbraco.Core/Umbraco.Core.csproj
src/Umbraco.Web/Controllers/UmbLoginController.cs
src/Umbraco.Web/Controllers/UmbLoginStatusController.cs
src/Umbraco.Web/Controllers/UmbProfileController.cs
src/Umbraco.Web/Controllers/UmbRegisterController.cs
2014-03-13 14:12:02 +11:00
Shannon
85a74e4fa7
Fixes: U4-4419 TempData is not being cleared on RedirectToCurrentUmbracoPage - it actually shouldn't be cleared but we need to handle how we add it properly as tempdata only clears when it is read
2014-03-13 12:21:31 +11:00
Shannon
74c777b1ae
Ensures the built-in member controllers have the correct logic - somehow got reverted and then not merged.
2014-03-07 19:39:31 +11:00
Shannon
878156e21e
putting back what the UmbLoginController should be ... where in the hell has this been overwritten from??!
2014-03-07 19:13:25 +11:00
Shannon
f5ee02a3e9
Updates the membership partial view templates to redirect to current page by default but allows this to be overridden. Creates a new RedirectToCurrentUmbracoUrl method which is slightly diff from RedirectToCurrentUmbracoPage since it doesn't care about the actual page item rendering, just the currently rendered URL which is useful if coming from a rewritten URL (which is what happens with public access rewrites)
2014-02-13 13:30:32 +11:00
Shannon
ec08d3e910
Updates MembershipHelper to not change the email/name if the value has not changed. Updates the templates to show only validation summaries for their own values/prefixes. Fixes some underlying MVC methods that merge view state to ensure the prefixes work with validation summaries properly when not showing property level errors. Updates the Umb controllers to add model level validation msgs when failed.
2014-02-10 18:34:12 +11:00
Shannon
0bfd032fad
Obsoletes the RedirectOnSucces on the RegisterModel as it is not needed. Adds RedirectUrl to the ProfileModel and updates the controller to redirect properly (ensures it doesn't just redirect to home!)
2014-02-10 16:46:45 +11:00
Shannon
2bb58b6fca
Updates MembershipHelper to ensure that the membership provider is used when updating a profile, specifically to deal with unique emails. Updates the profile edit template to have correct validation procedures.
2014-02-10 16:22:15 +11:00
Shannon
f28ae52ae3
moved logic to update a profile to MembershipHelper.
2014-01-28 21:57:00 +11:00