Commit Graph

4699 Commits

Author SHA1 Message Date
Warren Buckley
ee348be8a5 Merge pull request #10496 from umbraco/v8/fix/10483
Fixes clashing aliases when new mediatypes had been installed

(cherry picked from commit f69cee87f9)
2021-06-21 19:27:31 +02:00
Warren Buckley
9ef806d4e9 Rename Media Picker 3 and make current Media Picker Obsolete (#10332) 2021-05-26 16:13:25 +02:00
Sebastiaan Janssen
809fd81982 Merge branch 'v8/dev' into v8/contrib
# Conflicts:
#	src/Umbraco.Web.UI.Client/package-lock.json
2021-05-11 10:57:57 +02:00
Patrick de Mooij
499d22aa20 Move the SetWeight logic to WeightedCollectionBuilderBase so other collections can use it too 2021-05-11 14:56:25 +10:00
Shannon
f5406b9b2f Updates to Examine 1.2.0
and removes ExecutionContext workaround since it's part of Examine now.
2021-05-11 14:42:29 +10:00
Sebastiaan Janssen
e7a3fd37ce Revert "Fixed copy preserving sort order (#10091)"
This reverts commit 26d11a8314.
2021-04-27 14:57:17 +02:00
Niels Lyngsø
1a5b88525b Media Picker v3 (#9461)
* set input file accept

* Use PreValue file extensions for limiting the files to be chosen in file input

* Current state for Warren to review

* This should fix up what you need Niels

* update csproj

* use empty string if fileExtensions is undefined

* public interface

* initial work

* local crops

* translations

* translation correction

* fix misspeling

* some progress

* filter media picker

* align media card grid items correctly

* responsive media cropper

* always be able to scale 3 times smallest scale

* making image cropper property editor responsive

* scroll to scale

* adjust slider look

* rearrange parts of mediaentryeditor

* test helper

* styling

* move controls inside umb-image-crop

* seperate umg-cropper-gravity styling

* corrected layout

* more ui refinement

* keep the idea of mandatory out for now.

* remove double ;

* removed testing code

* JSON Property Value Convertor now has an array of property editors to exclude

* Property Value Convertor for Media Picker 3 aka Media Picker with Local Crops

* Experimenting on best approach to retrieve local crop in razor view when iterating over picked media items

* Update ValueConvertor to use ImageCropperValue as part of the model for views as alot of existing CropUrls can then use it

* Update extension methods to take an ImageCropperValue model (localCropData)

* Forgot to update CSProj for new ValueConvertor

* New GetCropUrl @Url.GetCropUrl(crop.Alias, media.LocalCrops) as oppposed to @Url.GetCropUrl(media.LocalCrops, cropAlias:crop.Alias, useCropDimensions: true)

* Remove dupe item in CSProj

* Use a contains as an opposed to Array.IndexOf

* various corrections, SingleMode based on max 1, remove double checkerBackground, enforce validation for Crops, changed error indication

* mediapicker v3

* correct version

* fixing file ext label text color

* clipboard features for MediaPicker v3

* highlight not allowed types

* highlight trashed as an error

* Media Types Video, Sound, Document and Vector Image

* Rename to Audio and VectorGraphics

* Add (SVG) in the name for Vector Graphics

* adding CSV to Documents

* remove this commented code.

* remove this commented code

* number range should not go below 0, at-least as default until we make that configurable.

* use min not ng-min

* description for local crops

* Error/Limits highlighting reactive

* visual adjustments

* Enabling opening filtered folders + corrected select hover states

* Varous fixes to resolve issues with unit tests.

* Refactor MediaType Documents to only contain Article file type

* mark as build-in

* predefined MediaPicker3 DataTypes, renaming v2 to "old"

* set scale bar current value after min and max has been set

* added missing }

* update when focal point is dragged

* adjusted styling for Image Cropper property editor

* correcting comment

* remove todo - message for trashed media items works

* Changed parameter ordering

* Introduced new extension method on MediaWithCrops to get croppings urls in with full path

* Reintroducing Single Item Mode

* use Multiple instead of SingleMode

* renaming and adding multiple to preconfigured datatypes

* Change existing media picker to use the Clipboard type MEDIA, enabling shared functionality.

* clean up unused clipboard parts

* adjusted to new amount

* correcting test

* Fix unit test

* Move MediaWithCrops to separate file and move to Core.Models

* parseContentForPaste

* clean up

* ensure crops is an array.

* actively enable focal points, so we dont set focal points that aren't used.

* only accept files that matches file extensions from Umbraco Settings

* Cleanup

* Add references from MediaPicker3 to media

* corrections from various feedback

* remove comment

* correct wording

* use windowResizeListener

Co-authored-by: Warren Buckley <warren@umbraco.com>
Co-authored-by: Niels Lyngsø <nsl@umbraco.com>
Co-authored-by: Mads Rasmussen <madsr@hey.com>
Co-authored-by: Andy Butland <abutland73@gmail.com>
Co-authored-by: Bjarke Berg <mail@bergmania.dk>
Co-authored-by: Sebastiaan Janssen <sebastiaan@umbraco.com>
Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
2021-04-22 10:28:53 +02:00
Elitsa Marinovska
8e14543616 Merge remote-tracking branch 'origin/v8/dev' into v8/feature/AB10632-recycle-bin-smells-caching 2021-04-15 09:02:53 +02:00
Elitsa Marinovska
038afa5664 Fixing tests after adding the new event related to EmptiedRecycleBin 2021-04-15 09:00:58 +02:00
Sebastiaan Janssen
b0592f1126 Merge branch 'v8/dev' into v8/contrib 2021-04-07 16:27:34 +02:00
Mole
f6eb8c9dbb Merge pull request #9995 from umbraco/v8/feature/10615-mappers-with-explicit-scope
Create explicit scope for mappers in UmbracoMapper
2021-04-07 14:58:39 +02:00
Sebastiaan Janssen
9d5a5d886e Merge branch 'v8/dev' into v8/contrib 2021-04-07 13:45:38 +02:00
Sebastiaan Janssen
d85d0d75f3 Revert "Updated LightInject to v6.4.0"
This reverts commit fc77252ec7.
2021-04-06 16:13:40 +02:00
ric
26d11a8314 Fixed copy preserving sort order (#10091) 2021-04-06 13:44:49 +01:00
Dave de Moel
fc77252ec7 Updated LightInject to v6.4.0 2021-04-06 09:35:12 +02:00
Sebastiaan Janssen
e8a9c4da2e Merge branch 'v8/dev' into v8/contrib 2021-03-31 13:01:25 +02:00
Martin Bentancour
9ac4eacdbd Anchor noopener (#10009)
* Set rel="noopener" for anchors with target="_blank"

* Reverted unwanted changes to Default.cshtml
2021-03-24 02:43:20 +01:00
Mole
507c821f66 Create method for generating log message
And remove forgotten comments.
2021-03-19 13:19:39 +01:00
Mole
8f50bdbef4 Apply suggestions from review 2021-03-18 11:24:14 +01:00
Mole
9bd1b06eaf Only create the dicts and hashset when a lock is requested 2021-03-17 13:09:45 +01:00
Mole
54a4a76efb Use a hashset to keep track of acquired locks
This simplifies disposing/checking for locks greatly.
2021-03-17 11:10:34 +01:00
Mole
68c4ce2008 Wrap calls to map in scopes 2021-03-16 14:18:17 +01:00
Mole
d1afb6eabc Merge remote-tracking branch 'origin/v8/dev' into v8/feature/10613-distributed-locks 2021-03-15 13:19:36 +01:00
Shannon Deminick
d0f047e729 Fixes and Updates for DB Scope and Ambient Context leaks (#9953)
* Adds some scope tests (ported back from netcore) and provides a much better error message, ensure execution context is not flowed to child tasks that shouldn't leak any current ambient context

* updates comment

* Ensure SqlMainDomLock suppresses execution context too

* Since we're awaiting a task in a library method, ConfigureAwait(false)

* missing null check

Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
2021-03-15 12:56:38 +01:00
Mole
92fd9ff685 Clean 2021-03-15 11:31:23 +01:00
Mole
ef59829489 Throw error if all scopes hasn't been disposed 2021-03-15 08:54:52 +01:00
Mole
cee33e863e Fix errors shown in unit tests 2021-03-15 08:38:23 +01:00
Mole
ea816e8110 Add more unit tests, showing current issue 2021-03-12 13:30:25 +01:00
Mole
5c7e4f8dde Adjust unit tests and apply fixes to scope 2021-03-12 13:10:17 +01:00
Sebastiaan Janssen
9b39bfbf51 Merge branch 'v8/dev' into v8/contrib 2021-03-12 09:30:30 +01:00
Mole
c69a89baf1 Merge branch 'v8/dev' into v8/feature/10613-distributed-locks 2021-03-11 13:43:07 +01:00
Bjarke Berg
8cd41ab36a Merge pull request #9924 from umbraco/v8/feature/10613-distributed-locks
Change scope to only acquire distributed locks once in a scope chain.
2021-03-10 15:51:04 +01:00
Sebastiaan Janssen
a997f0c1e5 Merge branch 'v8/dev' into v8/contrib
# Conflicts:
#	src/Umbraco.Web/Editors/BackOfficeServerVariables.cs
2021-03-09 15:02:46 +01:00
Bjarke Berg
745014a4c3 User manager related updates (#9935)
* Only allow not-admins to assign groups they have themselves

* Only admins is allowed to change password of other admins

* Fixed issue with deep clone of UserGroup. The Allowed sections was not cloned. This resulted in the allowed sections of the object stored in cache was updated, everytime we changed the allowed sections on an object cloned from the cache. Even if we did not save it.

* Only Admins are allowed to add sections to a user group, that they don't have access to themselves

* Align backend code with UI. User managers that is are not admin, can only assign the same groups new users, that they have themselves.

* Make existingGroupAliases and empty array when creating a new user

Co-authored-by: Mole <nikolajlauridsen@protonmail.ch>
2021-03-08 13:26:52 +01:00
Sebastiaan Janssen
7d0b5ecd14 Merge branch 'v8/dev' into v8/contrib 2021-03-03 17:57:00 +01:00
Bjarke Berg
1bac97e0b0 Bugfix: Members not locked out after failed login attempts (#9921)
* https://github.com/umbraco/Umbraco-CMS/issues/9861
Added test that shows the error

* https://github.com/umbraco/Umbraco-CMS/issues/9861
Fixed test that shows the error. Caches needs to be active, otherwise it do not show the error

* https://github.com/umbraco/Umbraco-CMS/issues/9861
More fix of test that shows the error. Caches needs to be active, otherwise it do not show the error

* https://github.com/umbraco/Umbraco-CMS/issues/9861
Fix issue by raise event and thereby update caches.

Co-authored-by: Elitsa Marinovska <elm@umbraco.dk>
2021-03-03 15:00:45 +01:00
Mole
8c99a8e8a7 Combine the two lock inner methods into one
And add a couple of more unit tests
2021-03-02 13:07:04 +01:00
Mole
e75edbcaf0 Add more tests. 2021-03-02 10:53:55 +01:00
Mole
400b436d98 Fir stab/POC
This still need ALOT of work, but is just an attempt to get my head around things.
2021-03-01 16:06:16 +01:00
Sebastiaan Janssen
ece7008ce7 Merge branch 'v8/dev' into v8/contrib 2021-03-01 16:06:12 +01:00
Patrick de Mooij
3139eb310e 9842: Fix for defaultConfig not working without prevalues 2021-02-26 00:22:50 +01:00
Bjarke Berg
3e7f912fcd Merge pull request #9441 from umbraco/v8/bugfix/explicit-scope-examine
Ensure there's explicit scopes used for all service access in the Examine indexing logic
2021-02-24 08:17:49 +01:00
Chad
b8540ca128 Improve speed and reduce allocations by implementing logger overloads to avoid params [] allocation (#8917)
* Implement logger overloads to avoid params [] allocation

* Implement console logger ILogger

* Call correct signature

* Fix exceptions

* Introduce ILogger2

* fix logger reference

Co-authored-by: Nathan Woulfe <nathan@nathanw.com.au>
2021-02-22 08:22:49 +10:00
Matthew-Wise
d85b6694fe Make models builder properties virtual to allow mocking (#9335) 2021-02-21 17:19:48 +01:00
Sebastiaan Janssen
f27a3be4e6 Fix unit tests after merging PR #9646 2021-02-21 10:30:17 +01:00
Sebastiaan Janssen
980acafbeb Merge branch 'v8/contrib' into v8/dev 2021-02-20 17:17:27 +01:00
Sebastiaan Janssen
2c54adacf2 Add the ability to change the SQL Write Lock TimeOut (#9750)
Co-authored-by: Shannon <sdeminick@gmail.com>
2021-02-20 13:44:15 +01:00
Sebastiaan Janssen
81f1c2e7d6 Update to latest Examine 2021-02-18 22:08:12 +01:00
Bjarke Berg
4aff5d38f8 Merge pull request #9778 from umbraco/v8/bugfix/broken-user-permissions-caches
Fixes issue with broken caches used for user permissions
2021-02-16 13:41:29 +01:00
Bjarke Berg
176b10cf5d Added overloads to inject AppCaches + Fixed tests 2021-02-16 10:56:16 +01:00