* Removed obsoletes from IConfigManipulator. * Removed obsolete models builder extensions. * Removed the obsolete ContentDashboardSettings. * Removed the obsolete InstallMissingDatabase setting on GlobalSettings. * Removed obsolete NuCache settings. * Removed obsolete RuntimeMinificationSettings. * Removed obsolete health check constant. * Removed obsolete icon constant. * Removed obsolete telemetry constant. * Removed obsolete property and constructor on UmbracoBuilder. * Removed obsolete constructor on AuditNotificationsHandler. * Removed obsolete constructor on HTTP header health checks. * Removed obsolete constructor on MediaFileManager. * Removed obsolete GetDefaultFileContent on ViewHelper. * Remove obsoleted methods on embed providers. * Fix tests. * Removed obsolete constructors on BlockEditorDataConverter. * Removed obsolete SeedCacheDuration property on CacheSettings. * Removed obsolete PublishCulture on ContentRepositoryExtensions. * Removed obsolete MonitorLock. * Removed obsolete synchronous HasSavedValues from IDataTypeUsageService and IDataTypeUsageRepository. * Removed obsolete HasSavedPropertyValues from IPropertyTypeUsageService and IPropertyTypeUsageRepository. * Removed obsolete methods in ITrackedReferencesService and ITrackedReferencesRepository. * Removed obsolete DateValueEditor constructors. * Removed obsolete GetAutomaticRelationTypesAliases. * Removed obsolete constructor on TextOnlyValueEditor. * Removed obsolete constructors on RegexValidator and RequiredValidator. * Removed obsolete constructs on SliderValueConverter and TagsValueConverter. * Removed obsolete GetContentType methods from IPublishedCache. * Removed ContentFinderByIdPath. * Removed obsolete constructor on DefaultMediaUrlProvider. * Removed obsolete constructor on Domain. * Removed obsolete constructor on PublishedRequest. * Removed obsolete methods on CheckPermissions. * Removed obsolete GetUserId from IBackOfficeSecurity. * Removed obsolete methods on LegacyPasswordSecurity. * Removed obsolete constructors on AuditService. * Removed obsolete methods on IContentEditingService. * Remove obsolete constructors and methods on ContentService/IContentService. * Removed obsolete constructor in ContentTypeEditingService. * Removed obsolete constructor in MediaTypeEditingService. * Removed obsolete constructor in MemberTypeEditingService. * Removed obsolete constructor in ContentTypeService. * Removed obsolete constructors in ContentTypeServiceBase. * Removed obsolete constructors and methods in ContentVersionService. * Removed obsolete constructor in DataTypeUsageService. * Removed obsolete constructor in DomainService. * Removed obsolete constructor in FileService. * Removes obsolete AttemptMove from IContentService. * Removes obsolete SetPreventCleanup from IContentVersionService. * Removes obsolete GetReferences from IDataTypeService. * Removed obsolete SetConsentLevel from IMetricsConsentService. * Removed obsolete methods from IPackageDataInstallation. * Removed obsolete methods from IPackagingService. * Removed obsolete methods on ITwoFactorLoginService. Removed obsolete ITemporaryMediaService. * Removed obsolete constructor from MediaService, MemberTypeService and MediaTypeService. * More obsolete constructors. * Removed obsoleted overloads on IPropertyValidationService. * Fixed build for tests. * Removed obsolete constructor for PublicAccessService, UserService and RelationService. * Removed GetDefaultMemberType. * Removed obsolete user group functionality from IUserService. * Removed obsolete extension methods on IUserService. * Removed obsolete method from ITelemetryService. * Removed obsolete UdiParserServiceConnectors. * Removed obsolete method on ICookieManager. * Removed obsolete DynamicContext. * Removed obsolete XmlHelper. * Fixed failing integration tests. * Removed obsoletes in Umbraco.Cms.Api.Common * Removed obsoletes in Umbraco.Cms.Api.Delivery * Removed obsoletes in Umbraco.Cms.Api.Management * Removed obsoletes in Umbraco.Examine.Lucene * Removed obsoletes in Umbraco.Infrastructure * Fix failing delivery API contract integration test. * Made integration tests internal. * Removed obsoletes from web projects. * Fix build. * Removed Twitter OEmbed provider * Removed obsolete constructor on PublishedDataType. * Removed obsolete constructors on PublishedCacheBase. * Removed the obsolete PropertyEditorTagsExtensions. * Removed obsoletion properties on configuration response models (#18697) * Removed obsolete methods from server-side models. * Update client-side types and sdk. * Update client-side files. * Removed obsoletion of Utf8ToAsciiConverter.ToAsciiString overload. (#18694) * Removed obsolete method in UserService. (#18710) * Removed obsoleted group alias keys from being publicly available. (#18682) * Removed unneceessary ApiVersion attribute. * Clean-up obsoletions on MemberService (#18703) * Removed obsoleted method on MemberService, added future obsoletion to interface and updated all callers. * Removed obsoletion on member service method that's not obsolete on the interface.
193 lines
8.1 KiB
C#
193 lines
8.1 KiB
C#
using NUnit.Framework;
|
|
using Umbraco.Cms.Core;
|
|
using Umbraco.Cms.Core.Configuration.Models;
|
|
using Umbraco.Cms.Core.Models;
|
|
using Umbraco.Cms.Core.Models.Membership;
|
|
using Umbraco.Cms.Core.Services.OperationStatus;
|
|
|
|
namespace Umbraco.Cms.Tests.Integration.Umbraco.Core.Services;
|
|
|
|
internal sealed partial class UserServiceCrudTests
|
|
{
|
|
[Test]
|
|
public async Task Only_Super_User_Can_Get_Super_user()
|
|
{
|
|
var userService = CreateUserService();
|
|
var editorGroup = await UserGroupService.GetAsync(Constants.Security.EditorGroupKey);
|
|
var adminGroup = await UserGroupService.GetAsync(Constants.Security.AdminGroupKey);
|
|
|
|
var nonSuperCreateModel = new UserCreateModel
|
|
{
|
|
Email = "not@super.com",
|
|
UserName = "not@super.com",
|
|
UserGroupKeys = new HashSet<Guid> { editorGroup.Key, adminGroup.Key },
|
|
Name = "Not A Super User"
|
|
};
|
|
|
|
var createEditorAttempt = await userService.CreateAsync(Constants.Security.SuperUserKey, nonSuperCreateModel, true);
|
|
Assert.IsTrue(createEditorAttempt.Success);
|
|
|
|
var editor = createEditorAttempt.Result.CreatedUser;
|
|
var allUsersAttempt = await userService.GetAllAsync(editor!.Key, 0, 10000);
|
|
|
|
Assert.IsTrue(allUsersAttempt.Success);
|
|
var result = allUsersAttempt.Result;
|
|
Assert.IsNotNull(result);
|
|
Assert.AreEqual(1, result.Items.Count());
|
|
Assert.AreEqual(1, result.Total);
|
|
var onlyUser = result.Items.First();
|
|
Assert.AreEqual(editor.Key, onlyUser.Key);
|
|
}
|
|
|
|
[Test]
|
|
public async Task Super_User_Can_See_Super_User()
|
|
{
|
|
var userService = CreateUserService();
|
|
var editorGroup = await UserGroupService.GetAsync(Constants.Security.EditorGroupKey);
|
|
|
|
var nonSuperCreateModel = new UserCreateModel
|
|
{
|
|
Email = "not@super.com",
|
|
UserName = "not@super.com",
|
|
UserGroupKeys = new HashSet<Guid> { editorGroup.Key },
|
|
Name = "Not A Super User"
|
|
};
|
|
|
|
var createEditorAttempt = await userService.CreateAsync(Constants.Security.SuperUserKey, nonSuperCreateModel, true);
|
|
Assert.IsTrue(createEditorAttempt.Success);
|
|
|
|
var editor = createEditorAttempt.Result.CreatedUser;
|
|
var allUsersAttempt = await userService.GetAllAsync(Constants.Security.SuperUserKey, 0, 10000);
|
|
Assert.IsTrue(allUsersAttempt.Success);
|
|
var result = allUsersAttempt.Result;
|
|
|
|
Assert.AreEqual(2, result.Items.Count());
|
|
Assert.AreEqual(2, result.Total);
|
|
Assert.IsTrue(result.Items.Any(x => x.Key == Constants.Security.SuperUserKey));
|
|
Assert.IsTrue(result.Items.Any(x => x.Key == editor!.Key));
|
|
}
|
|
|
|
[Test]
|
|
public async Task Non_Admins_Cannot_Get_admins()
|
|
{
|
|
var userService = CreateUserService();
|
|
var adminGroup = await UserGroupService.GetAsync(Constants.Security.AdminGroupKey);
|
|
var editorGroup = await UserGroupService.GetAsync(Constants.Security.EditorGroupKey);
|
|
|
|
var editorCreateModel = new UserCreateModel
|
|
{
|
|
UserName = "editor@mail.com",
|
|
Email = "editor@mail.com",
|
|
Name = "Editor Mc. Gee",
|
|
UserGroupKeys = new HashSet<Guid> { editorGroup.Key },
|
|
};
|
|
|
|
var adminCreateModel = new UserCreateModel
|
|
{
|
|
UserName = "admin@mail.com",
|
|
Email = "admin@mail.com",
|
|
Name = "Admin Mc. Gee",
|
|
UserGroupKeys = new HashSet<Guid> { editorGroup.Key, adminGroup.Key },
|
|
};
|
|
|
|
var createEditorAttempt = await userService.CreateAsync(Constants.Security.SuperUserKey, editorCreateModel, true);
|
|
var createAdminAttempt = await userService.CreateAsync(Constants.Security.SuperUserKey, adminCreateModel, true);
|
|
|
|
Assert.IsTrue(createEditorAttempt.Success);
|
|
Assert.IsTrue(createAdminAttempt.Success);
|
|
|
|
var editorAllUsersAttempt = await userService.GetAllAsync(createEditorAttempt.Result.CreatedUser!.Key, 0, 10000);
|
|
Assert.IsTrue(editorAllUsersAttempt.Success);
|
|
var editorAllUsers = editorAllUsersAttempt.Result.Items.ToList();
|
|
Assert.AreEqual(1, editorAllUsers.Count);
|
|
Assert.AreEqual(createEditorAttempt.Result.CreatedUser!.Key, editorAllUsers.First().Key);
|
|
}
|
|
|
|
[Test]
|
|
public async Task Admins_Can_See_Admins()
|
|
{
|
|
var userService = CreateUserService();
|
|
var adminGroup = await UserGroupService.GetAsync(Constants.Security.AdminGroupKey);
|
|
var editorGroup = await UserGroupService.GetAsync(Constants.Security.EditorGroupKey);
|
|
|
|
var editorCreateModel = new UserCreateModel
|
|
{
|
|
UserName = "editor@mail.com",
|
|
Email = "editor@mail.com",
|
|
Name = "Editor Mc. Gee",
|
|
UserGroupKeys = new HashSet<Guid> { editorGroup.Key },
|
|
};
|
|
|
|
var adminCreateModel = new UserCreateModel
|
|
{
|
|
UserName = "admin@mail.com",
|
|
Email = "admin@mail.com",
|
|
Name = "Admin Mc. Gee",
|
|
UserGroupKeys = new HashSet<Guid> { editorGroup.Key, adminGroup.Key },
|
|
};
|
|
|
|
var createEditorAttempt = await userService.CreateAsync(Constants.Security.SuperUserKey, editorCreateModel, true);
|
|
var createAdminAttempt = await userService.CreateAsync(Constants.Security.SuperUserKey, adminCreateModel, true);
|
|
|
|
Assert.IsTrue(createEditorAttempt.Success);
|
|
Assert.IsTrue(createAdminAttempt.Success);
|
|
|
|
var adminAllUsersAttempt = await userService.GetAllAsync(createAdminAttempt.Result.CreatedUser!.Key, 0, 10000);
|
|
Assert.IsTrue(adminAllUsersAttempt.Success);
|
|
var adminAllUsers = adminAllUsersAttempt.Result.Items.ToList();
|
|
Assert.AreEqual(2, adminAllUsers.Count);
|
|
Assert.IsTrue(adminAllUsers.Any(x => x.Key == createEditorAttempt.Result.CreatedUser!.Key));
|
|
Assert.IsTrue(adminAllUsers.Any(x => x.Key == createAdminAttempt.Result.CreatedUser!.Key));
|
|
}
|
|
|
|
[Test]
|
|
public async Task Cannot_See_Disabled_When_HideDisabled_Is_True()
|
|
{
|
|
var userService = CreateUserService(securitySettings: new SecuritySettings { HideDisabledUsersInBackOffice = true });
|
|
var editorGroup = await UserGroupService.GetAsync(Constants.Security.EditorGroupKey);
|
|
|
|
var firstEditorCreateModel = new UserCreateModel
|
|
{
|
|
UserName = "firstEditor@mail.com",
|
|
Email = "firstEditor@mail.com",
|
|
Name = "First Editor",
|
|
UserGroupKeys = new HashSet<Guid> { editorGroup.Key },
|
|
};
|
|
|
|
var firstEditorResult = await userService.CreateAsync(Constants.Security.SuperUserKey, firstEditorCreateModel, true);
|
|
Assert.IsTrue(firstEditorResult.Success);
|
|
|
|
var secondEditorCreateModel = new UserCreateModel
|
|
{
|
|
UserName = "secondEditor@mail.com",
|
|
Email = "secondEditor@mail.com",
|
|
Name = "Second Editor",
|
|
UserGroupKeys = new HashSet<Guid> { editorGroup.Key },
|
|
};
|
|
|
|
var secondEditorResult = await userService.CreateAsync(Constants.Security.SuperUserKey, secondEditorCreateModel, true);
|
|
Assert.IsTrue(secondEditorResult.Success);
|
|
|
|
var disableStatus = await userService.DisableAsync(Constants.Security.SuperUserKey, new HashSet<Guid>{ secondEditorResult.Result.CreatedUser!.Key });
|
|
Assert.AreEqual(disableStatus, UserOperationStatus.Success);
|
|
|
|
var allUsersAttempt = await userService.GetAllAsync(Constants.Security.SuperUserKey, 0, 10000);
|
|
Assert.IsTrue(allUsersAttempt.Success);
|
|
var allUsers = allUsersAttempt.Result!.Items.ToList();
|
|
Assert.AreEqual(2, allUsers.Count);
|
|
Assert.IsTrue(allUsers.Any(x => x.Key == firstEditorResult.Result.CreatedUser!.Key));
|
|
Assert.IsTrue(allUsers.Any(x => x.Key == Constants.Security.SuperUserKey));
|
|
}
|
|
|
|
[Test]
|
|
public async Task Requesting_User_Must_Exist_When_Calling_Get_All()
|
|
{
|
|
var userService = CreateUserService();
|
|
|
|
var getAllAttempt = await userService.GetAllAsync(Guid.NewGuid(), 0, 10000);
|
|
Assert.IsFalse(getAllAttempt.Success);
|
|
Assert.AreEqual(UserOperationStatus.MissingUser, getAllAttempt.Status);
|
|
Assert.IsNull(getAllAttempt.Result);
|
|
}
|
|
}
|