Files
Umbraco-CMS/src/Umbraco.Core/HashGenerator.cs
Emma L Garland ac575662ac Resolved more warnings, and marked more warning types as errors (#16991)
* Fix warnings SA1111, SA1028, SA1500, IDE1270  in Umbraco.Web.Website, and updated rules.

* Remove warnings: IDE0270: Null check can be simplified

* More SqlServer project warnings resolved

* CS0105 namespace appeared already

* Suppress warning until implementation:

#pragma warning disable CS0162 // Unreachable code detected
#pragma warning disable CS0618 // Type or member is obsolete

CS0162 remove unreachable code
SA1028 remove trailing whitespace
SA1106 no empty statements
CS1570 malformed XML
CS1572 corrected xml parameter
CS1573 param tag added
IDE0007 var not explicit
IDE0008 explicit not var
IDE0057 simplify substring
IDE0074 compound assignment
CA1825 array.empty

Down to 3479 warnings

* - SA1116, SA117 params on same line
- IDE0057 substring simplified

Specific warnings for Umbraco.Tests.Benchmarks

* Fixed IDE0074 compound assignment and added specific warnings for Umbraco.Tests.Common

* Specific warnings for Umbraco.Tests.Integration and Umbraco.Tests.Common

Fixed:

- SA1111, SA1116, SA117 params and line formatting (not all as there are many)
- SA1122 string.Empty
- IDE0057 simplify substring
- IDE0044,IDE0044 make field readonly
- IDE1006 naming rule violation (add _)
- SA1111 closing parenthesis on line of last parameter
- SA1649 filename match type name
- SA1312,SA1306 lowercase variable and field names

* Fixed various warnings where they are more straight-forward, including:

- SA1649 file name match type name
- SA111 parenthesis on line of last parameter
- IDE0028 simplify collection initializer
- SA1306 lower-case letter field
- IDE044 readonly field
- SA1122 string.Empty
- SA1116 params same line
- IDE1006 upper casing
- IDE0041 simplify null check

Updated the following projects to only list their remaining specific warning codes:

- Umbraco.Tests.UnitTests

Typo in `Umbraco.Web.Website` project

* Reverted test change

* Now 1556 warnings.

Fixed various warnings where they are more straight-forward, including:

- SA1111/SA1116/SA1119 parenthesis
- SA1117 params
- SA1312 lowercase variable
- SA1121 built-in type
- SA1500/SA1513/SA1503 formatting braces
- SA1400 declare access modifier
- SA1122 string.Empty
- SA1310 no underscore
- IDE0049 name simplified
- IDE0057 simplify substring
- IDE0074 compound assignment
- IDE0032 use auto-property
- IDE0037 simplify member name
- IDE0008 explicit type not var
- IDE0016/IDE0270/IDE0041 simplify null checks
- IDE0048/SA1407 clarity in arithmetic
- IDE1006 correct param names
- IDE0042 deconstruct variable
- IDE0044 readonly
- IDE0018 inline variable declarations
- IDE0074/IDE0054 compound assignment
- IDE1006 naming
- CS1573 param XML
- CS0168 unused variable

Comment formatting in project files for consistency.

Updated all projects to only list remaining specific warning codes as warnings instead of errors (errors is now default).

* Type not var, and more warning exceptions

* Tweaked merge issue, readded comment about rollback

* Readded comment re rollback.

* Readded comments

* Comment tweak

* Comment tweak
2024-09-24 12:56:28 +01:00

134 lines
4.3 KiB
C#

using System.Security.Cryptography;
using System.Text;
namespace Umbraco.Cms.Core;
/// <summary>
/// Used to generate a string hash using crypto libraries over multiple objects
/// </summary>
/// <remarks>
/// This should be used to generate a reliable hash that survives AppDomain restarts.
/// This will use the crypto libs to generate the hash and will try to ensure that
/// strings, etc... are not re-allocated so it's not consuming much memory.
/// </remarks>
public class HashGenerator : DisposableObjectSlim
{
private readonly MemoryStream _ms = new();
private StreamWriter _writer;
public HashGenerator() => _writer = new StreamWriter(_ms, Encoding.Unicode, 1024, true);
public void AddInt(int i) => _writer.Write(i);
public void AddLong(long i) => _writer.Write(i);
public void AddObject(object o) => _writer.Write(o);
public void AddDateTime(DateTime d) => _writer.Write(d.Ticks);
public void AddString(string s)
{
if (s != null)
{
_writer.Write(s);
}
}
public void AddCaseInsensitiveString(string s)
{
// I've tried to no allocate a new string with this which can be done if we use the CompareInfo.GetSortKey method which will create a new
// byte array that we can use to write to the output, however this also allocates new objects so i really don't think the performance
// would be much different. In any case, I'll leave this here for reference. We could write the bytes out based on the sort key,
// this is how we could deal with case insensitivity without allocating another string
// for reference see: https://stackoverflow.com/a/10452967/694494
// we could go a step further and s.Normalize() but we're not really dealing with crazy unicode with this class so far.
if (s != null)
{
_writer.Write(s.ToUpperInvariant());
}
}
public void AddFileSystemItem(FileSystemInfo f)
{
// if it doesn't exist, don't proceed.
if (f.Exists == false)
{
return;
}
AddCaseInsensitiveString(f.FullName);
AddDateTime(f.CreationTimeUtc);
AddDateTime(f.LastWriteTimeUtc);
// check if it is a file or folder
if (f is FileInfo fileInfo)
{
AddLong(fileInfo.Length);
}
if (f is DirectoryInfo dirInfo)
{
foreach (FileInfo d in dirInfo.GetFiles())
{
AddFile(d);
}
foreach (DirectoryInfo s in dirInfo.GetDirectories())
{
AddFolder(s);
}
}
}
public void AddFile(FileInfo f) => AddFileSystemItem(f);
public void AddFolder(DirectoryInfo d) => AddFileSystemItem(d);
/// <summary>
/// Returns the generated hash output of all added objects
/// </summary>
/// <returns></returns>
public string GenerateHash()
{
// flush,close,dispose the writer,then create a new one since it's possible to keep adding after GenerateHash is called.
_writer.Flush();
_writer.Close();
_writer.Dispose();
_writer = new StreamWriter(_ms, Encoding.UTF8, 1024, true);
var hashType = CryptoConfig.AllowOnlyFipsAlgorithms ? "SHA1" : "MD5";
// create an instance of the correct hashing provider based on the type passed in
HashAlgorithm hasher = HashAlgorithm.Create(hashType) ?? throw new InvalidOperationException("No hashing type found by name " + hashType);
using (hasher)
{
var buffer = _ms.GetBuffer();
// get the hashed values created by our selected provider
var hashedByteArray = hasher.ComputeHash(buffer);
// create a StringBuilder object
var stringBuilder = new StringBuilder();
// loop to each byte
foreach (var b in hashedByteArray)
{
// append it to our StringBuilder
stringBuilder.Append(b.ToString("x2"));
}
// return the hashed value
return stringBuilder.ToString();
}
}
protected override void DisposeResources()
{
_writer.Close();
_writer.Dispose();
_ms.Close();
_ms.Dispose();
}
}