* Do not execute query if no macros found * Request cache the permission lookup * Unbreak change by adding obsolete ctor * Clean up * Wrap indexing for delivery API in a scope * Do not ask options every time for the timeout, instead listen for updates * Lookup content types once instead of one by one * Use TryGetValue instead * Do a distinct on user ids before building index, to avoid issue with more than 2100 parameters * Don't map ContentDto (it's unused) * Introduce request bound block editor element cache --------- Co-authored-by: kjac <kja@umbraco.dk>
182 lines
6.9 KiB
C#
182 lines
6.9 KiB
C#
using System.Data;
|
|
using System.Data.Common;
|
|
using System.Globalization;
|
|
using Microsoft.Data.Sqlite;
|
|
using Microsoft.Extensions.Logging;
|
|
using Microsoft.Extensions.Options;
|
|
using Umbraco.Cms.Core.Configuration.Models;
|
|
using Umbraco.Cms.Core.DistributedLocking;
|
|
using Umbraco.Cms.Core.DistributedLocking.Exceptions;
|
|
using Umbraco.Cms.Core.Exceptions;
|
|
using Umbraco.Cms.Infrastructure.Persistence;
|
|
using Umbraco.Cms.Infrastructure.Scoping;
|
|
using Umbraco.Extensions;
|
|
|
|
namespace Umbraco.Cms.Persistence.Sqlite.Services;
|
|
|
|
public class SqliteDistributedLockingMechanism : IDistributedLockingMechanism
|
|
{
|
|
private ConnectionStrings _connectionStrings;
|
|
private GlobalSettings _globalSettings;
|
|
private readonly ILogger<SqliteDistributedLockingMechanism> _logger;
|
|
private readonly Lazy<IScopeAccessor> _scopeAccessor;
|
|
|
|
public SqliteDistributedLockingMechanism(
|
|
ILogger<SqliteDistributedLockingMechanism> logger,
|
|
Lazy<IScopeAccessor> scopeAccessor,
|
|
IOptionsMonitor<GlobalSettings> globalSettings,
|
|
IOptionsMonitor<ConnectionStrings> connectionStrings)
|
|
{
|
|
_logger = logger;
|
|
_scopeAccessor = scopeAccessor;
|
|
_connectionStrings = connectionStrings.CurrentValue;
|
|
_globalSettings = globalSettings.CurrentValue;
|
|
globalSettings.OnChange(x=>_globalSettings = x);
|
|
connectionStrings.OnChange(x=>_connectionStrings = x);
|
|
}
|
|
|
|
/// <inheritdoc />
|
|
public bool Enabled => _connectionStrings.IsConnectionStringConfigured() &&
|
|
string.Equals(_connectionStrings.ProviderName, Constants.ProviderName, StringComparison.InvariantCultureIgnoreCase);
|
|
|
|
// With journal_mode=wal we can always read a snapshot.
|
|
public IDistributedLock ReadLock(int lockId, TimeSpan? obtainLockTimeout = null)
|
|
{
|
|
obtainLockTimeout ??= _globalSettings.DistributedLockingReadLockDefaultTimeout;
|
|
return new SqliteDistributedLock(this, lockId, DistributedLockType.ReadLock, obtainLockTimeout.Value);
|
|
}
|
|
|
|
// With journal_mode=wal only a single write transaction can exist at a time.
|
|
public IDistributedLock WriteLock(int lockId, TimeSpan? obtainLockTimeout = null)
|
|
{
|
|
obtainLockTimeout ??= _globalSettings.DistributedLockingWriteLockDefaultTimeout;
|
|
return new SqliteDistributedLock(this, lockId, DistributedLockType.WriteLock, obtainLockTimeout.Value);
|
|
}
|
|
|
|
private class SqliteDistributedLock : IDistributedLock
|
|
{
|
|
private readonly SqliteDistributedLockingMechanism _parent;
|
|
private readonly TimeSpan _timeout;
|
|
|
|
public SqliteDistributedLock(
|
|
SqliteDistributedLockingMechanism parent,
|
|
int lockId,
|
|
DistributedLockType lockType,
|
|
TimeSpan timeout)
|
|
{
|
|
_parent = parent;
|
|
_timeout = timeout;
|
|
LockId = lockId;
|
|
LockType = lockType;
|
|
if (_parent._logger.IsEnabled(Microsoft.Extensions.Logging.LogLevel.Debug))
|
|
{
|
|
_parent._logger.LogDebug("Requesting {lockType} for id {id}", LockType, LockId);
|
|
}
|
|
|
|
try
|
|
{
|
|
switch (lockType)
|
|
{
|
|
case DistributedLockType.ReadLock:
|
|
ObtainReadLock();
|
|
break;
|
|
case DistributedLockType.WriteLock:
|
|
ObtainWriteLock();
|
|
break;
|
|
default:
|
|
throw new ArgumentOutOfRangeException(nameof(lockType), lockType, @"Unsupported lockType");
|
|
}
|
|
}
|
|
catch (SqliteException ex) when (ex.SqliteErrorCode == SQLitePCL.raw.SQLITE_BUSY)
|
|
{
|
|
if (LockType == DistributedLockType.ReadLock)
|
|
{
|
|
throw new DistributedReadLockTimeoutException(LockId);
|
|
}
|
|
|
|
throw new DistributedWriteLockTimeoutException(LockId);
|
|
}
|
|
if (_parent._logger.IsEnabled(Microsoft.Extensions.Logging.LogLevel.Debug))
|
|
{
|
|
_parent._logger.LogDebug("Acquired {lockType} for id {id}", LockType, LockId);
|
|
}
|
|
}
|
|
|
|
public int LockId { get; }
|
|
|
|
public DistributedLockType LockType { get; }
|
|
|
|
public void Dispose()
|
|
{
|
|
if (_parent._logger.IsEnabled(Microsoft.Extensions.Logging.LogLevel.Debug))
|
|
{
|
|
// Mostly no op, cleaned up by completing transaction in scope.
|
|
_parent._logger.LogDebug("Dropped {lockType} for id {id}", LockType, LockId);
|
|
}
|
|
}
|
|
|
|
public override string ToString()
|
|
=> $"SqliteDistributedLock({LockId})";
|
|
|
|
// Can always obtain a read lock (snapshot isolation in wal mode)
|
|
// Mostly no-op just check that we didn't end up ReadUncommitted for real.
|
|
private void ObtainReadLock()
|
|
{
|
|
IUmbracoDatabase? db = _parent._scopeAccessor.Value.AmbientScope?.Database;
|
|
|
|
if (db is null)
|
|
{
|
|
throw new PanicException("no database was found");
|
|
}
|
|
|
|
if (!db.InTransaction)
|
|
{
|
|
throw new InvalidOperationException(
|
|
"SqliteDistributedLockingMechanism requires a transaction to function.");
|
|
}
|
|
}
|
|
|
|
// Only one writer is possible at a time
|
|
// lock occurs for entire database as opposed to row/table.
|
|
private void ObtainWriteLock()
|
|
{
|
|
IUmbracoDatabase? db = _parent._scopeAccessor.Value.AmbientScope?.Database;
|
|
|
|
if (db is null)
|
|
{
|
|
throw new PanicException("no database was found");
|
|
}
|
|
|
|
if (!db.InTransaction)
|
|
{
|
|
throw new InvalidOperationException(
|
|
"SqliteDistributedLockingMechanism requires a transaction to function.");
|
|
}
|
|
|
|
var query = @$"UPDATE umbracoLock SET value = (CASE WHEN (value=1) THEN -1 ELSE 1 END) WHERE id = {LockId.ToString(CultureInfo.InvariantCulture)}";
|
|
|
|
DbCommand command = db.CreateCommand(db.Connection, CommandType.Text, query);
|
|
|
|
// imagine there is an existing writer, whilst elapsed time is < command timeout sqlite will busy loop
|
|
// Important to note that if this value == 0 then Command.DefaultTimeout (30s) is used.
|
|
// Math.Ceiling such that (0 < totalseconds < 1) is rounded up to 1.
|
|
command.CommandTimeout = (int)Math.Ceiling(_timeout.TotalSeconds);
|
|
|
|
try
|
|
{
|
|
var i = db.ExecuteNonQuery(command);
|
|
|
|
if (i == 0)
|
|
{
|
|
// ensure we are actually locking!
|
|
throw new ArgumentException($"LockObject with id={LockId} does not exist.");
|
|
}
|
|
}
|
|
catch (SqliteException ex) when (ex.IsBusyOrLocked())
|
|
{
|
|
throw new DistributedWriteLockTimeoutException(LockId);
|
|
}
|
|
}
|
|
}
|
|
}
|