428 lines
18 KiB
C#
428 lines
18 KiB
C#
using System;
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using System.Text;
|
|
using System.Threading.Tasks;
|
|
using Moq;
|
|
using NUnit.Framework;
|
|
using Umbraco.Core;
|
|
using Umbraco.Core.Models;
|
|
using Umbraco.Core.Models.Entities;
|
|
using Umbraco.Core.Models.Membership;
|
|
using Umbraco.Core.Services;
|
|
using Umbraco.Web.Editors;
|
|
|
|
namespace Umbraco.Tests.Web.Controllers
|
|
{
|
|
[TestFixture]
|
|
public class UserEditorAuthorizationHelperTests
|
|
{
|
|
[Test]
|
|
public void Admin_Is_Authorized()
|
|
{
|
|
var currentUser = GetAdminUser();
|
|
var savingUser = Mock.Of<IUser>();
|
|
|
|
var contentService = new Mock<IContentService>();
|
|
var mediaService = new Mock<IMediaService>();
|
|
var userService = new Mock<IUserService>();
|
|
var entityService = new Mock<IEntityService>();
|
|
|
|
var authHelper = new UserEditorAuthorizationHelper(
|
|
contentService.Object,
|
|
mediaService.Object,
|
|
userService.Object,
|
|
entityService.Object);
|
|
|
|
var result = authHelper.IsAuthorized(currentUser, savingUser, new int[0], new int[0], new string[0]);
|
|
|
|
Assert.IsTrue(result.Success);
|
|
}
|
|
|
|
[Test]
|
|
public void Non_Admin_Cannot_Save_Admin()
|
|
{
|
|
var currentUser = Mock.Of<IUser>();
|
|
var savingUser = GetAdminUser();
|
|
|
|
var contentService = new Mock<IContentService>();
|
|
var mediaService = new Mock<IMediaService>();
|
|
var userService = new Mock<IUserService>();
|
|
var entityService = new Mock<IEntityService>();
|
|
|
|
var authHelper = new UserEditorAuthorizationHelper(
|
|
contentService.Object,
|
|
mediaService.Object,
|
|
userService.Object,
|
|
entityService.Object);
|
|
|
|
var result = authHelper.IsAuthorized(currentUser, savingUser, new int[0], new int[0], new string[0]);
|
|
|
|
Assert.IsFalse(result.Success);
|
|
}
|
|
|
|
[Test]
|
|
public void Cannot_Grant_Group_Membership_Without_Being_A_Member()
|
|
{
|
|
var currentUser = Mock.Of<IUser>(user => user.Groups == new[]
|
|
{
|
|
new ReadOnlyUserGroup(1, "Test", "icon-user", null, null, "test", new string[0], new string[0])
|
|
});
|
|
var savingUser = Mock.Of<IUser>();
|
|
|
|
var contentService = new Mock<IContentService>();
|
|
var mediaService = new Mock<IMediaService>();
|
|
var userService = new Mock<IUserService>();
|
|
var entityService = new Mock<IEntityService>();
|
|
|
|
var authHelper = new UserEditorAuthorizationHelper(
|
|
contentService.Object,
|
|
mediaService.Object,
|
|
userService.Object,
|
|
entityService.Object);
|
|
|
|
var result = authHelper.IsAuthorized(currentUser, savingUser, new int[0], new int[0], new[] {"FunGroup"});
|
|
|
|
Assert.IsFalse(result.Success);
|
|
}
|
|
|
|
[Test]
|
|
public void Can_Grant_Group_Membership_With_Being_A_Member()
|
|
{
|
|
var currentUser = Mock.Of<IUser>(user => user.Groups == new[]
|
|
{
|
|
new ReadOnlyUserGroup(1, "Test", "icon-user", null, null, "test", new string[0], new string[0])
|
|
});
|
|
var savingUser = Mock.Of<IUser>();
|
|
|
|
var contentService = new Mock<IContentService>();
|
|
var mediaService = new Mock<IMediaService>();
|
|
var userService = new Mock<IUserService>();
|
|
var entityService = new Mock<IEntityService>();
|
|
|
|
var authHelper = new UserEditorAuthorizationHelper(
|
|
contentService.Object,
|
|
mediaService.Object,
|
|
userService.Object,
|
|
entityService.Object);
|
|
|
|
var result = authHelper.IsAuthorized(currentUser, savingUser, new int[0], new int[0], new[] { "test" });
|
|
|
|
Assert.IsTrue(result.Success);
|
|
}
|
|
|
|
[Test]
|
|
public void Can_Add_Another_Content_Start_Node_On_User_With_Access()
|
|
{
|
|
var nodePaths = new Dictionary<int, string>
|
|
{
|
|
{1234, "-1,1234"},
|
|
{9876, "-1,9876"},
|
|
{5555, "-1,9876,5555"},
|
|
{4567, "-1,4567"},
|
|
};
|
|
|
|
var currentUser = Mock.Of<IUser>(user => user.StartContentIds == new[] { 9876 });
|
|
var savingUser = Mock.Of<IUser>(user => user.StartContentIds == new[] {1234});
|
|
|
|
var contentService = new Mock<IContentService>();
|
|
contentService.Setup(x => x.GetById(It.IsAny<int>()))
|
|
.Returns((int id) => Mock.Of<IContent>(content => content.Path == nodePaths[id]));
|
|
var mediaService = new Mock<IMediaService>();
|
|
var userService = new Mock<IUserService>();
|
|
var entityService = new Mock<IEntityService>();
|
|
entityService.Setup(service => service.GetAllPaths(It.IsAny<UmbracoObjectTypes>(), It.IsAny<int[]>()))
|
|
.Returns((UmbracoObjectTypes objType, int[] ids) =>
|
|
{
|
|
return ids.Select(x => new TreeEntityPath {Path = nodePaths[x], Id = x});
|
|
});
|
|
|
|
var authHelper = new UserEditorAuthorizationHelper(
|
|
contentService.Object,
|
|
mediaService.Object,
|
|
userService.Object,
|
|
entityService.Object);
|
|
|
|
//adding 5555 which currentUser has access to since it's a child of 9876 ... adding is still ok even though currentUser doesn't have access to 1234
|
|
var result = authHelper.IsAuthorized(currentUser, savingUser, new[] { 1234, 5555 }, new int[0], new string[0]);
|
|
|
|
Assert.IsTrue(result.Success);
|
|
}
|
|
|
|
[Test]
|
|
public void Can_Remove_Content_Start_Node_On_User_Without_Access()
|
|
{
|
|
var nodePaths = new Dictionary<int, string>
|
|
{
|
|
{1234, "-1,1234"},
|
|
{9876, "-1,9876"},
|
|
{5555, "-1,9876,5555"},
|
|
{4567, "-1,4567"},
|
|
};
|
|
|
|
var currentUser = Mock.Of<IUser>(user => user.StartContentIds == new[] { 9876 });
|
|
var savingUser = Mock.Of<IUser>(user => user.StartContentIds == new[] { 1234, 4567 });
|
|
|
|
var contentService = new Mock<IContentService>();
|
|
contentService.Setup(x => x.GetById(It.IsAny<int>()))
|
|
.Returns((int id) => Mock.Of<IContent>(content => content.Path == nodePaths[id]));
|
|
var mediaService = new Mock<IMediaService>();
|
|
var userService = new Mock<IUserService>();
|
|
var entityService = new Mock<IEntityService>();
|
|
entityService.Setup(service => service.GetAllPaths(It.IsAny<UmbracoObjectTypes>(), It.IsAny<int[]>()))
|
|
.Returns((UmbracoObjectTypes objType, int[] ids) =>
|
|
{
|
|
return ids.Select(x => new TreeEntityPath { Path = nodePaths[x], Id = x });
|
|
});
|
|
|
|
var authHelper = new UserEditorAuthorizationHelper(
|
|
contentService.Object,
|
|
mediaService.Object,
|
|
userService.Object,
|
|
entityService.Object);
|
|
|
|
//removing 4567 start node even though currentUser doesn't have acces to it ... removing is ok
|
|
var result = authHelper.IsAuthorized(currentUser, savingUser, new[] { 1234 }, new int[0], new string[0]);
|
|
|
|
Assert.IsTrue(result.Success);
|
|
}
|
|
|
|
[Test]
|
|
public void Cannot_Add_Content_Start_Node_On_User_Without_Access()
|
|
{
|
|
var nodePaths = new Dictionary<int, string>
|
|
{
|
|
{1234, "-1,1234"},
|
|
{9876, "-1,9876"},
|
|
{5555, "-1,9876,5555"},
|
|
{4567, "-1,4567"},
|
|
};
|
|
|
|
var currentUser = Mock.Of<IUser>(user => user.StartContentIds == new[]{9876});
|
|
var savingUser = Mock.Of<IUser>();
|
|
|
|
var contentService = new Mock<IContentService>();
|
|
contentService.Setup(x => x.GetById(It.IsAny<int>()))
|
|
.Returns((int id) => Mock.Of<IContent>(content => content.Path == nodePaths[id]));
|
|
var mediaService = new Mock<IMediaService>();
|
|
var userService = new Mock<IUserService>();
|
|
var entityService = new Mock<IEntityService>();
|
|
entityService.Setup(service => service.GetAllPaths(It.IsAny<UmbracoObjectTypes>(), It.IsAny<int[]>()))
|
|
.Returns((UmbracoObjectTypes objType, int[] ids) =>
|
|
{
|
|
return ids.Select(x => new TreeEntityPath { Path = nodePaths[x], Id = x });
|
|
});
|
|
|
|
var authHelper = new UserEditorAuthorizationHelper(
|
|
contentService.Object,
|
|
mediaService.Object,
|
|
userService.Object,
|
|
entityService.Object);
|
|
|
|
//adding 1234 but currentUser doesn't have access to it ... nope
|
|
var result = authHelper.IsAuthorized(currentUser, savingUser, new []{1234}, new int[0], new string[0]);
|
|
|
|
Assert.IsFalse(result.Success);
|
|
}
|
|
|
|
[Test]
|
|
public void Can_Add_Content_Start_Node_On_User_With_Access()
|
|
{
|
|
var nodePaths = new Dictionary<int, string>
|
|
{
|
|
{1234, "-1,1234"},
|
|
{9876, "-1,9876"},
|
|
{5555, "-1,9876,5555"},
|
|
{4567, "-1,4567"},
|
|
};
|
|
|
|
var currentUser = Mock.Of<IUser>(user => user.StartContentIds == new[] { 9876 });
|
|
var savingUser = Mock.Of<IUser>();
|
|
|
|
var contentService = new Mock<IContentService>();
|
|
contentService.Setup(x => x.GetById(It.IsAny<int>()))
|
|
.Returns((int id) => Mock.Of<IContent>(content => content.Path == nodePaths[id]));
|
|
var mediaService = new Mock<IMediaService>();
|
|
var userService = new Mock<IUserService>();
|
|
var entityService = new Mock<IEntityService>();
|
|
entityService.Setup(service => service.GetAllPaths(It.IsAny<UmbracoObjectTypes>(), It.IsAny<int[]>()))
|
|
.Returns((UmbracoObjectTypes objType, int[] ids) =>
|
|
{
|
|
return ids.Select(x => new TreeEntityPath { Path = nodePaths[x], Id = x });
|
|
});
|
|
|
|
var authHelper = new UserEditorAuthorizationHelper(
|
|
contentService.Object,
|
|
mediaService.Object,
|
|
userService.Object,
|
|
entityService.Object);
|
|
|
|
//adding 5555 which currentUser has access to since it's a child of 9876 ... ok
|
|
var result = authHelper.IsAuthorized(currentUser, savingUser, new[] { 5555 }, new int[0], new string[0]);
|
|
|
|
Assert.IsTrue(result.Success);
|
|
}
|
|
|
|
[Test]
|
|
public void Cannot_Add_Media_Start_Node_On_User_Without_Access()
|
|
{
|
|
var nodePaths = new Dictionary<int, string>
|
|
{
|
|
{1234, "-1,1234"},
|
|
{9876, "-1,9876"},
|
|
{5555, "-1,9876,5555"},
|
|
{4567, "-1,4567"},
|
|
};
|
|
|
|
var currentUser = Mock.Of<IUser>(user => user.StartMediaIds == new[] { 9876 });
|
|
var savingUser = Mock.Of<IUser>();
|
|
|
|
var contentService = new Mock<IContentService>();
|
|
var mediaService = new Mock<IMediaService>();
|
|
mediaService.Setup(x => x.GetById(It.IsAny<int>()))
|
|
.Returns((int id) => Mock.Of<IMedia>(content => content.Path == nodePaths[id]));
|
|
var userService = new Mock<IUserService>();
|
|
var entityService = new Mock<IEntityService>();
|
|
entityService.Setup(service => service.GetAllPaths(It.IsAny<UmbracoObjectTypes>(), It.IsAny<int[]>()))
|
|
.Returns((UmbracoObjectTypes objType, int[] ids) =>
|
|
{
|
|
return ids.Select(x => new TreeEntityPath { Path = nodePaths[x], Id = x });
|
|
});
|
|
|
|
var authHelper = new UserEditorAuthorizationHelper(
|
|
contentService.Object,
|
|
mediaService.Object,
|
|
userService.Object,
|
|
entityService.Object);
|
|
|
|
//adding 1234 but currentUser doesn't have access to it ... nope
|
|
var result = authHelper.IsAuthorized(currentUser, savingUser, new int[0], new[] {1234}, new string[0]);
|
|
|
|
Assert.IsFalse(result.Success);
|
|
}
|
|
|
|
[Test]
|
|
public void Can_Add_Media_Start_Node_On_User_With_Access()
|
|
{
|
|
var nodePaths = new Dictionary<int, string>
|
|
{
|
|
{1234, "-1,1234"},
|
|
{9876, "-1,9876"},
|
|
{5555, "-1,9876,5555"},
|
|
{4567, "-1,4567"},
|
|
};
|
|
|
|
var currentUser = Mock.Of<IUser>(user => user.StartMediaIds == new[] { 9876 });
|
|
var savingUser = Mock.Of<IUser>();
|
|
|
|
var contentService = new Mock<IContentService>();
|
|
var mediaService = new Mock<IMediaService>();
|
|
mediaService.Setup(x => x.GetById(It.IsAny<int>()))
|
|
.Returns((int id) => Mock.Of<IMedia>(content => content.Path == nodePaths[id]));
|
|
var userService = new Mock<IUserService>();
|
|
var entityService = new Mock<IEntityService>();
|
|
entityService.Setup(service => service.GetAllPaths(It.IsAny<UmbracoObjectTypes>(), It.IsAny<int[]>()))
|
|
.Returns((UmbracoObjectTypes objType, int[] ids) =>
|
|
{
|
|
return ids.Select(x => new TreeEntityPath { Path = nodePaths[x], Id = x });
|
|
});
|
|
|
|
var authHelper = new UserEditorAuthorizationHelper(
|
|
contentService.Object,
|
|
mediaService.Object,
|
|
userService.Object,
|
|
entityService.Object);
|
|
|
|
//adding 5555 which currentUser has access to since it's a child of 9876 ... ok
|
|
var result = authHelper.IsAuthorized(currentUser, savingUser, new int[0], new[] { 5555 }, new string[0]);
|
|
|
|
Assert.IsTrue(result.Success);
|
|
}
|
|
|
|
[Test]
|
|
public void Can_Add_Another_Media_Start_Node_On_User_With_Access()
|
|
{
|
|
var nodePaths = new Dictionary<int, string>
|
|
{
|
|
{1234, "-1,1234"},
|
|
{9876, "-1,9876"},
|
|
{5555, "-1,9876,5555"},
|
|
{4567, "-1,4567"},
|
|
};
|
|
|
|
var currentUser = Mock.Of<IUser>(user => user.StartMediaIds == new[] { 9876 });
|
|
var savingUser = Mock.Of<IUser>(user => user.StartMediaIds == new[] { 1234 });
|
|
|
|
var contentService = new Mock<IContentService>();
|
|
var mediaService = new Mock<IMediaService>();
|
|
mediaService.Setup(x => x.GetById(It.IsAny<int>()))
|
|
.Returns((int id) => Mock.Of<IMedia>(content => content.Path == nodePaths[id]));
|
|
var userService = new Mock<IUserService>();
|
|
var entityService = new Mock<IEntityService>();
|
|
entityService.Setup(service => service.GetAllPaths(It.IsAny<UmbracoObjectTypes>(), It.IsAny<int[]>()))
|
|
.Returns((UmbracoObjectTypes objType, int[] ids) =>
|
|
{
|
|
return ids.Select(x => new TreeEntityPath { Path = nodePaths[x], Id = x });
|
|
});
|
|
|
|
var authHelper = new UserEditorAuthorizationHelper(
|
|
contentService.Object,
|
|
mediaService.Object,
|
|
userService.Object,
|
|
entityService.Object);
|
|
|
|
//adding 5555 which currentUser has access to since it's a child of 9876 ... adding is still ok even though currentUser doesn't have access to 1234
|
|
var result = authHelper.IsAuthorized(currentUser, savingUser, new int[0], new[] { 1234, 5555 }, new string[0]);
|
|
|
|
Assert.IsTrue(result.Success);
|
|
}
|
|
|
|
[Test]
|
|
public void Can_Remove_Media_Start_Node_On_User_Without_Access()
|
|
{
|
|
var nodePaths = new Dictionary<int, string>
|
|
{
|
|
{1234, "-1,1234"},
|
|
{9876, "-1,9876"},
|
|
{5555, "-1,9876,5555"},
|
|
{4567, "-1,4567"},
|
|
};
|
|
|
|
var currentUser = Mock.Of<IUser>(user => user.StartMediaIds == new[] { 9876 });
|
|
var savingUser = Mock.Of<IUser>(user => user.StartMediaIds == new[] { 1234, 4567 });
|
|
|
|
var contentService = new Mock<IContentService>();
|
|
var mediaService = new Mock<IMediaService>();
|
|
mediaService.Setup(x => x.GetById(It.IsAny<int>()))
|
|
.Returns((int id) => Mock.Of<IMedia>(content => content.Path == nodePaths[id]));
|
|
var userService = new Mock<IUserService>();
|
|
var entityService = new Mock<IEntityService>();
|
|
entityService.Setup(service => service.GetAllPaths(It.IsAny<UmbracoObjectTypes>(), It.IsAny<int[]>()))
|
|
.Returns((UmbracoObjectTypes objType, int[] ids) =>
|
|
{
|
|
return ids.Select(x => new TreeEntityPath { Path = nodePaths[x], Id = x });
|
|
});
|
|
|
|
var authHelper = new UserEditorAuthorizationHelper(
|
|
contentService.Object,
|
|
mediaService.Object,
|
|
userService.Object,
|
|
entityService.Object);
|
|
|
|
//removing 4567 start node even though currentUser doesn't have acces to it ... removing is ok
|
|
var result = authHelper.IsAuthorized(currentUser, savingUser, new int[0], new[] { 1234 }, new string[0]);
|
|
|
|
Assert.IsTrue(result.Success);
|
|
}
|
|
|
|
private IUser GetAdminUser()
|
|
{
|
|
var admin = Mock.Of<IUser>(user => user.Groups == new[]
|
|
{
|
|
new ReadOnlyUserGroup(1, "Admin", "icon-user", null, null, Constants.Security.AdminGroupAlias, new string[0], new string[0])
|
|
});
|
|
return admin;
|
|
}
|
|
}
|
|
}
|