* Implemented culture based authorization for content * Implemented culture auth for create/update of documents * Applied culture authorization to dictionary create/update * Added an integration test to test an assumption about the ContentTypeEditingService.CreateAsync method * Fix processing when result is already false; * Apply suggestions from code review Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com> * Refactor method to async + clarify and consilidate comments regarding dictionary locks --------- Co-authored-by: Sven Geusens <sge@umbraco.dk> Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com>
71 lines
2.9 KiB
C#
71 lines
2.9 KiB
C#
using Asp.Versioning;
|
|
using Microsoft.AspNetCore.Authorization;
|
|
using Microsoft.AspNetCore.Http;
|
|
using Microsoft.AspNetCore.Mvc;
|
|
using Umbraco.Cms.Api.Management.Factories;
|
|
using Umbraco.Cms.Api.Management.Security.Authorization.Dictionary;
|
|
using Umbraco.Cms.Core.Models;
|
|
using Umbraco.Cms.Core.Services;
|
|
using Umbraco.Cms.Api.Management.ViewModels.Dictionary;
|
|
using Umbraco.Cms.Core;
|
|
using Umbraco.Cms.Core.Security;
|
|
using Umbraco.Cms.Core.Services.OperationStatus;
|
|
using Umbraco.Cms.Web.Common.Authorization;
|
|
using Umbraco.Extensions;
|
|
|
|
namespace Umbraco.Cms.Api.Management.Controllers.Dictionary;
|
|
|
|
[ApiVersion("1.0")]
|
|
public class UpdateDictionaryController : DictionaryControllerBase
|
|
{
|
|
private readonly IDictionaryItemService _dictionaryItemService;
|
|
private readonly IBackOfficeSecurityAccessor _backOfficeSecurityAccessor;
|
|
private readonly IDictionaryPresentationFactory _dictionaryPresentationFactory;
|
|
private readonly IAuthorizationService _authorizationService;
|
|
|
|
public UpdateDictionaryController(
|
|
IDictionaryItemService dictionaryItemService,
|
|
IBackOfficeSecurityAccessor backOfficeSecurityAccessor,
|
|
IDictionaryPresentationFactory dictionaryPresentationFactory,
|
|
IAuthorizationService authorizationService)
|
|
{
|
|
_dictionaryItemService = dictionaryItemService;
|
|
_backOfficeSecurityAccessor = backOfficeSecurityAccessor;
|
|
_dictionaryPresentationFactory = dictionaryPresentationFactory;
|
|
_authorizationService = authorizationService;
|
|
}
|
|
|
|
[HttpPut($"{{{nameof(id)}:guid}}")]
|
|
[MapToApiVersion("1.0")]
|
|
[ProducesResponseType(StatusCodes.Status200OK)]
|
|
[ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status400BadRequest)]
|
|
[ProducesResponseType(typeof(ProblemDetails), StatusCodes.Status404NotFound)]
|
|
public async Task<IActionResult> Update(Guid id, UpdateDictionaryItemRequestModel updateDictionaryItemRequestModel)
|
|
{
|
|
IDictionaryItem? current = await _dictionaryItemService.GetAsync(id);
|
|
if (current == null)
|
|
{
|
|
return DictionaryNotFound();
|
|
}
|
|
|
|
AuthorizationResult authorizationResult = await _authorizationService.AuthorizeResourceAsync(
|
|
User,
|
|
new DictionaryPermissionResource(updateDictionaryItemRequestModel.Translations.Select(t => t.IsoCode)),
|
|
AuthorizationPolicies.DictionaryPermissionByResource);
|
|
|
|
if (authorizationResult.Succeeded is false)
|
|
{
|
|
return Forbidden();
|
|
}
|
|
|
|
IDictionaryItem updated = await _dictionaryPresentationFactory.MapUpdateModelToDictionaryItemAsync(current, updateDictionaryItemRequestModel);
|
|
|
|
Attempt<IDictionaryItem, DictionaryItemOperationStatus> result =
|
|
await _dictionaryItemService.UpdateAsync(updated, CurrentUserKey(_backOfficeSecurityAccessor));
|
|
|
|
return result.Success
|
|
? Ok()
|
|
: DictionaryItemOperationStatusResult(result.Status);
|
|
}
|
|
}
|