Files
Umbraco-CMS/tests/Umbraco.Tests.Integration/Umbraco.Core/Services/UserServiceCrudTests.Create.cs
Mole 21b0a7ffae New Backoffice: Fix feedback to users controller (#14031)
* Add specific not found results

* Add tests for the enable/disable not found tweak

* Cache ids and key in UserIdKeyResolver

* Don't cache null keys

* BackOffice not Backoffice

* Move fetching the user out of the ChangePasswordUsersController

* Move resolving user out of SetAvatar

* Move resolving user out of Update

* Return more specific notfound in bykey

* Use ErrorResult for all endpoints with unknown errors

* Split integration tests

* Add mappers

* Use ?: consistently

* Add reuseable iso code validator

* Validate ISO code

* Update supressions

* Use method from base to get current user key

* Rename ISo to Iso

* Use keys in services instead of user groups + Added a couple of new validations

---------

Co-authored-by: Bjarke Berg <mail@bergmania.dk>
2023-04-04 15:41:12 +02:00

144 lines
5.3 KiB
C#

using NUnit.Framework;
using Umbraco.Cms.Core;
using Umbraco.Cms.Core.Configuration.Models;
using Umbraco.Cms.Core.Models;
using Umbraco.Cms.Core.Models.Membership;
using Umbraco.Cms.Core.Services;
using Umbraco.Cms.Core.Services.OperationStatus;
namespace Umbraco.Cms.Tests.Integration.Umbraco.Core.Services;
public partial class UserServiceCrudTests
{
[Test]
[TestCase("test@email.com", "test@email.com", true, true)]
[TestCase("test@email.com", "notTheUserName@email.com", true, false)]
[TestCase("NotAnEmail", "test@email.com", true, false)]
[TestCase("test@email.com", "test@email.com", false, true)]
[TestCase("NotAnEmail", "test@email.com", false, true)]
[TestCase("aDifferentEmail@email.com", "test@email.com", false, true)]
public async Task Creating_User_Name_Must_Be_Email(
string username,
string email,
bool userNameIsEmailEnabled,
bool shouldSucceed)
{
var securitySettings = new SecuritySettings { UsernameIsEmail = userNameIsEmailEnabled };
var userService = CreateUserService(securitySettings);
var userGroup = await UserGroupService.GetAsync(Constants.Security.AdminGroupAlias);
var creationModel = new UserCreateModel
{
UserName = username,
Email = email,
Name = "Test Mc. Gee",
UserGroupKeys = new HashSet<Guid> { userGroup.Key }
};
var result = await userService.CreateAsync(Constants.Security.SuperUserKey, creationModel, true);
if (shouldSucceed is false)
{
Assert.IsFalse(result.Success);
Assert.AreEqual(UserOperationStatus.UserNameIsNotEmail, result.Status);
return;
}
Assert.IsTrue(result.Success);
Assert.AreEqual(UserOperationStatus.Success, result.Status);
var createdUser = result.Result.CreatedUser;
Assert.IsNotNull(createdUser);
Assert.AreEqual(username, createdUser.Username);
Assert.AreEqual(email, createdUser.Email);
}
[Test]
public async Task Cannot_Create_User_With_Duplicate_Email()
{
var email = "test@test.com";
var userGroup = await UserGroupService.GetAsync(Constants.Security.AdminGroupAlias);
var initialUserCreateModel = new UserCreateModel
{
UserName = "Test1",
Email = email,
Name = "Test Mc. Gee",
UserGroupKeys = new HashSet<Guid> { userGroup.Key }
};
var userService = CreateUserService(new SecuritySettings { UsernameIsEmail = false });
var result = await userService.CreateAsync(Constants.Security.SuperUserKey, initialUserCreateModel, true);
Assert.IsTrue(result.Success);
var duplicateUserCreateModel = new UserCreateModel
{
UserName = "Test2",
Email = email,
Name = "Duplicate Mc. Gee",
UserGroupKeys = new HashSet<Guid> { userGroup.Key }
};
var secondResult = await userService.CreateAsync(Constants.Security.SuperUserKey, duplicateUserCreateModel, true);
Assert.IsFalse(secondResult.Success);
Assert.AreEqual(UserOperationStatus.DuplicateEmail, secondResult.Status);
}
[Test]
public async Task Cannot_Create_User_With_Duplicate_UserName()
{
var userName = "UserName";
var userGroup = await UserGroupService.GetAsync(Constants.Security.AdminGroupAlias);
var initialUserCreateModel = new UserCreateModel
{
UserName = userName,
Email = "test@email.com",
Name = "Test Mc. Gee",
UserGroupKeys = new HashSet<Guid> { userGroup.Key }
};
var userService = CreateUserService(new SecuritySettings { UsernameIsEmail = false });
var result = await userService.CreateAsync(Constants.Security.SuperUserKey, initialUserCreateModel, true);
Assert.IsTrue(result.Success);
var duplicateUserCreateModel = new UserCreateModel
{
UserName = userName,
Email = "another@email.com",
Name = "Duplicate Mc. Gee",
UserGroupKeys = new HashSet<Guid> { userGroup.Key }
};
var secondResult = await userService.CreateAsync(Constants.Security.SuperUserKey, duplicateUserCreateModel, true);
Assert.IsFalse(secondResult.Success);
Assert.AreEqual(UserOperationStatus.DuplicateUserName, secondResult.Status);
}
[Test]
public async Task Cannot_Create_User_Without_User_Group()
{
UserCreateModel userCreateModel = new UserCreateModel
{
UserName = "NoUser@Group.com",
Email = "NoUser@Group.com",
Name = "NoUser@Group.com",
};
IUserService userService = CreateUserService();
var result = await userService.CreateAsync(Constants.Security.SuperUserKey, userCreateModel, true);
Assert.IsFalse(result.Success);
Assert.AreEqual(UserOperationStatus.NoUserGroup, result.Status);
}
[Test]
public async Task Performing_User_Must_Exist_When_Creating()
{
IUserService userService = CreateUserService();
var result = await userService.CreateAsync(Guid.Empty, new UserCreateModel(), true);
Assert.IsFalse(result.Success);
Assert.AreEqual(UserOperationStatus.MissingUser, result.Status);
}
}