Files
Umbraco-CMS/tests/Umbraco.Tests.Integration/Umbraco.Infrastructure/Persistence/Repositories/MacroRepositoryTest.cs
Paul Johnson 3961c4c233 v10 SQLite support + distributed locking abstractions (#11922)
* Created Persistence.SQLite project skeleton.

* SQLite database initialization

* Various changes and hacks to make things work.

* WIP integration tests

* Fix thread safety tests

* Fix tests that relied on tie breaker sorting.

Spent a fair amount of time looking for a less lazy fix but gave up.

* Convert right join to left join ContentTypeRepository.PerformGetByQuery
SQLite doesn't support right join

* Fix test Can_Generate_Delete_SubQuery_Statement

Worth noting that NPoco.DatabaseTypes.SQLiteDatabaseType doesn't override
EscapeSqlIdentifier so NPoco will escape with [].

SQLite docs say > "A keyword enclosed in square brackets is an identifier.
This is not standard SQL.
This quoting mechanism is used by MS Access and SQL Server and is
included in SQLite for compatibility."

Also could have updated SqliteSyntaxProvider to match npoco but
decided against it.

* Fixes for paginated custom order by

* Fix tests broken by lack of unique indexes.

* Fix SqlServerTableByTableTest tests.

These tests didn't actually do anything as the tables already exist so schema creator just returned.

Did however point out that the default implementation for DoesTableExist just returns false so added a default naive implementation.

* Fix ValidateLoginSession - SelectTop must come later

* dry up database cleanup

* Fix up db migration tests.
We can't drop pk in sqlite without recreating table.
Test looks to be testing that add column works as intended which we can test.

* Prevent schema creation errors.

* SQLite ignore lock tests, WAL back on.

* Fix package schema tests

* Fix NPocoFetchTests - case sensitivity not under test

* Fix AdvancedMigrationTests (where possible)

Migrations probably need a good look later.
Maybe nuke old migrations and only support moving to v10 from v9.

If we do that can do some cleanup.

* Cleanup test database configuration

* Run integration tests against SQLite on build agent.

* Drop MS.Data.SQLite
System.Data.SQLite was quicker to roll out due to more CLR type mapping

* YAML

* Skip Umbraco.Tests.Integration.SqlCe

* Drop SqlServerTableByTable tests.

Until this week they did nothing anyway as they with NewSchemaPerTest
so the tests all passed as CreateTable was no op (already exists).

Also all of the tables are created in an empty database by SchemaValidationTest.cs
DatabaseSchemaCreation_Produces_DatabaseSchemaResult_With_Zero_Errors

* Might aswell run against macOS also.

* Copy azure pipelines task header layout

* Delete SQLCe projects

* Remove SQL CE specific code.

* Remove SQL CE NuSpec, template params, build script setup

* Delete umbraco-netcore-only.sln

* Add SkipTests solution configuration and use for codeql

* Remove reference to deleted nuspec file.

* Refactor ConnectionStrings WRT DataDirectory placeholder & ProviderName.

At this point you can try out SQLite support by setting the following
in appsettings.json and then completing the install process.

"ConnectionStrings": {
  "umbracoDbDSN": "Data Source=|DataDirectory|/umbraco.sqlite",
  "umbracoDbDSN_ProviderName": "System.Data.SQLite"
},

Not currently possible via installer UI without provider name pre-set in
configuration.

* Switch to Microsoft.Data.Sqlite

Some gross hacks but will be good to find out if this works
with apple silicon.

* Enable selection of SQLite via installer UI (also quick install)

* Remove SqlServerDbProviderFactoryCreator to cleanup a TODO

* Move SQL Server support to its own class library

* Add persistence dependencies to Umbraco.CMS metapackage

* Bugfix packages delete query

Created invalid query for SQLite.

* Try out cypress tests Linux + SQLite

* Prevent cypress test artifact upload failure on attempt 2+

* LocalDb bugfixes

* Drop redundant enum

* Move SqlClient constant

* Misc whitespace

* Remove IsSqlCe extension (TODO: drop non 9->10 migrations later).

* Umbraco.Persistence.* -> Umbraco.Cms.Persistence.*

* Display quick install defaults and per provider default database name.

* Misc remove old comment

* little re-arrange

* Remove almost all usages of IsSqlite extension.

* visual adjustments

* Custom Database Configuration is last step and should then say Install.

* use text instead of disabled inputs

* move legend, rename to Install

* Update SqlMainDomLock to work without distributed locks.

* Added IDistributedLockingMechanism interface and in memory impl.

* Drop locking from ISqlSyntaxProvider & wire up scope to abstraction.

* Added SqlServerDistributedLockingMechanism

* Move distributed locking interfaces and exceptions to Core + xmldocs.

* Fix tests, Misc cleanup, Add SQL distributed locking integration tests

* Provide mechanism to specify DistributedLockingMechanism in config
(even if added by composer)

* Nomplementation -> NoImplementation

* Fix misleading comment

* Integration tests use SqlServerDistributedLockingMechanism when possible

* Handle up-gradable locks SqlServerDistributedLockingMechanism.
TODO: InMemoryDistributedLockingMechanism.

Note: Nuked SqlServerDistributedLockingMechanismTests, will still sleep
at night.
Is covered by Umbraco.Cms.Tests.Integration.Umbraco.Infrastructure.Persistence.LockTests

* Make tests pass for InMemoryDistributedLockingMechanism, pretty hacky.

* Tweak constraints on WithCollectionBuilder so i can drop bad constructor

* Added SqliteDistributedLockingMechanism

* Dropped InMemoryDistributedMechanism + magic

InMemoryDistributedMechanism was pretty rubbish and now we have
a decent implementation for SQLite as we no longer block readers
see 8d1f42b.

Also drop the CollectionBuilder setup, instead do the same as we do
for syntax providers etc, it's more automagical so we never require an
explicit selection although we are allowing for it.

However keeping the optional IUmbracoBuilder constructor param for
CollectionBuilders as it's extremely useful.

* Fix quick install "" database name.

* Hide Database Configuration section when a connection string is pre-set.

Doesn't seem worth it to extract db name from connection string.

* Ensure wal test 2+

* Fix logging inconsistencies.

* Ensure in transaction when obtaining locks + no-op the SQLite read lock.

There's no point in running the query just to make a single test pass.

* Fix installer database display names

* Allow SQLite shared cache without losing deferred transactions

* Opt into shared cache for new SQLite databases + fix filename

* Fix misc inconsistency in .gitignore

* Prefer our interceptor interface

* Restore DEBUG_DATABASES code OnConnectionOpened in case it's used.

* Back to private cache.

* Added retry strategy for SQLite + refactor out SQL server specific stuff

* Fix SQL server tests.

* Misc - Orphaned comment, incorrect casing.

* InMemory SQLite test database & turn shared cache back on everywhere.

Co-authored-by: Niels Lyngsø <niels.lyngso@gmail.com>
2022-03-11 17:14:20 +01:00

419 lines
16 KiB
C#

// Copyright (c) Umbraco.
// See LICENSE for more details.
using System.Collections.Generic;
using System.Data.Common;
using System.Linq;
using Microsoft.Data.SqlClient;
using Microsoft.Extensions.Logging;
using NUnit.Framework;
using Umbraco.Cms.Core.Cache;
using Umbraco.Cms.Core.Models;
using Umbraco.Cms.Core.Persistence.Querying;
using Umbraco.Cms.Core.Scoping;
using Umbraco.Cms.Infrastructure.Persistence.Repositories.Implement;
using Umbraco.Cms.Infrastructure.Scoping;
using Umbraco.Cms.Tests.Common.Testing;
using Umbraco.Cms.Tests.Integration.Testing;
namespace Umbraco.Cms.Tests.Integration.Umbraco.Infrastructure.Persistence.Repositories
{
[TestFixture]
[UmbracoTest(Database = UmbracoTestOptions.Database.NewSchemaPerTest)]
public class MacroRepositoryTest : UmbracoIntegrationTest
{
private ILogger<MacroRepository> _logger;
[SetUp]
public void SetUp()
{
_logger = LoggerFactory.CreateLogger<MacroRepository>();
CreateTestData();
}
[Test]
public void Cannot_Add_Duplicate_Macros()
{
// Arrange
IScopeProvider provider = ScopeProvider;
using (provider.CreateScope())
{
var repository = new MacroRepository((IScopeAccessor)provider, AppCaches.Disabled, _logger, ShortStringHelper);
var macro = new Macro(ShortStringHelper, "test1", "Test", "~/views/macropartials/test.cshtml");
Assert.That(() => repository.Save(macro), Throws.InstanceOf<DbException>());
}
}
[Test]
public void Cannot_Update_To_Duplicate_Macro_Alias()
{
// Arrange
IScopeProvider provider = ScopeProvider;
using (provider.CreateScope())
{
var repository = new MacroRepository((IScopeAccessor)provider, AppCaches.Disabled, _logger, ShortStringHelper);
IMacro macro = repository.Get(1);
macro.Alias = "test2";
Assert.That(() => repository.Save(macro), Throws.InstanceOf<DbException>());
}
}
[Test]
public void Can_Instantiate_Repository()
{
// Arrange
IScopeProvider provider = ScopeProvider;
using (provider.CreateScope())
{
var repository = new MacroRepository((IScopeAccessor)provider, AppCaches.Disabled, _logger, ShortStringHelper);
// Assert
Assert.That(repository, Is.Not.Null);
}
}
[Test]
public void Can_Perform_Get_On_Repository()
{
// Arrange
IScopeProvider provider = ScopeProvider;
using (provider.CreateScope())
{
var repository = new MacroRepository((IScopeAccessor)provider, AppCaches.Disabled, _logger, ShortStringHelper);
// Act
IMacro macro = repository.Get(1);
// Assert
Assert.That(macro, Is.Not.Null);
Assert.That(macro.HasIdentity, Is.True);
Assert.That(macro.Alias, Is.EqualTo("test1"));
Assert.That(macro.CacheByPage, Is.EqualTo(false));
Assert.That(macro.CacheByMember, Is.EqualTo(false));
Assert.That(macro.DontRender, Is.EqualTo(true));
Assert.That(macro.Name, Is.EqualTo("Test1"));
Assert.That(macro.CacheDuration, Is.EqualTo(0));
Assert.That(macro.MacroSource, Is.EqualTo("~/views/macropartials/test1.cshtml"));
Assert.That(macro.UseInEditor, Is.EqualTo(false));
}
}
[Test]
public void Can_Perform_GetAll_On_Repository()
{
// Arrange
IScopeProvider provider = ScopeProvider;
using (provider.CreateScope())
{
var repository = new MacroRepository((IScopeAccessor)provider, AppCaches.Disabled, _logger, ShortStringHelper);
// Act
IEnumerable<IMacro> macros = repository.GetMany();
// Assert
Assert.That(macros.Count(), Is.EqualTo(3));
}
}
[Test]
public void Can_Perform_GetByQuery_On_Repository()
{
// Arrange
IScopeProvider provider = ScopeProvider;
using (IScope scope = provider.CreateScope())
{
var repository = new MacroRepository((IScopeAccessor)provider, AppCaches.Disabled, _logger, ShortStringHelper);
// Act
IQuery<IMacro> query = ScopeAccessor.AmbientScope.SqlContext.Query<IMacro>().Where(x => x.Alias.ToUpper() == "TEST1");
IEnumerable<IMacro> result = repository.Get((IQuery<IMacro>)query);
// Assert
Assert.AreEqual(1, result.Count());
}
}
[Test]
public void Can_Perform_Count_On_Repository()
{
// Arrange
IScopeProvider provider = ScopeProvider;
using (IScope scope = provider.CreateScope())
{
var repository = new MacroRepository((IScopeAccessor)provider, AppCaches.Disabled, _logger, ShortStringHelper);
// Act
IQuery<IMacro> query = ScopeAccessor.AmbientScope.SqlContext.Query<IMacro>().Where(x => x.Name.StartsWith("Test"));
int count = repository.Count(query);
// Assert
Assert.That(count, Is.EqualTo(2));
}
}
[Test]
public void Can_Perform_Add_On_Repository()
{
// Arrange
IScopeProvider provider = ScopeProvider;
using (provider.CreateScope())
{
var repository = new MacroRepository((IScopeAccessor)provider, AppCaches.Disabled, _logger, ShortStringHelper);
// Act
var macro = new Macro(ShortStringHelper, "test", "Test", "~/views/macropartials/test.cshtml");
macro.Properties.Add(new MacroProperty("test", "Test", 0, "test"));
repository.Save(macro);
// Assert
Assert.That(macro.HasIdentity, Is.True);
Assert.That(macro.Id, Is.EqualTo(4)); // With 3 existing entries the Id should be 4
Assert.Greater(macro.Properties.Values.Single().Id, 0);
}
}
[Test]
public void Can_Perform_Update_On_Repository()
{
// Arrange
IScopeProvider provider = ScopeProvider;
using (provider.CreateScope())
{
var repository = new MacroRepository((IScopeAccessor)provider, AppCaches.Disabled, _logger, ShortStringHelper);
// Act
IMacro macro = repository.Get(2);
macro.Name = "Hello";
macro.CacheDuration = 1234;
macro.CacheByPage = true;
macro.CacheByMember = true;
macro.DontRender = false;
macro.MacroSource = "~/newpath.cshtml";
macro.UseInEditor = true;
repository.Save(macro);
IMacro macroUpdated = repository.Get(2);
// Assert
Assert.That(macroUpdated, Is.Not.Null);
Assert.That(macroUpdated.Name, Is.EqualTo("Hello"));
Assert.That(macroUpdated.CacheDuration, Is.EqualTo(1234));
Assert.That(macroUpdated.CacheByPage, Is.EqualTo(true));
Assert.That(macroUpdated.CacheByMember, Is.EqualTo(true));
Assert.That(macroUpdated.DontRender, Is.EqualTo(false));
Assert.That(macroUpdated.MacroSource, Is.EqualTo("~/newpath.cshtml"));
Assert.That(macroUpdated.UseInEditor, Is.EqualTo(true));
}
}
[Test]
public void Can_Perform_Delete_On_Repository()
{
// Arrange
IScopeProvider provider = ScopeProvider;
using (provider.CreateScope())
{
var repository = new MacroRepository((IScopeAccessor)provider, AppCaches.Disabled, _logger, ShortStringHelper);
// Act
IMacro macro = repository.Get(3);
Assert.IsNotNull(macro);
repository.Delete(macro);
bool exists = repository.Exists(3);
// Assert
Assert.That(exists, Is.False);
}
}
[Test]
public void Can_Perform_Exists_On_Repository()
{
// Arrange
IScopeProvider provider = ScopeProvider;
using (provider.CreateScope())
{
var repository = new MacroRepository((IScopeAccessor)provider, AppCaches.Disabled, _logger, ShortStringHelper);
// Act
bool exists = repository.Exists(3);
bool doesntExist = repository.Exists(10);
// Assert
Assert.That(exists, Is.True);
Assert.That(doesntExist, Is.False);
}
}
[Test]
public void Can_Add_Property_For_Macro()
{
// Arrange
IScopeProvider provider = ScopeProvider;
using (provider.CreateScope())
{
var repository = new MacroRepository((IScopeAccessor)provider, AppCaches.Disabled, _logger, ShortStringHelper);
IMacro macro = repository.Get(1);
macro.Properties.Add(new MacroProperty("new1", "New1", 3, "test"));
repository.Save(macro);
// Assert
Assert.Greater(macro.Properties.Values.First().Id, 0); // ensure id is returned
IMacro result = repository.Get(1);
Assert.Greater(result.Properties.Values.First().Id, 0);
Assert.AreEqual(1, result.Properties.Values.Count());
Assert.AreEqual("new1", result.Properties.Values.First().Alias);
Assert.AreEqual("New1", result.Properties.Values.First().Name);
Assert.AreEqual(3, result.Properties.Values.First().SortOrder);
}
}
[Test]
public void Can_Add_New_Macro_With_Property()
{
// Arrange
IScopeProvider provider = ScopeProvider;
using (provider.CreateScope())
{
var repository = new MacroRepository((IScopeAccessor)provider, AppCaches.Disabled, _logger, ShortStringHelper);
var macro = new Macro(ShortStringHelper, "newmacro", "A new macro", "~/views/macropartials/test1.cshtml");
macro.Properties.Add(new MacroProperty("blah1", "New1", 4, "test.editor"));
repository.Save(macro);
// Assert
IMacro result = repository.Get(macro.Id);
Assert.AreEqual(1, result.Properties.Values.Count());
Assert.AreEqual("blah1", result.Properties.Values.First().Alias);
Assert.AreEqual("New1", result.Properties.Values.First().Name);
Assert.AreEqual(4, result.Properties.Values.First().SortOrder);
}
}
[Test]
public void Can_Remove_Macro_Property()
{
// Arrange
IScopeProvider provider = ScopeProvider;
using (provider.CreateScope())
{
var repository = new MacroRepository((IScopeAccessor)provider, AppCaches.Disabled, _logger, ShortStringHelper);
var macro = new Macro(ShortStringHelper, "newmacro", "A new macro", "~/views/macropartials/test1.cshtml");
macro.Properties.Add(new MacroProperty("blah1", "New1", 4, "test.editor"));
repository.Save(macro);
IMacro result = repository.Get(macro.Id);
result.Properties.Remove("blah1");
repository.Save(result);
// Assert
result = repository.Get(macro.Id);
Assert.AreEqual(0, result.Properties.Values.Count());
}
}
[Test]
public void Can_Add_Remove_Macro_Properties()
{
// Arrange
IScopeProvider provider = ScopeProvider;
using (provider.CreateScope())
{
var repository = new MacroRepository((IScopeAccessor)provider, AppCaches.Disabled, _logger, ShortStringHelper);
var macro = new Macro(ShortStringHelper, "newmacro", "A new macro", "~/views/macropartials/test1.cshtml");
var prop1 = new MacroProperty("blah1", "New1", 4, "test.editor");
var prop2 = new MacroProperty("blah2", "New2", 3, "test.editor");
// add/remove a few to test the collection observable
macro.Properties.Add(prop1);
macro.Properties.Add(prop2);
macro.Properties.Remove(prop1);
macro.Properties.Remove("blah2");
macro.Properties.Add(prop2);
repository.Save(macro);
// Assert
IMacro result = repository.Get(macro.Id);
Assert.AreEqual(1, result.Properties.Values.Count());
Assert.AreEqual("blah2", result.Properties.Values.Single().Alias);
}
}
[Test]
public void Can_Update_Property_For_Macro()
{
// Arrange
IScopeProvider provider = ScopeProvider;
using (provider.CreateScope())
{
var repository = new MacroRepository((IScopeAccessor)provider, AppCaches.Disabled, _logger, ShortStringHelper);
IMacro macro = repository.Get(1);
macro.Properties.Add(new MacroProperty("new1", "New1", 3, "test"));
repository.Save(macro);
// Act
macro = repository.Get(1);
macro.Properties["new1"].Name = "this is a new name";
repository.Save(macro);
// Assert
IMacro result = repository.Get(1);
Assert.AreEqual("new1", result.Properties.Values.First().Alias);
Assert.AreEqual("this is a new name", result.Properties.Values.First().Name);
}
}
[Test]
public void Can_Update_Macro_Property_Alias()
{
// Arrange
IScopeProvider provider = ScopeProvider;
using (provider.CreateScope())
{
var repository = new MacroRepository((IScopeAccessor)provider, AppCaches.Disabled, _logger, ShortStringHelper);
IMacro macro = repository.Get(1);
macro.Properties.Add(new MacroProperty("new1", "New1", 3, "test"));
repository.Save(macro);
// Act
macro = repository.Get(1);
macro.Properties.UpdateProperty("new1", newAlias: "newAlias");
repository.Save(macro);
// Assert
IMacro result = repository.Get(1);
Assert.AreEqual("newAlias", result.Properties.Values.First().Alias);
}
}
public void CreateTestData()
{
IScopeProvider provider = ScopeProvider;
using (IScope scope = provider.CreateScope())
{
var repository = new MacroRepository((IScopeAccessor)provider, AppCaches.Disabled, _logger, ShortStringHelper);
repository.Save(new Macro(ShortStringHelper, "test1", "Test1", "~/views/macropartials/test1.cshtml"));
repository.Save(new Macro(ShortStringHelper, "test2", "Test2", "~/views/macropartials/test2.cshtml"));
repository.Save(new Macro(ShortStringHelper, "test3", "Tet3", "~/views/macropartials/test3.cshtml"));
scope.Complete();
}
}
}
}