* Update gitignore * Move csproj * Update project references * Update solutions * Update build scripts * Tests used to share editorconfig with projects in src * Fix broken tests. * Stop copying around .editorconfig merged root one with linting * csharp_style_expression_bodied -> suggestion * Move StyleCop rulesets to matching directories and update shared build properties * Remove legacy build files, update NuGet.cofig and solution files * Restore myget source * Clean up .gitignore * Update .gitignore * Move new test classes to tests after merge * Gitignore + nuget config * Move new test Co-authored-by: Ronald Barendse <ronald@barend.se>
269 lines
13 KiB
C#
269 lines
13 KiB
C#
// Copyright (c) Umbraco.
|
|
// See LICENSE for more details.
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using Microsoft.Extensions.Logging.Abstractions;
|
|
using Moq;
|
|
using NUnit.Framework;
|
|
using Umbraco.Cms.Core.Cache;
|
|
using Umbraco.Cms.Core.Models;
|
|
using Umbraco.Cms.Core.Models.PublishedContent;
|
|
using Umbraco.Cms.Core.PropertyEditors;
|
|
using Umbraco.Cms.Core.PublishedCache;
|
|
using Umbraco.Cms.Core.Services;
|
|
using Umbraco.Cms.Core.Strings;
|
|
using Umbraco.Cms.Infrastructure.Serialization;
|
|
using Umbraco.Extensions;
|
|
|
|
namespace Umbraco.Cms.Tests.UnitTests.Umbraco.Core.Published
|
|
{
|
|
[TestFixture]
|
|
public class PropertyCacheLevelTests
|
|
{
|
|
[TestCase(PropertyCacheLevel.None, 2)]
|
|
[TestCase(PropertyCacheLevel.Element, 1)]
|
|
[TestCase(PropertyCacheLevel.Elements, 1)]
|
|
[TestCase(PropertyCacheLevel.Snapshot, 1)]
|
|
public void CacheLevelTest(PropertyCacheLevel cacheLevel, int interConverts)
|
|
{
|
|
var converter = new CacheConverter1(cacheLevel);
|
|
|
|
var converters = new PropertyValueConverterCollection(() => new IPropertyValueConverter[]
|
|
{
|
|
converter,
|
|
});
|
|
|
|
var configurationEditorJsonSerializer = new ConfigurationEditorJsonSerializer();
|
|
var dataTypeServiceMock = new Mock<IDataTypeService>();
|
|
var dataType = new DataType(
|
|
new VoidEditor(
|
|
Mock.Of<IDataValueEditorFactory>()), configurationEditorJsonSerializer)
|
|
{ Id = 1 };
|
|
dataTypeServiceMock.Setup(x => x.GetAll()).Returns(dataType.Yield);
|
|
|
|
var publishedContentTypeFactory = new PublishedContentTypeFactory(Mock.Of<IPublishedModelFactory>(), converters, dataTypeServiceMock.Object);
|
|
|
|
IEnumerable<IPublishedPropertyType> CreatePropertyTypes(IPublishedContentType contentType)
|
|
{
|
|
yield return publishedContentTypeFactory.CreatePropertyType(contentType, "prop1", dataType.Id);
|
|
}
|
|
|
|
IPublishedContentType setType1 = publishedContentTypeFactory.CreateContentType(Guid.NewGuid(), 1000, "set1", CreatePropertyTypes);
|
|
|
|
// PublishedElementPropertyBase.GetCacheLevels:
|
|
//
|
|
// if property level is > reference level, or both are None
|
|
// use None for property & new reference
|
|
// else
|
|
// use Content for property, & keep reference
|
|
//
|
|
// PublishedElement creates properties with reference being None
|
|
// if converter specifies None, keep using None
|
|
// anything else is not > None, use Content
|
|
//
|
|
// for standalone elements, it's only None or Content
|
|
var set1 = new PublishedElement(setType1, Guid.NewGuid(), new Dictionary<string, object> { { "prop1", "1234" } }, false);
|
|
|
|
Assert.AreEqual(1234, set1.Value(Mock.Of<IPublishedValueFallback>(), "prop1"));
|
|
Assert.AreEqual(1, converter.SourceConverts);
|
|
Assert.AreEqual(1, converter.InterConverts);
|
|
|
|
// source is always converted once and cached per content
|
|
// inter conversion depends on the specified cache level
|
|
Assert.AreEqual(1234, set1.Value(Mock.Of<IPublishedValueFallback>(), "prop1"));
|
|
Assert.AreEqual(1, converter.SourceConverts);
|
|
Assert.AreEqual(interConverts, converter.InterConverts);
|
|
}
|
|
|
|
// property is not cached, converted cached at Content, exept
|
|
// /None = not cached at all
|
|
[TestCase(PropertyCacheLevel.None, PropertyCacheLevel.None, 2, 0, 0, 0, 0)]
|
|
[TestCase(PropertyCacheLevel.None, PropertyCacheLevel.Element, 1, 0, 0, 0, 0)]
|
|
[TestCase(PropertyCacheLevel.None, PropertyCacheLevel.Elements, 1, 0, 0, 0, 0)]
|
|
[TestCase(PropertyCacheLevel.None, PropertyCacheLevel.Snapshot, 1, 0, 0, 0, 0)]
|
|
|
|
// property is cached at element level, converted cached at
|
|
// /None = not at all
|
|
// /Element = in element
|
|
// /Snapshot = in snapshot
|
|
// /Elements = in elements
|
|
[TestCase(PropertyCacheLevel.Element, PropertyCacheLevel.None, 2, 0, 0, 0, 0)]
|
|
[TestCase(PropertyCacheLevel.Element, PropertyCacheLevel.Element, 1, 0, 0, 0, 0)]
|
|
[TestCase(PropertyCacheLevel.Element, PropertyCacheLevel.Elements, 1, 1, 0, 1, 0)]
|
|
[TestCase(PropertyCacheLevel.Element, PropertyCacheLevel.Snapshot, 1, 0, 1, 0, 1)]
|
|
|
|
// property is cached at elements level, converted cached at Element, exept
|
|
// /None = not cached at all
|
|
// /Snapshot = cached in snapshot
|
|
[TestCase(PropertyCacheLevel.Elements, PropertyCacheLevel.None, 2, 0, 0, 0, 0)]
|
|
[TestCase(PropertyCacheLevel.Elements, PropertyCacheLevel.Element, 1, 0, 0, 0, 0)]
|
|
[TestCase(PropertyCacheLevel.Elements, PropertyCacheLevel.Elements, 1, 0, 0, 0, 0)]
|
|
[TestCase(PropertyCacheLevel.Elements, PropertyCacheLevel.Snapshot, 1, 0, 1, 0, 1)]
|
|
|
|
// property is cached at snapshot level, converted cached at Element, exept
|
|
// /None = not cached at all
|
|
[TestCase(PropertyCacheLevel.Snapshot, PropertyCacheLevel.None, 2, 0, 0, 0, 0)]
|
|
[TestCase(PropertyCacheLevel.Snapshot, PropertyCacheLevel.Element, 1, 0, 0, 0, 0)]
|
|
[TestCase(PropertyCacheLevel.Snapshot, PropertyCacheLevel.Elements, 1, 0, 0, 0, 0)]
|
|
[TestCase(PropertyCacheLevel.Snapshot, PropertyCacheLevel.Snapshot, 1, 0, 0, 0, 0)]
|
|
|
|
public void CachePublishedSnapshotTest(
|
|
PropertyCacheLevel referenceCacheLevel,
|
|
PropertyCacheLevel converterCacheLevel,
|
|
int interConverts,
|
|
int elementsCount1,
|
|
int snapshotCount1,
|
|
int elementsCount2,
|
|
int snapshotCount2)
|
|
{
|
|
var converter = new CacheConverter1(converterCacheLevel);
|
|
|
|
var converters = new PropertyValueConverterCollection(() => new IPropertyValueConverter[]
|
|
{
|
|
converter,
|
|
});
|
|
|
|
var dataTypeServiceMock = new Mock<IDataTypeService>();
|
|
var dataType = new DataType(
|
|
new VoidEditor(
|
|
Mock.Of<IDataValueEditorFactory>()), new ConfigurationEditorJsonSerializer())
|
|
{ Id = 1 };
|
|
dataTypeServiceMock.Setup(x => x.GetAll()).Returns(dataType.Yield);
|
|
|
|
var publishedContentTypeFactory = new PublishedContentTypeFactory(Mock.Of<IPublishedModelFactory>(), converters, dataTypeServiceMock.Object);
|
|
|
|
IEnumerable<IPublishedPropertyType> CreatePropertyTypes(IPublishedContentType contentType)
|
|
{
|
|
yield return publishedContentTypeFactory.CreatePropertyType(contentType, "prop1", 1);
|
|
}
|
|
|
|
IPublishedContentType setType1 = publishedContentTypeFactory.CreateContentType(Guid.NewGuid(), 1000, "set1", CreatePropertyTypes);
|
|
|
|
var elementsCache = new FastDictionaryAppCache();
|
|
var snapshotCache = new FastDictionaryAppCache();
|
|
|
|
var publishedSnapshot = new Mock<IPublishedSnapshot>();
|
|
publishedSnapshot.Setup(x => x.SnapshotCache).Returns(snapshotCache);
|
|
publishedSnapshot.Setup(x => x.ElementsCache).Returns(elementsCache);
|
|
|
|
var publishedSnapshotAccessor = new Mock<IPublishedSnapshotAccessor>();
|
|
var localPublishedSnapshot = publishedSnapshot.Object;
|
|
publishedSnapshotAccessor.Setup(x => x.TryGetPublishedSnapshot(out localPublishedSnapshot)).Returns(true);
|
|
|
|
// pretend we're creating this set as a value for a property
|
|
// referenceCacheLevel is the cache level for this fictious property
|
|
// converterCacheLevel is the cache level specified by the converter
|
|
var set1 = new PublishedElement(setType1, Guid.NewGuid(), new Dictionary<string, object> { { "prop1", "1234" } }, false, referenceCacheLevel, publishedSnapshotAccessor.Object);
|
|
|
|
Assert.AreEqual(1234, set1.Value(Mock.Of<IPublishedValueFallback>(), "prop1"));
|
|
Assert.AreEqual(1, converter.SourceConverts);
|
|
Assert.AreEqual(1, converter.InterConverts);
|
|
|
|
Assert.AreEqual(elementsCount1, elementsCache.Count);
|
|
Assert.AreEqual(snapshotCount1, snapshotCache.Count);
|
|
|
|
Assert.AreEqual(1234, set1.Value(Mock.Of<IPublishedValueFallback>(), "prop1"));
|
|
Assert.AreEqual(1, converter.SourceConverts);
|
|
Assert.AreEqual(interConverts, converter.InterConverts);
|
|
|
|
Assert.AreEqual(elementsCount2, elementsCache.Count);
|
|
Assert.AreEqual(snapshotCount2, snapshotCache.Count);
|
|
|
|
FastDictionaryAppCache oldSnapshotCache = snapshotCache;
|
|
snapshotCache.Clear();
|
|
|
|
Assert.AreEqual(1234, set1.Value(Mock.Of<IPublishedValueFallback>(), "prop1"));
|
|
Assert.AreEqual(1, converter.SourceConverts);
|
|
|
|
Assert.AreEqual(elementsCount2, elementsCache.Count);
|
|
Assert.AreEqual(snapshotCount2, snapshotCache.Count);
|
|
Assert.AreEqual(snapshotCount2, oldSnapshotCache.Count);
|
|
|
|
Assert.AreEqual((interConverts == 1 ? 1 : 3) + snapshotCache.Count, converter.InterConverts);
|
|
|
|
FastDictionaryAppCache oldElementsCache = elementsCache;
|
|
elementsCache.Clear();
|
|
|
|
Assert.AreEqual(1234, set1.Value(Mock.Of<IPublishedValueFallback>(), "prop1"));
|
|
Assert.AreEqual(1, converter.SourceConverts);
|
|
|
|
Assert.AreEqual(elementsCount2, elementsCache.Count);
|
|
Assert.AreEqual(elementsCount2, oldElementsCache.Count);
|
|
Assert.AreEqual(snapshotCount2, snapshotCache.Count);
|
|
|
|
Assert.AreEqual((interConverts == 1 ? 1 : 4) + snapshotCache.Count + elementsCache.Count, converter.InterConverts);
|
|
}
|
|
|
|
[Test]
|
|
public void CacheUnknownTest()
|
|
{
|
|
var converter = new CacheConverter1(PropertyCacheLevel.Unknown);
|
|
|
|
var converters = new PropertyValueConverterCollection(() => new IPropertyValueConverter[]
|
|
{
|
|
converter,
|
|
});
|
|
|
|
var dataTypeServiceMock = new Mock<IDataTypeService>();
|
|
var dataType = new DataType(
|
|
new VoidEditor(
|
|
Mock.Of<IDataValueEditorFactory>()), new ConfigurationEditorJsonSerializer())
|
|
{ Id = 1 };
|
|
dataTypeServiceMock.Setup(x => x.GetAll()).Returns(dataType.Yield);
|
|
|
|
var publishedContentTypeFactory = new PublishedContentTypeFactory(Mock.Of<IPublishedModelFactory>(), converters, dataTypeServiceMock.Object);
|
|
|
|
IEnumerable<IPublishedPropertyType> CreatePropertyTypes(IPublishedContentType contentType)
|
|
{
|
|
yield return publishedContentTypeFactory.CreatePropertyType(contentType, "prop1", 1);
|
|
}
|
|
|
|
IPublishedContentType setType1 = publishedContentTypeFactory.CreateContentType(Guid.NewGuid(), 1000, "set1", CreatePropertyTypes);
|
|
|
|
Assert.Throws<Exception>(() =>
|
|
{
|
|
var unused = new PublishedElement(setType1, Guid.NewGuid(), new Dictionary<string, object> { { "prop1", "1234" } }, false);
|
|
});
|
|
}
|
|
|
|
private class CacheConverter1 : IPropertyValueConverter
|
|
{
|
|
private readonly PropertyCacheLevel _cacheLevel;
|
|
|
|
public CacheConverter1(PropertyCacheLevel cacheLevel) => _cacheLevel = cacheLevel;
|
|
|
|
public int SourceConverts { get; private set; }
|
|
|
|
public int InterConverts { get; private set; }
|
|
|
|
public bool? IsValue(object value, PropertyValueLevel level)
|
|
=> value != null && (!(value is string) || string.IsNullOrWhiteSpace((string)value) == false);
|
|
|
|
public bool IsConverter(IPublishedPropertyType propertyType)
|
|
=> propertyType.EditorAlias.InvariantEquals("Umbraco.Void");
|
|
|
|
public Type GetPropertyValueType(IPublishedPropertyType propertyType)
|
|
=> typeof(int);
|
|
|
|
public PropertyCacheLevel GetPropertyCacheLevel(IPublishedPropertyType propertyType)
|
|
=> _cacheLevel;
|
|
|
|
public object ConvertSourceToIntermediate(IPublishedElement owner, IPublishedPropertyType propertyType, object source, bool preview)
|
|
{
|
|
SourceConverts++;
|
|
return int.TryParse(source as string, out int i) ? i : 0;
|
|
}
|
|
|
|
public object ConvertIntermediateToObject(IPublishedElement owner, IPublishedPropertyType propertyType, PropertyCacheLevel referenceCacheLevel, object inter, bool preview)
|
|
{
|
|
InterConverts++;
|
|
return (int)inter;
|
|
}
|
|
|
|
public object ConvertIntermediateToXPath(IPublishedElement owner, IPublishedPropertyType propertyType, PropertyCacheLevel referenceCacheLevel, object inter, bool preview)
|
|
=> ((int)inter).ToString();
|
|
}
|
|
}
|
|
}
|