* V15 QA Added the authorization integration tests (#18419) * Added authorization integration tests * Removed unnecessary tests and update tests for preview controller * Updated to use the newest changes from v15/dev and added an override for the AuthenticateClientAsync to use the userGroupKey * Updated CompatibilitySuppressions to include changes from integration tests * Updated pipelines * Skips managementApi tests * Only run necessary tests * Added new schema per fixture to reduce test setup time * Fixed failing tests * Updated test setup * Updated test * Added suppression * Fixed failing tests * Updated addOnTeardown methods to protected * Added method for clearing the host * Added teardown * Updated model usage * Added a lot of cleanup for memory leak issues when running tests * Added CompatibilitySuppressions.xml * Updated tests * Cleaned up * Adjusted base classes * Updated pipeline * Updated CompatibilitySuppressions.xml * Updated test logging * Fixed reponse * Updated condition to skip tests * Updated tests, not done * Reworked test to expect correct responses with correct setup * Updated tests * More updates to tests * Updated tests * Cleaned up tests * Updated setup * Cleaned up tests to match setup * Cleaned up setup * Removed suppression * Fixed tests * Move order of checks * Fix naming * Formatting * Dispose of host * Keep track of if we're disposed * Compat suppression * Dont dispose * Fix failing tests * removed unused virtual * Updated CompatibilitySuppressions.xml --------- Co-authored-by: Andreas Zerbst <andr317c@live.dk> Co-authored-by: Zeegaan <skrivdetud@gmail.com> Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com> # Conflicts: # tests/Umbraco.Tests.Integration/CompatibilitySuppressions.xml # tests/Umbraco.Tests.Integration/ManagementApi/ManagementApiTest.cs # tests/Umbraco.Tests.Integration/ManagementApi/Policies/AllCultureControllerTests.cs # tests/Umbraco.Tests.Integration/ManagementApi/Policies/CreateDocumentTests.cs # tests/Umbraco.Tests.Integration/ManagementApi/Policies/UpdateDocumentTests.cs # tests/Umbraco.Tests.Integration/ManagementApi/Preview/EndPreviewTests.cs # tests/Umbraco.Tests.Integration/ManagementApi/Preview/EnterPreviewTests.cs # tests/Umbraco.Tests.Integration/TestServerTest/UmbracoTestServerTestBase.cs * Updated test * Updates * Removed unnessecary test --------- Co-authored-by: Nhu Dinh <150406148+nhudinh0309@users.noreply.github.com> Co-authored-by: Zeegaan <skrivdetud@gmail.com> Co-authored-by: Nikolaj Geisle <70372949+Zeegaan@users.noreply.github.com>
368 lines
15 KiB
C#
368 lines
15 KiB
C#
using System.Linq.Expressions;
|
|
using System.Reflection;
|
|
using Asp.Versioning;
|
|
using Microsoft.AspNetCore.Authentication;
|
|
using Microsoft.AspNetCore.Builder;
|
|
using Microsoft.AspNetCore.Hosting;
|
|
using Microsoft.AspNetCore.Http;
|
|
using Microsoft.AspNetCore.Mvc.Testing;
|
|
using Microsoft.AspNetCore.Routing;
|
|
using Microsoft.AspNetCore.TestHost;
|
|
using Microsoft.Extensions.Configuration;
|
|
using Microsoft.Extensions.DependencyInjection;
|
|
using Microsoft.Extensions.Hosting;
|
|
using Moq;
|
|
using NUnit.Framework;
|
|
using Umbraco.Cms.Api.Delivery.Controllers.Content;
|
|
using Umbraco.Cms.Api.Management.Controllers;
|
|
using Umbraco.Cms.Api.Management.Controllers.ModelsBuilder;
|
|
using Umbraco.Cms.Api.Management.DependencyInjection;
|
|
using Umbraco.Cms.Core;
|
|
using Umbraco.Cms.Core.Cache;
|
|
using Umbraco.Cms.Core.Composing;
|
|
using Umbraco.Cms.Core.Persistence.Repositories;
|
|
using Umbraco.Cms.Core.Services;
|
|
using Umbraco.Cms.Core.Web;
|
|
using Umbraco.Cms.Persistence.Sqlite;
|
|
using Umbraco.Cms.Persistence.SqlServer;
|
|
using Umbraco.Cms.Tests.Common.Testing;
|
|
using Umbraco.Cms.Tests.Integration.DependencyInjection;
|
|
using Umbraco.Cms.Tests.Integration.Testing;
|
|
using Umbraco.Cms.Web.Common.Controllers;
|
|
using Umbraco.Cms.Web.Website.Controllers;
|
|
|
|
namespace Umbraco.Cms.Tests.Integration.TestServerTest
|
|
{
|
|
[TestFixture]
|
|
[UmbracoTest(Database = UmbracoTestOptions.Database.NewSchemaPerTest, Logger = UmbracoTestOptions.Logger.Console, Boot = true)]
|
|
public abstract class UmbracoTestServerTestBase : UmbracoIntegrationTestBase
|
|
{
|
|
private static readonly Dictionary<string, WebApplicationFactory<UmbracoTestServerTestBase>> _factoryCache = new();
|
|
|
|
protected HttpClient Client { get; private set; }
|
|
|
|
protected WebApplicationFactory<UmbracoTestServerTestBase> Factory { get; private set; }
|
|
|
|
protected IServiceProvider Services => Factory?.Services;
|
|
|
|
protected LinkGenerator LinkGenerator => Factory.Services.GetRequiredService<LinkGenerator>();
|
|
|
|
protected void CustomMvcSetup(IMvcBuilder mvcBuilder)
|
|
{
|
|
}
|
|
|
|
protected virtual void ConfigureTestServices(IServiceCollection services)
|
|
{
|
|
}
|
|
|
|
/// <summary>
|
|
/// Hook for altering UmbracoBuilder setup
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// Can also be used for registering test doubles.
|
|
/// </remarks>
|
|
protected virtual void CustomTestSetup(IUmbracoBuilder builder)
|
|
{
|
|
}
|
|
|
|
protected virtual void CustomTestAuthSetup(IServiceCollection services)
|
|
{
|
|
// Add a test auth scheme with a test auth handler to authn and assign the user
|
|
services.AddAuthentication(TestAuthHandler.TestAuthenticationScheme)
|
|
.AddScheme<AuthenticationSchemeOptions, TestAuthHandler>(TestAuthHandler.TestAuthenticationScheme,
|
|
options => { });
|
|
}
|
|
|
|
[SetUp]
|
|
public virtual void Setup()
|
|
{
|
|
// Don't cache factory if using NewSchemaPerTest
|
|
if (TestOptions.Database == UmbracoTestOptions.Database.NewSchemaPerTest ||
|
|
TestOptions.Database == UmbracoTestOptions.Database.NewEmptyPerTest)
|
|
{
|
|
// Create a new factory for each test when using per-test database
|
|
Factory = CreateNewFactory();
|
|
}
|
|
else
|
|
{
|
|
// Use cached factory for per-fixture database options
|
|
var cacheKey = $"{TestOptions.Database}_{TestOptions.Boot}";
|
|
|
|
if (!_factoryCache.TryGetValue(cacheKey, out var cachedFactory))
|
|
{
|
|
cachedFactory = CreateNewFactory();
|
|
_factoryCache[cacheKey] = cachedFactory;
|
|
}
|
|
|
|
Factory = cachedFactory;
|
|
}
|
|
|
|
Client = Factory.CreateClient(new WebApplicationFactoryClientOptions
|
|
{
|
|
AllowAutoRedirect = false, BaseAddress = new Uri("https://localhost/", UriKind.Absolute),
|
|
});
|
|
}
|
|
|
|
private WebApplicationFactory<UmbracoTestServerTestBase> CreateNewFactory()
|
|
{
|
|
/*
|
|
* It's worth noting that our usage of WebApplicationFactory is non-standard,
|
|
* the intent is that your Startup.ConfigureServices is called just like
|
|
* when the app starts up, then replacements are registered in this class with
|
|
* builder.ConfigureServices (builder.ConfigureTestServices has hung around from before the
|
|
* generic host switchover).
|
|
*
|
|
* This is currently a pain to refactor towards due to UmbracoBuilder+TypeFinder+TypeLoader setup but
|
|
* we should get there one day.
|
|
*
|
|
* However we need to separate the testing framework we provide for downstream projects from our own tests.
|
|
* We cannot use the Umbraco.Web.UI startup yet as that is not available downstream.
|
|
*
|
|
* See https://docs.microsoft.com/en-us/aspnet/core/test/integration-tests
|
|
*/
|
|
return new UmbracoWebApplicationFactory<UmbracoTestServerTestBase>(CreateHostBuilder)
|
|
.WithWebHostBuilder(builder =>
|
|
{
|
|
builder.UseContentRoot(Assembly.GetExecutingAssembly().GetRootDirectorySafe());
|
|
builder.ConfigureTestServices(services =>
|
|
{
|
|
services.AddSingleton<IWebProfilerRepository, TestWebProfilerRepository>();
|
|
CustomTestAuthSetup(services);
|
|
});
|
|
});
|
|
}
|
|
|
|
[TearDown]
|
|
public void TearDownClient()
|
|
{
|
|
Client?.Dispose();
|
|
|
|
// Dispose the factory if using per-test database
|
|
if (TestOptions.Database == UmbracoTestOptions.Database.NewSchemaPerTest ||
|
|
TestOptions.Database == UmbracoTestOptions.Database.NewEmptyPerTest)
|
|
{
|
|
Factory?.Dispose();
|
|
Factory = null;
|
|
}
|
|
}
|
|
|
|
[OneTimeTearDown]
|
|
public static async Task CleanupFactories()
|
|
{
|
|
foreach (var factory in _factoryCache.Values)
|
|
{
|
|
await factory.DisposeAsync();
|
|
}
|
|
|
|
_factoryCache.Clear();
|
|
}
|
|
|
|
/// <summary>
|
|
/// Prepare a url before using <see cref="Client"/>.
|
|
/// This returns the url but also sets the HttpContext.request into to use this url.
|
|
/// </summary>
|
|
/// <returns>The string URL of the controller action.</returns>
|
|
protected string PrepareApiControllerUrl<T>(Expression<Func<T, object>> methodSelector)
|
|
where T : UmbracoApiController
|
|
{
|
|
var url = LinkGenerator.GetUmbracoApiService(methodSelector);
|
|
return PrepareUrl(url);
|
|
}
|
|
|
|
protected string GetManagementApiUrl<T>(Expression<Func<T, object>> methodSelector)
|
|
where T : ManagementApiControllerBase
|
|
{
|
|
MethodInfo? method = ExpressionHelper.GetMethodInfo(methodSelector);
|
|
IDictionary<string, object?> methodParams = ExpressionHelper.GetMethodParams(methodSelector) ?? new Dictionary<string, object?>();
|
|
|
|
// Remove the CancellationToken from the method params, this is automatically added by the framework
|
|
// So we do not want to add this to the query string
|
|
methodParams.Remove(methodParams.FirstOrDefault(x => x.Value is CancellationToken).Key);
|
|
methodParams["version"] = method?.GetCustomAttribute<MapToApiVersionAttribute>()?.Versions[0].MajorVersion.ToString();
|
|
return LinkGenerator.GetUmbracoControllerUrl(method.Name, ControllerExtensions.GetControllerName<T>(), null, methodParams);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Prepare a url before using <see cref="Client"/>.
|
|
/// This returns the url but also sets the HttpContext.request into to use this url.
|
|
/// </summary>
|
|
/// <returns>The string URL of the controller action.</returns>
|
|
protected string PrepareSurfaceControllerUrl<T>(Expression<Func<T, object>> methodSelector)
|
|
where T : SurfaceController
|
|
{
|
|
var url = LinkGenerator.GetUmbracoSurfaceUrl(methodSelector);
|
|
return PrepareUrl(url);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Prepare a url before using <see cref="Client"/>.
|
|
/// This returns the url but also sets the HttpContext.request into to use this url.
|
|
/// </summary>
|
|
/// <returns>The string URL of the controller action.</returns>
|
|
protected string PrepareUrl(string url)
|
|
{
|
|
IUmbracoContextFactory umbracoContextFactory = GetRequiredService<IUmbracoContextFactory>();
|
|
IHttpContextAccessor httpContextAccessor = GetRequiredService<IHttpContextAccessor>();
|
|
|
|
httpContextAccessor.HttpContext = new DefaultHttpContext
|
|
{
|
|
Request =
|
|
{
|
|
Scheme = "https",
|
|
Host = new HostString("localhost", 80),
|
|
Path = url,
|
|
QueryString = new QueryString(string.Empty)
|
|
}
|
|
};
|
|
|
|
umbracoContextFactory.EnsureUmbracoContext();
|
|
return url;
|
|
}
|
|
|
|
private IHostBuilder CreateHostBuilder()
|
|
{
|
|
IHostBuilder hostBuilder = Host.CreateDefaultBuilder()
|
|
.ConfigureUmbracoDefaults()
|
|
.ConfigureAppConfiguration((context, configBuilder) =>
|
|
{
|
|
context.HostingEnvironment = TestHelper.GetWebHostEnvironment();
|
|
configBuilder.Sources.Clear();
|
|
configBuilder.AddInMemoryCollection(InMemoryConfiguration);
|
|
configBuilder.AddConfiguration(GlobalSetupTeardown.TestConfiguration);
|
|
|
|
Configuration = configBuilder.Build();
|
|
})
|
|
.ConfigureWebHost(builder =>
|
|
{
|
|
builder.ConfigureServices((context, services) =>
|
|
{
|
|
context.HostingEnvironment = TestHelper.GetWebHostEnvironment();
|
|
ConfigureServices(services);
|
|
ConfigureTestServices(services);
|
|
services.AddUnique(CreateLoggerFactory());
|
|
|
|
if (!TestOptions.Boot)
|
|
{
|
|
// If boot is false, we don't want the CoreRuntime hosted service to start
|
|
// So we replace it with a Mock
|
|
services.AddUnique(Mock.Of<IRuntime>());
|
|
}
|
|
});
|
|
|
|
// call startup
|
|
builder.Configure(Configure);
|
|
})
|
|
.UseDefaultServiceProvider(cfg =>
|
|
{
|
|
// These default to true *if* WebHostEnvironment.EnvironmentName == Development
|
|
// When running tests, EnvironmentName used to be null on the mock that we register into services.
|
|
// Enable opt in for tests so that validation occurs regardless of environment name.
|
|
// Would be nice to have this on for UmbracoIntegrationTest also but requires a lot more effort to resolve issues.
|
|
cfg.ValidateOnBuild = true;
|
|
cfg.ValidateScopes = true;
|
|
});
|
|
|
|
return hostBuilder;
|
|
}
|
|
|
|
protected virtual T GetRequiredService<T>() => Factory.Services.GetRequiredService<T>();
|
|
|
|
protected void ConfigureServices(IServiceCollection services)
|
|
{
|
|
services.AddTransient<TestUmbracoDatabaseFactoryProvider>();
|
|
|
|
TypeLoader typeLoader = services.AddTypeLoader(
|
|
GetType().Assembly,
|
|
TestHelper.ConsoleLoggerFactory,
|
|
Configuration);
|
|
|
|
services.AddLogger(TestHelper.GetWebHostEnvironment(), Configuration);
|
|
|
|
var builder = new UmbracoBuilder(services, Configuration, typeLoader, TestHelper.ConsoleLoggerFactory, TestHelper.Profiler, AppCaches.NoCache);
|
|
builder.Services.AddTransient<IHostedService>(sp =>
|
|
new TestDatabaseHostedLifecycleService(() => UseTestDatabase(sp)));
|
|
builder
|
|
.AddConfiguration()
|
|
.AddUmbracoCore()
|
|
.AddWebComponents()
|
|
.AddUmbracoHybridCache()
|
|
.AddBackOfficeCore()
|
|
.AddBackOfficeAuthentication()
|
|
.AddBackOfficeIdentity()
|
|
.AddMembersIdentity()
|
|
// .AddBackOfficeAuthorizationPolicies(TestAuthHandler.TestAuthenticationScheme)
|
|
.AddMvcAndRazor(mvcBuilding: mvcBuilder =>
|
|
{
|
|
// Adds Umbraco.Web.Common
|
|
mvcBuilder.AddApplicationPart(typeof(RenderController).Assembly);
|
|
|
|
// Adds Umbraco.Web.Website
|
|
mvcBuilder.AddApplicationPart(typeof(SurfaceController).Assembly);
|
|
|
|
// Adds Umbraco.Cms.Api.ManagementApi
|
|
mvcBuilder.AddApplicationPart(typeof(ModelsBuilderControllerBase).Assembly);
|
|
|
|
// Adds Umbraco.Cms.Api.DeliveryApi
|
|
mvcBuilder.AddApplicationPart(typeof(ContentApiItemControllerBase).Assembly);
|
|
|
|
// Adds Umbraco.Tests.Integration
|
|
mvcBuilder.AddApplicationPart(typeof(UmbracoTestServerTestBase).Assembly);
|
|
|
|
CustomMvcSetup(mvcBuilder);
|
|
})
|
|
.AddWebsite()
|
|
.AddUmbracoSqlServerSupport()
|
|
.AddUmbracoSqliteSupport()
|
|
.AddDeliveryApi()
|
|
.AddUmbracoManagementApi()
|
|
.AddComposers()
|
|
.AddTestServices(TestHelper); // This is the important one!
|
|
|
|
CustomTestSetup(builder);
|
|
|
|
builder.Build();
|
|
}
|
|
|
|
protected void Configure(IApplicationBuilder app)
|
|
{
|
|
app.UseUmbraco()
|
|
.WithMiddleware(u =>
|
|
{
|
|
u.UseBackOffice();
|
|
u.UseWebsite();
|
|
})
|
|
.WithEndpoints(u =>
|
|
{
|
|
u.UseBackOfficeEndpoints();
|
|
u.UseWebsiteEndpoints();
|
|
});
|
|
}
|
|
}
|
|
}
|
|
|
|
public class TestDatabaseHostedLifecycleService : IHostedLifecycleService
|
|
{
|
|
private readonly Action _action;
|
|
|
|
public TestDatabaseHostedLifecycleService(Action action)
|
|
{
|
|
_action = action;
|
|
}
|
|
|
|
public Task StartAsync(CancellationToken cancellationToken) => Task.CompletedTask;
|
|
|
|
public Task StopAsync(CancellationToken cancellationToken) => Task.CompletedTask;
|
|
|
|
public Task StartedAsync(CancellationToken cancellationToken) => Task.CompletedTask;
|
|
|
|
public Task StartingAsync(CancellationToken cancellationToken)
|
|
{
|
|
_action();
|
|
return Task.CompletedTask;
|
|
}
|
|
|
|
public Task StoppedAsync(CancellationToken cancellationToken) => Task.CompletedTask;
|
|
|
|
public Task StoppingAsync(CancellationToken cancellationToken) => Task.CompletedTask;
|
|
}
|