Files
Umbraco-CMS/tests/Umbraco.Tests.Integration/Umbraco.Core/Services/UserServiceCrudTests.PartialUpdates.cs
Andy Butland 825f791d01 Remove the non-controversial, straightforward obsoleted constructs for Umbraco 16 (#18661)
* Removed obsoletes from IConfigManipulator.

* Removed obsolete models builder extensions.

* Removed the obsolete ContentDashboardSettings.

* Removed the obsolete InstallMissingDatabase setting on GlobalSettings.

* Removed obsolete NuCache settings.

* Removed obsolete RuntimeMinificationSettings.

* Removed obsolete health check constant.

* Removed obsolete icon constant.

* Removed obsolete telemetry constant.

* Removed obsolete property and constructor on UmbracoBuilder.

* Removed obsolete constructor on AuditNotificationsHandler.

* Removed obsolete constructor on HTTP header health checks.

* Removed obsolete constructor on MediaFileManager.

* Removed obsolete GetDefaultFileContent on ViewHelper.

* Remove obsoleted methods on embed providers.

* Fix tests.

* Removed obsolete constructors on BlockEditorDataConverter.

* Removed obsolete SeedCacheDuration property on CacheSettings.

* Removed obsolete PublishCulture on ContentRepositoryExtensions.

* Removed obsolete MonitorLock.

* Removed obsolete synchronous HasSavedValues from IDataTypeUsageService and IDataTypeUsageRepository.

* Removed obsolete HasSavedPropertyValues from IPropertyTypeUsageService and IPropertyTypeUsageRepository.

* Removed obsolete methods in ITrackedReferencesService and ITrackedReferencesRepository.

* Removed obsolete DateValueEditor constructors.

* Removed obsolete GetAutomaticRelationTypesAliases.

* Removed obsolete constructor on TextOnlyValueEditor.

* Removed obsolete constructors on RegexValidator and RequiredValidator.

* Removed obsolete constructs on SliderValueConverter and TagsValueConverter.

* Removed obsolete GetContentType methods from IPublishedCache.

* Removed ContentFinderByIdPath.

* Removed obsolete constructor on DefaultMediaUrlProvider.

* Removed obsolete constructor on Domain.

* Removed obsolete constructor on PublishedRequest.

* Removed obsolete methods on CheckPermissions.

* Removed obsolete GetUserId from IBackOfficeSecurity.

* Removed obsolete methods on LegacyPasswordSecurity.

* Removed obsolete constructors on AuditService.

* Removed obsolete methods on IContentEditingService.

* Remove obsolete constructors and methods on ContentService/IContentService.

* Removed obsolete constructor in ContentTypeEditingService.

* Removed obsolete constructor in MediaTypeEditingService.

* Removed obsolete constructor in MemberTypeEditingService.

* Removed obsolete constructor in ContentTypeService.

* Removed obsolete constructors in ContentTypeServiceBase.

* Removed obsolete constructors and methods in ContentVersionService.

* Removed obsolete constructor in DataTypeUsageService.

* Removed obsolete constructor in DomainService.

* Removed obsolete constructor in FileService.

* Removes obsolete AttemptMove from IContentService.

* Removes obsolete SetPreventCleanup from IContentVersionService.

* Removes obsolete GetReferences from IDataTypeService.

* Removed obsolete SetConsentLevel from IMetricsConsentService.

* Removed obsolete methods from IPackageDataInstallation.

* Removed obsolete methods from IPackagingService.

* Removed obsolete methods on ITwoFactorLoginService.
Removed obsolete ITemporaryMediaService.

* Removed obsolete constructor from MediaService, MemberTypeService and MediaTypeService.

* More obsolete constructors.

* Removed obsoleted overloads on IPropertyValidationService.

* Fixed build for tests.

* Removed obsolete constructor for PublicAccessService, UserService and RelationService.

* Removed GetDefaultMemberType.

* Removed obsolete user group functionality from IUserService.

* Removed obsolete extension methods on IUserService.

* Removed obsolete method from ITelemetryService.

* Removed obsolete UdiParserServiceConnectors.

* Removed obsolete method on ICookieManager.

* Removed obsolete DynamicContext.

* Removed obsolete XmlHelper.

* Fixed failing integration tests.

* Removed obsoletes in Umbraco.Cms.Api.Common

* Removed obsoletes in Umbraco.Cms.Api.Delivery

* Removed obsoletes in Umbraco.Cms.Api.Management

* Removed obsoletes in Umbraco.Examine.Lucene

* Removed obsoletes in Umbraco.Infrastructure

* Fix failing delivery API contract integration test.

* Made integration tests internal.

* Removed obsoletes from web projects.

* Fix build.

* Removed Twitter OEmbed provider

* Removed obsolete constructor on PublishedDataType.

* Removed obsolete constructors on PublishedCacheBase.

* Removed the obsolete PropertyEditorTagsExtensions.

* Removed obsoletion properties on configuration response  models (#18697)

* Removed obsolete methods from server-side models.

* Update client-side types and sdk.

* Update client-side files.

* Removed obsoletion of Utf8ToAsciiConverter.ToAsciiString overload. (#18694)

* Removed obsolete method in UserService. (#18710)

* Removed obsoleted group alias keys from being publicly available. (#18682)

* Removed unneceessary ApiVersion attribute.

* Clean-up obsoletions on MemberService (#18703)

* Removed obsoleted method on MemberService, added future obsoletion to interface and updated all callers.

* Removed obsoletion on member service method that's not obsolete on the interface.
2025-03-21 17:02:31 +00:00

155 lines
6.0 KiB
C#

using NUnit.Framework;
using Umbraco.Cms.Core;
using Umbraco.Cms.Core.Models;
using Umbraco.Cms.Core.Models.Membership;
using Umbraco.Cms.Core.Services.OperationStatus;
namespace Umbraco.Cms.Tests.Integration.Umbraco.Core.Services;
internal sealed partial class UserServiceCrudTests
{
[Test]
public async Task Can_Enable_User()
{
var editorUserGroup = await UserGroupService.GetAsync(Constants.Security.EditorGroupKey);
var userCreateModel = new UserCreateModel
{
UserName = "test@email.com",
Email = "test@email.com",
Name = "Test User",
UserGroupKeys = new HashSet<Guid> { editorUserGroup.Key },
};
var userService = CreateUserService();
var createAttempt = await userService.CreateAsync(Constants.Security.SuperUserKey, userCreateModel, false);
Assert.IsTrue(createAttempt.Success);
var user = createAttempt.Result.CreatedUser;
Assert.AreEqual(UserState.Disabled, user!.UserState);
var enableStatus = await userService.EnableAsync(Constants.Security.SuperUserKey, new HashSet<Guid> { user.Key });
Assert.AreEqual(UserOperationStatus.Success, enableStatus);
var updatedUser = await userService.GetAsync(user.Key);
// The user has not logged in, so after enabling the user, the user state should be inactive
Assert.AreEqual(UserState.Inactive, updatedUser!.UserState);
}
[Test]
public async Task Can_Disable_User()
{
var editorUserGroup = await UserGroupService.GetAsync(Constants.Security.EditorGroupKey);
var userCreateModel = new UserCreateModel
{
UserName = "test@email.com",
Email = "test@email.com",
Name = "Test User",
UserGroupKeys = new HashSet<Guid> { editorUserGroup.Key },
};
var userService = CreateUserService();
var createAttempt = await userService.CreateAsync(Constants.Security.SuperUserKey, userCreateModel, true);
Assert.IsTrue(createAttempt.Success);
var user = createAttempt.Result.CreatedUser;
Assert.AreEqual(UserState.Inactive, user!.UserState);
var disableStatus = await userService.DisableAsync(Constants.Security.SuperUserKey, new HashSet<Guid> { user.Key });
Assert.AreEqual(UserOperationStatus.Success, disableStatus);
}
[Test]
public async Task User_Cannot_Disable_Self()
{
var adminUserGroup = await UserGroupService.GetAsync(Constants.Security.AdminGroupKey);
var userCreateModel = new UserCreateModel
{
UserName = "test@email.com",
Email = "test@email.com",
Name = "Test User",
UserGroupKeys = new HashSet<Guid> { adminUserGroup.Key },
};
var userService = CreateUserService();
var createAttempt = await userService.CreateAsync(Constants.Security.SuperUserKey, userCreateModel, true);
Assert.IsTrue(createAttempt.Success);
var createdUser = createAttempt.Result.CreatedUser;
var disableStatus = await userService.DisableAsync(createdUser!.Key, new HashSet<Guid>{ createdUser.Key });
Assert.AreEqual(UserOperationStatus.CannotDisableSelf, disableStatus);
}
[Test]
public async Task Cannot_Disable_Invited_User()
{
var editorUserGroup = await UserGroupService.GetAsync(Constants.Security.EditorGroupKey);
var userInviteModel = new UserInviteModel
{
UserName = "test@email.com",
Email = "test@email.com",
Name = "Test User",
UserGroupKeys = new HashSet<Guid> { editorUserGroup.Key },
};
var userService = CreateUserService();
var userInviteAttempt = await userService.InviteAsync(Constants.Security.SuperUserKey, userInviteModel);
Assert.IsTrue(userInviteAttempt.Success);
var invitedUser = userInviteAttempt.Result.InvitedUser;
var disableStatus = await userService.DisableAsync(Constants.Security.SuperUserKey, new HashSet<Guid> { invitedUser!.Key });
Assert.AreEqual(UserOperationStatus.CannotDisableInvitedUser, disableStatus);
}
[Test]
public async Task Enable_Missing_User_Fails_With_Not_Found()
{
var editorUserGroup = await UserGroupService.GetAsync(Constants.Security.EditorGroupKey);
var userCreateModel = new UserCreateModel
{
UserName = "test@email.com",
Email = "test@email.com",
Name = "Test User",
UserGroupKeys = new HashSet<Guid> { editorUserGroup.Key },
};
var userService = CreateUserService();
var createAttempt = await userService.CreateAsync(Constants.Security.SuperUserKey, userCreateModel, false);
Assert.IsTrue(createAttempt.Success);
var user = createAttempt.Result.CreatedUser;
Assert.AreEqual(UserState.Disabled, user!.UserState);
var enableStatus = await userService.EnableAsync(Constants.Security.SuperUserKey, new HashSet<Guid> { user.Key, Guid.NewGuid() });
Assert.AreEqual(UserOperationStatus.UserNotFound, enableStatus);
}
[Test]
public async Task Disable_Missing_User_Fails_With_Not_Found()
{
var editorUserGroup = await UserGroupService.GetAsync(Constants.Security.EditorGroupKey);
var userCreateModel = new UserCreateModel
{
UserName = "test@email.com",
Email = "test@email.com",
Name = "Test User",
UserGroupKeys = new HashSet<Guid> { editorUserGroup.Key },
};
var userService = CreateUserService();
var createAttempt = await userService.CreateAsync(Constants.Security.SuperUserKey, userCreateModel, true);
Assert.IsTrue(createAttempt.Success);
var user = createAttempt.Result.CreatedUser;
var enableStatus = await userService.DisableAsync(Constants.Security.SuperUserKey, new HashSet<Guid> { user.Key, Guid.NewGuid() });
Assert.AreEqual(UserOperationStatus.UserNotFound, enableStatus);
}
}