8e0912cbf1
* Only prevent the unpubkish or delete of a related item when configured to do so if it is related as a child, not as a parent. * Fixed incorect parameter names. * Fixed failing integration tests. * Use using variable instead to reduce nesting * Applied suggestions from code review. * Used simple using statement throughout RelationService for consistency. * Applied XML header comments consistently. --------- Co-authored-by: mole <nikolajlauridsen@protonmail.ch>
89 lines
4.0 KiB
C#
89 lines
4.0 KiB
C#
using Microsoft.Extensions.DependencyInjection;
|
|
using NUnit.Framework;
|
|
using Umbraco.Cms.Core;
|
|
using Umbraco.Cms.Core.Configuration.Models;
|
|
using Umbraco.Cms.Core.Services.OperationStatus;
|
|
using Umbraco.Cms.Tests.Integration.Attributes;
|
|
|
|
namespace Umbraco.Cms.Tests.Integration.Umbraco.Infrastructure.Services;
|
|
|
|
public partial class ContentEditingServiceTests
|
|
{
|
|
public static new void ConfigureDisableUnpublishWhenReferencedTrue(IUmbracoBuilder builder)
|
|
=> builder.Services.Configure<ContentSettings>(config =>
|
|
config.DisableUnpublishWhenReferenced = true);
|
|
|
|
[TestCase(true)]
|
|
[TestCase(false)]
|
|
public async Task Can_Move_To_Recycle_Bin(bool variant)
|
|
{
|
|
var content = await (variant ? CreateVariantContent() : CreateInvariantContent());
|
|
var result = await ContentEditingService.MoveToRecycleBinAsync(content.Key, Constants.Security.SuperUserKey);
|
|
|
|
Assert.IsTrue(result.Success);
|
|
Assert.AreEqual(ContentEditingOperationStatus.Success, result.Status);
|
|
|
|
// re-get and verify move
|
|
content = await ContentEditingService.GetAsync(content.Key);
|
|
Assert.IsNotNull(content);
|
|
Assert.IsTrue(content.Trashed);
|
|
}
|
|
|
|
[Test]
|
|
[ConfigureBuilder(ActionName = nameof(ConfigureDisableUnpublishWhenReferencedTrue))]
|
|
public async Task Cannot_Move_To_Recycle_Bin_When_Content_Is_Related_As_A_Child_And_Configured_To_Disable_When_Related()
|
|
{
|
|
// Setup a relation where the page being deleted is related to another page as a child (e.g. the other page has a picker and has selected this page).
|
|
Relate(Subpage2, Subpage);
|
|
var moveAttempt = await ContentEditingService.MoveToRecycleBinAsync(Subpage.Key, Constants.Security.SuperUserKey);
|
|
Assert.IsFalse(moveAttempt.Success);
|
|
Assert.AreEqual(ContentEditingOperationStatus.CannotMoveToRecycleBinWhenReferenced, moveAttempt.Status);
|
|
|
|
// re-get and verify not moved
|
|
var content = await ContentEditingService.GetAsync(Subpage.Key);
|
|
Assert.IsNotNull(content);
|
|
Assert.IsFalse(content.Trashed);
|
|
}
|
|
|
|
[Test]
|
|
[ConfigureBuilder(ActionName = nameof(ConfigureDisableUnpublishWhenReferencedTrue))]
|
|
public async Task Can_Move_To_Recycle_Bin_When_Content_Is_Related_As_A_Parent_And_Configured_To_Disable_When_Related()
|
|
{
|
|
// Setup a relation where the page being deleted is related to another page as a child (e.g. the other page has a picker and has selected this page).
|
|
Relate(Subpage, Subpage2);
|
|
var moveAttempt = await ContentEditingService.MoveToRecycleBinAsync(Subpage.Key, Constants.Security.SuperUserKey);
|
|
Assert.IsTrue(moveAttempt.Success);
|
|
Assert.AreEqual(ContentEditingOperationStatus.Success, moveAttempt.Status);
|
|
|
|
// re-get and verify moved
|
|
var content = await ContentEditingService.GetAsync(Subpage.Key);
|
|
Assert.IsNotNull(content);
|
|
Assert.IsTrue(content.Trashed);
|
|
}
|
|
|
|
[Test]
|
|
public async Task Cannot_Move_Non_Existing_To_Recycle_Bin()
|
|
{
|
|
var result = await ContentEditingService.MoveToRecycleBinAsync(Guid.NewGuid(), Constants.Security.SuperUserKey);
|
|
Assert.IsFalse(result.Success);
|
|
Assert.AreEqual(ContentEditingOperationStatus.NotFound, result.Status);
|
|
}
|
|
|
|
[TestCase(true)]
|
|
[TestCase(false)]
|
|
public async Task Cannot_Move_To_Recycle_Bin_If_Already_In_Recycle_Bin(bool variant)
|
|
{
|
|
var content = await (variant ? CreateVariantContent() : CreateInvariantContent());
|
|
await ContentEditingService.MoveToRecycleBinAsync(content.Key, Constants.Security.SuperUserKey);
|
|
var result = await ContentEditingService.MoveToRecycleBinAsync(content.Key, Constants.Security.SuperUserKey);
|
|
|
|
Assert.IsFalse(result.Success);
|
|
Assert.AreEqual(ContentEditingOperationStatus.InTrash, result.Status);
|
|
|
|
// re-get and verify that it still is in the recycle bin
|
|
content = await ContentEditingService.GetAsync(content.Key);
|
|
Assert.IsNotNull(content);
|
|
Assert.IsTrue(content.Trashed);
|
|
}
|
|
}
|