* Removed obsoletes from IConfigManipulator. * Removed obsolete models builder extensions. * Removed the obsolete ContentDashboardSettings. * Removed the obsolete InstallMissingDatabase setting on GlobalSettings. * Removed obsolete NuCache settings. * Removed obsolete RuntimeMinificationSettings. * Removed obsolete health check constant. * Removed obsolete icon constant. * Removed obsolete telemetry constant. * Removed obsolete property and constructor on UmbracoBuilder. * Removed obsolete constructor on AuditNotificationsHandler. * Removed obsolete constructor on HTTP header health checks. * Removed obsolete constructor on MediaFileManager. * Removed obsolete GetDefaultFileContent on ViewHelper. * Remove obsoleted methods on embed providers. * Fix tests. * Removed obsolete constructors on BlockEditorDataConverter. * Removed obsolete SeedCacheDuration property on CacheSettings. * Removed obsolete PublishCulture on ContentRepositoryExtensions. * Removed obsolete MonitorLock. * Removed obsolete synchronous HasSavedValues from IDataTypeUsageService and IDataTypeUsageRepository. * Removed obsolete HasSavedPropertyValues from IPropertyTypeUsageService and IPropertyTypeUsageRepository. * Removed obsolete methods in ITrackedReferencesService and ITrackedReferencesRepository. * Removed obsolete DateValueEditor constructors. * Removed obsolete GetAutomaticRelationTypesAliases. * Removed obsolete constructor on TextOnlyValueEditor. * Removed obsolete constructors on RegexValidator and RequiredValidator. * Removed obsolete constructs on SliderValueConverter and TagsValueConverter. * Removed obsolete GetContentType methods from IPublishedCache. * Removed ContentFinderByIdPath. * Removed obsolete constructor on DefaultMediaUrlProvider. * Removed obsolete constructor on Domain. * Removed obsolete constructor on PublishedRequest. * Removed obsolete methods on CheckPermissions. * Removed obsolete GetUserId from IBackOfficeSecurity. * Removed obsolete methods on LegacyPasswordSecurity. * Removed obsolete constructors on AuditService. * Removed obsolete methods on IContentEditingService. * Remove obsolete constructors and methods on ContentService/IContentService. * Removed obsolete constructor in ContentTypeEditingService. * Removed obsolete constructor in MediaTypeEditingService. * Removed obsolete constructor in MemberTypeEditingService. * Removed obsolete constructor in ContentTypeService. * Removed obsolete constructors in ContentTypeServiceBase. * Removed obsolete constructors and methods in ContentVersionService. * Removed obsolete constructor in DataTypeUsageService. * Removed obsolete constructor in DomainService. * Removed obsolete constructor in FileService. * Removes obsolete AttemptMove from IContentService. * Removes obsolete SetPreventCleanup from IContentVersionService. * Removes obsolete GetReferences from IDataTypeService. * Removed obsolete SetConsentLevel from IMetricsConsentService. * Removed obsolete methods from IPackageDataInstallation. * Removed obsolete methods from IPackagingService. * Removed obsolete methods on ITwoFactorLoginService. Removed obsolete ITemporaryMediaService. * Removed obsolete constructor from MediaService, MemberTypeService and MediaTypeService. * More obsolete constructors. * Removed obsoleted overloads on IPropertyValidationService. * Fixed build for tests. * Removed obsolete constructor for PublicAccessService, UserService and RelationService. * Removed GetDefaultMemberType. * Removed obsolete user group functionality from IUserService. * Removed obsolete extension methods on IUserService. * Removed obsolete method from ITelemetryService. * Removed obsolete UdiParserServiceConnectors. * Removed obsolete method on ICookieManager. * Removed obsolete DynamicContext. * Removed obsolete XmlHelper. * Fixed failing integration tests. * Removed obsoletes in Umbraco.Cms.Api.Common * Removed obsoletes in Umbraco.Cms.Api.Delivery * Removed obsoletes in Umbraco.Cms.Api.Management * Removed obsoletes in Umbraco.Examine.Lucene * Removed obsoletes in Umbraco.Infrastructure * Fix failing delivery API contract integration test. * Made integration tests internal. * Removed obsoletes from web projects. * Fix build. * Removed Twitter OEmbed provider * Removed obsolete constructor on PublishedDataType. * Removed obsolete constructors on PublishedCacheBase. * Removed the obsolete PropertyEditorTagsExtensions. * Removed obsoletion properties on configuration response models (#18697) * Removed obsolete methods from server-side models. * Update client-side types and sdk. * Update client-side files. * Removed obsoletion of Utf8ToAsciiConverter.ToAsciiString overload. (#18694) * Removed obsolete method in UserService. (#18710) * Removed obsoleted group alias keys from being publicly available. (#18682) * Removed unneceessary ApiVersion attribute. * Clean-up obsoletions on MemberService (#18703) * Removed obsoleted method on MemberService, added future obsoletion to interface and updated all callers. * Removed obsoletion on member service method that's not obsolete on the interface.
330 lines
12 KiB
C#
330 lines
12 KiB
C#
// Copyright (c) Umbraco.
|
|
// See LICENSE for more details.
|
|
|
|
using System.Linq;
|
|
using Microsoft.Extensions.DependencyInjection;
|
|
using Microsoft.Extensions.Logging;
|
|
using Moq;
|
|
using NUnit.Framework;
|
|
using Umbraco.Cms.Core.Cache;
|
|
using Umbraco.Cms.Core.Configuration;
|
|
using Umbraco.Cms.Core.Events;
|
|
using Umbraco.Cms.Core.Migrations;
|
|
using Umbraco.Cms.Core.PublishedCache;
|
|
using Umbraco.Cms.Core.Scoping;
|
|
using Umbraco.Cms.Core.Services;
|
|
using Umbraco.Cms.Infrastructure.Migrations;
|
|
using Umbraco.Cms.Infrastructure.Migrations.Install;
|
|
using Umbraco.Cms.Infrastructure.Migrations.Upgrade;
|
|
using Umbraco.Cms.Infrastructure.Persistence;
|
|
using Umbraco.Cms.Infrastructure.Persistence.Dtos;
|
|
using Umbraco.Cms.Infrastructure.Scoping;
|
|
using Umbraco.Cms.Tests.Common.Testing;
|
|
using Umbraco.Cms.Tests.Integration.Testing;
|
|
|
|
namespace Umbraco.Cms.Tests.Integration.Umbraco.Infrastructure.Migrations;
|
|
|
|
[TestFixture]
|
|
[UmbracoTest(Database = UmbracoTestOptions.Database.NewEmptyPerTest)]
|
|
internal sealed class AdvancedMigrationTests : UmbracoIntegrationTest
|
|
{
|
|
private IUmbracoVersion UmbracoVersion => GetRequiredService<IUmbracoVersion>();
|
|
private IEventAggregator EventAggregator => GetRequiredService<IEventAggregator>();
|
|
private ICoreScopeProvider CoreScopeProvider => GetRequiredService<ICoreScopeProvider>();
|
|
private IScopeAccessor ScopeAccessor => GetRequiredService<IScopeAccessor>();
|
|
private ILoggerFactory LoggerFactory => GetRequiredService<ILoggerFactory>();
|
|
private IMigrationBuilder MigrationBuilder => GetRequiredService<IMigrationBuilder>();
|
|
private IUmbracoDatabaseFactory UmbracoDatabaseFactory => GetRequiredService<IUmbracoDatabaseFactory>();
|
|
private IServiceScopeFactory ServiceScopeFactory => GetRequiredService<IServiceScopeFactory>();
|
|
private DistributedCache DistributedCache => GetRequiredService<DistributedCache>();
|
|
private IDatabaseCacheRebuilder DatabaseCacheRebuilder => GetRequiredService<IDatabaseCacheRebuilder>();
|
|
private IMigrationPlanExecutor MigrationPlanExecutor => new MigrationPlanExecutor(
|
|
CoreScopeProvider,
|
|
ScopeAccessor,
|
|
LoggerFactory,
|
|
MigrationBuilder,
|
|
UmbracoDatabaseFactory,
|
|
DatabaseCacheRebuilder,
|
|
DistributedCache,
|
|
Mock.Of<IKeyValueService>(),
|
|
ServiceScopeFactory,
|
|
AppCaches.NoCache);
|
|
|
|
[Test]
|
|
public async Task CreateTableOfTDtoAsync()
|
|
{
|
|
var builder = Mock.Of<IMigrationBuilder>();
|
|
Mock.Get(builder)
|
|
.Setup(x => x.Build(It.IsAny<Type>(), It.IsAny<IMigrationContext>()))
|
|
.Returns<Type, IMigrationContext>((t, c) =>
|
|
{
|
|
if (t != typeof(CreateTableOfTDtoMigration))
|
|
{
|
|
throw new NotSupportedException();
|
|
}
|
|
|
|
return new CreateTableOfTDtoMigration(c);
|
|
});
|
|
|
|
using (ScopeProvider.CreateScope(autoComplete: true))
|
|
{
|
|
var upgrader = new Upgrader(
|
|
new MigrationPlan("test")
|
|
.From(string.Empty)
|
|
.To<CreateTableOfTDtoMigration>("done"));
|
|
|
|
await upgrader.ExecuteAsync(MigrationPlanExecutor, ScopeProvider, Mock.Of<IKeyValueService>()).ConfigureAwait(false);
|
|
|
|
var db = ScopeAccessor.AmbientScope.Database;
|
|
var exists = ScopeAccessor.AmbientScope.SqlContext.SqlSyntax.DoesTableExist(db, "umbracoUser");
|
|
|
|
Assert.IsTrue(exists);
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public async Task DeleteKeysAndIndexesOfTDtoAsync()
|
|
{
|
|
var builder = Mock.Of<IMigrationBuilder>();
|
|
Mock.Get(builder)
|
|
.Setup(x => x.Build(It.IsAny<Type>(), It.IsAny<IMigrationContext>()))
|
|
.Returns<Type, IMigrationContext>((t, c) =>
|
|
{
|
|
switch (t.Name)
|
|
{
|
|
case "CreateTableOfTDtoMigration":
|
|
return new CreateTableOfTDtoMigration(c);
|
|
case "DeleteKeysAndIndexesMigration":
|
|
return new DeleteKeysAndIndexesMigration(c);
|
|
default:
|
|
throw new NotSupportedException();
|
|
}
|
|
});
|
|
|
|
using (var scope = ScopeProvider.CreateScope())
|
|
{
|
|
var upgrader = new Upgrader(
|
|
new MigrationPlan("test")
|
|
.From(string.Empty)
|
|
.To<CreateTableOfTDtoMigration>("a")
|
|
.To<DeleteKeysAndIndexesMigration>("done"));
|
|
|
|
await upgrader.ExecuteAsync(MigrationPlanExecutor, ScopeProvider, Mock.Of<IKeyValueService>()).ConfigureAwait(false);
|
|
scope.Complete();
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public async Task CreateKeysAndIndexesOfTDtoAsync()
|
|
{
|
|
if (BaseTestDatabase.IsSqlite())
|
|
{
|
|
// TODO: Think about this for future migrations.
|
|
Assert.Ignore("Can't add / drop keys in SQLite.");
|
|
return;
|
|
}
|
|
|
|
var builder = Mock.Of<IMigrationBuilder>();
|
|
Mock.Get(builder)
|
|
.Setup(x => x.Build(It.IsAny<Type>(), It.IsAny<IMigrationContext>()))
|
|
.Returns<Type, IMigrationContext>((t, c) =>
|
|
{
|
|
switch (t.Name)
|
|
{
|
|
case "CreateTableOfTDtoMigration":
|
|
return new CreateTableOfTDtoMigration(c);
|
|
case "DeleteKeysAndIndexesMigration":
|
|
return new DeleteKeysAndIndexesMigration(c);
|
|
case "CreateKeysAndIndexesOfTDtoMigration":
|
|
return new CreateKeysAndIndexesOfTDtoMigration(c);
|
|
default:
|
|
throw new NotSupportedException();
|
|
}
|
|
});
|
|
|
|
using (var scope = ScopeProvider.CreateScope())
|
|
{
|
|
var upgrader = new Upgrader(
|
|
new MigrationPlan("test")
|
|
.From(string.Empty)
|
|
.To<CreateTableOfTDtoMigration>("a")
|
|
.To<DeleteKeysAndIndexesMigration>("b")
|
|
.To<CreateKeysAndIndexesOfTDtoMigration>("done"));
|
|
|
|
await upgrader.ExecuteAsync(MigrationPlanExecutor, ScopeProvider, Mock.Of<IKeyValueService>()).ConfigureAwait(false);
|
|
scope.Complete();
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public async Task CreateKeysAndIndexesAsync()
|
|
{
|
|
if (BaseTestDatabase.IsSqlite())
|
|
{
|
|
// TODO: Think about this for future migrations.
|
|
Assert.Ignore("Can't add / drop keys in SQLite.");
|
|
return;
|
|
}
|
|
|
|
var builder = Mock.Of<IMigrationBuilder>();
|
|
Mock.Get(builder)
|
|
.Setup(x => x.Build(It.IsAny<Type>(), It.IsAny<IMigrationContext>()))
|
|
.Returns<Type, IMigrationContext>((t, c) =>
|
|
{
|
|
switch (t.Name)
|
|
{
|
|
case "CreateTableOfTDtoMigration":
|
|
return new CreateTableOfTDtoMigration(c);
|
|
case "DeleteKeysAndIndexesMigration":
|
|
return new DeleteKeysAndIndexesMigration(c);
|
|
case "CreateKeysAndIndexesMigration":
|
|
return new CreateKeysAndIndexesMigration(c);
|
|
default:
|
|
throw new NotSupportedException();
|
|
}
|
|
});
|
|
|
|
using (var scope = ScopeProvider.CreateScope())
|
|
{
|
|
var upgrader = new Upgrader(
|
|
new MigrationPlan("test")
|
|
.From(string.Empty)
|
|
.To<CreateTableOfTDtoMigration>("a")
|
|
.To<DeleteKeysAndIndexesMigration>("b")
|
|
.To<CreateKeysAndIndexesMigration>("done"));
|
|
|
|
await upgrader.ExecuteAsync(MigrationPlanExecutor, ScopeProvider, Mock.Of<IKeyValueService>()).ConfigureAwait(false);
|
|
scope.Complete();
|
|
}
|
|
}
|
|
|
|
[Test]
|
|
public async Task AddColumnAsync()
|
|
{
|
|
var builder = Mock.Of<IMigrationBuilder>();
|
|
Mock.Get(builder)
|
|
.Setup(x => x.Build(It.IsAny<Type>(), It.IsAny<IMigrationContext>()))
|
|
.Returns<Type, IMigrationContext>((t, c) =>
|
|
{
|
|
switch (t.Name)
|
|
{
|
|
case "CreateTableOfTDtoMigration":
|
|
return new CreateTableOfTDtoMigration(c);
|
|
case "CreateColumnMigration":
|
|
return new AddColumnMigration(c);
|
|
default:
|
|
throw new NotSupportedException();
|
|
}
|
|
});
|
|
|
|
using (ScopeProvider.CreateScope(autoComplete: true))
|
|
{
|
|
var upgrader = new Upgrader(
|
|
new MigrationPlan("test")
|
|
.From(string.Empty)
|
|
.To<CreateTableOfTDtoMigration>("a")
|
|
.To<AddColumnMigration>("done"));
|
|
|
|
await upgrader.ExecuteAsync(MigrationPlanExecutor, ScopeProvider, Mock.Of<IKeyValueService>()).ConfigureAwait(false);
|
|
|
|
var db = ScopeAccessor.AmbientScope.Database;
|
|
|
|
var columnInfo = ScopeAccessor.AmbientScope.SqlContext.SqlSyntax.GetColumnsInSchema(db)
|
|
.Where(x => x.TableName == "umbracoUser")
|
|
.FirstOrDefault(x => x.ColumnName == "Foo");
|
|
|
|
Assert.Multiple(() =>
|
|
{
|
|
Assert.NotNull(columnInfo);
|
|
Assert.IsTrue(columnInfo.DataType.Contains("nvarchar"));
|
|
});
|
|
}
|
|
}
|
|
|
|
public class CreateTableOfTDtoMigration : MigrationBase
|
|
{
|
|
public CreateTableOfTDtoMigration(IMigrationContext context)
|
|
: base(context)
|
|
{
|
|
}
|
|
|
|
protected override void Migrate() =>
|
|
|
|
// Create User table with keys, indexes, etc.
|
|
Create.Table<UserDto>().Do();
|
|
}
|
|
|
|
public class DeleteKeysAndIndexesMigration : MigrationBase
|
|
{
|
|
public DeleteKeysAndIndexesMigration(IMigrationContext context)
|
|
: base(context)
|
|
{
|
|
}
|
|
|
|
protected override void Migrate()
|
|
{
|
|
// drops User table keys and indexes
|
|
// Execute.DropKeysAndIndexes("umbracoUser");
|
|
|
|
// drops *all* tables keys and indexes
|
|
var tables = SqlSyntax.GetTablesInSchema(Context.Database).ToList();
|
|
foreach (var table in tables)
|
|
{
|
|
Delete.KeysAndIndexes(table, false).Do();
|
|
}
|
|
|
|
foreach (var table in tables)
|
|
{
|
|
Delete.KeysAndIndexes(table, true, false).Do();
|
|
}
|
|
}
|
|
}
|
|
|
|
public class CreateKeysAndIndexesOfTDtoMigration : MigrationBase
|
|
{
|
|
public CreateKeysAndIndexesOfTDtoMigration(IMigrationContext context)
|
|
: base(context)
|
|
{
|
|
}
|
|
|
|
protected override void Migrate() =>
|
|
|
|
// Create User table keys and indexes.
|
|
Create.KeysAndIndexes<UserDto>().Do();
|
|
}
|
|
|
|
public class CreateKeysAndIndexesMigration : MigrationBase
|
|
{
|
|
public CreateKeysAndIndexesMigration(IMigrationContext context)
|
|
: base(context)
|
|
{
|
|
}
|
|
|
|
protected override void Migrate()
|
|
{
|
|
// Creates *all* tables keys and indexes
|
|
foreach (var x in DatabaseSchemaCreator._orderedTables)
|
|
{
|
|
// ok - for tests, restrict to Node
|
|
if (x != typeof(UserDto))
|
|
{
|
|
continue;
|
|
}
|
|
|
|
Create.KeysAndIndexes(x).Do();
|
|
}
|
|
}
|
|
}
|
|
|
|
public class AddColumnMigration : MigrationBase
|
|
{
|
|
public AddColumnMigration(IMigrationContext context)
|
|
: base(context)
|
|
{
|
|
}
|
|
|
|
protected override void Migrate() =>
|
|
Database.Execute($"ALTER TABLE {SqlSyntax.GetQuotedTableName("umbracoUser")} ADD Foo nvarchar(255)");
|
|
}
|
|
}
|