Files
Umbraco-CMS/tests/Umbraco.Tests.UnitTests/Umbraco.Core/Telemetry/TelemetryServiceTests.cs
Ronald Barendse 41e51d6e71 Add PackageId to package manifest and PackageMigrationPlan (#14047)
* Add VersionAssemblyName to package manifest

* Fix/improve nullability

* Ensure package version from manifest is set when package migration exists

* Set versionAssemblyName in umbracopackage template

* Use Assembly.Load instead of ITypeFinder

* Use AssemblyLoadContext to get asesmbly by name

* Add PackageId to package manifest

* Show ID on installed packages overview

* Fallback to package ID to get assembly version

* Include package ID in telemetry data

* Set id in umbracopackage template

* Add PackageId to PackageMigrationPlan

* Get version from package migration assembly

* Hide unknown package version

* Always use package name from manifest

* Use IPackagingService to return package telemety data

* Set versionAssemblyName in umbracopackage-rcl template

* Set id in umbracopackage-rcl template
2023-05-31 11:31:37 +02:00

161 lines
6.1 KiB
C#

using Moq;
using NUnit.Framework;
using Umbraco.Cms.Core.Configuration;
using Umbraco.Cms.Core.Models;
using Umbraco.Cms.Core.Packaging;
using Umbraco.Cms.Core.Semver;
using Umbraco.Cms.Core.Services;
using Umbraco.Cms.Core.Telemetry;
namespace Umbraco.Cms.Tests.UnitTests.Umbraco.Core.Telemetry;
[TestFixture]
public class TelemetryServiceTests
{
[Test]
public void UsesGetOrCreateSiteId()
{
var version = CreateUmbracoVersion(9, 3, 1);
var siteIdentifierServiceMock = new Mock<ISiteIdentifierService>();
var usageInformationServiceMock = new Mock<IUsageInformationService>();
var sut = new TelemetryService(
Mock.Of<IPackagingService>(),
version,
siteIdentifierServiceMock.Object,
usageInformationServiceMock.Object,
Mock.Of<IMetricsConsentService>());
Guid guid;
sut.TryGetTelemetryReportData(out _);
siteIdentifierServiceMock.Verify(x => x.TryGetOrCreateSiteIdentifier(out guid), Times.Once);
}
[Test]
public void SkipsIfCantGetOrCreateId()
{
var version = CreateUmbracoVersion(9, 3, 1);
var sut = new TelemetryService(
Mock.Of<IPackagingService>(),
version,
CreateSiteIdentifierService(false),
Mock.Of<IUsageInformationService>(),
Mock.Of<IMetricsConsentService>());
var result = sut.TryGetTelemetryReportData(out var telemetry);
Assert.IsFalse(result);
Assert.IsNull(telemetry);
}
[Test]
public void ReturnsSemanticVersionWithoutBuild()
{
var version = CreateUmbracoVersion(9, 1, 1, "-rc", "-ad2f4k2d");
var metricsConsentService = new Mock<IMetricsConsentService>();
metricsConsentService.Setup(x => x.GetConsentLevel()).Returns(TelemetryLevel.Detailed);
var sut = new TelemetryService(
Mock.Of<IPackagingService>(),
version,
CreateSiteIdentifierService(),
Mock.Of<IUsageInformationService>(),
metricsConsentService.Object);
var result = sut.TryGetTelemetryReportData(out var telemetry);
Assert.IsTrue(result);
Assert.AreEqual("9.1.1-rc", telemetry.Version);
}
[Test]
public void CanGatherPackageTelemetry()
{
var version = CreateUmbracoVersion(9, 1, 1);
var versionPackageId = "VersionPackageId";
var versionPackageName = "VersionPackageName";
var packageVersion = "1.0.0";
var noVersionPackageName = "NoVersionPackageName";
InstalledPackage[] installedPackages =
{
new() { PackageId = versionPackageId, PackageName = versionPackageName, Version = packageVersion },
new() { PackageName = noVersionPackageName },
};
var packagingService = CreatePackagingService(installedPackages);
var metricsConsentService = new Mock<IMetricsConsentService>();
metricsConsentService.Setup(x => x.GetConsentLevel()).Returns(TelemetryLevel.Detailed);
var sut = new TelemetryService(
packagingService,
version,
CreateSiteIdentifierService(),
Mock.Of<IUsageInformationService>(),
metricsConsentService.Object);
var success = sut.TryGetTelemetryReportData(out var telemetry);
Assert.IsTrue(success);
Assert.Multiple(() =>
{
Assert.AreEqual(2, telemetry.Packages.Count());
var versionPackage = telemetry.Packages.FirstOrDefault(x => x.Name == versionPackageName);
Assert.AreEqual(versionPackageId, versionPackage.Id);
Assert.AreEqual(versionPackageName, versionPackage.Name);
Assert.AreEqual(packageVersion, versionPackage.Version);
var noVersionPackage = telemetry.Packages.FirstOrDefault(x => x.Name == noVersionPackageName);
Assert.AreEqual(null, noVersionPackage.Id);
Assert.AreEqual(noVersionPackageName, noVersionPackage.Name);
Assert.AreEqual(null, noVersionPackage.Version);
});
}
[Test]
public void RespectsAllowPackageTelemetry()
{
var version = CreateUmbracoVersion(9, 1, 1);
InstalledPackage[] installedPackages =
{
new() { PackageName = "DoNotTrack", AllowPackageTelemetry = false },
new() { PackageName = "TrackingAllowed", AllowPackageTelemetry = true },
};
var packagingService = CreatePackagingService(installedPackages);
var metricsConsentService = new Mock<IMetricsConsentService>();
metricsConsentService.Setup(x => x.GetConsentLevel()).Returns(TelemetryLevel.Detailed);
var sut = new TelemetryService(
packagingService,
version,
CreateSiteIdentifierService(),
Mock.Of<IUsageInformationService>(),
metricsConsentService.Object);
var success = sut.TryGetTelemetryReportData(out var telemetry);
Assert.IsTrue(success);
Assert.Multiple(() =>
{
Assert.AreEqual(1, telemetry.Packages.Count());
Assert.AreEqual("TrackingAllowed", telemetry.Packages.First().Name);
});
}
private IPackagingService CreatePackagingService(IEnumerable<InstalledPackage> installedPackages)
{
var packagingServiceMock = new Mock<IPackagingService>();
packagingServiceMock.Setup(x => x.GetAllInstalledPackages()).Returns(installedPackages);
return packagingServiceMock.Object;
}
private IUmbracoVersion CreateUmbracoVersion(int major, int minor, int patch, string prerelease = "", string build = "")
{
var version = new SemVersion(major, minor, patch, prerelease, build);
return Mock.Of<IUmbracoVersion>(x => x.SemanticVersion == version);
}
private ISiteIdentifierService CreateSiteIdentifierService(bool shouldSucceed = true)
{
var mock = new Mock<ISiteIdentifierService>();
var siteIdentifier = shouldSucceed ? Guid.NewGuid() : Guid.Empty;
mock.Setup(x => x.TryGetOrCreateSiteIdentifier(out siteIdentifier)).Returns(shouldSucceed);
return mock.Object;
}
}