* Remove nucache reference from Web.Common * Get tests building-ish * Move ReservedFieldNamesService to the right project * Remove IPublishedSnapshotStatus * Added functionality to the INavigationQueryService to get root keys * Fixed issue with navigation * Remove IPublishedSnapshot from UmbracoContext * Begin removing usage of IPublishedSnapshot from PublishedContentExtensions * Fix PublishedContentExtensions.cs * Don't use snapshots in delivery media api * Use IPublishedMediaCache in QueryMediaApiController * Remove more usages of IPublishedSnapshotAccessor * Comment out tests * Remove more usages of PublishedSnapshotAccessor * Remove PublishedSnapshot from property * Fixed test build * Fix errors * Fix some tests * Delete NuCache 🎉 * Implement DatabaseCacheRebuilder * Remove usage of IPublishedSnapshotService * Remove IPublishedSnapshotService * Remove TestPublishedSnapshotAccessor and make tests build * Don't test Snapshot cachelevel It's no longer supported * Fix BlockEditorConverter Element != Element document type * Remember to set cachemanager * Fix RichTextParserTests * Implement TryGetLevel on INavigationQueryService * Fake level and obsolete it in PublishedContent * Remove ChildrenForAllCultures * Hack Path property on PublishedContent * Remove usages of IPublishedSnapshot in tests * More ConvertersTests * Add hybrid cache to integration tests We can actually do this now because we no longer save files on disk * Rename IPublishedSnapshotRebuilder to ICacheRebuilder * Comment out tests * V15: Replacing the usages of Parent (navigation data) from IPublishedContent (#17125) * Fix .Parent references in PublishedContentExtensions * Add missing methods to FriendlyPublishedContentExtensions (ones that you were able to call on the content directly as they now require extra params) * Fix references from the extension methods * Fix dependencies in tests * Replace IPublishedSnapshotAccessor with the content cache in tests * Resolving more .Parent references * Fix unit tests * Obsolete and use extension methods * Remove private method and use extension instead * Moving code around * Fix tests * Fix more references * Cleanup * Fix more usages * Resolve merge conflict * Fix tests * Cleanup * Fix more tests * Fixed unit tests * Cleanup * Replace last usages --------- Co-authored-by: Bjarke Berg <mail@bergmania.dk> * Remove usage of IPublishedSnapshotAccessor from IRequestItemProvider * Post merge fixup * Remo IPublishedSnapshot * Add HasAny to IDocumentUrlService * Fix TextBuilder * Fix modelsbuilder tests * Use explicit types * Implement GetByContentType * Support element types in PublishedContentTypeCache * Run enlistments before publishing notifications * Fix elements cache refreshing * Implement GetByUdi * Implement GetAtRoot * Implement GetByRoute * Reimplement GetRouteById * Fix blocks unit tests * Initialize domain cache on boot * Only return routes with domains on non default lanauges * V15: Replacing the usages of `Children` (navigation data) from `IPublishedContent` (#17159) * Update params in PublishedContentExtensions to the general interfaces for the published cache and navigation service, so that we can use the extension methods on both documents and media * Introduce GetParent() which uses the right services * Fix obsolete message on .Parent * Obsolete .Children * Fix usages of Children for ApiMediaQueryService * Fix usage in internal * Fix usages in views * Fix indentation * Fix issue with delete language * Update nuget pacakges * Clear elements cache when content is deleted instead of trying to update it * Reset publishedModelFactory * Fixed publishing --------- Co-authored-by: Bjarke Berg <mail@bergmania.dk> Co-authored-by: Elitsa Marinovska <21998037+elit0451@users.noreply.github.com> Co-authored-by: kjac <kja@umbraco.dk>
260 lines
10 KiB
C#
260 lines
10 KiB
C#
using System.Collections.Generic;
|
|
using System.Data;
|
|
using System.Linq;
|
|
using System.Threading;
|
|
using System.Threading.Tasks;
|
|
using Microsoft.AspNetCore.Identity;
|
|
using Microsoft.Extensions.Logging.Abstractions;
|
|
using Moq;
|
|
using NUnit.Framework;
|
|
using Umbraco.Cms.Core;
|
|
using Umbraco.Cms.Core.Events;
|
|
using Umbraco.Cms.Core.Mapping;
|
|
using Umbraco.Cms.Core.Models;
|
|
using Umbraco.Cms.Core.PublishedCache;
|
|
using Umbraco.Cms.Core.Scoping;
|
|
using Umbraco.Cms.Core.Security;
|
|
using Umbraco.Cms.Core.Services;
|
|
using Umbraco.Cms.Tests.UnitTests.TestHelpers;
|
|
using Umbraco.Cms.Tests.UnitTests.Umbraco.Core.ShortStringHelper;
|
|
using IScopeProvider = Umbraco.Cms.Infrastructure.Scoping.IScopeProvider;
|
|
|
|
namespace Umbraco.Cms.Tests.UnitTests.Umbraco.Infrastructure.Security;
|
|
|
|
[TestFixture]
|
|
public class MemberUserStoreTests
|
|
{
|
|
private Mock<IMemberService> _mockMemberService;
|
|
|
|
public MemberUserStore CreateSut()
|
|
{
|
|
_mockMemberService = new Mock<IMemberService>();
|
|
var mockScopeProvider = TestHelper.ScopeProvider;
|
|
|
|
return new MemberUserStore(
|
|
_mockMemberService.Object,
|
|
new UmbracoMapper(new MapDefinitionCollection(() => new List<IMapDefinition>()), mockScopeProvider, NullLogger<UmbracoMapper>.Instance),
|
|
mockScopeProvider,
|
|
new IdentityErrorDescriber(),
|
|
Mock.Of<IExternalLoginWithKeyService>(),
|
|
Mock.Of<ITwoFactorLoginService>(),
|
|
Mock.Of<IPublishedMemberCache>());
|
|
}
|
|
|
|
[Test]
|
|
public async Task GivenISetNormalizedUserName_ThenIShouldGetASuccessResult()
|
|
{
|
|
// arrange
|
|
var sut = CreateSut();
|
|
var fakeUser = new MemberIdentityUser { UserName = "MyName" };
|
|
|
|
// act
|
|
await sut.SetNormalizedUserNameAsync(fakeUser, "NewName", CancellationToken.None);
|
|
|
|
// assert
|
|
Assert.AreEqual("NewName", fakeUser.UserName);
|
|
Assert.AreEqual("NewName", await sut.GetNormalizedUserNameAsync(fakeUser, CancellationToken.None));
|
|
}
|
|
|
|
[Test]
|
|
public async Task GivenICreateUser_AndTheUserIsNull_ThenIShouldGetAFailedResultAsync()
|
|
{
|
|
// arrange
|
|
var sut = CreateSut();
|
|
|
|
// act
|
|
var actual = await sut.CreateAsync(null);
|
|
|
|
// assert
|
|
Assert.IsFalse(actual.Succeeded);
|
|
Assert.IsTrue(actual.Errors.Any(x =>
|
|
x.Code == "IdentityErrorUserStore" && x.Description == "Value cannot be null. (Parameter 'user')"));
|
|
_mockMemberService.VerifyNoOtherCalls();
|
|
}
|
|
|
|
[Test]
|
|
public async Task GivenICreateUser_AndTheUserDoesNotHaveIdentity_ThenIShouldGetAFailedResultAsync()
|
|
{
|
|
// arrange
|
|
var sut = CreateSut();
|
|
var fakeUser = new MemberIdentityUser();
|
|
|
|
IMemberType fakeMemberType = new MemberType(new MockShortStringHelper(), 77);
|
|
var mockMember = Mock.Of<IMember>(m =>
|
|
m.Name == "fakeName" &&
|
|
m.Email == "fakeemail@umbraco.com" &&
|
|
m.Username == "fakeUsername" &&
|
|
m.RawPasswordValue == "fakePassword" &&
|
|
m.ContentTypeAlias == fakeMemberType.Alias &&
|
|
m.HasIdentity == false);
|
|
|
|
_mockMemberService
|
|
.Setup(x => x.CreateMember(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>()))
|
|
.Returns(mockMember);
|
|
_mockMemberService.Setup(x => x.Save(mockMember, Constants.Security.SuperUserId));
|
|
|
|
// act
|
|
var actual = await sut.CreateAsync(null);
|
|
|
|
// assert
|
|
Assert.IsFalse(actual.Succeeded);
|
|
Assert.IsTrue(actual.Errors.Any(x =>
|
|
x.Code == "IdentityErrorUserStore" && x.Description == "Value cannot be null. (Parameter 'user')"));
|
|
_mockMemberService.VerifyNoOtherCalls();
|
|
}
|
|
|
|
[Test]
|
|
public async Task GivenICreateANewUser_AndTheUserIsPopulatedCorrectly_ThenIShouldGetASuccessResultAsync()
|
|
{
|
|
// arrange
|
|
var sut = CreateSut();
|
|
var fakeUser = new MemberIdentityUser();
|
|
|
|
IMemberType fakeMemberType = new MemberType(new MockShortStringHelper(), 77);
|
|
var mockMember = Mock.Of<IMember>(m =>
|
|
m.Name == "fakeName" &&
|
|
m.Email == "fakeemail@umbraco.com" &&
|
|
m.Username == "fakeUsername" &&
|
|
m.RawPasswordValue == "fakePassword" &&
|
|
m.Comments == "hello" &&
|
|
m.ContentTypeAlias == fakeMemberType.Alias &&
|
|
m.HasIdentity == true);
|
|
|
|
_mockMemberService
|
|
.Setup(x => x.CreateMember(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>()))
|
|
.Returns(mockMember);
|
|
_mockMemberService
|
|
.Setup(x => x.Save(mockMember, Constants.Security.SuperUserId))
|
|
.Returns(Attempt.Succeed<OperationResult?>(null));
|
|
// act
|
|
var identityResult = await sut.CreateAsync(fakeUser, CancellationToken.None);
|
|
|
|
// assert
|
|
Assert.IsTrue(identityResult.Succeeded);
|
|
Assert.IsTrue(!identityResult.Errors.Any());
|
|
_mockMemberService.Verify(x =>
|
|
x.CreateMember(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>()));
|
|
_mockMemberService.Verify(x => x.Save(mockMember, Constants.Security.SuperUserId));
|
|
}
|
|
|
|
[Test]
|
|
public async Task GivenIUpdateAUser_ThenIShouldGetASuccessResultAsync()
|
|
{
|
|
// arrange
|
|
var sut = CreateSut();
|
|
var fakeUser = new MemberIdentityUser
|
|
{
|
|
Id = "123",
|
|
Name = "fakeName",
|
|
Email = "fakeemail@umbraco.com",
|
|
UserName = "fakeUsername",
|
|
Comments = "hello",
|
|
LastLoginDateUtc = DateTime.UtcNow,
|
|
LastPasswordChangeDateUtc = DateTime.UtcNow,
|
|
EmailConfirmed = true,
|
|
AccessFailedCount = 3,
|
|
LockoutEnd = DateTime.UtcNow.AddDays(10),
|
|
IsApproved = true,
|
|
PasswordHash = "abcde",
|
|
SecurityStamp = "abc",
|
|
};
|
|
fakeUser.Roles.Add(new IdentityUserRole<string> { RoleId = "role1", UserId = "123" });
|
|
fakeUser.Roles.Add(new IdentityUserRole<string> { RoleId = "role2", UserId = "123" });
|
|
|
|
IMemberType fakeMemberType = new MemberType(new MockShortStringHelper(), 77);
|
|
var mockMember = Mock.Of<IMember>(m =>
|
|
m.Id == 123 &&
|
|
m.Name == "a" &&
|
|
m.Email == "a@b.com" &&
|
|
m.Username == "c" &&
|
|
m.RawPasswordValue == "d" &&
|
|
m.Comments == "e" &&
|
|
m.ContentTypeAlias == fakeMemberType.Alias &&
|
|
m.HasIdentity == true &&
|
|
m.EmailConfirmedDate == DateTime.MinValue &&
|
|
m.FailedPasswordAttempts == 0 &&
|
|
m.LastLockoutDate == DateTime.MinValue &&
|
|
m.IsApproved == false &&
|
|
m.RawPasswordValue == "xyz" &&
|
|
m.SecurityStamp == "xyz");
|
|
|
|
_mockMemberService.Setup(x => x.Save(mockMember, Constants.Security.SuperUserId));
|
|
_mockMemberService.Setup(x => x.GetById(123)).Returns(mockMember);
|
|
|
|
// act
|
|
var identityResult = await sut.UpdateAsync(fakeUser, CancellationToken.None);
|
|
|
|
// assert
|
|
Assert.IsTrue(identityResult.Succeeded);
|
|
Assert.IsTrue(!identityResult.Errors.Any());
|
|
|
|
Assert.AreEqual(fakeUser.Name, mockMember.Name);
|
|
Assert.AreEqual(fakeUser.Email, mockMember.Email);
|
|
Assert.AreEqual(fakeUser.UserName, mockMember.Username);
|
|
Assert.AreEqual(fakeUser.Comments, mockMember.Comments);
|
|
Assert.AreEqual(fakeUser.LastPasswordChangeDateUtc.Value.ToLocalTime(), mockMember.LastPasswordChangeDate);
|
|
Assert.AreEqual(fakeUser.LastLoginDateUtc.Value.ToLocalTime(), mockMember.LastLoginDate);
|
|
Assert.AreEqual(fakeUser.AccessFailedCount, mockMember.FailedPasswordAttempts);
|
|
Assert.AreEqual(fakeUser.IsLockedOut, mockMember.IsLockedOut);
|
|
Assert.AreEqual(fakeUser.IsApproved, mockMember.IsApproved);
|
|
Assert.AreEqual(fakeUser.PasswordHash, mockMember.RawPasswordValue);
|
|
Assert.AreEqual(fakeUser.SecurityStamp, mockMember.SecurityStamp);
|
|
Assert.AreNotEqual(DateTime.MinValue, mockMember.EmailConfirmedDate.Value);
|
|
|
|
_mockMemberService.Verify(x => x.Save(mockMember, Constants.Security.SuperUserId));
|
|
_mockMemberService.Verify(x => x.GetById(123));
|
|
_mockMemberService.Verify(x => x.ReplaceRoles(new[] { 123 }, new[] { "role1", "role2" }));
|
|
}
|
|
|
|
[Test]
|
|
public async Task GivenIDeleteUser_AndTheUserIsNotPresent_ThenIShouldGetAFailedResultAsync()
|
|
{
|
|
// arrange
|
|
var sut = CreateSut();
|
|
|
|
// act
|
|
var actual = await sut.DeleteAsync(null);
|
|
|
|
// assert
|
|
Assert.IsTrue(actual.Succeeded == false);
|
|
Assert.IsTrue(actual.Errors.Any(x =>
|
|
x.Code == "IdentityErrorUserStore" && x.Description == "Value cannot be null. (Parameter 'user')"));
|
|
_mockMemberService.VerifyNoOtherCalls();
|
|
}
|
|
|
|
[Test]
|
|
public async Task GivenIDeleteUser_AndTheUserIsDeletedCorrectly_ThenIShouldGetASuccessResultAsync()
|
|
{
|
|
// arrange
|
|
var memberKey = new Guid("4B003A55-1DE9-4DEB-95A0-352FFC693D8F");
|
|
var sut = CreateSut();
|
|
var fakeUser = new MemberIdentityUser(777) { Key = memberKey };
|
|
var fakeCancellationToken = CancellationToken.None;
|
|
|
|
IMemberType fakeMemberType = new MemberType(new MockShortStringHelper(), 77);
|
|
IMember mockMember = new Member(fakeMemberType)
|
|
{
|
|
Id = 777,
|
|
Key = memberKey,
|
|
Name = "fakeName",
|
|
Email = "fakeemail@umbraco.com",
|
|
Username = "fakeUsername",
|
|
RawPasswordValue = "fakePassword",
|
|
};
|
|
|
|
_mockMemberService.Setup(x => x.GetById(mockMember.Id)).Returns(mockMember);
|
|
_mockMemberService.Setup(x => x.GetByKey(mockMember.Key)).Returns(mockMember);
|
|
_mockMemberService.Setup(x => x.Delete(mockMember, Constants.Security.SuperUserId));
|
|
|
|
// act
|
|
var identityResult = await sut.DeleteAsync(fakeUser, fakeCancellationToken);
|
|
|
|
// assert
|
|
Assert.IsTrue(identityResult.Succeeded);
|
|
Assert.IsTrue(!identityResult.Errors.Any());
|
|
_mockMemberService.Verify(x => x.GetByKey(mockMember.Key));
|
|
_mockMemberService.Verify(x => x.Delete(mockMember, Constants.Security.SuperUserId));
|
|
_mockMemberService.VerifyNoOtherCalls();
|
|
}
|
|
}
|