* Removed obsoletes from IConfigManipulator. * Removed obsolete models builder extensions. * Removed the obsolete ContentDashboardSettings. * Removed the obsolete InstallMissingDatabase setting on GlobalSettings. * Removed obsolete NuCache settings. * Removed obsolete RuntimeMinificationSettings. * Removed obsolete health check constant. * Removed obsolete icon constant. * Removed obsolete telemetry constant. * Removed obsolete property and constructor on UmbracoBuilder. * Removed obsolete constructor on AuditNotificationsHandler. * Removed obsolete constructor on HTTP header health checks. * Removed obsolete constructor on MediaFileManager. * Removed obsolete GetDefaultFileContent on ViewHelper. * Remove obsoleted methods on embed providers. * Fix tests. * Removed obsolete constructors on BlockEditorDataConverter. * Removed obsolete SeedCacheDuration property on CacheSettings. * Removed obsolete PublishCulture on ContentRepositoryExtensions. * Removed obsolete MonitorLock. * Removed obsolete synchronous HasSavedValues from IDataTypeUsageService and IDataTypeUsageRepository. * Removed obsolete HasSavedPropertyValues from IPropertyTypeUsageService and IPropertyTypeUsageRepository. * Removed obsolete methods in ITrackedReferencesService and ITrackedReferencesRepository. * Removed obsolete DateValueEditor constructors. * Removed obsolete GetAutomaticRelationTypesAliases. * Removed obsolete constructor on TextOnlyValueEditor. * Removed obsolete constructors on RegexValidator and RequiredValidator. * Removed obsolete constructs on SliderValueConverter and TagsValueConverter. * Removed obsolete GetContentType methods from IPublishedCache. * Removed ContentFinderByIdPath. * Removed obsolete constructor on DefaultMediaUrlProvider. * Removed obsolete constructor on Domain. * Removed obsolete constructor on PublishedRequest. * Removed obsolete methods on CheckPermissions. * Removed obsolete GetUserId from IBackOfficeSecurity. * Removed obsolete methods on LegacyPasswordSecurity. * Removed obsolete constructors on AuditService. * Removed obsolete methods on IContentEditingService. * Remove obsolete constructors and methods on ContentService/IContentService. * Removed obsolete constructor in ContentTypeEditingService. * Removed obsolete constructor in MediaTypeEditingService. * Removed obsolete constructor in MemberTypeEditingService. * Removed obsolete constructor in ContentTypeService. * Removed obsolete constructors in ContentTypeServiceBase. * Removed obsolete constructors and methods in ContentVersionService. * Removed obsolete constructor in DataTypeUsageService. * Removed obsolete constructor in DomainService. * Removed obsolete constructor in FileService. * Removes obsolete AttemptMove from IContentService. * Removes obsolete SetPreventCleanup from IContentVersionService. * Removes obsolete GetReferences from IDataTypeService. * Removed obsolete SetConsentLevel from IMetricsConsentService. * Removed obsolete methods from IPackageDataInstallation. * Removed obsolete methods from IPackagingService. * Removed obsolete methods on ITwoFactorLoginService. Removed obsolete ITemporaryMediaService. * Removed obsolete constructor from MediaService, MemberTypeService and MediaTypeService. * More obsolete constructors. * Removed obsoleted overloads on IPropertyValidationService. * Fixed build for tests. * Removed obsolete constructor for PublicAccessService, UserService and RelationService. * Removed GetDefaultMemberType. * Removed obsolete user group functionality from IUserService. * Removed obsolete extension methods on IUserService. * Removed obsolete method from ITelemetryService. * Removed obsolete UdiParserServiceConnectors. * Removed obsolete method on ICookieManager. * Removed obsolete DynamicContext. * Removed obsolete XmlHelper. * Fixed failing integration tests. * Removed obsoletes in Umbraco.Cms.Api.Common * Removed obsoletes in Umbraco.Cms.Api.Delivery * Removed obsoletes in Umbraco.Cms.Api.Management * Removed obsoletes in Umbraco.Examine.Lucene * Removed obsoletes in Umbraco.Infrastructure * Fix failing delivery API contract integration test. * Made integration tests internal. * Removed obsoletes from web projects. * Fix build. * Removed Twitter OEmbed provider * Removed obsolete constructor on PublishedDataType. * Removed obsolete constructors on PublishedCacheBase. * Removed the obsolete PropertyEditorTagsExtensions. * Removed obsoletion properties on configuration response models (#18697) * Removed obsolete methods from server-side models. * Update client-side types and sdk. * Update client-side files. * Removed obsoletion of Utf8ToAsciiConverter.ToAsciiString overload. (#18694) * Removed obsolete method in UserService. (#18710) * Removed obsoleted group alias keys from being publicly available. (#18682) * Removed unneceessary ApiVersion attribute. * Clean-up obsoletions on MemberService (#18703) * Removed obsoleted method on MemberService, added future obsoletion to interface and updated all callers. * Removed obsoletion on member service method that's not obsolete on the interface.
131 lines
5.2 KiB
C#
131 lines
5.2 KiB
C#
using System.Linq.Expressions;
|
|
using System.Net;
|
|
using System.Text;
|
|
using NUnit.Framework;
|
|
using Umbraco.Cms.Api.Management.Controllers.Document;
|
|
using Umbraco.Cms.Api.Management.ViewModels.Document;
|
|
using Umbraco.Cms.Core;
|
|
using Umbraco.Cms.Core.Actions;
|
|
using Umbraco.Cms.Core.Models;
|
|
using Umbraco.Cms.Core.Models.Membership;
|
|
using Umbraco.Cms.Core.Serialization;
|
|
using Umbraco.Cms.Core.Services;
|
|
using Umbraco.Cms.Core.Services.ContentTypeEditing;
|
|
using Umbraco.Cms.Core.Strings;
|
|
using Umbraco.Cms.Tests.Common.Builders;
|
|
using Umbraco.Cms.Tests.Common.TestHelpers;
|
|
|
|
namespace Umbraco.Cms.Tests.Integration.ManagementApi.Policies;
|
|
|
|
[TestFixture]
|
|
internal sealed class CreateDocumentTests : ManagementApiTest<CreateDocumentController>
|
|
{
|
|
private IUserGroupService UserGroupService => GetRequiredService<IUserGroupService>();
|
|
|
|
private IShortStringHelper ShortStringHelper => GetRequiredService<IShortStringHelper>();
|
|
|
|
private ITemplateService TemplateService => GetRequiredService<ITemplateService>();
|
|
|
|
private IContentTypeEditingService ContentTypeEditingService => GetRequiredService<IContentTypeEditingService>();
|
|
|
|
private IJsonSerializer JsonSerializer => GetRequiredService<IJsonSerializer>();
|
|
|
|
private IContentService ContentService => GetRequiredService<IContentService>();
|
|
|
|
protected override Expression<Func<CreateDocumentController, object>> MethodSelector =>
|
|
x => x.Create(CancellationToken.None, null!);
|
|
|
|
[Test]
|
|
public async Task ReadonlyUserCannotCreateDocument()
|
|
{
|
|
var userGroup = await CreateReadonlyUserGroupAsync();
|
|
|
|
await AuthenticateClientAsync(Client, async userService =>
|
|
{
|
|
var email = "test@test.com";
|
|
var testUserCreateModel = new UserCreateModel
|
|
{
|
|
Email = email,
|
|
Name = "Test Mc.Gee",
|
|
UserName = email,
|
|
UserGroupKeys = new HashSet<Guid> { userGroup.Key },
|
|
};
|
|
|
|
var userCreationResult =
|
|
await userService.CreateAsync(Constants.Security.SuperUserKey, testUserCreateModel, true);
|
|
|
|
Assert.IsTrue(userCreationResult.Success);
|
|
|
|
return (userCreationResult.Result.CreatedUser, "1234567890");
|
|
});
|
|
|
|
var (contentType, template) = await CreateDocumentTypeAsync();
|
|
var contentCreateModel = ContentEditingBuilder.CreateSimpleContent(contentType.Key);
|
|
|
|
var requestModel = DocumentUpdateHelper.CreateDocumentRequestModel(contentCreateModel);
|
|
|
|
var response = await GetManagementApiResponseAsync(requestModel);
|
|
|
|
Assert.That(response.StatusCode, Is.EqualTo(HttpStatusCode.Forbidden));
|
|
}
|
|
|
|
[Test]
|
|
public async Task EditorCanCreateDocument()
|
|
{
|
|
await AuthenticateClientAsync(Client, "editor@editor.com", "1234567890", false);
|
|
|
|
var (contentType, template) = await CreateDocumentTypeAsync();
|
|
var requestModel = DocumentUpdateHelper.CreateDocumentRequestModel(ContentEditingBuilder.CreateSimpleContent(contentType.Key));
|
|
|
|
var response = await GetManagementApiResponseAsync(requestModel);
|
|
|
|
Assert.That(response.StatusCode, Is.EqualTo(HttpStatusCode.Created));
|
|
|
|
var locationHeader = response.Headers.GetValues("Location").First();
|
|
var key = Guid.Parse(locationHeader.Split('/')[^1]);
|
|
var createdContent = ContentService.GetById(key);
|
|
Assert.NotNull(createdContent);
|
|
}
|
|
|
|
private async Task<HttpResponseMessage> GetManagementApiResponseAsync(CreateDocumentRequestModel requestModel)
|
|
{
|
|
var url = GetManagementApiUrl<CreateDocumentController>(x => x.Create(CancellationToken.None, requestModel));
|
|
var requestBody = new StringContent(JsonSerializer.Serialize(requestModel), Encoding.UTF8, "application/json");
|
|
var response = await Client.PostAsync(url, requestBody);
|
|
return response;
|
|
}
|
|
|
|
private async Task<IUserGroup> CreateReadonlyUserGroupAsync()
|
|
{
|
|
var userGroup = new UserGroup(ShortStringHelper)
|
|
{
|
|
Name = "Test",
|
|
Alias = "test",
|
|
Permissions = new HashSet<string> { ActionBrowse.ActionLetter },
|
|
HasAccessToAllLanguages = true,
|
|
StartContentId = -1,
|
|
StartMediaId = -1
|
|
};
|
|
userGroup.AddAllowedSection("content");
|
|
userGroup.AddAllowedSection("media");
|
|
|
|
var groupCreationResult = await UserGroupService.CreateAsync(userGroup, Constants.Security.SuperUserKey);
|
|
Assert.IsTrue(groupCreationResult.Success);
|
|
return groupCreationResult.Result;
|
|
}
|
|
|
|
private async Task<(IContentType contentType, ITemplate template)> CreateDocumentTypeAsync()
|
|
{
|
|
var userKey = Constants.Security.SuperUserKey;
|
|
var template = TemplateBuilder.CreateTextPageTemplate();
|
|
var templateAttempt = await TemplateService.CreateAsync(template, userKey);
|
|
Assert.IsTrue(templateAttempt.Success);
|
|
|
|
var contentTypeCreateModel = ContentTypeEditingBuilder.CreateSimpleContentType(defaultTemplateKey: template.Key);
|
|
var contentTypeAttempt = await ContentTypeEditingService.CreateAsync(contentTypeCreateModel, userKey);
|
|
Assert.IsTrue(contentTypeAttempt.Success);
|
|
|
|
return (contentTypeAttempt.Result!, templateAttempt.Result!);
|
|
}
|
|
}
|