Files
Umbraco-CMS/tests/Umbraco.Tests.Integration/Umbraco.Core/IO/FileSystemsTests.cs
Andy Butland 2b8146f72d Media: Add protection to restrict access to media in recycle bin (closes #2931) (#20378)
* Add MoveFile it IFileSystem and implement on file systems.

* Rename media file on move to recycle bin.

* Rename file on restore from recycle bin.

* Add configuration to enabled recycle bin media protection.

* Expose backoffice authentication as cookie for non-backoffice usage.
Protected requests for media in recycle bin.

* Display protected image when viewing image cropper in the backoffice media recycle bin.

* Code tidy and comments.

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Introduced helper class to DRY up repeated code between image cropper and file upload notification handlers.

* Reverted client-side and management API updates.

* Moved update of path to media file in recycle bin with deleted suffix to the server.

* Separate integration tests for add and remove.

* Use interpolated strings.

* Renamed variable.

* Move EnableMediaRecycleBinProtection to ContentSettings.

* Tidied up comments.

* Added TODO for 18.

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2025-11-04 07:39:44 +00:00

157 lines
6.0 KiB
C#

// Copyright (c) Umbraco.
// See LICENSE for more details.
using System.Text;
using NUnit.Framework;
using Umbraco.Cms.Core.Hosting;
using Umbraco.Cms.Core.IO;
using Umbraco.Cms.Core.IO.MediaPathSchemes;
using Umbraco.Cms.Tests.Common.Attributes;
using Umbraco.Cms.Tests.Common.Testing;
using Umbraco.Cms.Tests.Integration.Testing;
namespace Umbraco.Cms.Tests.Integration.Umbraco.Core.IO;
[TestFixture]
[UmbracoTest]
internal sealed class FileSystemsTests : UmbracoIntegrationTest
{
[Test]
public void Can_Get_MediaFileManager()
{
var fileSystem = GetRequiredService<MediaFileManager>();
Assert.NotNull(fileSystem);
}
[Test]
public void MediaFileManager_Is_Singleton()
{
var fileManager1 = GetRequiredService<MediaFileManager>();
var fileManager2 = GetRequiredService<MediaFileManager>();
Assert.AreSame(fileManager1, fileManager2);
}
[Test]
[LongRunning]
public void Can_Delete_MediaFiles()
{
var mediaFileManager = GetRequiredService<MediaFileManager>();
var memoryStream = new MemoryStream(Encoding.UTF8.GetBytes("test"));
var virtualPath = mediaFileManager.GetMediaPath("file.txt", Guid.NewGuid(), Guid.NewGuid());
mediaFileManager.FileSystem.AddFile(virtualPath, memoryStream);
// ~/media/1234/file.txt exists
var hostingEnvironment = GetRequiredService<IHostingEnvironment>();
var physPath = hostingEnvironment.MapPathWebRoot(Path.Combine("media", virtualPath));
Assert.IsTrue(File.Exists(physPath));
// ~/media/1234/file.txt is gone
mediaFileManager.DeleteMediaFiles(new[] { virtualPath });
Assert.IsFalse(File.Exists(physPath));
var scheme = GetRequiredService<IMediaPathScheme>();
if (scheme is UniqueMediaPathScheme)
{
// ~/media/1234 is *not* gone
physPath = Path.GetDirectoryName(physPath);
Assert.IsTrue(Directory.Exists(physPath));
}
else
{
// ~/media/1234 is gone
physPath = Path.GetDirectoryName(physPath);
Assert.IsFalse(Directory.Exists(physPath));
}
// ~/media exists
physPath = Path.GetDirectoryName(physPath);
Assert.IsTrue(Directory.Exists(physPath));
}
[Test]
public void Can_Add_Suffix_To_Media_Files()
{
var mediaFileManager = GetRequiredService<MediaFileManager>();
var hostingEnvironment = GetRequiredService<IHostingEnvironment>();
CreateMediaFile(mediaFileManager, hostingEnvironment, out string virtualPath, out string physicalPath);
Assert.IsTrue(File.Exists(physicalPath));
mediaFileManager.SuffixMediaFiles([virtualPath], Cms.Core.Constants.Conventions.Media.TrashedMediaSuffix);
Assert.IsFalse(File.Exists(physicalPath));
var virtualPathWithSuffix = virtualPath.Replace("file.txt", $"file{Cms.Core.Constants.Conventions.Media.TrashedMediaSuffix}.txt");
physicalPath = hostingEnvironment.MapPathWebRoot(Path.Combine("media", virtualPathWithSuffix));
Assert.IsTrue(File.Exists(physicalPath));
}
[Test]
public void Can_Remove_Suffix_From_Media_Files()
{
var mediaFileManager = GetRequiredService<MediaFileManager>();
var hostingEnvironment = GetRequiredService<IHostingEnvironment>();
CreateMediaFile(mediaFileManager, hostingEnvironment, out string virtualPath, out string physicalPath);
mediaFileManager.SuffixMediaFiles([virtualPath], Cms.Core.Constants.Conventions.Media.TrashedMediaSuffix);
Assert.IsFalse(File.Exists(physicalPath));
mediaFileManager.RemoveSuffixFromMediaFiles([virtualPath], Cms.Core.Constants.Conventions.Media.TrashedMediaSuffix);
Assert.IsFalse(File.Exists(physicalPath));
var virtualPathWithSuffix = virtualPath.Replace("file.txt", $"file{Cms.Core.Constants.Conventions.Media.TrashedMediaSuffix}.txt");
physicalPath = hostingEnvironment.MapPathWebRoot(Path.Combine("media", virtualPathWithSuffix));
Assert.IsTrue(File.Exists(physicalPath));
}
private static void CreateMediaFile(
MediaFileManager mediaFileManager,
IHostingEnvironment hostingEnvironment,
out string virtualPath,
out string physicalPath)
{
virtualPath = mediaFileManager.GetMediaPath("file.txt", Guid.NewGuid(), Guid.NewGuid());
physicalPath = hostingEnvironment.MapPathWebRoot(Path.Combine("media", virtualPath));
var memoryStream = new MemoryStream(Encoding.UTF8.GetBytes("test"));
mediaFileManager.FileSystem.AddFile(virtualPath, memoryStream);
Assert.IsTrue(File.Exists(physicalPath));
}
// TODO: don't make sense anymore
/*
[Test]
public void Cannot_Get_InvalidFileSystem()
{
// throws because InvalidTypedFileSystem does not have the proper attribute with an alias
Assert.Throws<InvalidOperationException>(() => FileSystems.GetFileSystem<InvalidFileSystem>());
}
[Test]
public void Cannot_Get_NonConfiguredFileSystem()
{
// note: we need to reset the manager between tests else the Accept_Fallback test would corrupt that one
// throws because NonConfiguredFileSystem has the proper attribute with an alias,
// but then the container cannot find an IFileSystem implementation for that alias
Assert.Throws<InvalidOperationException>(() => FileSystems.GetFileSystem<NonConfiguredFileSystem>());
// all we'd need to pass is to register something like:
//_container.Register<IFileSystem>("noconfig", factory => new PhysicalFileSystem("~/foo"));
}
internal class InvalidFileSystem : FileSystemWrapper
{
public InvalidFileSystem(IFileSystem innerFileSystem)
: base(innerFileSystem)
{ }
}
[InnerFileSystem("noconfig")]
internal class NonConfiguredFileSystem : FileSystemWrapper
{
public NonConfiguredFileSystem(IFileSystem innerFileSystem)
: base(innerFileSystem)
{ }
}
*/
}