Files

yv01p 9962df50ee feat(core): register IContentCrudService in DI container

Adds IContentCrudService registration to UmbracoBuilder alongside
IContentService. Both services are now resolvable from DI.

Includes integration test verifying successful resolution.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

2025-12-21 03:31:23 +00:00

5.6 KiB

Raw Blame History

date, researcher, git_commit, branch, repository, topic, tags, status, last_updated, last_updated_by, type

date researcher git_commit branch repository topic tags status last_updated last_updated_by type

2025-12-21T01:09:28+00:00

Claude

0351dc06b4

refactor/ContentService

Umbraco-CMS

ContentService Phase 1 CRUD Extraction - Subagent-Driven Development

implementation

refactoring

contentservice

subagent-driven-development

in_progress

2025-12-21

Claude

implementation_strategy

Handoff: ContentService Phase 1 CRUD Extraction - Resume at Task 4

Task(s)

Primary Task: Execute Phase 1 of ContentService refactoring using subagent-driven development methodology.

Phase 1 Goal: Extract CRUD operations (Create, Get, Save, Delete) from the monolithic ContentService (3823 lines) into a dedicated IContentCrudService interface and ContentCrudService implementation.

Task Status (8 total):

#	Task	Status
1	Create ContentServiceBase Abstract Class	COMPLETED
2	Create IContentCrudService Interface	COMPLETED
3	Create ContentCrudService Implementation	COMPLETED
4	Register ContentCrudService in DI	IN PROGRESS (not started)
5	Update ContentService to Delegate CRUD Operations	Pending
6	Add Benchmark Regression Enforcement	Pending
7	Run Phase 1 Gate Tests	Pending
8	Update Phase Tracking Documentation	Pending

Critical References

Implementation Plan: docs/plans/2025-12-20-contentservice-refactor-phase1-implementation.md - Contains complete task specifications including code to implement
Design Document: docs/plans/2025-12-19-contentservice-refactor-design.md - Overall refactoring architecture
Skill Being Used: superpowers:subagent-driven-development - Dispatch fresh subagent per task with two-stage review

Recent changes

src/Umbraco.Core/Services/ContentCrudService.cs - NEW: Full CRUD service implementation (~750 lines)
- 23 public methods (6 Create, 9 Read, 5 Tree Traversal, 2 Save, 1 Delete)
- 7 private helpers (SaveLocked, DeleteLocked, GetContentTypeLocked, etc.)
- Fixed all 5 issues from code quality review (batch audit bug, RecycleBinContent check, null checks, trashed parent validation, notification publishing)
tests/Umbraco.Tests.UnitTests/Umbraco.Core/Services/ContentCrudServiceTests.cs - NEW: 8 unit tests, all passing
- Fixed mocking issue with ContentCultureInfos (used real instance instead of mock)

Learnings

Subagent Workflow: Each task requires three subagents: implementer, spec reviewer, code quality reviewer. Only proceed after both reviews pass.
Test Mocking Limitation: ContentCultureInfos.Culture is a non-virtual property and cannot be mocked. Use real instances: new ContentCultureInfos("en-US").
Lock Ordering: Always acquire locks in order: ContentTree (write) → ContentTypes (read) → Languages (read). SaveLocked requires both ContentTree and Languages locks.
Validation Placement: Save validation (PublishedState, name length) MUST be inside SaveLocked, not in public Save method, to prevent race conditions.
GetParent Special Cases: Must check for both Constants.System.Root AND Constants.System.RecycleBinContent as parent IDs that should return null.
Commit Hashes:
- Task 1: c9ff758aca - ContentServiceBase + ContentServiceConstants
- Task 2: b72db59957 - IContentCrudService interface
- Task 3: 0351dc06b4 - ContentCrudService implementation (after all fixes)

Artifacts

docs/plans/2025-12-20-contentservice-refactor-phase1-implementation.md - Complete implementation plan (2396 lines) with all 8 tasks
src/Umbraco.Core/Services/ContentServiceBase.cs - Abstract base class (69 lines)
src/Umbraco.Core/Services/ContentServiceConstants.cs - Constants class (12 lines)
src/Umbraco.Core/Services/IContentCrudService.cs - Interface (251 lines)
src/Umbraco.Core/Services/ContentCrudService.cs - Implementation (~750 lines)
tests/Umbraco.Tests.UnitTests/Umbraco.Core/Services/ContentCrudServiceTests.cs - Unit tests (8 tests)

Action Items & Next Steps

Resume Task 4: Register ContentCrudService in DI
- Dispatch implementer subagent with Task 4 content from the plan
- Add Services.AddUnique<IContentCrudService, ContentCrudService>(); to src/Umbraco.Core/DependencyInjection/UmbracoBuilder.cs around line 300 (before IContentService registration)
- Add integration test to verify DI resolution
- Run: spec reviewer → code quality reviewer → mark complete
Continue with Tasks 5-8: Follow the plan exactly as specified
- Task 5: Update ContentService to delegate CRUD to ContentCrudService (largest remaining task)
- Task 6: Add benchmark regression enforcement
- Task 7: Run Phase 1 gate tests
- Task 8: Update documentation
Final Steps (after Task 8):
- Dispatch final code reviewer for entire implementation
- Use superpowers:finishing-a-development-branch skill

Other Notes

Methodology: Using superpowers:subagent-driven-development skill - fresh subagent per task with two-stage review (spec compliance, then code quality)
Prompt Templates Location: /home/yv01p/.claude/plugins/cache/superpowers-marketplace/superpowers/4.0.0/skills/subagent-driven-development/
Build Command: dotnet build src/Umbraco.Core/Umbraco.Core.csproj
Test Command: dotnet test tests/Umbraco.Tests.UnitTests --filter "FullyQualifiedName~ContentCrudServiceTests"
The plan has been through 5 critical reviews - see "Critical Review Changes Applied" sections at bottom of plan document
Task 4 is small: Just one line addition to UmbracoBuilder.cs + integration test

5.6 KiB Raw Blame History